Issue metadata
Sign in to add a comment
|
TBR in Gerrit seems to only work with equals sign (TBR=xxx), not with colon (TBR: xxx) |
||||||||||||||||||||||
Issue descriptionTBR in Gerrit seems to only work with equals sign (TBR=xxx), not with colon (TBR: xxx). If this is a known thing, then I guess that is fine. If it is possible to make TBR work with both equals, and colon, I think that would be good. I've done a recent CL where I used TBR, and also been on the receiving end of a CL with me as TBR. On the CL that I sent (https://chromium-review.googlesource.com/c/558745/), I originally put TBR using colon in the description, but I was not able to submit, TBR: username@chromium.org until I used the equals sign: TBR=username@chromium.org On the CL that I received (https://chromium-review.googlesource.com/c/558772/), I am copied in with Tbr using colon. I did not receive any email notification about this CL. Tbr: joelhockey@chromium.org
,
Jul 6 2017
As TE-Team doesn't have permission to change the "Chromium Gerrit", adding "TE-NeedsTriageHelp" label for further triage. Thank You!
,
Jul 6 2017
No TE help needed here, this is in my component.
,
Jul 11 2017
Ok, finally starting to look at this. Joel, I'm a bit confused: on the first CL (https://chromium-review.googlesource.com/c/558745), you added the "TBR: " in the second patchset, then replaced it with "TBR=" in the third patchset, but you never ran any tryjobs (in particular the chromium_presubmit tryjob which could have failed based on OWNERS approval or the lack thereof) in between. There are only two systems which care about TBR in general: 1) git-cl, which parses the line to add TBR'd people to the set of reviewers 2) PRESUBMIT, which parses the line to see if it should bypass OWNERS checks PRESUBMIT was already fixed. However, git-cl's handling of reviewers and tbr lines is still... bad. I hope to fix it all in one fell swoop here: https://bugs.chromium.org/p/chromium/issues/detail?id=735352
,
Jul 11 2017
My recollection is that after adding "TBR:" in second patchset, the UI did not show the submit button (not sure exact text on the button but it is blue in top right corner). When I changed to patchset 3 with "TBR=", then immediately the blue submit button was showing and I was able to click it.
,
Jul 11 2017
The existence or lack thereof of TBR (or any variation thereof) in the commit message doesn't affect the Submit button in the UI. I wish it did, but it doesn't.
,
Jul 18 2017
I tried using Tbr: someone@chromium.org yesterday [1], worked for me. [1] https://chromium-review.googlesource.com/c/572890
,
Sep 7 2017
,
Nov 17 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by joelhockey@chromium.org
, Jul 5 2017