Files under //content/renderer/media/gpu [1] are not gpu specific, but webrtc,
we should consider moving those to //content/renderer/media/webrtc.
In the same line, //content/renderer/media/ has a webrtc/ subfolder, but
there are plenty of files in //content/renderer/media that are webrtc
specific: consider moving those to //content/renderer/media/webrtc:
At least the files:
- *media_stream*
- *peer_connection*
- webrtc*
- webmediaplayer_ms*
- rtc_*
- video_track*
- video_capture_impl*
- user_media_client*
are webrtc-specific (either MediaStream-specific or PeerConnection).
Consider moving all those to webrtc/ subfolder.
[1] https://cs.chromium.org/chromium/src/content/renderer/media/gpu/?sq=package:chromium&dr
Files under //content/renderer/media/gpu [1] are not gpu specific but
webrtc specific, we should consider moving those to
//content/renderer/media/webrtc.
In the same line, //content/renderer/media/ has a webrtc/ subfolder, but
there are plenty of files in //content/renderer/media that are webrtc
specific: consider moving those to //content/renderer/media/webrtc:
At least the files:
- *media_stream*
- *peer_connection*
- webrtc*
- webmediaplayer_ms*
- rtc_*
- video_track*
- video_capture_impl*
- user_media_client*
are webrtc-specific (either MediaStream-specific or PeerConnection).
Consider moving all those to webrtc/ subfolder.
[1] https://cs.chromium.org/chromium/src/content/renderer/media/gpu/?sq=package:chromium&dr
Moving files around should be pretty simple with //tools/git/mass-rename.py:
just move the files with:
git mv A B
and _without_ committing, run
tools/git/mass-rename.py
then commit, upload, review, land, profit !
Some side comments/APs out of the review [1]:
//content/renderer/media/webrtc_local_audio_source_provider* needs rename
//content/renderer/media/webrtc_logging* is not webrtc-specific (also for MediaStream stuff).
[1] https://chromium-review.googlesource.com/c/chromium/src/+/909188#message-a543b2b26640e4130861d2c740ff89f3c501a763
Also the idea would be to somehow try to replicate the Blink folder
structure, i.e. there we have
Source/modules/mediastream
Source/modules/peerconnection
so we should move the media-stream related files to e.g.
//content/renderer/media/stream -- partner of Source/modules/mediastream
//content/renderer/media/webrtc -- partner of Source/modules/peerconnection.
miu@, guidou@, just an idea, WDYT about renaming
//content/renderer/media/webrtc to //c/r/m/peerconnection
?
Mostly finished! Someone should do something about the audio files -- e.g.
move //content/renderer/media/audio* into a //content/renderer/media/audio ?
And also address the presubmit warnings on the blocked-on bugs.
Comment 1 by mcasas@chromium.org
, Jul 5 2017