css interpretation: border-radius and border-left size breaks border-top/bottom dotted
Reported by
larry.fl...@gmail.com,
Jul 4 2017
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36 Steps to reproduce the problem: 1. http://jsfiddle.net/kep2h5fe/ 2. vary border-left width 3. only happens when border-radius > 1 What is the expected behavior? top border should look dotted but it looks dashed What went wrong? The dot widths get wider depending on the size of the left border. Did this work before? Yes 58 Does this work in other browsers? Yes Chrome version: 59.0.3071.115 Channel: stable OS Version: 10.0 Flash Version:
,
Jul 5 2017
,
Jul 5 2017
Able to reproduce on Windows 10, Ubuntu 14.04 and Mac OS 10.12.5 using chrome stable M54-59.0.3071.115. Bisect Information: ===================== Good build: 59.0.3040.0 Bad Build : 59.0.3042.0 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/bbd052efa719a473ee143cdb8f6e84bcbfbf0876..77f3bbabe3fcfb626cd268a018c683a948438c5f From the above change log suspecting below change Review URL: https://codereview.chromium.org/2737063002 schenney@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
Jul 5 2017
That does look like my change. I'll look into it soon as I can. Leaving the release block for now, but this just might be a Skia issue that will take longer to fix.
,
Jul 11 2017
Just to update, Still able to reproduce the issue on mac 10.12.5 using latest canary #61.0.3154.0. Thanks...!!
,
Jul 17 2017
Just to update, Still able to reproduce the issue on Win-10 using latest canary #61.0.3159.0. schenney@ - Gentle Ping...!! Could you please have a look into the issue as it has been marked as a stable blocker. Thanks...!!
,
Jul 17 2017
I'll take a look but this probably isn't a release blocker. I'm super busy with something else right now so might not have time to fix it.
,
Jul 24 2017
sgtm, moving this to M-61
,
Jul 26 2017
URGENT - PTAL. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the M61 branch #3163 ASAP to have enough baking time in Beta before Stable promotion. Thank you! Know that this issue shouldn't block the release? Remove the ReleaseBlock-Stable label.
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa5101c8859a5979c9ee4d61a62079b06f6226e9 commit aa5101c8859a5979c9ee4d61a62079b06f6226e9 Author: Stephen Chenney <schenney@chromium.org> Date: Fri Jul 28 02:40:02 2017 Fix dotted/dashed borders adjacent to thick A previous change switched to using the draw_thickness for dash and dot size calculations, rather then the thickness. But the draw_thickness is the max of the edge in question and its adjacent edges. So a thin edge bordering a thick edge would have oversized dots and dashes. This patch switches to sizing the dots and dashes based on the edge thickness alone. R=pdr@chromium.org BUG= 739228 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie3bdd1409405fcb6e4cd7e924832620eb7b96076 Reviewed-on: https://chromium-review.googlesource.com/588407 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#490220} [modify] https://crrev.com/aa5101c8859a5979c9ee4d61a62079b06f6226e9/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDashed05-expected.png [modify] https://crrev.com/aa5101c8859a5979c9ee4d61a62079b06f6226e9/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDashed06-expected.png [add] https://crrev.com/aa5101c8859a5979c9ee4d61a62079b06f6226e9/third_party/WebKit/LayoutTests/fast/borders/dotted-border-ajoining-thick-expected.png [add] https://crrev.com/aa5101c8859a5979c9ee4d61a62079b06f6226e9/third_party/WebKit/LayoutTests/fast/borders/dotted-border-ajoining-thick.html [modify] https://crrev.com/aa5101c8859a5979c9ee4d61a62079b06f6226e9/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp
,
Jul 28 2017
Very simple patch requesting merge to fix dotted borders in some cases. Not important enough to re-spin M-60.
,
Jul 29 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 30 2017
Pls merge you change to M61 branch 3163 before 3:00 PM PT on Monday so we can take it in for next week last M61 Dev release. Thank you.
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8655be3f7451e4e232d995419a7d55c72a240c3 commit e8655be3f7451e4e232d995419a7d55c72a240c3 Author: Stephen Chenney <schenney@chromium.org> Date: Mon Jul 31 14:34:15 2017 Fix dotted/dashed borders adjacent to thick Merge to M-61 A previous change switched to using the draw_thickness for dash and dot size calculations, rather then the thickness. But the draw_thickness is the max of the edge in question and its adjacent edges. So a thin edge bordering a thick edge would have oversized dots and dashes. This patch switches to sizing the dots and dashes based on the edge thickness alone. R=pdr@chromium.org TBR=schenney@chromium.org BUG= 739228 (cherry picked from commit aa5101c8859a5979c9ee4d61a62079b06f6226e9) Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie3bdd1409405fcb6e4cd7e924832620eb7b96076 Reviewed-on: https://chromium-review.googlesource.com/588407 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490220} Reviewed-on: https://chromium-review.googlesource.com/594027 Reviewed-by: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#152} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/e8655be3f7451e4e232d995419a7d55c72a240c3/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDashed05-expected.png [modify] https://crrev.com/e8655be3f7451e4e232d995419a7d55c72a240c3/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDashed06-expected.png [add] https://crrev.com/e8655be3f7451e4e232d995419a7d55c72a240c3/third_party/WebKit/LayoutTests/fast/borders/dotted-border-ajoining-thick-expected.png [add] https://crrev.com/e8655be3f7451e4e232d995419a7d55c72a240c3/third_party/WebKit/LayoutTests/fast/borders/dotted-border-ajoining-thick.html [modify] https://crrev.com/e8655be3f7451e4e232d995419a7d55c72a240c3/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp
,
Aug 1 2017
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a88d25b2610485e42fc148c34065900e773b2b53 commit a88d25b2610485e42fc148c34065900e773b2b53 Author: Stephen Chenney <schenney@chromium.org> Date: Wed Aug 02 14:09:11 2017 Rename parameters in BoxBorderPainter methods The names are confusing, leading to bugs. Try to make them more obvious. R=pdr@chromium.org BUG= 739228 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5fe6b1c4432818279f4758397d07b581a0fbe408 Reviewed-on: https://chromium-review.googlesource.com/596847 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#491364} [modify] https://crrev.com/a88d25b2610485e42fc148c34065900e773b2b53/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp
,
Aug 3 2017
Tested the issue on Mac OS 10.12.6, Ubuntu 14.04 and Windows 7 using Chrome Canary version M62 - 62.0.3175.0 as per the issue mentioned in original comment. Observed that issue is working as intended (Dotted border is displayed on top and bottom). Hence adding TE-Verified label. Attached the screenshot for reference. Thank you! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dstockwell@google.com
, Jul 4 2017