New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739182 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Remove GLOzoneOSMesa when Ozone uses SwiftShader everywhere

Project Member Reported by kylec...@chromium.org, Jul 4 2017

Issue description

When all Ozone platforms support SwiftShader and uses it for software GL in tests then we can probably just remove OSMesa support. This would essentially just be removing GLOzoneOSMesa and it's use in each SurfaceFactoryOzone implementation.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 4

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
The work for Chrome OS to support SwiftShader is still ongoing, so this is still relevant.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://swiftshader.googlesource.com/SwiftShader.git/+/dd662d210afc9bed3ce127e65188bb47564bcd8e

commit dd662d210afc9bed3ce127e65188bb47564bcd8e
Author: Alexis Hetu <sugoi@google.com>
Date: Fri Aug 10 14:47:50 2018

SwiftShader on Fuchsia x64

This cl contains the necessary config and build changes
to make SwiftShader work on Fuchsia x64.

Passes all tests in content_unittests.

Bug:  chromium:739182 

Change-Id: I7df44bd6b12b2560f18e4375f16ada3850f1d8a5
Reviewed-on: https://swiftshader-review.googlesource.com/20208
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

[modify] https://crrev.com/dd662d210afc9bed3ce127e65188bb47564bcd8e/src/OpenGL/libEGL/libEGL.hpp
[modify] https://crrev.com/dd662d210afc9bed3ce127e65188bb47564bcd8e/src/OpenGL/libGLESv2/libGLESv2.hpp
[modify] https://crrev.com/dd662d210afc9bed3ce127e65188bb47564bcd8e/src/Reactor/BUILD.gn
[modify] https://crrev.com/dd662d210afc9bed3ce127e65188bb47564bcd8e/third_party/LLVM/BUILD.gn
[modify] https://crrev.com/dd662d210afc9bed3ce127e65188bb47564bcd8e/third_party/LLVM/include-fuchsia/llvm/Config/config.h
[add] https://crrev.com/dd662d210afc9bed3ce127e65188bb47564bcd8e/third_party/llvm-subzero/build/Fuchsia/include/llvm/Config/abi-breaking.h
[add] https://crrev.com/dd662d210afc9bed3ce127e65188bb47564bcd8e/third_party/llvm-subzero/build/Fuchsia/include/llvm/Config/config.h
[add] https://crrev.com/dd662d210afc9bed3ce127e65188bb47564bcd8e/third_party/llvm-subzero/build/Fuchsia/include/llvm/Config/llvm-config.h
[add] https://crrev.com/dd662d210afc9bed3ce127e65188bb47564bcd8e/third_party/llvm-subzero/build/Fuchsia/include/llvm/IR/Attributes.gen
[add] https://crrev.com/dd662d210afc9bed3ce127e65188bb47564bcd8e/third_party/llvm-subzero/build/Fuchsia/include/llvm/IR/Intrinsics.gen
[add] https://crrev.com/dd662d210afc9bed3ce127e65188bb47564bcd8e/third_party/llvm-subzero/build/Fuchsia/include/llvm/Support/DataTypes.h

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56d2155d33fd78eac37ae544ac86c750d188f0f4

commit 56d2155d33fd78eac37ae544ac86c750d188f0f4
Author: Alexis Hetu <sugoi@google.com>
Date: Fri Aug 10 19:22:41 2018

Enable SwiftShader on Fuchsia

SwiftShader is now usable on Fuchsia.
Requires sister cl to roll into chromium:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/20208

Bug:  chromium:739182 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8be1f554da7633a46ecb888975911d9897f07c78
Reviewed-on: https://chromium-review.googlesource.com/1170040
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582284}
[modify] https://crrev.com/56d2155d33fd78eac37ae544ac86c750d188f0f4/BUILD.gn
[modify] https://crrev.com/56d2155d33fd78eac37ae544ac86c750d188f0f4/ui/gl/BUILD.gn
[modify] https://crrev.com/56d2155d33fd78eac37ae544ac86c750d188f0f4/ui/ozone/common/egl_util.cc

Status: Fixed (was: Available)

Sign in to add a comment