New issue
Advanced search Search tips

Issue 739181 link

Starred by 1 user
Status: Fixed
Owner:
jlebel@chromium.org
Closed: Jul 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Should remove "on" prefix in ChromeIdentityServiceObserver protocol methods

Project Member Reported by jlebel@chromium.org, Jul 4 2017 
To be consistant with the rest of the code, "on" should be removed from the ChromeIdentityServiceObserver protocol methods.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41f2338e41b11fb6cf1ec6574856fa9a864196d7

commit 41f2338e41b11fb6cf1ec6574856fa9a864196d7
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Thu Jul 06 11:49:30 2017

Removing "on" prefix for ChromeIdentityServiceObserver

Bug:  739181 
Change-Id: I365195c19d5d379979d7e719fd790f1468a9c6a5
Reviewed-on: https://chromium-review.googlesource.com/559101
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484545}
[modify] https://crrev.com/41f2338e41b11fb6cf1ec6574856fa9a864196d7/ios/chrome/browser/signin/chrome_identity_service_observer_bridge.h
[modify] https://crrev.com/41f2338e41b11fb6cf1ec6574856fa9a864196d7/ios/chrome/browser/signin/chrome_identity_service_observer_bridge.mm
[modify] https://crrev.com/41f2338e41b11fb6cf1ec6574856fa9a864196d7/ios/chrome/browser/signin/chrome_identity_service_observer_bridge_unittest.mm
[modify] https://crrev.com/41f2338e41b11fb6cf1ec6574856fa9a864196d7/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm
[modify] https://crrev.com/41f2338e41b11fb6cf1ec6574856fa9a864196d7/ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.mm
[modify] https://crrev.com/41f2338e41b11fb6cf1ec6574856fa9a864196d7/ios/chrome/browser/ui/authentication/signin_account_selector_view_controller.mm
[modify] https://crrev.com/41f2338e41b11fb6cf1ec6574856fa9a864196d7/ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.mm
[modify] https://crrev.com/41f2338e41b11fb6cf1ec6574856fa9a864196d7/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.mm
[modify] https://crrev.com/41f2338e41b11fb6cf1ec6574856fa9a864196d7/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
[modify] https://crrev.com/41f2338e41b11fb6cf1ec6574856fa9a864196d7/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/41f2338e41b11fb6cf1ec6574856fa9a864196d7/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm

Comment 2 by jlebel@chromium.org, Jul 6 2017

Status: Fixed (was: Started)
►

Sign in to add a comment