New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739170 link

Starred by 8 users

Issue metadata

Status: Assigned
Owner:
Buried. Ping if important.
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Feature

Blocked on:
issue 865900



Sign in to add a comment

Explore a "safe" system of types for typical XSS sinks.

Project Member Reported by mkwst@chromium.org, Jul 4 2017

Issue description

After talking with some folks about xtof's [1], I think there's something there that browsers are uniquely positioned to help out with. This patch starts sketching out what a set of safe types might look like, and what it might feel like for a developer to lock themselves out of raw string assignments to typical XSS sinks like `location.href` or `el.innerHTML`.

I don't even have an explainer yet, but the core would be something like:

```
var html = SafeHTML.escape(userProvidedString);
el.innerHTML = html;

var trusted = SafeHTML.unsafelyConstruct(developerProvidedStringOrConstant);
el.innerHTML = html;

var url = SafeURL.construct(userProvidedString);
iframe.href = url;

var trustedURL = SafeURL.unsafelyConstruct(developerProvidedStringOrConstant);
iframe.href = url;
```

With something like:

```
Content-Security-Policy: require-safe-types
```

Making direct string assignments (`el.innerHTML = "<p>Yay!</p>";`) throw `TypeError`s.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e92361313635c5d5f29ed29b053442c9be8be6ec

commit e92361313635c5d5f29ed29b053442c9be8be6ec
Author: Mike West <mkwst@chromium.org>
Date: Wed Sep 20 11:38:50 2017

Trusted Types: Prototype for hacking.

After talking with some folks about xtof's [1], I think there's something
there that browsers are uniquely positioned to help out with. This patch
starts sketching out what a set of safe types might look like, and what
it might feel like for a developer to lock themselves out of raw string
assignments to typical XSS sinks like `location.href` or `el.innerHTML`.

This patch implements a first pass at `TrustedHTML` and `TrustedURL`,
along with updates to a few sinks to use these new types. It's by no
means a complete implementation, but should give us enough to play
around with while we experiment with library authors to see how the
layering might work.

Explainer: https://github.com/mikewest/trusted-types
Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/qbOrXp9g3B8/hziymUnHAQAJ

[1]: https://research.google.com/pubs/pub42934.html

P.S. This patch looks huge and ugly, but the majority of the changes are
the renamings of `set{Inner,Outer}HTML` that touch a million tests.

Bug: 739170
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I65e5add5cc7fcbc17f97ca8b737d7a3e1d8cad3b
Reviewed-on: https://chromium-review.googlesource.com/559061
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#503113}
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedHTML.tentative.html
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedURL.tentative.html
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-innerHTML.tentative.html
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-insertAdjacentHTML.tentative.html
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-href.tentative.html
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-outerHTML.tentative.html
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/external/wpt/trusted-types/document-write.tentative.html
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/external/wpt/trusted-types/innerHTML.tentative.html
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/external/wpt/trusted-types/insertAdjacentHTML.tentative.html
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/external/wpt/trusted-types/location-href.tentative.html
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/external/wpt/trusted-types/outerHTML.tentative.html
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/external/wpt/trusted-types/support/helper.js
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/clipboard/DataTransferTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/css/AffectedByPseudoTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/css/CSSSelectorWatchTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/css/DragUpdateTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/css/SelectorQueryTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/css/StyleElementTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/css/StyleEngineTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/css/invalidation/StyleInvalidatorTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolverTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/Document.idl
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/DocumentStatisticsCollectorTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/DocumentTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/Element.idl
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/ElementTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/FlatTreeTraversalTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/MutationObserverTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/NodeTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/NthIndexCacheTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/RangeTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/SecurityContext.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/SecurityContext.h
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/ShadowDOMV0Test.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/ShadowRoot.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/ShadowRoot.h
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/ShadowRoot.idl
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/StaticRangeTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/WhitespaceAttacherTest.cpp
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/trustedtypes/TrustedHTML.cpp
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/trustedtypes/TrustedHTML.h
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/trustedtypes/TrustedHTML.idl
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/trustedtypes/TrustedURL.cpp
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/trustedtypes/TrustedURL.h
[add] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/dom/trustedtypes/TrustedURL.idl
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/FrameCaretTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/LayoutSelectionTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/SurroundingTextTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/TextFinderTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommandTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/commands/CompositeEditCommandTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/commands/InsertTextCommandTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/testing/EditingTestBase.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/testing/SelectionSample.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/editing/testing/SelectionSampleTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/exported/WebElement.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/exported/WebElementTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/exported/WebFrameSerializerSanitizationTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/exported/WebNodeTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/frame/Location.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/frame/Location.h
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/frame/Location.idl
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/frame/MHTMLTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/frame/PerformanceMonitorTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/frame/VisualViewportTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/HTMLElement.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/HTMLEmbedElementTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/HTMLLinkElementTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/HTMLVideoElementPersistentTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/TextControlElementTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/canvas/CanvasFontCacheTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/custom/CustomElementTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/custom/V0CustomElementMicrotaskResolutionStep.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/forms/ExternalPopupMenuTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/forms/OptionListTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/forms/PasswordInputTypeTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/media/AutoplayUmaHelperTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/html/media/MediaCustomControlsFullscreenDetectorTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/input/TouchActionTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/layout/LayoutTestHelper.h
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/layout/TextAutosizerTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/page/DragControllerTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/page/FocusControllerTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/page/PrintContextTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/page/SlotScopedTraversalTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/page/scrolling/RootScrollerTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/page/scrolling/SnapCoordinatorTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/paint/HTMLCanvasPainterTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/paint/VideoPainterTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/modules/accessibility/AXObjectTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/modules/document_metadata/CopylessPasteExtractorTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasTest.cpp
[modify] https://crrev.com/e92361313635c5d5f29ed29b053442c9be8be6ec/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8e9916c04daad19335f5d6412526fb87e1cc359

commit e8e9916c04daad19335f5d6412526fb87e1cc359
Author: Mike West <mkwst@chromium.org>
Date: Tue Sep 26 07:29:47 2017

Trusted Types: First stab at TrustedScriptURL.

koto@ added [`TrustedScriptURL`][1] to the explainer as a mechanism to
distinguish URLs that directly lead to script execution (e.g. via
assignment to `<script>`'s `src` attribute). This patch is a first pass
at an implementation, along with restrictions on `script.src` so we can
test it out.

[1]: https://github.com/mikewest/trusted-types/commit/834163e519b579e5566908cafcedb2efe24be6da

Bug: 739170
Change-Id: Ie784ff3992dbcf750521fd55710befe3ed26036c
Reviewed-on: https://chromium-review.googlesource.com/677390
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#504306}
[add] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedScriptURL.tentative.html
[add] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-script-src.tentative.html
[add] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/LayoutTests/external/wpt/trusted-types/script-src.tentative.html
[modify] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/Source/core/dom/Element.h
[add] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/Source/core/dom/trustedtypes/TrustedScriptURL.cpp
[add] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/Source/core/dom/trustedtypes/TrustedScriptURL.h
[add] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/Source/core/dom/trustedtypes/TrustedScriptURL.idl
[modify] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/Source/core/dom/trustedtypes/TrustedURL.h
[modify] https://crrev.com/e8e9916c04daad19335f5d6412526fb87e1cc359/third_party/WebKit/Source/core/html/HTMLScriptElement.idl

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e0209957aebe3e069df6e64063a838fb6d5f972

commit 7e0209957aebe3e069df6e64063a838fb6d5f972
Author: Mike West <mkwst@chromium.org>
Date: Mon Oct 09 11:14:21 2017

Fix a no-op Trusted Types test.

`promise_test`s should use `promise_rejects` to test rejection, rather
than catching a rejection and asserting something about its properties.

Bug: 739170
Change-Id: Ic3460741f42d56a149d9c0bd816b3510973c72e4
Reviewed-on: https://chromium-review.googlesource.com/704580
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507353}
[modify] https://crrev.com/7e0209957aebe3e069df6e64063a838fb6d5f972/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-href.tentative.html

Comment 4 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 5 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f759f5dd68ceae20ddb56b81a52c7b3c30c8f9ea

commit f759f5dd68ceae20ddb56b81a52c7b3c30c8f9ea
Author: Maja Kabus <kabusm@google.com>
Date: Fri Jul 13 14:17:03 2018

location.assign() and location.replace() changed to accept TrustedTypes

Previous versions of functions made private and named
assignFromString and replaceFromString,respectively.
assign wraps assignFromString.
replace wraps replaceFromString.

Bug: 739170
Change-Id: I3fd39a44fed1482f7e07524815297b9eec322b60
Reviewed-on: https://chromium-review.googlesource.com/1134987
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574907}
[add] https://crrev.com/f759f5dd68ceae20ddb56b81a52c7b3c30c8f9ea/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-assign.tentative.html
[add] https://crrev.com/f759f5dd68ceae20ddb56b81a52c7b3c30c8f9ea/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-replace.tentative.html
[add] https://crrev.com/f759f5dd68ceae20ddb56b81a52c7b3c30c8f9ea/third_party/WebKit/LayoutTests/external/wpt/trusted-types/location-assign.tentative.html
[add] https://crrev.com/f759f5dd68ceae20ddb56b81a52c7b3c30c8f9ea/third_party/WebKit/LayoutTests/external/wpt/trusted-types/location-replace.tentative.html
[modify] https://crrev.com/f759f5dd68ceae20ddb56b81a52c7b3c30c8f9ea/third_party/blink/renderer/core/frame/location.cc
[modify] https://crrev.com/f759f5dd68ceae20ddb56b81a52c7b3c30c8f9ea/third_party/blink/renderer/core/frame/location.h
[modify] https://crrev.com/f759f5dd68ceae20ddb56b81a52c7b3c30c8f9ea/third_party/blink/renderer/core/frame/location.idl

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 16

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b2dcd3a9725c9809a90537c026f47bf42c08311

commit 6b2dcd3a9725c9809a90537c026f47bf42c08311
Author: Orsi Batiz <orsibatiz@google.com>
Date: Wed Jul 18 10:05:05 2018

Creating setAttribute in element.cc with arguments: USVStringOrTrustedURL
and ExceptionState

Changing attribute src of HTMLSourceElement and HTMLImageElement to URLString
Change of SetSrc of HTMLSourceElement and HTMLImageElement to hava arguments
USVStringOrTrustedURL; calling setAttribute mentioned above from it
Changing calls of SetSrc in other files so that the arguments match; wrapping
arguments and using ASSERT_NO_EXCEPTION
Adding tests for SetSrc

Bug: 739170
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ic99a338783bfcbfc5c2dca5061352367c2daeaec
Reviewed-on: https://chromium-review.googlesource.com/1137821
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575992}
[add] https://crrev.com/6b2dcd3a9725c9809a90537c026f47bf42c08311/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLImageElement-src.tentative.html
[add] https://crrev.com/6b2dcd3a9725c9809a90537c026f47bf42c08311/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLSourceElement-src.tentative.html
[add] https://crrev.com/6b2dcd3a9725c9809a90537c026f47bf42c08311/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLImageElement-src.tentative.html
[add] https://crrev.com/6b2dcd3a9725c9809a90537c026f47bf42c08311/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLSourceElement-src.tentative.html
[modify] https://crrev.com/6b2dcd3a9725c9809a90537c026f47bf42c08311/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/6b2dcd3a9725c9809a90537c026f47bf42c08311/third_party/blink/renderer/core/dom/element.h
[modify] https://crrev.com/6b2dcd3a9725c9809a90537c026f47bf42c08311/third_party/blink/renderer/core/html/html_image_element.cc
[modify] https://crrev.com/6b2dcd3a9725c9809a90537c026f47bf42c08311/third_party/blink/renderer/core/html/html_image_element.h
[modify] https://crrev.com/6b2dcd3a9725c9809a90537c026f47bf42c08311/third_party/blink/renderer/core/html/html_image_element.idl
[modify] https://crrev.com/6b2dcd3a9725c9809a90537c026f47bf42c08311/third_party/blink/renderer/core/html/html_source_element.cc
[modify] https://crrev.com/6b2dcd3a9725c9809a90537c026f47bf42c08311/third_party/blink/renderer/core/html/html_source_element.h
[modify] https://crrev.com/6b2dcd3a9725c9809a90537c026f47bf42c08311/third_party/blink/renderer/core/html/html_source_element.idl

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8

commit ac436aaa9d361c99dcf4df11bd11ad201a2bccd8
Author: Maja Kabus <kabusm@google.com>
Date: Wed Jul 18 14:18:26 2018

Adjusted references in tests to match new helper.sub.js file

helper.js changed to helper.sub.js.
URLS.safe modified to work with wpt.

Bug: 739170
Change-Id: I89e0efdb07c94e78be826c8807d0577ede8a97ec
Reviewed-on: https://chromium-review.googlesource.com/1141725
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Maja Kabus <kabusm@google.com>
Cr-Commit-Position: refs/heads/master@{#576037}
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/DOMParser-requiresTrustedTypes.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/DOMParser.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLBaseElement-href.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedHTML.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedScriptURL.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedURL.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLBaseElement-href.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-createContextualFragment.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-innerHTML.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-insertAdjacentHTML.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-assign.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-href.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-replace.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-outerHTML.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-script-src.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/createContextualFragment.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/document-write.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/innerHTML.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/insertAdjacentHTML.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/location-assign.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/location-href.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/location-replace.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/outerHTML.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/script-src.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/srcDoc-requiresTrustedTypes.tentative.html
[modify] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/srcDoc.tentative.html
[rename] https://crrev.com/ac436aaa9d361c99dcf4df11bd11ad201a2bccd8/third_party/WebKit/LayoutTests/external/wpt/trusted-types/support/helper.sub.js

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 18

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a079f46b4034fee7969cb4d3f4a8c03aff38422

commit 8a079f46b4034fee7969cb4d3f4a8c03aff38422
Author: Orsi Batiz <orsibatiz@google.com>
Date: Wed Jul 18 15:00:38 2018

src attribute of HTMLEmbedElement changed from DOMString to ScriptURLString

attribute src of HTMLEmbedElement changed from DOMString to ScriptURLString
Tests added

Bug: 739170
Change-Id: I6ded15b826d1da0d95f31885577db61f5adc7375
Reviewed-on: https://chromium-review.googlesource.com/1140305
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576060}
[add] https://crrev.com/8a079f46b4034fee7969cb4d3f4a8c03aff38422/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-embed-src.tentative.html
[add] https://crrev.com/8a079f46b4034fee7969cb4d3f4a8c03aff38422/third_party/WebKit/LayoutTests/external/wpt/trusted-types/embed-src.tentative.html
[modify] https://crrev.com/8a079f46b4034fee7969cb4d3f4a8c03aff38422/third_party/blink/renderer/core/html/html_embed_element.idl

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe

commit 1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe
Author: Alex Moshchuk <alexmos@chromium.org>
Date: Wed Jul 18 17:17:17 2018

Revert "Adjusted references in tests to match new helper.sub.js file"

This reverts commit ac436aaa9d361c99dcf4df11bd11ad201a2bccd8.

Reason for revert: 
Sorry for the revert, but this might be breaking some layout tests on 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests/71090 (see also a few subsequent builds)

Failing tests include:
 external/wpt/trusted-types/HTMLImageElement-src.tentative.html
 external/wpt/trusted-types/HTMLMediaElement-src.tentative.html
 external/wpt/trusted-types/HTMLSourceElement-src.tentative.html
 external/wpt/trusted-types/block-string-assignment-to-HTMLImageElement-src.tentative.html
 external/wpt/trusted-types/block-string-assignment-to-HTMLMediaElement-src.tentative.html
 external/wpt/trusted-types/block-string-assignment-to-HTMLSourceElement-src.tentative.html

Sample failure output (from external/wpt/trusted-types/HTMLImageElement-src.tentative.html, others are similar):

This is a testharness.js-based test.
FAIL src = TrustedURL.create(). URLS is not defined
FAIL src = TrustedURL.unsafelyCreate(). URLS is not defined
Harness: the test ran to completion.



Original change's description:
> Adjusted references in tests to match new helper.sub.js file
> 
> helper.js changed to helper.sub.js.
> URLS.safe modified to work with wpt.
> 
> Bug: 739170
> Change-Id: I89e0efdb07c94e78be826c8807d0577ede8a97ec
> Reviewed-on: https://chromium-review.googlesource.com/1141725
> Reviewed-by: Mike West <mkwst@chromium.org>
> Commit-Queue: Maja Kabus <kabusm@google.com>
> Cr-Commit-Position: refs/heads/master@{#576037}

TBR=vogelheim@chromium.org,mkwst@chromium.org,kabusm@google.com

Change-Id: Ieaa3bba36a970c7aa7547939c8f97a57a1b32544
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 739170
Reviewed-on: https://chromium-review.googlesource.com/1142165
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576103}
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/DOMParser-requiresTrustedTypes.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/DOMParser.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLBaseElement-href.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedHTML.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedScriptURL.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedURL.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLBaseElement-href.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-createContextualFragment.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-innerHTML.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-insertAdjacentHTML.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-assign.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-href.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-replace.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-outerHTML.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-script-src.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/createContextualFragment.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/document-write.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/innerHTML.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/insertAdjacentHTML.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/location-assign.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/location-href.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/location-replace.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/outerHTML.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/script-src.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/srcDoc-requiresTrustedTypes.tentative.html
[modify] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/srcDoc.tentative.html
[rename] https://crrev.com/1eba109a0a9ecda29a6ef9e4c9083ed75bee5dfe/third_party/WebKit/LayoutTests/external/wpt/trusted-types/support/helper.js

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/053acc161b46a3cd07a95c358cbf896eb98fc3f0

commit 053acc161b46a3cd07a95c358cbf896eb98fc3f0
Author: Ian Clelland <iclelland@chromium.org>
Date: Wed Jul 18 21:59:41 2018

Reland "Adjusted references in tests to match new helper.sub.js file"

This is a reland of ac436aaa9d361c99dcf4df11bd11ad201a2bccd8

Original change's description:
> Adjusted references in tests to match new helper.sub.js file
>
> helper.js changed to helper.sub.js.
> URLS.safe modified to work with wpt.
>
> Bug: 739170
> Change-Id: I89e0efdb07c94e78be826c8807d0577ede8a97ec
> Reviewed-on: https://chromium-review.googlesource.com/1141725
> Reviewed-by: Mike West <mkwst@chromium.org>
> Commit-Queue: Maja Kabus <kabusm@google.com>
> Cr-Commit-Position: refs/heads/master@{#576037}

Bug: 739170
Tbr: alexmos@chromium.org
Change-Id: Idc1e5d5cc4b1dbbc4de4145af38b894c5f4a65b5
Reviewed-on: https://chromium-review.googlesource.com/1142169
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576229}
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/DOMParser-requiresTrustedTypes.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/DOMParser.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLBaseElement-href.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLImageElement-src.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLMediaElement-src.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLSourceElement-src.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedHTML.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedScriptURL.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedURL.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLBaseElement-href.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLImageElement-src.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLMediaElement-src.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLSourceElement-src.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-createContextualFragment.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-embed-src.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-innerHTML.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-insertAdjacentHTML.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-assign.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-href.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-replace.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-outerHTML.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-script-src.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/createContextualFragment.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/document-write.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/embed-src.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/innerHTML.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/insertAdjacentHTML.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/location-assign.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/location-href.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/location-replace.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/outerHTML.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/script-src.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/srcDoc-requiresTrustedTypes.tentative.html
[modify] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/srcDoc.tentative.html
[rename] https://crrev.com/053acc161b46a3cd07a95c358cbf896eb98fc3f0/third_party/WebKit/LayoutTests/external/wpt/trusted-types/support/helper.sub.js

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b4ed8031c901d98734383570ccf4c785fc1aa87

commit 0b4ed8031c901d98734383570ccf4c785fc1aa87
Author: Maja Kabus <kabusm@google.com>
Date: Thu Jul 19 06:58:30 2018

Window, LocalDomWindow and Document open() functions modified to accept
TrustedTypes

Changed open() definitions in .idl files.
Introduced new implementations of LocalDomWindow::open(), old versions
renamed openFromString and moved to private section.
Changed definition of 3-argument version of Document::open.

Bug: 739170
Change-Id: I64931c5e95eaa9dd2d2aab19ccb0bf8896621e7d
Reviewed-on: https://chromium-review.googlesource.com/1141581
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Maja Kabus <kabusm@google.com>
Cr-Commit-Position: refs/heads/master@{#576398}
[add] https://crrev.com/0b4ed8031c901d98734383570ccf4c785fc1aa87/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-window-open.tentative.html
[add] https://crrev.com/0b4ed8031c901d98734383570ccf4c785fc1aa87/third_party/WebKit/LayoutTests/external/wpt/trusted-types/window-open.tentative.html
[modify] https://crrev.com/0b4ed8031c901d98734383570ccf4c785fc1aa87/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/0b4ed8031c901d98734383570ccf4c785fc1aa87/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/0b4ed8031c901d98734383570ccf4c785fc1aa87/third_party/blink/renderer/core/dom/document.idl
[modify] https://crrev.com/0b4ed8031c901d98734383570ccf4c785fc1aa87/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/0b4ed8031c901d98734383570ccf4c785fc1aa87/third_party/blink/renderer/core/frame/local_dom_window.h
[modify] https://crrev.com/0b4ed8031c901d98734383570ccf4c785fc1aa87/third_party/blink/renderer/core/frame/window.idl

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/120d983258c7474607f36f27c35ec47b2f5d5f3c

commit 120d983258c7474607f36f27c35ec47b2f5d5f3c
Author: Orsi Batiz <orsibatiz@google.com>
Date: Thu Jul 19 12:12:27 2018

Changing src attribute of HTMLXXXElement from USVString to URLString

Attribute src of HTMLIFrameElement changed from USVString to URLString
Attribute src of HTMLTrackElement changed from USVString to URLString
Attribute src of HTMLInputElement changed from USVString to URLString
Attribute src of HTMLFrameElement changed from USVString to URLString
Tests created for assignment to src

Bug: 739170
Change-Id: I52254462ab7325264420aac989f08a30adfe4933
Reviewed-on: https://chromium-review.googlesource.com/1139062
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576452}
[add] https://crrev.com/120d983258c7474607f36f27c35ec47b2f5d5f3c/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLIFrameElement-src.tentative.html
[add] https://crrev.com/120d983258c7474607f36f27c35ec47b2f5d5f3c/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLIFrameElement-src.tentative.html
[add] https://crrev.com/120d983258c7474607f36f27c35ec47b2f5d5f3c/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-frame-src.tentative.html
[add] https://crrev.com/120d983258c7474607f36f27c35ec47b2f5d5f3c/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-input-src.tentative.html
[add] https://crrev.com/120d983258c7474607f36f27c35ec47b2f5d5f3c/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-track-src.tentative.html
[add] https://crrev.com/120d983258c7474607f36f27c35ec47b2f5d5f3c/third_party/WebKit/LayoutTests/external/wpt/trusted-types/frame-src.tentative.html
[add] https://crrev.com/120d983258c7474607f36f27c35ec47b2f5d5f3c/third_party/WebKit/LayoutTests/external/wpt/trusted-types/input-src.tentative.html
[add] https://crrev.com/120d983258c7474607f36f27c35ec47b2f5d5f3c/third_party/WebKit/LayoutTests/external/wpt/trusted-types/track-src.tentative.html
[modify] https://crrev.com/120d983258c7474607f36f27c35ec47b2f5d5f3c/third_party/blink/renderer/core/html/forms/html_input_element.idl
[modify] https://crrev.com/120d983258c7474607f36f27c35ec47b2f5d5f3c/third_party/blink/renderer/core/html/html_frame_element.idl
[modify] https://crrev.com/120d983258c7474607f36f27c35ec47b2f5d5f3c/third_party/blink/renderer/core/html/html_iframe_element.idl
[modify] https://crrev.com/120d983258c7474607f36f27c35ec47b2f5d5f3c/third_party/blink/renderer/core/html/track/html_track_element.idl

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61c030481f3ff340215da3c3a2415ca131a05c9e

commit 61c030481f3ff340215da3c3a2415ca131a05c9e
Author: Maja Kabus <kabusm@google.com>
Date: Thu Jul 19 13:20:18 2018

HTMLObjectElement changed to accept Trusted Types

Modified data and codeBase attributes definition in *.idl file.

Bug: 739170
Change-Id: Ia332493450d0e780e4e6eb332708216da02060d1
Reviewed-on: https://chromium-review.googlesource.com/1137824
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576465}
[add] https://crrev.com/61c030481f3ff340215da3c3a2415ca131a05c9e/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLObjectElement.tentative.html
[add] https://crrev.com/61c030481f3ff340215da3c3a2415ca131a05c9e/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLObjectElement.tentative.html
[modify] https://crrev.com/61c030481f3ff340215da3c3a2415ca131a05c9e/third_party/blink/renderer/core/html/html_object_element.idl

Project Member

Comment 20 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15b8ee56782b0a554830ae9cec0d2a210080a098

commit 15b8ee56782b0a554830ae9cec0d2a210080a098
Author: Maja Kabus <kabusm@google.com>
Date: Thu Jul 19 13:21:19 2018

HTMLLinkElement::href modified to accept TrustedTypes

Existing implementation of setHref() changed,
older version is abandoned.
Added new function href() to accept URLString
as an argument.

Bug: 739170
Change-Id: Id57e361574c50b13df1876fe83e8693429b66fc8
Reviewed-on: https://chromium-review.googlesource.com/1136635
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576466}
[add] https://crrev.com/15b8ee56782b0a554830ae9cec0d2a210080a098/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLLinkElement-href.tentative.html
[add] https://crrev.com/15b8ee56782b0a554830ae9cec0d2a210080a098/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLLinkElement-href.tentative.html
[modify] https://crrev.com/15b8ee56782b0a554830ae9cec0d2a210080a098/third_party/blink/renderer/core/html/html_link_element.idl

Project Member

Comment 21 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d08cdfe7c019223f43a34dec416ed069067b4b9

commit 3d08cdfe7c019223f43a34dec416ed069067b4b9
Author: Maja Kabus <kabusm@google.com>
Date: Thu Jul 19 16:45:51 2018

HTMLAnchorElement::href and HTMLAreaElement::href changed
to accept Trusted Types

Existing implementation of setHref moved from DOMURLUtils
to DOMURL
New implementation of setHref added to DOMURLUtils
New implementations of href() added to DOMURLUtilsReadOnly
to accept URLString as an argument

Bug: 739170
Change-Id: I047d6a564e65a3be78436faef8780f60b85e8f7c
Reviewed-on: https://chromium-review.googlesource.com/1143391
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576525}
[add] https://crrev.com/3d08cdfe7c019223f43a34dec416ed069067b4b9/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLAnchorElement-href.tentative.html
[add] https://crrev.com/3d08cdfe7c019223f43a34dec416ed069067b4b9/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLAreaElement-href.tentative.html
[add] https://crrev.com/3d08cdfe7c019223f43a34dec416ed069067b4b9/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLAnchorElement-href.tentative.html
[add] https://crrev.com/3d08cdfe7c019223f43a34dec416ed069067b4b9/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLAreaElement-href.tentative.html
[modify] https://crrev.com/3d08cdfe7c019223f43a34dec416ed069067b4b9/third_party/blink/renderer/core/html/html_hyperlink_element_utils.idl
[modify] https://crrev.com/3d08cdfe7c019223f43a34dec416ed069067b4b9/third_party/blink/renderer/core/url/dom_url.cc
[modify] https://crrev.com/3d08cdfe7c019223f43a34dec416ed069067b4b9/third_party/blink/renderer/core/url/dom_url.h
[modify] https://crrev.com/3d08cdfe7c019223f43a34dec416ed069067b4b9/third_party/blink/renderer/core/url/dom_url_utils.cc
[modify] https://crrev.com/3d08cdfe7c019223f43a34dec416ed069067b4b9/third_party/blink/renderer/core/url/dom_url_utils.h
[modify] https://crrev.com/3d08cdfe7c019223f43a34dec416ed069067b4b9/third_party/blink/renderer/core/url/dom_url_utils_read_only.cc
[modify] https://crrev.com/3d08cdfe7c019223f43a34dec416ed069067b4b9/third_party/blink/renderer/core/url/dom_url_utils_read_only.h

Blockedon: 865900
Project Member

Comment 23 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86c9de0fc5587d093b9d3175ceecfa098e3ecf81

commit 86c9de0fc5587d093b9d3175ceecfa098e3ecf81
Author: Orsi Batiz <orsibatiz@google.com>
Date: Tue Jul 24 07:47:33 2018

GetString added in TrustedURL

Function String GetString(USVStringOrTrustedURL, const Document*, ExceptionState&)
has been added to trusted_url.cc
All other callsites (setAttribute in element.cc, open in local_dom_window.cc,
assign, replace and setHref in location.cc) have been updated to call this function
setHref in html_base_element.cc has been changed to call a different setAttribute
from element.cc (the one mentioned above), this way there was no need to call
GetString in there as well

Bug: 739170
Change-Id: I07b9fee53ea62aa706bb59814f147a394f214549
Reviewed-on: https://chromium-review.googlesource.com/1144927
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577449}
[modify] https://crrev.com/86c9de0fc5587d093b9d3175ceecfa098e3ecf81/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/86c9de0fc5587d093b9d3175ceecfa098e3ecf81/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/86c9de0fc5587d093b9d3175ceecfa098e3ecf81/third_party/blink/renderer/core/frame/location.cc
[modify] https://crrev.com/86c9de0fc5587d093b9d3175ceecfa098e3ecf81/third_party/blink/renderer/core/html/html_base_element.cc
[modify] https://crrev.com/86c9de0fc5587d093b9d3175ceecfa098e3ecf81/third_party/blink/renderer/core/trustedtypes/trusted_url.cc
[modify] https://crrev.com/86c9de0fc5587d093b9d3175ceecfa098e3ecf81/third_party/blink/renderer/core/trustedtypes/trusted_url.h

Project Member

Comment 24 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/182500b6508e429c1834a46c23e53aa7ed5a3761

commit 182500b6508e429c1834a46c23e53aa7ed5a3761
Author: Orsi Batiz <orsibatiz@google.com>
Date: Tue Jul 24 07:48:35 2018

GetString added in TrustedHTML

Function String GetString(StringOrTrustedHTML, const Document*, ExceptionState&)
has been added to trusted_html.cc
All other callsites (setInnerHTML, setOuterHTML, setAttribute in element.cc,
parseFromString in dom_parser.cc and createContextualFragment in range.cc,
setInnerHTML in shadow_root.cc) have been updated to call this function

Bug: 739170
Change-Id: Ie84462cd233669e55f2b76e685d5d3545198ee59
Reviewed-on: https://chromium-review.googlesource.com/1142768
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577450}
[modify] https://crrev.com/182500b6508e429c1834a46c23e53aa7ed5a3761/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/182500b6508e429c1834a46c23e53aa7ed5a3761/third_party/blink/renderer/core/dom/range.cc
[modify] https://crrev.com/182500b6508e429c1834a46c23e53aa7ed5a3761/third_party/blink/renderer/core/dom/shadow_root.cc
[modify] https://crrev.com/182500b6508e429c1834a46c23e53aa7ed5a3761/third_party/blink/renderer/core/trustedtypes/trusted_html.cc
[modify] https://crrev.com/182500b6508e429c1834a46c23e53aa7ed5a3761/third_party/blink/renderer/core/trustedtypes/trusted_html.h
[modify] https://crrev.com/182500b6508e429c1834a46c23e53aa7ed5a3761/third_party/blink/renderer/core/xml/dom_parser.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f08daecfd3c91a5c20efae98ff9ee19e3344d858

commit f08daecfd3c91a5c20efae98ff9ee19e3344d858
Author: Maja Kabus <kabusm@google.com>
Date: Thu Jul 26 07:53:26 2018

Reverted changes introduced in change 1143391 and added
HTMLAnchorElement::setHref()

Added setHref() function to HTMLAnchorElement to accept
TrustedTypes.
Changes introduced by change 1143391 in DOMURL and
DOMURLUtils abandoned, and in DOMURLUtilsReadOnly
- modified.

Bug: 739170, 866488
Change-Id: I006662624699dfcb0c49a4dbb060ec2264c60baf
Reviewed-on: https://chromium-review.googlesource.com/1150031
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578235}
[modify] https://crrev.com/f08daecfd3c91a5c20efae98ff9ee19e3344d858/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/f08daecfd3c91a5c20efae98ff9ee19e3344d858/third_party/blink/renderer/core/html/html_anchor_element.h
[modify] https://crrev.com/f08daecfd3c91a5c20efae98ff9ee19e3344d858/third_party/blink/renderer/core/html/html_hyperlink_element_utils.idl
[modify] https://crrev.com/f08daecfd3c91a5c20efae98ff9ee19e3344d858/third_party/blink/renderer/core/url/dom_url.cc
[modify] https://crrev.com/f08daecfd3c91a5c20efae98ff9ee19e3344d858/third_party/blink/renderer/core/url/dom_url.h
[modify] https://crrev.com/f08daecfd3c91a5c20efae98ff9ee19e3344d858/third_party/blink/renderer/core/url/dom_url_utils.cc
[modify] https://crrev.com/f08daecfd3c91a5c20efae98ff9ee19e3344d858/third_party/blink/renderer/core/url/dom_url_utils.h
[modify] https://crrev.com/f08daecfd3c91a5c20efae98ff9ee19e3344d858/third_party/blink/renderer/core/url/dom_url_utils_read_only.cc
[modify] https://crrev.com/f08daecfd3c91a5c20efae98ff9ee19e3344d858/third_party/blink/renderer/core/url/dom_url_utils_read_only.h

Project Member

Comment 26 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/854efe827036e7cb6df534a0efe0a6e32b3cb1fb

commit 854efe827036e7cb6df534a0efe0a6e32b3cb1fb
Author: Orsi Batiz <orsibatiz@google.com>
Date: Thu Jul 26 12:37:47 2018

Created new interface and class TrustedTypePolicy

Created interface TrustedTypePolicy with readonly attribute name of type
DOMString
Added function createPolicy(const String& policyName) to
TrustedTypePolicyFactory class


Bug: 739170
Change-Id: Iada8bbdb697b24f450290d27e2673df3974fc2cd
Reviewed-on: https://chromium-review.googlesource.com/1148440
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578271}
[add] https://crrev.com/854efe827036e7cb6df534a0efe0a6e32b3cb1fb/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy.tentative.html
[add] https://crrev.com/854efe827036e7cb6df534a0efe0a6e32b3cb1fb/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Window-trustedTypes.tentative.html
[modify] https://crrev.com/854efe827036e7cb6df534a0efe0a6e32b3cb1fb/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/854efe827036e7cb6df534a0efe0a6e32b3cb1fb/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/854efe827036e7cb6df534a0efe0a6e32b3cb1fb/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/854efe827036e7cb6df534a0efe0a6e32b3cb1fb/third_party/blink/renderer/core/frame/local_dom_window.h
[modify] https://crrev.com/854efe827036e7cb6df534a0efe0a6e32b3cb1fb/third_party/blink/renderer/core/frame/window.idl
[modify] https://crrev.com/854efe827036e7cb6df534a0efe0a6e32b3cb1fb/third_party/blink/renderer/core/trustedtypes/BUILD.gn
[add] https://crrev.com/854efe827036e7cb6df534a0efe0a6e32b3cb1fb/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.cc
[add] https://crrev.com/854efe827036e7cb6df534a0efe0a6e32b3cb1fb/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.h
[add] https://crrev.com/854efe827036e7cb6df534a0efe0a6e32b3cb1fb/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.idl
[add] https://crrev.com/854efe827036e7cb6df534a0efe0a6e32b3cb1fb/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc
[add] https://crrev.com/854efe827036e7cb6df534a0efe0a6e32b3cb1fb/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.h
[add] https://crrev.com/854efe827036e7cb6df534a0efe0a6e32b3cb1fb/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.idl

Project Member

Comment 27 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df79c4b01ef505d7e975ad00ea4c891242a198fa

commit df79c4b01ef505d7e975ad00ea4c891242a198fa
Author: Maja Kabus <kabusm@google.com>
Date: Mon Aug 13 11:48:03 2018

Replaced HTML*Element tests with two generic test files

HTML*Element href and src test files merged into two
HTMLElement-generic test files.

Bug: 739170
Change-Id: I3cf49c9d72540c7f51439fb157f1d201048a349e
Reviewed-on: https://chromium-review.googlesource.com/1146567
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582550}
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLAnchorElement-href.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLAreaElement-href.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLBaseElement-href.tentative.html
[add] https://crrev.com/df79c4b01ef505d7e975ad00ea4c891242a198fa/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLElement-generic.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLIFrameElement-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLImageElement-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLLinkElement-href.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLMediaElement-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLObjectElement.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLSourceElement-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLAnchorElement-href.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLAreaElement-href.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLBaseElement-href.tentative.html
[add] https://crrev.com/df79c4b01ef505d7e975ad00ea4c891242a198fa/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLIFrameElement-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLImageElement-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLLinkElement-href.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLMediaElement-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLObjectElement.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLSourceElement-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-embed-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-frame-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-input-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-script-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-track-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/embed-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/frame-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/input-src.tentative.html
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/script-src.tentative.html
[modify] https://crrev.com/df79c4b01ef505d7e975ad00ea4c891242a198fa/third_party/WebKit/LayoutTests/external/wpt/trusted-types/support/helper.sub.js
[delete] https://crrev.com/ecdeaeda77d1cecf8c4feb5834a27f434e756b0a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/track-src.tentative.html

Project Member

Comment 28 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/805100686757fb55544c02d83e4c146650a55399

commit 805100686757fb55544c02d83e4c146650a55399
Author: Maja Kabus <kabusm@google.com>
Date: Fri Aug 17 13:04:00 2018

Introduced dictionary TrustedTypePolicyOptions

Created new dictionary TrustedTypePolicyOptions with callbacks and
adjusted TrustedTypePolicyFactory and TrustedTypePolicy to accept the
dictionary.

Added createURL() and createScriptURL, and adjusted createHTML()
in TrustedTypePolicyOptions.

Bug: 739170
Change-Id: Ie63fdf90b5aac53188fcd8141c95d287c3e726fd
Reviewed-on: https://chromium-review.googlesource.com/1167282
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Maja Kabus <kabusm@google.com>
Cr-Commit-Position: refs/heads/master@{#584038}
[modify] https://crrev.com/805100686757fb55544c02d83e4c146650a55399/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy.tentative.html
[modify] https://crrev.com/805100686757fb55544c02d83e4c146650a55399/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/805100686757fb55544c02d83e4c146650a55399/third_party/blink/renderer/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/805100686757fb55544c02d83e4c146650a55399/third_party/blink/renderer/bindings/scripts/v8_types.py
[modify] https://crrev.com/805100686757fb55544c02d83e4c146650a55399/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/805100686757fb55544c02d83e4c146650a55399/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.cc
[modify] https://crrev.com/805100686757fb55544c02d83e4c146650a55399/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.h
[modify] https://crrev.com/805100686757fb55544c02d83e4c146650a55399/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.idl
[modify] https://crrev.com/805100686757fb55544c02d83e4c146650a55399/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc
[modify] https://crrev.com/805100686757fb55544c02d83e4c146650a55399/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.h
[modify] https://crrev.com/805100686757fb55544c02d83e4c146650a55399/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.idl
[add] https://crrev.com/805100686757fb55544c02d83e4c146650a55399/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_options.idl

Project Member

Comment 29 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6

commit 53b12b9d8454f0f3db649aff794b7ed34a7d9ee6
Author: Maja Kabus <kabusm@google.com>
Date: Fri Aug 17 17:14:06 2018

TrustedTypes tests updated to match newest API version.

Bug: 739170
Change-Id: Ia0ec627627b8ad6b208eb9351f3e7786e6d2c9b2
Reviewed-on: https://chromium-review.googlesource.com/1177752
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584108}
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/DOMParser-parseFromString.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/DOMParser-requiresTrustedTypes.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/DOMParser.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Document-write.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Element-insertAdjacentHTML.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Element-outerHTML.tentative.html
[modify] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLElement-generic.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Location-assign.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Location-href.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Location-replace.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Range-createContextualFragment.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedHTML.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedScriptURL.tentative.html
[modify] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedURL.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Window-open.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-DOMParser-parseFromString.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Document-write.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-insertAdjacentHTML.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-outerHTML.tentative.html
[modify] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-assign.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-href.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-replace.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Range-createContextualFragment.tentative.html
[add] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Window-open.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-createContextualFragment.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-innerHTML.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-insertAdjacentHTML.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-assign.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-href.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-location-replace.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-outerHTML.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-window-open.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/createContextualFragment.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/document-write.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/innerHTML.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/insertAdjacentHTML.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/location-assign.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/location-href.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/location-replace.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/outerHTML.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/srcDoc-requiresTrustedTypes.tentative.html
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/srcDoc.tentative.html
[modify] https://crrev.com/53b12b9d8454f0f3db649aff794b7ed34a7d9ee6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/support/helper.sub.js
[delete] https://crrev.com/323f860eb0cfafe56bb784b5f9674d6d6b15ea05/third_party/WebKit/LayoutTests/external/wpt/trusted-types/window-open.tentative.html

Project Member

Comment 30 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a

commit fd253972e5e9a0ed19629ea1883497ac7dcc4d8a
Author: Maja Kabus <kabusm@google.com>
Date: Fri Aug 17 21:30:29 2018

Added new class TrustedScript to TrustedTypes

New class TrustedScript added as a C++ implementation of JS
TrustedScript.

Bug: 739170
Change-Id: Ife70f8838aefa6bb4aac45f09639464c19de6e1b
Reviewed-on: https://chromium-review.googlesource.com/1168494
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584197}
[modify] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy.tentative.html
[modify] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/support/helper.sub.js
[modify] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/blink/renderer/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/blink/renderer/core/trustedtypes/BUILD.gn
[add] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/blink/renderer/core/trustedtypes/trusted_script.cc
[add] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/blink/renderer/core/trustedtypes/trusted_script.h
[add] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/blink/renderer/core/trustedtypes/trusted_script.idl
[modify] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.cc
[modify] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.h
[modify] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.idl
[modify] https://crrev.com/fd253972e5e9a0ed19629ea1883497ac7dcc4d8a/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_options.idl

Project Member

Comment 31 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/136008de5d2e0b2e1913bcbcbd641b2bd4158bee

commit 136008de5d2e0b2e1913bcbcbd641b2bd4158bee
Author: Orsi Batiz <orsibatiz@google.com>
Date: Tue Aug 28 09:28:47 2018

TrustedTypes: Added TrustedTypes.getPolicyNames & minor changes

Changed window.trustedTypes to window.TrustedTypes.
Added TrustedTypes.getPolicyNames.
Throw exception for TrustedTypes.createPolicy with non-unique policy name.
Adapted tests to match.
Most existing applications are synchronous, createPolicy was made synchronous.
Changed tests from async_test to test, because of change mentioned above.

Bug: 739170
Change-Id: Ie4e2702994a8674e65376b7bf4b42d4c41e9cec4
Reviewed-on: https://chromium-review.googlesource.com/1181362
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586630}
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/DOMParser-parseFromString.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Document-write.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Element-insertAdjacentHTML.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Element-outerHTML.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLElement-generic.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Location-assign.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Location-href.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Location-replace.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Range-createContextualFragment.tentative.html
[add] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-createXYZTests.tentative.html
[add] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-nameTests.tentative.html
[delete] https://crrev.com/eb0dd58a9102dd0a0896086ce577e37349d05dde/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy.tentative.html
[rename] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Window-TrustedTypes.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Window-open.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-DOMParser-parseFromString.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Document-write.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-insertAdjacentHTML.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-outerHTML.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-assign.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-href.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-replace.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Range-createContextualFragment.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Window-open.tentative.html
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/external/wpt/trusted-types/support/helper.sub.js
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/blink/renderer/core/frame/window.idl
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.cc
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.h
[modify] https://crrev.com/136008de5d2e0b2e1913bcbcbd641b2bd4158bee/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.idl

Project Member

Comment 32 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36788839c8fb09472f4c54ec8369cc3dfd1521f6

commit 36788839c8fb09472f4c54ec8369cc3dfd1521f6
Author: Orsi Batiz <orsibatiz@google.com>
Date: Thu Aug 30 12:50:53 2018

TrustedTypes: Added TrustedTypes.getExposedPolicy(name) & minor changes

Added TrustedTypes.getExposedPolicy(name) and bool exposed in TrustedTypePolicyOptions
Added test
Changed Vector of created policies into Map of created policies

Bug: 739170
Change-Id: Ib5fe7a14ddadb88e3de70ee55f2783b9d10a01b5
Reviewed-on: https://chromium-review.googlesource.com/1193869
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587534}
[add] https://crrev.com/36788839c8fb09472f4c54ec8369cc3dfd1521f6/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-exposedTests.tentative.html
[modify] https://crrev.com/36788839c8fb09472f4c54ec8369cc3dfd1521f6/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/36788839c8fb09472f4c54ec8369cc3dfd1521f6/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.cc
[modify] https://crrev.com/36788839c8fb09472f4c54ec8369cc3dfd1521f6/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.h
[modify] https://crrev.com/36788839c8fb09472f4c54ec8369cc3dfd1521f6/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc
[modify] https://crrev.com/36788839c8fb09472f4c54ec8369cc3dfd1521f6/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.h
[modify] https://crrev.com/36788839c8fb09472f4c54ec8369cc3dfd1521f6/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.idl
[modify] https://crrev.com/36788839c8fb09472f4c54ec8369cc3dfd1521f6/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_options.idl

Project Member

Comment 33 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5e545c6dc59e06f752241c053f9bb03c120a35b

commit d5e545c6dc59e06f752241c053f9bb03c120a35b
Author: Maja Kabus <kabusm@google.com>
Date: Tue Sep 04 07:51:29 2018

TrustedTypes util file with GetString() and GetStringWithoutCheck()
added

Definition of a union type that can replace any of Trusted Types added.
New functions GetString() and GetStringWithoutCheck() added in a util
file to accept the generic Trusted Type as an argument.

The change is required in situations where multiple Trusted Types could
be matched as an argument of a function e.g. in change 1146563.

Bug: 739170
Change-Id: Iea619108633dc80c8807b90da0df6f84a08585c8
Reviewed-on: https://chromium-review.googlesource.com/1196517
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588466}
[modify] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/trustedtypes/BUILD.gn
[modify] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.idl
[add] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc
[add] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/trustedtypes/trusted_types_util.h
[add] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/trustedtypes/trusted_types_util_test.cc

Project Member

Comment 34 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80

commit 0b2a75e2c4e8759f82deff1ed7229bb8ac740a80
Author: Maja Kabus <kabusm@google.com>
Date: Tue Sep 04 11:32:03 2018

Global GetStringFromTrustedXXX() functions added to trusted_types_util.*

Static GetString() functions removed from TrustedHTML, TrustedScript
and TrustedURL. Their implementations has been moved into global
GetStringFromTrusted{HTML | Script | ScriptURL | URL} functions
in the util file.

Calls to GetString() adjusted in the files that use it.

Bug: 739170
Change-Id: I1f73b2d63164fc8df4ad9c16dd6806a109a2db0b
Reviewed-on: https://chromium-review.googlesource.com/1203831
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Maja Kabus <kabusm@google.com>
Cr-Commit-Position: refs/heads/master@{#588486}
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/dom/range.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/dom/shadow_root.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/frame/location.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_html.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_html.h
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_script.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_script.h
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_types_util.h
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_types_util_test.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_url.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_url.h
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/xml/dom_parser.cc

Project Member

Comment 35 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0479ae0ce4e3cb9cd93660096713de4fb795031d

commit 0479ae0ce4e3cb9cd93660096713de4fb795031d
Author: Orsi Batiz <orsibatiz@google.com>
Date: Tue Sep 04 12:53:16 2018

String_list_directive created

Created a primitive version of function AllowTrustedTypePolicy
"require-trusted-types" changed into "trusted-types" and takes a list of policy names
createPolicy updated to throw when policy name is not allowed
Tests added for policy creation attempt when policy name is on the whitelist and when it isn't
Tests added fot policy creation attempt with no whitelist given
Poked at existing tests to change "require-trusted-types" into "trusted-types"
Removed boolean require_safe_types_ from csp_directive_list

Bug: 739170
Change-Id: Ida0188cf38f8edba8b966b2f708b7a7919d08b29
Reviewed-on: https://chromium-review.googlesource.com/1186325
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Cr-Commit-Position: refs/heads/master@{#588496}
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLElement-generic.tentative.html
[add] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-noNamesGiven.tentative.html
[add] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-DOMParser-parseFromString.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Document-write.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-insertAdjacentHTML.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-outerHTML.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-assign.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-href.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-replace.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Range-createContextualFragment.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Window-open.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/BUILD.gn
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/content_security_policy.cc
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/content_security_policy.h
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/csp_directive_list.cc
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/csp_directive_list.h
[add] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/string_list_directive.cc
[add] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/string_list_directive.h
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc

Project Member

Comment 36 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5e545c6dc59e06f752241c053f9bb03c120a35b

commit d5e545c6dc59e06f752241c053f9bb03c120a35b
Author: Maja Kabus <kabusm@google.com>
Date: Tue Sep 04 07:51:29 2018

TrustedTypes util file with GetString() and GetStringWithoutCheck()
added

Definition of a union type that can replace any of Trusted Types added.
New functions GetString() and GetStringWithoutCheck() added in a util
file to accept the generic Trusted Type as an argument.

The change is required in situations where multiple Trusted Types could
be matched as an argument of a function e.g. in change 1146563.

Bug: 739170
Change-Id: Iea619108633dc80c8807b90da0df6f84a08585c8
Reviewed-on: https://chromium-review.googlesource.com/1196517
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588466}
[modify] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/trustedtypes/BUILD.gn
[modify] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.idl
[add] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc
[add] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/trustedtypes/trusted_types_util.h
[add] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/trustedtypes/trusted_types_util_test.cc

Project Member

Comment 37 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80

commit 0b2a75e2c4e8759f82deff1ed7229bb8ac740a80
Author: Maja Kabus <kabusm@google.com>
Date: Tue Sep 04 11:32:03 2018

Global GetStringFromTrustedXXX() functions added to trusted_types_util.*

Static GetString() functions removed from TrustedHTML, TrustedScript
and TrustedURL. Their implementations has been moved into global
GetStringFromTrusted{HTML | Script | ScriptURL | URL} functions
in the util file.

Calls to GetString() adjusted in the files that use it.

Bug: 739170
Change-Id: I1f73b2d63164fc8df4ad9c16dd6806a109a2db0b
Reviewed-on: https://chromium-review.googlesource.com/1203831
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Maja Kabus <kabusm@google.com>
Cr-Commit-Position: refs/heads/master@{#588486}
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/dom/range.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/dom/shadow_root.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/frame/location.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_html.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_html.h
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_script.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_script.h
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_types_util.h
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_types_util_test.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_url.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_url.h
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/xml/dom_parser.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0479ae0ce4e3cb9cd93660096713de4fb795031d

commit 0479ae0ce4e3cb9cd93660096713de4fb795031d
Author: Orsi Batiz <orsibatiz@google.com>
Date: Tue Sep 04 12:53:16 2018

String_list_directive created

Created a primitive version of function AllowTrustedTypePolicy
"require-trusted-types" changed into "trusted-types" and takes a list of policy names
createPolicy updated to throw when policy name is not allowed
Tests added for policy creation attempt when policy name is on the whitelist and when it isn't
Tests added fot policy creation attempt with no whitelist given
Poked at existing tests to change "require-trusted-types" into "trusted-types"
Removed boolean require_safe_types_ from csp_directive_list

Bug: 739170
Change-Id: Ida0188cf38f8edba8b966b2f708b7a7919d08b29
Reviewed-on: https://chromium-review.googlesource.com/1186325
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Cr-Commit-Position: refs/heads/master@{#588496}
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLElement-generic.tentative.html
[add] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-noNamesGiven.tentative.html
[add] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-DOMParser-parseFromString.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Document-write.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-insertAdjacentHTML.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-outerHTML.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-assign.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-href.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-replace.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Range-createContextualFragment.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Window-open.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/BUILD.gn
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/content_security_policy.cc
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/content_security_policy.h
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/csp_directive_list.cc
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/csp_directive_list.h
[add] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/string_list_directive.cc
[add] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/string_list_directive.h
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc

Project Member

Comment 39 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5e545c6dc59e06f752241c053f9bb03c120a35b

commit d5e545c6dc59e06f752241c053f9bb03c120a35b
Author: Maja Kabus <kabusm@google.com>
Date: Tue Sep 04 07:51:29 2018

TrustedTypes util file with GetString() and GetStringWithoutCheck()
added

Definition of a union type that can replace any of Trusted Types added.
New functions GetString() and GetStringWithoutCheck() added in a util
file to accept the generic Trusted Type as an argument.

The change is required in situations where multiple Trusted Types could
be matched as an argument of a function e.g. in change 1146563.

Bug: 739170
Change-Id: Iea619108633dc80c8807b90da0df6f84a08585c8
Reviewed-on: https://chromium-review.googlesource.com/1196517
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588466}
[modify] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/trustedtypes/BUILD.gn
[modify] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.idl
[add] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc
[add] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/trustedtypes/trusted_types_util.h
[add] https://crrev.com/d5e545c6dc59e06f752241c053f9bb03c120a35b/third_party/blink/renderer/core/trustedtypes/trusted_types_util_test.cc

Project Member

Comment 40 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80

commit 0b2a75e2c4e8759f82deff1ed7229bb8ac740a80
Author: Maja Kabus <kabusm@google.com>
Date: Tue Sep 04 11:32:03 2018

Global GetStringFromTrustedXXX() functions added to trusted_types_util.*

Static GetString() functions removed from TrustedHTML, TrustedScript
and TrustedURL. Their implementations has been moved into global
GetStringFromTrusted{HTML | Script | ScriptURL | URL} functions
in the util file.

Calls to GetString() adjusted in the files that use it.

Bug: 739170
Change-Id: I1f73b2d63164fc8df4ad9c16dd6806a109a2db0b
Reviewed-on: https://chromium-review.googlesource.com/1203831
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Maja Kabus <kabusm@google.com>
Cr-Commit-Position: refs/heads/master@{#588486}
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/dom/range.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/dom/shadow_root.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/frame/location.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_html.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_html.h
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_script.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_script.h
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_types_util.h
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_types_util_test.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_url.cc
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/trustedtypes/trusted_url.h
[modify] https://crrev.com/0b2a75e2c4e8759f82deff1ed7229bb8ac740a80/third_party/blink/renderer/core/xml/dom_parser.cc

Project Member

Comment 41 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0479ae0ce4e3cb9cd93660096713de4fb795031d

commit 0479ae0ce4e3cb9cd93660096713de4fb795031d
Author: Orsi Batiz <orsibatiz@google.com>
Date: Tue Sep 04 12:53:16 2018

String_list_directive created

Created a primitive version of function AllowTrustedTypePolicy
"require-trusted-types" changed into "trusted-types" and takes a list of policy names
createPolicy updated to throw when policy name is not allowed
Tests added for policy creation attempt when policy name is on the whitelist and when it isn't
Tests added fot policy creation attempt with no whitelist given
Poked at existing tests to change "require-trusted-types" into "trusted-types"
Removed boolean require_safe_types_ from csp_directive_list

Bug: 739170
Change-Id: Ida0188cf38f8edba8b966b2f708b7a7919d08b29
Reviewed-on: https://chromium-review.googlesource.com/1186325
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Cr-Commit-Position: refs/heads/master@{#588496}
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLElement-generic.tentative.html
[add] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-noNamesGiven.tentative.html
[add] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-DOMParser-parseFromString.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Document-write.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-insertAdjacentHTML.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-outerHTML.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-assign.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-href.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-replace.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Range-createContextualFragment.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Window-open.tentative.html
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/BUILD.gn
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/content_security_policy.cc
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/content_security_policy.h
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/csp_directive_list.cc
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/csp_directive_list.h
[add] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/string_list_directive.cc
[add] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/frame/csp/string_list_directive.h
[modify] https://crrev.com/0479ae0ce4e3cb9cd93660096713de4fb795031d/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc

Project Member

Comment 42 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62e9021d26d7113ef35dda8eff8472a15e614f95

commit 62e9021d26d7113ef35dda8eff8472a15e614f95
Author: Maja Kabus <kabusm@google.com>
Date: Wed Sep 05 14:25:16 2018

Removed redundant functions and headers from TrustedXXX files

Removed TrustedHTML::escape(), TrustedHTML::unsafelyCreate(),
TrustedScriptURL::unsafelyCreate(), TrustedURL::create(),
TrustedURL::unsafelyCreate().

Current version of Trusted Types API is based on policies and no longer
uses the functions mentioned above.

Bug: 739170
Change-Id: I2bfc430bab3fa9a68ab9f3a0e5d76070841cec51
Reviewed-on: https://chromium-review.googlesource.com/1206474
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588860}
[modify] https://crrev.com/62e9021d26d7113ef35dda8eff8472a15e614f95/third_party/blink/renderer/core/trustedtypes/trusted_html.cc
[modify] https://crrev.com/62e9021d26d7113ef35dda8eff8472a15e614f95/third_party/blink/renderer/core/trustedtypes/trusted_html.h
[modify] https://crrev.com/62e9021d26d7113ef35dda8eff8472a15e614f95/third_party/blink/renderer/core/trustedtypes/trusted_html.idl
[modify] https://crrev.com/62e9021d26d7113ef35dda8eff8472a15e614f95/third_party/blink/renderer/core/trustedtypes/trusted_script.cc
[modify] https://crrev.com/62e9021d26d7113ef35dda8eff8472a15e614f95/third_party/blink/renderer/core/trustedtypes/trusted_script.h
[modify] https://crrev.com/62e9021d26d7113ef35dda8eff8472a15e614f95/third_party/blink/renderer/core/trustedtypes/trusted_script.idl
[modify] https://crrev.com/62e9021d26d7113ef35dda8eff8472a15e614f95/third_party/blink/renderer/core/trustedtypes/trusted_script_url.cc
[modify] https://crrev.com/62e9021d26d7113ef35dda8eff8472a15e614f95/third_party/blink/renderer/core/trustedtypes/trusted_script_url.h
[modify] https://crrev.com/62e9021d26d7113ef35dda8eff8472a15e614f95/third_party/blink/renderer/core/trustedtypes/trusted_script_url.idl
[modify] https://crrev.com/62e9021d26d7113ef35dda8eff8472a15e614f95/third_party/blink/renderer/core/trustedtypes/trusted_url.cc
[modify] https://crrev.com/62e9021d26d7113ef35dda8eff8472a15e614f95/third_party/blink/renderer/core/trustedtypes/trusted_url.h
[modify] https://crrev.com/62e9021d26d7113ef35dda8eff8472a15e614f95/third_party/blink/renderer/core/trustedtypes/trusted_url.idl

Project Member

Comment 43 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71

commit bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71
Author: Maja Kabus <kabusm@google.com>
Date: Wed Sep 05 15:11:23 2018

Element::setAttribute() modified to accept TrustedTypes

Element::setAttribute() modified to accept generic TrustedType
(StringOrTrustedHTMLOrTrustedScriptOrTrustedScriptURLOrTrustedURL)
(the name will be changed later).
This is the implementation used for setting attributes explicitly.

Added virtual GetCheckedAttributesNames() method, overriden in
HTMLXXXElement files, to return list of names of attributes that
need to have values checked against Trusted Types.

Added new implementations of Element::setAttribute(),
one per each Trusted Type, to be used internally
in HTMLElement functions.

Corrected existing TrustedXXX::GetString() implementations
to be concise.
Added TrustedScriptURL::GetString().

Bug: 739170
Change-Id: I3a9f51cbed5d75f8059141738b419cc66e529006
Reviewed-on: https://chromium-review.googlesource.com/1146563
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588867}
[add] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Element-setAttribute.tentative.html
[add] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-setAttribute.tentative.html
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/WebKit/LayoutTests/external/wpt/trusted-types/support/helper.sub.js
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/dom/element.h
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/dom/element.idl
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/forms/html_input_element.h
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_anchor_element.h
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_base_element.cc
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_base_element.h
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_embed_element.cc
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_embed_element.h
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_frame_element.cc
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_frame_element.h
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_iframe_element.cc
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_iframe_element.h
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_image_element.cc
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_image_element.h
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_link_element.cc
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_link_element.h
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_object_element.cc
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_object_element.h
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_script_element.cc
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_script_element.h
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_source_element.cc
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/html_source_element.h
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/media/html_media_element.h
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/track/html_track_element.cc
[modify] https://crrev.com/bc1bd3c02b8a2fcdcb423aacbe1ca4bbdbc81b71/third_party/blink/renderer/core/html/track/html_track_element.h

Project Member

Comment 44 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e14b9063b02d10b7f22bb08a9cd24787b71fa336

commit e14b9063b02d10b7f22bb08a9cd24787b71fa336
Author: Maja Kabus <kabusm@google.com>
Date: Thu Sep 06 13:17:39 2018

Idlharness.js tests added for Trusted Types API

Added Idlharness tests for Trusted Types interfaces.
Removed "Worker" from "Exposed=(...)" in TrustedXXX .idl files.

Bug: 739170
Change-Id: Id8834affcdded63f3ebb9ebd4d288cfd01ef24a8
Reviewed-on: https://chromium-review.googlesource.com/1204150
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589146}
[add] https://crrev.com/e14b9063b02d10b7f22bb08a9cd24787b71fa336/third_party/WebKit/LayoutTests/external/wpt/interfaces/trusted-types.tentative.idl
[add] https://crrev.com/e14b9063b02d10b7f22bb08a9cd24787b71fa336/third_party/WebKit/LayoutTests/external/wpt/trusted-types/idlharness.window.js
[modify] https://crrev.com/e14b9063b02d10b7f22bb08a9cd24787b71fa336/third_party/blink/renderer/core/trustedtypes/trusted_html.idl
[modify] https://crrev.com/e14b9063b02d10b7f22bb08a9cd24787b71fa336/third_party/blink/renderer/core/trustedtypes/trusted_script.idl
[modify] https://crrev.com/e14b9063b02d10b7f22bb08a9cd24787b71fa336/third_party/blink/renderer/core/trustedtypes/trusted_script_url.idl
[modify] https://crrev.com/e14b9063b02d10b7f22bb08a9cd24787b71fa336/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.idl
[modify] https://crrev.com/e14b9063b02d10b7f22bb08a9cd24787b71fa336/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.idl
[modify] https://crrev.com/e14b9063b02d10b7f22bb08a9cd24787b71fa336/third_party/blink/renderer/core/trustedtypes/trusted_url.idl

Project Member

Comment 45 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac90fa42a69da011287675ae7140a6116f20e508

commit ac90fa42a69da011287675ae7140a6116f20e508
Author: Maja Kabus <kabusm@google.com>
Date: Thu Sep 13 17:41:04 2018

Element::setAttributeNS() modified to accept TrustedTypes

Added new implementation of Element::setAttributeNS() to accept
generic TrustedType as an argument.
Existing implementation renamed to Element::setAttributeNSInternal
and made private.

Bug: 739170
Change-Id: Ib83250f579ba63fc519d1870671b2801c2ce2c5c
Reviewed-on: https://chromium-review.googlesource.com/1221321
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591062}
[add] https://crrev.com/ac90fa42a69da011287675ae7140a6116f20e508/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Element-setAttributeNS.tentative.html
[add] https://crrev.com/ac90fa42a69da011287675ae7140a6116f20e508/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-setAttributeNS.tentative.html
[modify] https://crrev.com/ac90fa42a69da011287675ae7140a6116f20e508/third_party/WebKit/LayoutTests/external/wpt/trusted-types/support/helper.sub.js
[modify] https://crrev.com/ac90fa42a69da011287675ae7140a6116f20e508/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/ac90fa42a69da011287675ae7140a6116f20e508/third_party/blink/renderer/core/dom/element.h
[modify] https://crrev.com/ac90fa42a69da011287675ae7140a6116f20e508/third_party/blink/renderer/core/dom/element.idl

Project Member

Comment 46 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eebc4d85a73150ccfd01d610784174d88c3cddb4

commit eebc4d85a73150ccfd01d610784174d88c3cddb4
Author: Maja Kabus <kabusm@google.com>
Date: Fri Sep 14 12:04:53 2018

DOMWindowTimers::setTimeout and setInterval modified to accept Trusted
Types.

New implementations of DOMWindowTimers::setTimeout() and setInterval()
added to accept TrustedScript as an argument.
Previously existing implementations renamed to setTimeoutFromString()
and setIntervalFromString(), respectively.

Bug: 739170
Change-Id: I3513ebb651534f0b1ef1b8de9c694136b02e2412
Reviewed-on: https://chromium-review.googlesource.com/1179899
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Maja Kabus <kabusm@google.com>
Cr-Commit-Position: refs/heads/master@{#591327}
[modify] https://crrev.com/eebc4d85a73150ccfd01d610784174d88c3cddb4/third_party/WebKit/LayoutTests/external/wpt/lint.whitelist
[add] https://crrev.com/eebc4d85a73150ccfd01d610784174d88c3cddb4/third_party/WebKit/LayoutTests/external/wpt/trusted-types/DOMWindowTimers-setTimeout-setInterval.tentative.html
[add] https://crrev.com/eebc4d85a73150ccfd01d610784174d88c3cddb4/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-DOMWindowTimers-setTimeout-setInterval.tentative.html
[modify] https://crrev.com/eebc4d85a73150ccfd01d610784174d88c3cddb4/third_party/blink/renderer/core/frame/dom_window_timers.cc
[modify] https://crrev.com/eebc4d85a73150ccfd01d610784174d88c3cddb4/third_party/blink/renderer/core/frame/dom_window_timers.h
[modify] https://crrev.com/eebc4d85a73150ccfd01d610784174d88c3cddb4/third_party/blink/renderer/core/frame/window_timers.idl

Project Member

Comment 48 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55f1176ad26062f50fa68c9735ef34e387905112

commit 55f1176ad26062f50fa68c9735ef34e387905112
Author: Daniel Vogelheim <vogelheim@chromium.org>
Date: Tue Sep 25 09:28:58 2018

Added SetterCallWith=ScriptState

SetterCallWith=ScriptState would be useful for TrustedTypes, because callbacks use script_state, mainly in setters
Made the necessary changes to support it

Bug: 739170
Change-Id: Iae271baf09fe511da33fb715f4a0f0f7ad7c4f20
Reviewed-on: https://chromium-review.googlesource.com/1238465
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593876}
[modify] https://crrev.com/55f1176ad26062f50fa68c9735ef34e387905112/third_party/blink/renderer/bindings/IDLExtendedAttributes.txt
[modify] https://crrev.com/55f1176ad26062f50fa68c9735ef34e387905112/third_party/blink/renderer/bindings/scripts/v8_attributes.py
[modify] https://crrev.com/55f1176ad26062f50fa68c9735ef34e387905112/third_party/blink/renderer/bindings/templates/attributes.cpp.tmpl
[modify] https://crrev.com/55f1176ad26062f50fa68c9735ef34e387905112/third_party/blink/renderer/platform/bindings/script_state.h

Project Member

Comment 49 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f492353dd73374a68d45fb35e529f8a72d227f38

commit f492353dd73374a68d45fb35e529f8a72d227f38
Author: Daniel Vogelheim <vogelheim@chromium.org>
Date: Wed Sep 26 15:04:06 2018

CSP/Trusted Types: No trusted-types policy means CSP allows all policies.

It's possible to use Trusted Types without the trusted-types CSP directive.
In that case, all policies are allowed. (The current code will just crash.)

Bug: 739170
Change-Id: I0a832be30f97f7401db221038119af491e418521
Reviewed-on: https://chromium-review.googlesource.com/1245781
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594313}
[modify] https://crrev.com/f492353dd73374a68d45fb35e529f8a72d227f38/third_party/blink/renderer/core/frame/csp/content_security_policy_test.cc
[modify] https://crrev.com/f492353dd73374a68d45fb35e529f8a72d227f38/third_party/blink/renderer/core/frame/csp/csp_directive_list.cc

Project Member

Comment 50 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c4b351dceb1ea31bf989627500f1b8ea3f72805

commit 7c4b351dceb1ea31bf989627500f1b8ea3f72805
Author: Daniel Vogelheim <vogelheim@chromium.org>
Date: Mon Oct 01 13:26:52 2018

[Trusted Types] Add renderer/core/trustedtypes/OWNERS

Bug: 739170
Change-Id: Ia158d98717cf0360870f46eeabca0777b1954ec1
Reviewed-on: https://chromium-review.googlesource.com/1243143
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595439}
[add] https://crrev.com/7c4b351dceb1ea31bf989627500f1b8ea3f72805/third_party/blink/renderer/core/trustedtypes/OWNERS

Project Member

Comment 51 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4bc9a82d16224f36de1ff8680574ac094d2cf7a

commit a4bc9a82d16224f36de1ff8680574ac094d2cf7a
Author: Maja Kabus <kabusm@google.com>
Date: Mon Oct 01 19:02:36 2018

Attribute case-insensivity for Trusted Type attribute assignments

Element::setAttribute() implementation with TrustedType modified to
prevent insecure case-insensitive attributes change with strings.

Bug: 739170
Change-Id: Ia0636f4791cbc204b679de510e5c676de817dd11
Reviewed-on: https://chromium-review.googlesource.com/1238539
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595493}
[modify] https://crrev.com/a4bc9a82d16224f36de1ff8680574ac094d2cf7a/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-setAttribute.tentative.html
[modify] https://crrev.com/a4bc9a82d16224f36de1ff8680574ac094d2cf7a/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/a4bc9a82d16224f36de1ff8680574ac094d2cf7a/third_party/blink/renderer/core/html/html_object_element.cc

Project Member

Comment 52 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/534cd7bbd0a8f325ed9d5a3d89200503d17da501

commit 534cd7bbd0a8f325ed9d5a3d89200503d17da501
Author: Maja Kabus <kabusm@google.com>
Date: Mon Oct 01 20:03:22 2018

isXXX methods added to TrustedTypePolicyFactory

isHTML(), isScript(), isScriptURL() and isURL() added to
TrustedTypePolicyFactory class as part of Trusted Types API update to
current JS polyfill.
The methods require additional code to be fully matched to polyfill
expected behaviour.

Added a helper private method GetWrapperTypeInfoFromScriptValue.

Bug: 739170
Change-Id: I027e43ab6432405c686255a4d0ce24248c59a4dc
Reviewed-on: https://chromium-review.googlesource.com/1238433
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595527}
[modify] https://crrev.com/534cd7bbd0a8f325ed9d5a3d89200503d17da501/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-createXYZTests.tentative.html
[add] https://crrev.com/534cd7bbd0a8f325ed9d5a3d89200503d17da501/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-isXXX.tentative.html
[modify] https://crrev.com/534cd7bbd0a8f325ed9d5a3d89200503d17da501/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/534cd7bbd0a8f325ed9d5a3d89200503d17da501/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc
[modify] https://crrev.com/534cd7bbd0a8f325ed9d5a3d89200503d17da501/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.h
[modify] https://crrev.com/534cd7bbd0a8f325ed9d5a3d89200503d17da501/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.idl

Project Member

Comment 53 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/deba13d3348946ca8aed98349faa4a21768d13e3

commit deba13d3348946ca8aed98349faa4a21768d13e3
Author: Daniel Vogelheim <vogelheim@chromium.org>
Date: Thu Oct 04 13:04:47 2018

Trusted Types: Implement "trusted-types *" and reserved names.

- An empty trusted-types declaration means no policies are allowed.
- A declaration of only "*" means all policies are allowed.
- Quoted strings are considered reserved (and thus cannot be policy names)

This aligns the implementation close with the trusted types polyfill.

Bug: 739170
Change-Id: If9fc66e80d60a81ec4228da35ae8c8820ebaa9b5
Reviewed-on: https://chromium-review.googlesource.com/c/1249269
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596638}
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-noNamesGiven.tentative.html
[add] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-wildcard.tentative.html
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-isXXX.tentative.html
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-DOMParser-parseFromString.tentative.html
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-DOMWindowTimers-setTimeout-setInterval.tentative.html
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Document-write.tentative.html
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-insertAdjacentHTML.tentative.html
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-outerHTML.tentative.html
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-setAttribute.tentative.html
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-setAttributeNS.tentative.html
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative.html
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-assign.tentative.html
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-href.tentative.html
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-replace.tentative.html
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Range-createContextualFragment.tentative.html
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Window-open.tentative.html
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/blink/renderer/core/frame/csp/content_security_policy_test.cc
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/blink/renderer/core/frame/csp/string_list_directive.cc
[modify] https://crrev.com/deba13d3348946ca8aed98349faa4a21768d13e3/third_party/blink/renderer/core/frame/csp/string_list_directive.h

Project Member

Comment 54 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ba7adede87a2eb016077622edb2bb366c7d19cd

commit 7ba7adede87a2eb016077622edb2bb366c7d19cd
Author: Daniel Vogelheim <vogelheim@chromium.org>
Date: Tue Nov 06 17:20:31 2018

Added mechanisms for default policy

With a default policy defined, assignments implicitly call createXXX on the default policy
Added ScriptState* to the accessors visible from JavaScript
Tests were updated to check string assignment when trusted-types are needed before and after the default policy is defined

Bug: 739170
Change-Id: I9bb841d69f324b841602d41abd71f753a9858af8
Reviewed-on: https://chromium-review.googlesource.com/c/1207530
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605720}
[add] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-defaultTests.tentative.html
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/Window-TrustedTypes.tentative.html
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-DOMParser-parseFromString.tentative.html
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-DOMWindowTimers-setTimeout-setInterval.tentative.html
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Document-write.tentative.html
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-insertAdjacentHTML.tentative.html
[add] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-outerHTML.tentative-expected.txt
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-outerHTML.tentative.html
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Element-setAttribute.tentative.html
[add] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative-expected.txt
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative.html
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-assign.tentative.html
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-href.tentative.html
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Location-replace.tentative.html
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Range-createContextualFragment.tentative.html
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-Window-open.tentative.html
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/WebKit/LayoutTests/external/wpt/trusted-types/support/helper.sub.js
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/blink/renderer/bindings/core/v8/custom/v8_element_custom.cc
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/blink/renderer/bindings/core/v8/custom/v8_shadow_root_custom.cc
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.cc
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.cc
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.h
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc
[modify] https://crrev.com/7ba7adede87a2eb016077622edb2bb366c7d19cd/third_party/blink/renderer/core/trustedtypes/trusted_types_util_test.cc

Project Member

Comment 55 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f897aba16c282977e361e733ca690044c199d899

commit f897aba16c282977e361e733ca690044c199d899
Author: Daniel Vogelheim <vogelheim@chromium.org>
Date: Thu Nov 08 13:11:22 2018

IDL compiler: Use inner type name for annotated types for GetAs* method.

Bug: 739170
Change-Id: I147200074ddd29f49d89a246c2a3a9e6cee132d1
Reviewed-on: https://chromium-review.googlesource.com/c/1325987
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606438}
[modify] https://crrev.com/f897aba16c282977e361e733ca690044c199d899/third_party/blink/renderer/bindings/scripts/v8_union.py
[modify] https://crrev.com/f897aba16c282977e361e733ca690044c199d899/third_party/blink/renderer/bindings/tests/results/core/string_treat_null_as_empty_string_or_long.cc

Project Member

Comment 56 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2abc21e5cedb9bf59c94192d72847c1e65b9b3ba

commit 2abc21e5cedb9bf59c94192d72847c1e65b9b3ba
Author: Daniel Vogelheim <vogelheim@chromium.org>
Date: Mon Nov 12 15:26:44 2018

HTMLScriptElement text attributes modified to accept TrustedTypes

HTMLScriptElement::text() and setText() functions modified to accept
TrustedScript as an argument.
Added HTMLScriptElement::innerText and HTMLScriptElement:textContent
attributes to override existing implementations in HTMLElement
and Node, and to accept TrustedScript.

Changed HTMLElement::innerText and Node::textContent .idl definitions
and adjusted setters and getters to accept TrustedScript.

Bug: 739170
Change-Id: I63da5714ffac328c6ae2f76e5da58c05f44a1cbf
Reviewed-on: https://chromium-review.googlesource.com/c/1178046
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607232}
[modify] https://crrev.com/2abc21e5cedb9bf59c94192d72847c1e65b9b3ba/third_party/WebKit/LayoutTests/external/wpt/trusted-types/HTMLElement-generic.tentative.html
[modify] https://crrev.com/2abc21e5cedb9bf59c94192d72847c1e65b9b3ba/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative-expected.txt
[modify] https://crrev.com/2abc21e5cedb9bf59c94192d72847c1e65b9b3ba/third_party/WebKit/LayoutTests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative.html
[modify] https://crrev.com/2abc21e5cedb9bf59c94192d72847c1e65b9b3ba/third_party/blink/renderer/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/2abc21e5cedb9bf59c94192d72847c1e65b9b3ba/third_party/blink/renderer/core/dom/node.cc
[modify] https://crrev.com/2abc21e5cedb9bf59c94192d72847c1e65b9b3ba/third_party/blink/renderer/core/dom/node.h
[modify] https://crrev.com/2abc21e5cedb9bf59c94192d72847c1e65b9b3ba/third_party/blink/renderer/core/dom/node.idl
[modify] https://crrev.com/2abc21e5cedb9bf59c94192d72847c1e65b9b3ba/third_party/blink/renderer/core/html/html_element.cc
[modify] https://crrev.com/2abc21e5cedb9bf59c94192d72847c1e65b9b3ba/third_party/blink/renderer/core/html/html_element.h
[modify] https://crrev.com/2abc21e5cedb9bf59c94192d72847c1e65b9b3ba/third_party/blink/renderer/core/html/html_element.idl
[modify] https://crrev.com/2abc21e5cedb9bf59c94192d72847c1e65b9b3ba/third_party/blink/renderer/core/html/html_script_element.cc
[modify] https://crrev.com/2abc21e5cedb9bf59c94192d72847c1e65b9b3ba/third_party/blink/renderer/core/html/html_script_element.h
[modify] https://crrev.com/2abc21e5cedb9bf59c94192d72847c1e65b9b3ba/third_party/blink/renderer/core/html/html_script_element.idl
[modify] https://crrev.com/2abc21e5cedb9bf59c94192d72847c1e65b9b3ba/third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc

Project Member

Comment 57 by bugdroid1@chromium.org, Nov 28

Project Member

Comment 58 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef

commit a25a9162d9bafa429ecf914d80f6ffeb6b31fdef
Author: Daniel Vogelheim <vogelheim@chromium.org>
Date: Tue Dec 04 14:13:36 2018

WorkerGlobalScope::importScripts() modified to accept TrustedTypes

Existing implementation made private and renamed
importScriptsFromString.
New version wraps importScriptsFromString.
Service_Worker_Global_Scope::importScripts() signature adjusted
to accept TrustedTypes.

Bug: 739170
Change-Id: Ifa7d9e9f13f0903ecdf0b4c1553f6039141b9b76
Reviewed-on: https://chromium-review.googlesource.com/c/1144825
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613538}
[modify] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/renderer/core/frame/window.idl
[modify] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc
[modify] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.h
[modify] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.idl
[modify] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/renderer/core/workers/worker_global_scope.cc
[modify] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/renderer/core/workers/worker_global_scope.h
[modify] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/renderer/core/workers/worker_global_scope.idl
[modify] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
[modify] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.h
[modify] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/web_tests/external/wpt/interfaces/trusted-types.tentative.idl
[add] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/web_tests/external/wpt/trusted-types/WorkerGlobalScope-importScripts.https.html
[add] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/web_tests/external/wpt/trusted-types/WorkerGlobalScope-importScripts.https.js
[add] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/web_tests/external/wpt/trusted-types/WorkerGlobalScope-importScripts.https.js.headers
[add] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/web_tests/external/wpt/trusted-types/support/worker.js
[modify] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/a25a9162d9bafa429ecf914d80f6ffeb6b31fdef/third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt

Project Member

Comment 59 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7767e2a1b9d044e7b284a34ec943e6357b6aff4f

commit 7767e2a1b9d044e7b284a34ec943e6357b6aff4f
Author: Daniel Vogelheim <vogelheim@chromium.org>
Date: Wed Dec 05 11:27:36 2018

[Trusted Types] Tests from WICG GitHub ported to WPT

WICG GitHub = https://github.com/WICG/trusted-types/tree/master/tests
ported

Bug: 739170
Change-Id: I56563c16facd7c17d79e7b5625115a0f045618f8
Reviewed-on: https://chromium-review.googlesource.com/c/1209708
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613937}
[add] https://crrev.com/7767e2a1b9d044e7b284a34ec943e6357b6aff4f/third_party/blink/web_tests/external/wpt/trusted-types/GlobalEventHandlers-onclick.tentative.html
[add] https://crrev.com/7767e2a1b9d044e7b284a34ec943e6357b6aff4f/third_party/blink/web_tests/external/wpt/trusted-types/TrustedTypePolicy-CSP-no-name.tentative.html
[add] https://crrev.com/7767e2a1b9d044e7b284a34ec943e6357b6aff4f/third_party/blink/web_tests/external/wpt/trusted-types/TrustedTypePolicy-CSP-wildcard.tentative.html
[add] https://crrev.com/7767e2a1b9d044e7b284a34ec943e6357b6aff4f/third_party/blink/web_tests/external/wpt/trusted-types/TrustedTypePolicy-CSP.tentative.html
[add] https://crrev.com/7767e2a1b9d044e7b284a34ec943e6357b6aff4f/third_party/blink/web_tests/external/wpt/trusted-types/TrustedTypePolicy-createXXX.tentative.html
[add] https://crrev.com/7767e2a1b9d044e7b284a34ec943e6357b6aff4f/third_party/blink/web_tests/external/wpt/trusted-types/TrustedTypePolicy-exposed.tentative.html
[add] https://crrev.com/7767e2a1b9d044e7b284a34ec943e6357b6aff4f/third_party/blink/web_tests/external/wpt/trusted-types/TrustedTypePolicy-name.tentative.html
[modify] https://crrev.com/7767e2a1b9d044e7b284a34ec943e6357b6aff4f/third_party/blink/web_tests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests.tentative.html
[modify] https://crrev.com/7767e2a1b9d044e7b284a34ec943e6357b6aff4f/third_party/blink/web_tests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-exposedTests.tentative.html
[modify] https://crrev.com/7767e2a1b9d044e7b284a34ec943e6357b6aff4f/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-Document-write.tentative.html
[modify] https://crrev.com/7767e2a1b9d044e7b284a34ec943e6357b6aff4f/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-Element-setAttribute.tentative.html
[modify] https://crrev.com/7767e2a1b9d044e7b284a34ec943e6357b6aff4f/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-Location-assign.tentative.html
[modify] https://crrev.com/7767e2a1b9d044e7b284a34ec943e6357b6aff4f/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-Location-href.tentative.html
[modify] https://crrev.com/7767e2a1b9d044e7b284a34ec943e6357b6aff4f/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-Location-replace.tentative.html
[modify] https://crrev.com/7767e2a1b9d044e7b284a34ec943e6357b6aff4f/third_party/blink/web_tests/external/wpt/trusted-types/support/helper.sub.js

Project Member

Comment 60 by bugdroid1@chromium.org, Dec 18

Project Member

Comment 62 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a54a0773e501aeb3b7149271149223632c478a71

commit a54a0773e501aeb3b7149271149223632c478a71
Author: Jakub Vrana <jakubvrana@google.com>
Date: Mon Jan 07 12:48:45 2019

Trusted Types: Store TrustedURL and TrustedScriptURL contents as string

Bug: 739170, 913180
Change-Id: I01391891d89aeb55e387059ed4c4a4b92c6dcd7b
Reviewed-on: https://chromium-review.googlesource.com/c/1375714
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620299}
[modify] https://crrev.com/a54a0773e501aeb3b7149271149223632c478a71/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/a54a0773e501aeb3b7149271149223632c478a71/third_party/blink/renderer/core/trustedtypes/trusted_script_url.cc
[modify] https://crrev.com/a54a0773e501aeb3b7149271149223632c478a71/third_party/blink/renderer/core/trustedtypes/trusted_script_url.h
[modify] https://crrev.com/a54a0773e501aeb3b7149271149223632c478a71/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.cc
[modify] https://crrev.com/a54a0773e501aeb3b7149271149223632c478a71/third_party/blink/renderer/core/trustedtypes/trusted_types_util_test.cc
[modify] https://crrev.com/a54a0773e501aeb3b7149271149223632c478a71/third_party/blink/renderer/core/trustedtypes/trusted_url.cc
[modify] https://crrev.com/a54a0773e501aeb3b7149271149223632c478a71/third_party/blink/renderer/core/trustedtypes/trusted_url.h
[modify] https://crrev.com/a54a0773e501aeb3b7149271149223632c478a71/third_party/blink/web_tests/external/wpt/trusted-types/TrustedTypePolicy-createXXX.tentative.html
[modify] https://crrev.com/a54a0773e501aeb3b7149271149223632c478a71/third_party/blink/web_tests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-createXYZTests.tentative.html
[modify] https://crrev.com/a54a0773e501aeb3b7149271149223632c478a71/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-Element-setAttribute.tentative.html
[modify] https://crrev.com/a54a0773e501aeb3b7149271149223632c478a71/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative.html

Project Member

Comment 64 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a2deccebf26f63280ed91b2ed2898649ebdc5f4

commit 5a2deccebf26f63280ed91b2ed2898649ebdc5f4
Author: Jakub Vrana <jakubvrana@google.com>
Date: Thu Jan 10 15:38:52 2019

Allow only correct Trusted Type in setAttribute

This now matches the behavior of assigning properties. The correct
Trusted Type is allowed, incorrect Trusted Type is converted to string
and then treated as string.

Bug: 919121, 739170
Change-Id: I400915f3c3d960f99f13b4e6894a61a9334e78b1
Reviewed-on: https://chromium-review.googlesource.com/c/1400668
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Jakub Vrana <jakubvrana@google.com>
Cr-Commit-Position: refs/heads/master@{#621589}
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/dom/element.h
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/forms/html_input_element.h
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_anchor_element.h
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_base_element.cc
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_base_element.h
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_embed_element.cc
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_embed_element.h
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_frame_element.cc
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_frame_element.h
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_iframe_element.cc
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_iframe_element.h
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_image_element.cc
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_image_element.h
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_link_element.cc
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_link_element.h
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_object_element.cc
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_object_element.h
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_script_element.cc
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_script_element.h
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_source_element.cc
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/html_source_element.h
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/media/html_media_element.h
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/track/html_track_element.cc
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/html/track/html_track_element.h
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/renderer/core/trustedtypes/trusted_types_util.h
[modify] https://crrev.com/5a2deccebf26f63280ed91b2ed2898649ebdc5f4/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-Element-setAttribute.tentative.html

Project Member

Comment 65 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/822e75f724b501832a7abb1353cf5c7e400d4aa0

commit 822e75f724b501832a7abb1353cf5c7e400d4aa0
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Thu Jan 10 17:12:35 2019

[Sheriff] Revert "Trusted Types: Store TrustedURL and TrustedScriptURL contents as string"

This reverts commit a54a0773e501aeb3b7149271149223632c478a71.

Reason for revert: flakiness https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTU0YTA3NzNlNTAxYWViM2I3MTQ5MjcxMTQ5MjIzNjMyYzQ3OGE3MQw

BUG=chromium:919833

Original change's description:
> Trusted Types: Store TrustedURL and TrustedScriptURL contents as string
> 
> Bug: 739170, 913180
> Change-Id: I01391891d89aeb55e387059ed4c4a4b92c6dcd7b
> Reviewed-on: https://chromium-review.googlesource.com/c/1375714
> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#620299}

TBR=vogelheim@chromium.org,mkwst@chromium.org,jakubvrana@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 739170, 913180
Change-Id: Ic3561942a74f6106d629c5f3a7b30014719bc7d5
Reviewed-on: https://chromium-review.googlesource.com/c/1405188
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621617}
[modify] https://crrev.com/822e75f724b501832a7abb1353cf5c7e400d4aa0/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/822e75f724b501832a7abb1353cf5c7e400d4aa0/third_party/blink/renderer/core/trustedtypes/trusted_script_url.cc
[modify] https://crrev.com/822e75f724b501832a7abb1353cf5c7e400d4aa0/third_party/blink/renderer/core/trustedtypes/trusted_script_url.h
[modify] https://crrev.com/822e75f724b501832a7abb1353cf5c7e400d4aa0/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.cc
[modify] https://crrev.com/822e75f724b501832a7abb1353cf5c7e400d4aa0/third_party/blink/renderer/core/trustedtypes/trusted_types_util_test.cc
[modify] https://crrev.com/822e75f724b501832a7abb1353cf5c7e400d4aa0/third_party/blink/renderer/core/trustedtypes/trusted_url.cc
[modify] https://crrev.com/822e75f724b501832a7abb1353cf5c7e400d4aa0/third_party/blink/renderer/core/trustedtypes/trusted_url.h
[modify] https://crrev.com/822e75f724b501832a7abb1353cf5c7e400d4aa0/third_party/blink/web_tests/external/wpt/trusted-types/TrustedTypePolicy-createXXX.tentative.html
[modify] https://crrev.com/822e75f724b501832a7abb1353cf5c7e400d4aa0/third_party/blink/web_tests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-createXYZTests.tentative.html
[modify] https://crrev.com/822e75f724b501832a7abb1353cf5c7e400d4aa0/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-Element-setAttribute.tentative.html
[modify] https://crrev.com/822e75f724b501832a7abb1353cf5c7e400d4aa0/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative.html

Project Member

Comment 66 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7125f00d56b72de13a58378478d7b928114b1308

commit 7125f00d56b72de13a58378478d7b928114b1308
Author: Jakub Vrana <jakubvrana@google.com>
Date: Thu Jan 10 18:57:18 2019

Require TrustedURL in form.action and .formAction

Bug: 739170
Change-Id: I50691fcab4f13fdaee47a4b4750ef7d3b4544848
Reviewed-on: https://chromium-review.googlesource.com/c/1397613
Commit-Queue: Jakub Vrana <jakubvrana@google.com>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621676}
[modify] https://crrev.com/7125f00d56b72de13a58378478d7b928114b1308/third_party/blink/renderer/core/html/forms/html_button_element.cc
[modify] https://crrev.com/7125f00d56b72de13a58378478d7b928114b1308/third_party/blink/renderer/core/html/forms/html_button_element.h
[modify] https://crrev.com/7125f00d56b72de13a58378478d7b928114b1308/third_party/blink/renderer/core/html/forms/html_button_element.idl
[modify] https://crrev.com/7125f00d56b72de13a58378478d7b928114b1308/third_party/blink/renderer/core/html/forms/html_form_control_element.cc
[modify] https://crrev.com/7125f00d56b72de13a58378478d7b928114b1308/third_party/blink/renderer/core/html/forms/html_form_control_element.h
[modify] https://crrev.com/7125f00d56b72de13a58378478d7b928114b1308/third_party/blink/renderer/core/html/forms/html_form_element.cc
[modify] https://crrev.com/7125f00d56b72de13a58378478d7b928114b1308/third_party/blink/renderer/core/html/forms/html_form_element.h
[modify] https://crrev.com/7125f00d56b72de13a58378478d7b928114b1308/third_party/blink/renderer/core/html/forms/html_form_element.idl
[modify] https://crrev.com/7125f00d56b72de13a58378478d7b928114b1308/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/7125f00d56b72de13a58378478d7b928114b1308/third_party/blink/renderer/core/html/forms/html_input_element.idl
[modify] https://crrev.com/7125f00d56b72de13a58378478d7b928114b1308/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-Element-setAttribute.tentative.html
[modify] https://crrev.com/7125f00d56b72de13a58378478d7b928114b1308/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative-expected.txt
[modify] https://crrev.com/7125f00d56b72de13a58378478d7b928114b1308/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative.html

Project Member

Comment 68 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08ab22533f042bf27bf609599a1ef16d5aeb1b76

commit 08ab22533f042bf27bf609599a1ef16d5aeb1b76
Author: Daniel Vogelheim <vogelheim@chromium.org>
Date: Fri Jan 18 14:24:06 2019

Store TrustedURL and TrustedScriptURL contents as string, take 2

Reland of crrev.com/c/1375714, with fix for the leaky test in crbug.com/919833.

BUG=739170, 919833

Change-Id: Id20122f815e676462446675e4cf853acb1e1e4ae
Reviewed-on: https://chromium-review.googlesource.com/c/1406709
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624108}
[modify] https://crrev.com/08ab22533f042bf27bf609599a1ef16d5aeb1b76/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/08ab22533f042bf27bf609599a1ef16d5aeb1b76/third_party/blink/renderer/core/trustedtypes/trusted_script_url.cc
[modify] https://crrev.com/08ab22533f042bf27bf609599a1ef16d5aeb1b76/third_party/blink/renderer/core/trustedtypes/trusted_script_url.h
[modify] https://crrev.com/08ab22533f042bf27bf609599a1ef16d5aeb1b76/third_party/blink/renderer/core/trustedtypes/trusted_type_policy.cc
[modify] https://crrev.com/08ab22533f042bf27bf609599a1ef16d5aeb1b76/third_party/blink/renderer/core/trustedtypes/trusted_types_util_test.cc
[modify] https://crrev.com/08ab22533f042bf27bf609599a1ef16d5aeb1b76/third_party/blink/renderer/core/trustedtypes/trusted_url.cc
[modify] https://crrev.com/08ab22533f042bf27bf609599a1ef16d5aeb1b76/third_party/blink/renderer/core/trustedtypes/trusted_url.h
[modify] https://crrev.com/08ab22533f042bf27bf609599a1ef16d5aeb1b76/third_party/blink/web_tests/external/wpt/trusted-types/TrustedTypePolicy-createXXX.tentative.html
[modify] https://crrev.com/08ab22533f042bf27bf609599a1ef16d5aeb1b76/third_party/blink/web_tests/external/wpt/trusted-types/TrustedTypePolicyFactory-createPolicy-createXYZTests.tentative.html
[modify] https://crrev.com/08ab22533f042bf27bf609599a1ef16d5aeb1b76/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-Element-setAttribute.tentative.html
[modify] https://crrev.com/08ab22533f042bf27bf609599a1ef16d5aeb1b76/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-HTMLElement-generic.tentative.html
[modify] https://crrev.com/08ab22533f042bf27bf609599a1ef16d5aeb1b76/third_party/blink/web_tests/external/wpt/trusted-types/block-string-assignment-to-Window-open.tentative.html

Sign in to add a comment