Leapfrog: preconnect to the end of a redirect chain at navigation time |
|||||||||||
Issue descriptionThis is a tracking bug for leapfrog.
,
Jul 11 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/ad90c807024e9f130f5879e2c50cabc6f5577cf2 commit ad90c807024e9f130f5879e2c50cabc6f5577cf2 Author: Benoît Lizé <lizeb@google.com> Date: Tue Jul 11 12:29:22 2017
,
Jul 13 2017
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67e17f3964ba1388b9b14c8d423d0441d210a94b commit 67e17f3964ba1388b9b14c8d423d0441d210a94b Author: Benoit Lize <lizeb@chromium.org> Date: Mon Jul 24 12:21:59 2017 customtabs: Always call CustomTabsConnection.onHandledIntent(). Previously, only new intents going to the current active session would go through CustomTabsConnection.onHandledIntent(), which is not the intended behavior, as this is used to trigger preconnection to redirect endpoints. Bug: 739165 Change-Id: Ie9da5dcf4e25f4d0ca2044cba20956a316f7a253 Reviewed-on: https://chromium-review.googlesource.com/581110 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#488952} [modify] https://crrev.com/67e17f3964ba1388b9b14c8d423d0441d210a94b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
,
Jul 25 2017
Requesting a merge to M61 for the commit above. Rationale: small bug fix for new code, and a feature aimed at M61.
,
Jul 26 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76374f4e2d8c63808c0eb74d779e354e15795f00 commit 76374f4e2d8c63808c0eb74d779e354e15795f00 Author: Benoit Lize <lizeb@chromium.org> Date: Wed Jul 26 13:19:53 2017 customtabs: Always call CustomTabsConnection.onHandledIntent(). Previously, only new intents going to the current active session would go through CustomTabsConnection.onHandledIntent(), which is not the intended behavior, as this is used to trigger preconnection to redirect endpoints. TBR=lizeb@chromium.org (cherry picked from commit 67e17f3964ba1388b9b14c8d423d0441d210a94b) Bug: 739165 Change-Id: Ie9da5dcf4e25f4d0ca2044cba20956a316f7a253 Reviewed-on: https://chromium-review.googlesource.com/581110 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488952} Reviewed-on: https://chromium-review.googlesource.com/586551 Reviewed-by: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#55} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/76374f4e2d8c63808c0eb74d779e354e15795f00/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c5197808ef235ba93e0376b6d8288b12a7e26be commit 6c5197808ef235ba93e0376b6d8288b12a7e26be Author: Benoit Lize <lizeb@chromium.org> Date: Thu Jul 27 15:43:47 2017 android: Test that preconnects can be issued from the Java side. Preconnects can be initiated from WarmupManager. This adds the testing infrastructure and a basic test checking that these preconnects are actually issued. This is required to test the redirect preconnection handling for Custom Tabs. Forthcoming CLs will add tests to check that the sockets are re-used, and end-to-end tests of redirect preconnection. In terms of implementation: Native: - Sets an EmbeddedTestServerConnectionListener on the native side. - Have this listener relay connection data to the Java side. In Java: - Add a callback AIDL interface to relay callbacks from the server to the test APK. - Have the client-side callback post a task to the UI thread, as AIDL backed callbacks are delivered to the binder thread pool. Bug: 739165 Change-Id: Ifa461aa614354eaa5cb5d7b1aec5ba84b8d1b8f7 Reviewed-on: https://chromium-review.googlesource.com/583607 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#489937} [modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java [modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/android/BUILD.gn [modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java [modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServerImpl.java [add] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/test/android/javatests/src/org/chromium/net/test/IConnectionListener.aidl [modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/test/android/javatests/src/org/chromium/net/test/IEmbeddedTestServerImpl.aidl [modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/test/android/javatests/src/org/chromium/net/test/IEmbeddedTestServerInterface.aidl [modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/test/embedded_test_server/android/embedded_test_server_android.cc [modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/test/embedded_test_server/android/embedded_test_server_android.h
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a64d20fb436742f7601b6e1ccd91c3c6b55188d commit 5a64d20fb436742f7601b6e1ccd91c3c6b55188d Author: Benoit Lize <lizeb@chromium.org> Date: Fri Aug 18 08:44:16 2017 android: Enable "redirect preconnect" by default. Preconnection to a redirect chain end point has been approved for M61, enabling the feature by default (see crbug.com/738256). Bug: 739165 Change-Id: I18434bce11329b665732fe0e6f4fd68f330ab2a6 Reviewed-on: https://chromium-review.googlesource.com/618928 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#495504} [modify] https://crrev.com/5a64d20fb436742f7601b6e1ccd91c3c6b55188d/chrome/browser/android/chrome_feature_list.cc
,
Aug 23 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/de9811a5bba8a7dfe5c48196c7cb6d06ab6c8a80 commit de9811a5bba8a7dfe5c48196c7cb6d06ab6c8a80 Author: Benoit Lize <lizeb@google.com> Date: Wed Aug 23 19:21:32 2017
,
Aug 23 2017
Requesting a merge to M61 for the commit above. Rationale: - Low risk: 2 lines of code change in new code (+ comments and tests) - Required for a coordinated experiment with another product See the e-mail thread for details (since this is an internal commit). Sorry about the very late notice, this is due to the need of coordinating between several products, that resulted in identifying the big late.
,
Aug 23 2017
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 25 2017
Merge approved for M61 branch 3163, but no more merges here - if it doesn't work, we'll turn it off.
,
Aug 25 2017
I meant to say "no more merges *after this* CL" in the above FWIW. So, we can merge that patch, but no additional patches.
,
Aug 29 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 29 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/4230c1f4971b06816e9bd06a734bc797957051e7 commit 4230c1f4971b06816e9bd06a734bc797957051e7 Author: Benoit Lize <lizeb@google.com> Date: Tue Aug 29 15:51:34 2017
,
May 16 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 10 2017