New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739165 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 742294



Sign in to add a comment

Leapfrog: preconnect to the end of a redirect chain at navigation time

Project Member Reported by lizeb@chromium.org, Jul 4 2017

Issue description

This is a tracking bug for leapfrog.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0c7a5551424c67edbd4439c9da6a03c12295ad9

commit c0c7a5551424c67edbd4439c9da6a03c12295ad9
Author: lizeb <lizeb@chromium.org>
Date: Mon Jul 10 16:47:39 2017

customtabs: Extract a redirect endpoint, and maybe connect to it.

When an intent is received in Custom Tabs, extract a redirect endpoint
from an extra. If it exists, the URL to load is first party with respect
to the calling app, preconnect to the redirect endpoint.

This is part of Leapfrog, see the bug.

Also, only disables preconnection with the data reduction proxy for HTTP
URLs, as HTTPS URLs don't go through the proxy.

BUG= 739165 

Review-Url: https://codereview.chromium.org/2970003003
Cr-Commit-Position: refs/heads/master@{#485295}

[modify] https://crrev.com/c0c7a5551424c67edbd4439c9da6a03c12295ad9/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/c0c7a5551424c67edbd4439c9da6a03c12295ad9/chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java
[modify] https://crrev.com/c0c7a5551424c67edbd4439c9da6a03c12295ad9/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java
[modify] https://crrev.com/c0c7a5551424c67edbd4439c9da6a03c12295ad9/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/c0c7a5551424c67edbd4439c9da6a03c12295ad9/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/c0c7a5551424c67edbd4439c9da6a03c12295ad9/chrome/android/java/src/org/chromium/chrome/browser/customtabs/OriginVerifier.java
[modify] https://crrev.com/c0c7a5551424c67edbd4439c9da6a03c12295ad9/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
[modify] https://crrev.com/c0c7a5551424c67edbd4439c9da6a03c12295ad9/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/ClientManagerTest.java
[modify] https://crrev.com/c0c7a5551424c67edbd4439c9da6a03c12295ad9/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/c0c7a5551424c67edbd4439c9da6a03c12295ad9/chrome/browser/android/chrome_feature_list.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/ad90c807024e9f130f5879e2c50cabc6f5577cf2

commit ad90c807024e9f130f5879e2c50cabc6f5577cf2
Author: Benoît Lizé <lizeb@google.com>
Date: Tue Jul 11 12:29:22 2017

Comment 3 by dgn@chromium.org, Jul 13 2017

Blockedon: 742294
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67e17f3964ba1388b9b14c8d423d0441d210a94b

commit 67e17f3964ba1388b9b14c8d423d0441d210a94b
Author: Benoit Lize <lizeb@chromium.org>
Date: Mon Jul 24 12:21:59 2017

customtabs: Always call CustomTabsConnection.onHandledIntent().

Previously, only new intents going to the current active session would go
through CustomTabsConnection.onHandledIntent(), which is not the
intended behavior, as this is used to trigger preconnection to redirect
endpoints.

Bug:  739165 
Change-Id: Ie9da5dcf4e25f4d0ca2044cba20956a316f7a253
Reviewed-on: https://chromium-review.googlesource.com/581110
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488952}
[modify] https://crrev.com/67e17f3964ba1388b9b14c8d423d0441d210a94b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Comment 5 by lizeb@chromium.org, Jul 25 2017

Labels: Merge-Request-61
Requesting a merge to M61 for the commit above.
Rationale: small bug fix for new code, and a feature aimed at M61.
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 26 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 26 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76374f4e2d8c63808c0eb74d779e354e15795f00

commit 76374f4e2d8c63808c0eb74d779e354e15795f00
Author: Benoit Lize <lizeb@chromium.org>
Date: Wed Jul 26 13:19:53 2017

customtabs: Always call CustomTabsConnection.onHandledIntent().

Previously, only new intents going to the current active session would go
through CustomTabsConnection.onHandledIntent(), which is not the
intended behavior, as this is used to trigger preconnection to redirect
endpoints.

TBR=lizeb@chromium.org

(cherry picked from commit 67e17f3964ba1388b9b14c8d423d0441d210a94b)

Bug:  739165 
Change-Id: Ie9da5dcf4e25f4d0ca2044cba20956a316f7a253
Reviewed-on: https://chromium-review.googlesource.com/581110
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488952}
Reviewed-on: https://chromium-review.googlesource.com/586551
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#55}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/76374f4e2d8c63808c0eb74d779e354e15795f00/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c5197808ef235ba93e0376b6d8288b12a7e26be

commit 6c5197808ef235ba93e0376b6d8288b12a7e26be
Author: Benoit Lize <lizeb@chromium.org>
Date: Thu Jul 27 15:43:47 2017

android: Test that preconnects can be issued from the Java side.

Preconnects can be initiated from WarmupManager. This adds the testing
infrastructure and a basic test checking that these preconnects are
actually issued. This is required to test the redirect preconnection
handling for Custom Tabs.
Forthcoming CLs will add tests to check that the sockets are re-used,
and end-to-end tests of redirect preconnection.

In terms of implementation:
Native:
  - Sets an EmbeddedTestServerConnectionListener on the native side.
  - Have this listener relay connection data to the Java side.

In Java:
  - Add a callback AIDL interface to relay callbacks from the server to
    the test APK.
  - Have the client-side callback post a task to the UI thread, as AIDL
    backed callbacks are delivered to the binder thread pool.

Bug:  739165 
Change-Id: Ifa461aa614354eaa5cb5d7b1aec5ba84b8d1b8f7
Reviewed-on: https://chromium-review.googlesource.com/583607
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489937}
[modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java
[modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/android/BUILD.gn
[modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java
[modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServerImpl.java
[add] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/test/android/javatests/src/org/chromium/net/test/IConnectionListener.aidl
[modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/test/android/javatests/src/org/chromium/net/test/IEmbeddedTestServerImpl.aidl
[modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/test/android/javatests/src/org/chromium/net/test/IEmbeddedTestServerInterface.aidl
[modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/test/embedded_test_server/android/embedded_test_server_android.cc
[modify] https://crrev.com/6c5197808ef235ba93e0376b6d8288b12a7e26be/net/test/embedded_test_server/android/embedded_test_server_android.h

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a64d20fb436742f7601b6e1ccd91c3c6b55188d

commit 5a64d20fb436742f7601b6e1ccd91c3c6b55188d
Author: Benoit Lize <lizeb@chromium.org>
Date: Fri Aug 18 08:44:16 2017

android: Enable "redirect preconnect" by default.

Preconnection to a redirect chain end point has been approved for M61,
enabling the feature by default (see crbug.com/738256).

Bug:  739165 
Change-Id: I18434bce11329b665732fe0e6f4fd68f330ab2a6
Reviewed-on: https://chromium-review.googlesource.com/618928
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495504}
[modify] https://crrev.com/5a64d20fb436742f7601b6e1ccd91c3c6b55188d/chrome/browser/android/chrome_feature_list.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/de9811a5bba8a7dfe5c48196c7cb6d06ab6c8a80

commit de9811a5bba8a7dfe5c48196c7cb6d06ab6c8a80
Author: Benoit Lize <lizeb@google.com>
Date: Wed Aug 23 19:21:32 2017

Comment 11 by lizeb@chromium.org, Aug 23 2017

Labels: -Hotlist-Merge-Approved -merge-merged-3163 Merge-Request-61
Requesting a merge to M61 for the commit above.

Rationale:
- Low risk: 2 lines of code change in new code (+ comments and tests)
- Required for a coordinated experiment with another product

See the e-mail thread for details (since this is an internal commit).
Sorry about the very late notice, this is due to the need of coordinating between several products, that resulted in identifying the big late.
Project Member

Comment 12 by sheriffbot@chromium.org, Aug 23 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Merge approved for M61 branch 3163, but no more merges here - if it doesn't work, we'll turn it off.
I meant to say "no more merges *after this* CL" in the above FWIW.  So, we can merge that patch, but no additional patches.
Project Member

Comment 15 by sheriffbot@chromium.org, Aug 29 2017

Cc: amineer@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 29 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/4230c1f4971b06816e9bd06a734bc797957051e7

commit 4230c1f4971b06816e9bd06a734bc797957051e7
Author: Benoit Lize <lizeb@google.com>
Date: Tue Aug 29 15:51:34 2017

Comment 17 by lizeb@chromium.org, May 16 2018

Status: Fixed (was: Started)

Sign in to add a comment