Video controls current time and remaining time are not formatted correctly |
|||||
Issue descriptionDevice name: Pixel Phone From "Settings > About Chrome" Application version: Chrome Canary 61.0.3145.0 Operating system: Android 8.0.0; Pixel Build/OPP3.170518.006 URLs (if applicable): https://developer.apple.com/videos/play/wwdc2017/102/ Steps to reproduce: (1) Go to https://developer.apple.com/videos/play/wwdc2017/102/ Expected result: Video controls current time and remaining time should be "00:00 / 01:43:11" Actual result: Video controls current time and remaining time are "000:00 / 103:11"
,
Jul 10 2017
I agree that showing minutes instead of hours is weird. FWIW, YT shows days too but I'm not sure that makes sense. Regarding leading zeros, I'm not sure if there was a reason that I might be missing. +rachelis@ WDYT of fbeaufort@'s proposal? We can quickly implement this if that's something you are happy with.
,
Jul 10 2017
This is a case where it would be a helpful proposal put together in a clearly communicated way so I can review it in a short time. :) Would one of you be able to take that on?
,
Jul 10 2017
,
Aug 10 2017
FWIW, YouTube uses "0:00 / 1:43:11" (no extra leading zeros for unnecessary double-digiting) So, for the proposal: 1) The end time would be split out into hours:minutes:seconds (maybe days too?) instead of the current state which only splits into minutes/seconds. This will always be padded to at least 1 minute digit and 2 second digits (e.g. 0:05 for a 5 second video), but will not zero-pad to make minutes or hours (or days if applicable) into 2 digits. 2) The start time will follow the same rules as above, not changing format at all based on the end time. For example, if we're 1 minute and 51 seconds into a 12 minute video, we would show "1:51 / 12:00" (not zero-padding the minutes). Does that sound good to everyone?
,
Aug 10 2017
To be clear, this would make our formatting the same as YouTube's (as far as I can tell)
,
Aug 10 2017
SGTM, Thanks
,
Aug 11 2017
Any thoughts on showing days too? Just checked and youtube on chrome desktop shows days, while the youtube app on my phone does not.
,
Aug 11 2017
Do you have a link to a multi-day video? My inclination is to just go with hours. The number of multi-day videos is likely to be small, so I think we can just pick one.
,
Aug 11 2017
,
Aug 11 2017
What's interesting is that the right panel of videos uses hours not days, but the main video uses days. I say let's just go for hours (just make sure we can handle lots of hour digits if needed).
,
Aug 11 2017
sounds good, thanks
,
Aug 16 2017
I had two quick visuals in here: https://docs.google.com/presentation/d/1IV6sOaGqhRs72SQ8xYEMmB962jY87DzM7K-nK0MmNZw/edit#slide=id.p (Made this last month and pretty much forgot about it -- shame on me!)
,
Aug 16 2017
Thanks for providing the visuals. As far as I can tell, the visuals represent the plan as of comment 11, correct?
,
Aug 17 2017
Hey folks, I'm happy to give feedback as needed. This is a good candidate for setting up an office hours slot with me. Jon - would you mind doing that?
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7d904a2cc1f1c54cb72d24f0436b13a6af10271 commit e7d904a2cc1f1c54cb72d24f0436b13a6af10271 Author: Tommy Steimel <steimel@chromium.org> Date: Fri Aug 25 00:35:39 2017 Update media controls time formatting to use hours This CL changes the formatting rules of the media controls as follows: [0-10) minutes => m:ss [10-60) minutes => mm:ss [1-10) hours => h:mm:ss [10-100) hours => hh:mm:ss [100-1000) hours => hhh:mm:ss etc. The current time format will no longer be affected by the duration. For example, if we're 1 minute and 51 seconds into a 12 minute video, we would show "1:51 / 12:00" (not zero-padding the minutes). Bug: 739152 Change-Id: Ibed50426593dff0c5541a3a9c88a0b6229a896b3 Reviewed-on: https://chromium-review.googlesource.com/611703 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#497265} [modify] https://crrev.com/e7d904a2cc1f1c54cb72d24f0436b13a6af10271/third_party/WebKit/Source/core/layout/LayoutTheme.cpp [modify] https://crrev.com/e7d904a2cc1f1c54cb72d24f0436b13a6af10271/third_party/WebKit/Source/core/layout/LayoutTheme.h [modify] https://crrev.com/e7d904a2cc1f1c54cb72d24f0436b13a6af10271/third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp [modify] https://crrev.com/e7d904a2cc1f1c54cb72d24f0436b13a6af10271/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [modify] https://crrev.com/e7d904a2cc1f1c54cb72d24f0436b13a6af10271/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp [modify] https://crrev.com/e7d904a2cc1f1c54cb72d24f0436b13a6af10271/third_party/WebKit/Source/modules/media_controls/elements/MediaControlRemainingTimeDisplayElement.cpp [modify] https://crrev.com/e7d904a2cc1f1c54cb72d24f0436b13a6af10271/third_party/WebKit/Source/modules/media_controls/elements/MediaControlRemainingTimeDisplayElement.h [modify] https://crrev.com/e7d904a2cc1f1c54cb72d24f0436b13a6af10271/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimeDisplayElement.cpp [modify] https://crrev.com/e7d904a2cc1f1c54cb72d24f0436b13a6af10271/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimeDisplayElement.h
,
Aug 25 2017
Verified in Google Chrome 62.0.3195.0 (Official Build) canary (64-bit). Thank you very much!
,
Aug 25 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by fbeaufort@chromium.org
, Jul 4 2017