Re-assigning to Jerome as this is an iOS bug.

--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Well, this is an interesting question.

The screen contains:
  + a collection view with all the accounts (and at the end "Add Account"), border in blue.
  + a gradient view, border in red.
  + 2 buttons CANCEL and CONTINUE, border in green.

See: https://drive.google.com/open?id=0ByXziH_JVCGJYThvX0hOeTloOTQ.

The bottom of the gradient is at the same position than the bottom of the collection view.

This current issue is a regression related to  issue 718023 . Before, the gradient used to prevent the tap go through. But since the content under the gradient is visible, there is no reason to prevent the tap go through, see: https://drive.google.com/open?id=0ByXziH_JVCGJLUlWR3JEc2ZSQ1U
I think it was confusing for the user to be able to see something and not be able to click on it. The UI tests were confused about that issue. So I did change the behavior of this gradient view with crrev.com/2906313004, to fix it.

In the video of this issue, the collection view contains cells. And there is big chunk of pixels white before the icon. The white part is still part of the cell and can be clickable.
See the cell background: https://drive.google.com/open?id=0ByXziH_JVCGJUGlrc0xKOWpibGM
Anything bellow the grey is part of the next cell, therefore, it is clickable.

So if the user tap just a little above the CANCEL button, they will hit the gradient view which let the tap through and they will hit the collection view cell. In the video, the user hits the top of the "Add Account" cell.

For me, I think there is no real software bug. But have a better user experience, I think it would be nice to have an extra space between the bottom of the collection view and the top of the buttons.

ewald@ I guess we need help from a UX to solve that. I can suggestion to shrink the collection view by 10 pixel and move up the gradient by 10px too:
https://drive.google.com/open?id=0ByXziH_JVCGJbVBZcjVueEd2ck0
This way, there will be less change for an user to miss one of the button, and hit the collection view cell.

Let me know what you think.

+UX friends

Interesting! Thanks for the very detailed explanation, Jerome. I agree that from one perspective, there is no "bug" here. But I also agree that from a UX perspective, it feels like there should be something of a "buffer" between the top of the buttons and where the tap targets for the accounts list view begins.

Jerome -- is this only a problem on iOS? Do we have the same gradient view on Android? (+Boris to help answer that question as well)

Assigning to Amy for now for advice, since this is scoped to iOS for the time being.

There's no padding on top of button bar in Android layout, too, so behavior matches iOS one. I agree with Jerome that adding a small padding can easily solve this issue.

Deleted: DeviceScreenshot_2017-08-11_11:58:34.png 205 KB

	DeviceScreenshot_2017-08-11_11:58:34.png 205 KB View Download

A little extra padding should do it, specs attached. 

On android it looks like it should be as simple as adding 16dp to the top. 

For iOS let's do 16pt all the way around. Currently it looks like it's 32 bottom and sides, so we'll want to reduce there in addition to adding the 16pt on top. 

(I think I remember bumping it up to 32pt to account for iPad, but I'd rather not dedicate any more pixels to these buttons. Redistributing the existing to make this change)

Deleted: Artboard.png 114 KB

	Artboard.png 114 KB View Download

Re-assigning to Jerome to make the change on iOS. Jerome, feel free to re-assign to Boris for the Android change afterwards.

Let me and Amy know if you have any follow-up questions on the specs.

I created  crbug.com/755947  for Android.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/157597a6e81a2660a41a96a8bddde76bcce79b76

commit 157597a6e81a2660a41a96a8bddde76bcce79b76
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Fri Aug 18 12:56:45 2017

Adding 16pt padding in ChromeSigninViewController

The padding is between the collection view and the buttons. The end of
the collection view was just at beginning of the buttons. It was too
easy for the user to tap on the collection view instead of the buttons.

Before:
https://drive.google.com/open?id=0ByXziH_JVCGJZGNDZFd5R19vM2M
https://drive.google.com/open?id=0ByXziH_JVCGJbnFoN1BFczViZnc

After:
https://drive.google.com/open?id=0ByXziH_JVCGJX2hjaGtkWmQ5dU0
https://drive.google.com/open?id=0ByXziH_JVCGJTl9FcC1JZlhQNm8

Bug:  739151 
Change-Id: I36b2a2b9d3952f828b0eceff23c6237a0cd8a7e7
Reviewed-on: https://chromium-review.googlesource.com/620770
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495532}
[modify] https://crrev.com/157597a6e81a2660a41a96a8bddde76bcce79b76/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm

Just to let you know:

This changed a little the iPad version (the iPad can use the iPhone constants when the sign-in controller is not in full screen, like multitasking, or on top of the screen).

iPhones, before:
https://drive.google.com/open?id=0ByXziH_JVCGJbnFoN1BFczViZnc
https://drive.google.com/open?id=0ByXziH_JVCGJZGNDZFd5R19vM2M

iPhone, after:
https://drive.google.com/open?id=0ByXziH_JVCGJd0NVLVdWb1BnSDQ
https://drive.google.com/open?id=0ByXziH_JVCGJR0x1SEJ2UjlPVkU


iPad, before:
https://drive.google.com/open?id=0ByXziH_JVCGJVlRFUUI5OVd1T0k
https://drive.google.com/open?id=0ByXziH_JVCGJR19HQTFRRGlWUm8

iPad, after
https://drive.google.com/open?id=0ByXziH_JVCGJV3Fxa0xiUnRZMWs
https://drive.google.com/open?id=0ByXziH_JVCGJOFBXZk80aEFzT0k

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f9008d2ce7727ffe6cd34da04cb07ad78d37c60

commit 8f9008d2ce7727ffe6cd34da04cb07ad78d37c60
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Fri Aug 18 16:01:30 2017

Padding for buttons in ChromeSigninViewController

Correction for crrev.com/c/620770
From comments in https://crbug.com/c/739151#c7
I missed to udpate horizontal padding and bottom padding for the
buttons (changed from 32pt to 16pt). I also missed the iPad version.

Before:
iPhone:
https://drive.google.com/open?id=0ByXziH_JVCGJbGlrcG5heGdHU0E
https://drive.google.com/open?id=0ByXziH_JVCGJT1Qyd0dzQU91emc
iPad:
https://drive.google.com/open?id=0ByXziH_JVCGJVlRFUUI5OVd1T0k
https://drive.google.com/open?id=0ByXziH_JVCGJR19HQTFRRGlWUm8

After:
iPhone:
https://drive.google.com/open?id=0ByXziH_JVCGJd0NVLVdWb1BnSDQ
https://drive.google.com/open?id=0ByXziH_JVCGJR0x1SEJ2UjlPVkU
iPad:
https://drive.google.com/open?id=0ByXziH_JVCGJV3Fxa0xiUnRZMWs
https://drive.google.com/open?id=0ByXziH_JVCGJOFBXZk80aEFzT0k


Bug:  739151 
Change-Id: I7a702518f76d1e84df34ed7668569d1b19edea55
Reviewed-on: https://chromium-review.googlesource.com/620689
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495559}
[modify] https://crrev.com/8f9008d2ce7727ffe6cd34da04cb07ad78d37c60/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm

Looks good to me. Amy - can you please take a look at the last four screenshots above (the "After" screenshots) and make sure the button placement and layout looks good to you?

Jerome - why is the profile picture on the iPhone confirmation screen underneath the status bar on top? Is that a bug?

Huh, just testing it out on my phone, looks like if you scroll down the photo can go underneath the status bar. I guess that's WAI?

The padding around the button LGTM but the profile pic/monogram should be farther down (reference attached)

Deleted: IMG_3513.PNG 143 KB

	IMG_3513.PNG 143 KB View Download

The reason it's farther up there is because Jerome has scrolled down. If you scroll down, the photo moves up underneath the status bar (see my comments in #15-16).

Sounds like the padding looks good though. Jerome, is there anything else to land, or can we mark this as Fixed?

as far as I know this can be marked as fixed.

(I used a small phone screen for my screenshot, so the user has to scroll down to get the "OK, GOT IT" button).

Verified in 61.0.3163.67 beta, iPhone 6 iOS 10.3.3, iPhone 7 iOS11, 
Looks good

Verified on latest chrome canary version 62.0.3199.0 on iPhone 6 plus with iOS 10.3.3 and 11 beta 8, following the steps mentioned in comment #0. Sign in screen is not triggered upon tapping above "Cancel" button.  Looks good.