New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739147 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in test_runner::TestRunnerForSpecificView::Reset

Project Member Reported by ClusterFuzz, Jul 4 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4718189436207104

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  test_runner::TestRunnerForSpecificView::Reset
  test_runner::WebViewTestProxyBase::Reset
  test_runner::TestInterfaces::ResetAll
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=420372:420473

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4718189436207104


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 4 2017

Labels: M-61
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 4 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 4 2017

Labels: Pri-1
Components: Blink>Infra
Owner: lukasza@chromium.org
Status: Assigned (was: Untriaged)
lukasza@, could you take a look at this issue since you changed content/shell/test_runner/test_runner_for_specific_view.cc recently?

Thanks! Please feel free to re-assign.
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 5 2017

Labels: M-61
Hmmm.... I can't repro with:

clusterfuzz reproduce 4718189436207104 -j 1500 -l 25 -i 20
# also no repro:
# with --disable-xvfb
# with --current (@ r483912 / 03322108cedb2b380926f58c507157828c6db4f2)
#       although in this case I had to tweak args.gn to work around a compile error
Labels: -ReleaseBlock-Stable
I don't think this should be marked as ReleaseBlock-Stable, as the problem is only present in test code (i.e. in content/shell/test_runner).
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 7 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by ta...@google.com, Jul 7 2017

 Issue 733460  has been merged into this issue.
Cc: mea...@chromium.org jialiul@chromium.org
+security sheriffs - can you please review the release blocker status (see #c7 and #c8 above).
Cc: tanin@chromium.org
+tanin@ - thank you for helping get a more reliable repro in issue 739498.  I'll try to take a closer look next week.
If we are sure that this is test only code, please feel free to remove the label again, though I don't know to tell ClusterFuzz not to revert that.
Labels: -ReleaseBlock-Stable ReleaseBlock-NA
Removing ReleaseBlock-Stable (see #c7 and #c12) again and adding ReleaseBlock-NA (see #c8 - I think this is supposed to prevent reapllying ReleaseBlock-Stable).
Cc: lukasza@chromium.org
 Issue 740389  has been merged into this issue.
FWIW, I tried to repro using the steps from https://crbug.com/739498#c5 and I couldn't get a local repro... :-/
Project Member

Comment 16 by ClusterFuzz, Jul 22 2017

ClusterFuzz has detected this issue as fixed in range 488838:488842.

Detailed report: https://clusterfuzz.com/testcase?key=4718189436207104

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  test_runner::TestRunnerForSpecificView::Reset
  test_runner::WebViewTestProxyBase::Reset
  test_runner::TestInterfaces::ResetAll
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=420372:420473
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=488838:488842

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4718189436207104


See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 17 by ClusterFuzz, Jul 22 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4718189436207104 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 18 by sheriffbot@chromium.org, Jul 22 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 19 by ClusterFuzz, Jul 29 2017

Labels: Needs-Feedback
ClusterFuzz testcase 5100461110853632 is still reproducing on tip-of-tree build (trunk).

Please re-test your fix against this testcase and if the fix was incorrect or incomplete, please re-open the bug. Otherwise, ignore this notification and add ClusterFuzz-Wrong label.
Cc: mbarbe...@chromium.org palmer@chromium.org
 Issue 766974  has been merged into this issue.
Cc: -jialiul@chromium.org
Project Member

Comment 22 by ClusterFuzz, Oct 11 2017

Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 23 by sheriffbot@chromium.org, Oct 28 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components

Sign in to add a comment