New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 739139 link

Starred by 1 user
Status: Fixed
Owner:
drott@chromium.org
Closed: Aug 2017
Cc:
timloh@chromium.org
█ meade@chromium.org
█ r...@opera.com
e...@chromium.org
█ bugsnash@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 750014
issue 739403
Blocking:
issue 733154


Show other hotlists

Hotlists containing this issue:
style-dev-current


Sign in to add a comment

Parse number values, for stretch, style, weight part of CSS Fonts Level 4

Project Member Reported by drott@chromium.org, Jul 4 2017 
https://drafts.csswg.org/css-fonts-4/#font-style-prop contains new number values, instead of discrete keywords for font-stretch, font-style and font-weight, as well as ranges of such numbers in the @font-face property descriptors. We need to extend the CSS parser and style types to support such values.

Comment 1 by dstockwell@google.com, Jul 4 2017

Labels: Update-Monthly

Comment 2 by drott@chromium.org, Jul 5 2017

Blockedon: 739403
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4

commit 4284165bb5adcb7cf7c06565e9f13e2c0fb775d4
Author: Dominik Röttsches <drott@chromium.org>
Date: Tue Jul 25 16:35:54 2017

Move font-weight parsing and representation to CSSPrimitiveValue

This also changes the computed style of font-weight to a number type,
according to the CSS Fonts Level 4 font-weight: property definition [1].

[1] https://drafts.csswg.org/css-fonts/#font-weight-prop

Bug:  739139 
Change-Id: I0174a9f781856a51cee6ec0ba21ca11df8e6e15c
Reviewed-on: https://chromium-review.googlesource.com/574167
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489331}
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/css3/font-weight-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/css3/font-weight-multiple-selectors-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/css3/font-weight-multiple-selectors.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/css3/font-weight.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/editing/pasteboard/onpaste-text-html-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/editing/pasteboard/paste-text-with-style-4-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/external/wpt/editing/run/multitest-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-shorthands.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/fast/css/child-selector-implicit-tbody.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/fast/css/css-properties-case-insensitive.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/fast/css/font-weight-1.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-empty-font-family-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-font-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/script-tests/computed-style-font.js
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/fast/css/invalidation/non-independent-inheritance-identical-computed-styles.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/fast/css/variables/longhand-pending-shorthand-substitution.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/fast/events/ondrop-text-html-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/grouping_content/figcaption-element-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/grouping_content/figcaption-element.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/grouping_content/figure-element-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/grouping_content/figure-element.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/grouping_content/main-element-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/grouping_content/main-element.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/sections/article-element-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/sections/article-element.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/sections/aside-element-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/sections/aside-element.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/sections/footer-element-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/sections/footer-element.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/sections/header-element-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/sections/header-element.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/sections/hgroup-element-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/sections/hgroup-element.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/sections/section-element-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/sections/section-element.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/text_level_semantics/mark-element-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/html/text_level_semantics/mark-element.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-styles-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/media/track/track-css-matching-default.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/platform/linux/fast/css/css2-system-fonts-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/platform/win/fast/css/css2-system-fonts-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/svg/parser/foreign-object-case-sensitivity-expected.txt
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/LayoutTests/svg/parser/foreign-object-case-sensitivity.html
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/core/css/CSSValueKeywords.json5
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/core/css/FontFaceCacheTest.cpp
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.cpp
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.h
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFont.cpp
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/core/css/resolver/FontBuilder.h
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/4284165bb5adcb7cf7c06565e9f13e2c0fb775d4/third_party/WebKit/Source/platform/fonts/FontSelectionTypes.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48906e26e45db659ea543f9ee1df9b694cdd3a15

commit 48906e26e45db659ea543f9ee1df9b694cdd3a15
Author: Alexandre Elias <aelias@chromium.org>
Date: Thu Jul 27 00:24:38 2017

Revert "Introduce FontSelectionTypes and FontSelectionAlgorithm" and dependent patches.

This patch causes an internal compiler error in Clang x86_64 official Android
codegen related to FontSelectionValueStyle.  This bot
gates all Android canary releases and the fix is not immediately obvious, so as
sheriff I unfortunately need to revert this patch and its dependencies.

Revert "Add range-matching capabilities to FontFaceCache"
This reverts commit b45665298c860afc0b5042ceac5b4131e8d55cac.

Revert "Move font-weight parsing and representation to CSSPrimitiveValue"
This reverts commit 4284165bb5adcb7cf7c06565e9f13e2c0fb775d4.

Revert "Introduce FontSelectionTypes and FontSelectionAlgorithm"
This reverts commit ad9b5da819de07237b1986dc59ca06a792467728.

NOTRY=true
TBR=drott
BUG=749273, 739139 , 733154 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2155239b95ea002fe139661318a63a5a537c7821
Reviewed-on: https://chromium-review.googlesource.com/587342
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489811}
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/css3/font-weight-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/css3/font-weight-multiple-selectors-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/css3/font-weight-multiple-selectors.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/css3/font-weight.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/editing/pasteboard/onpaste-text-html-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/editing/pasteboard/paste-text-with-style-4-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/external/wpt/editing/run/multitest-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-shorthands.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/child-selector-implicit-tbody.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/css-properties-case-insensitive.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/font-face-character-fallback-expected.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/font-face-default-font-expected.html
[add] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/font-face-multiple-faces-expected.html
[add] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/font-face-multiple-faces.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/font-weight-1.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-empty-font-family-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-font-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/script-tests/computed-style-font.js
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/invalidation/non-independent-inheritance-identical-computed-styles.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/css/variables/longhand-pending-shorthand-substitution.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/fast/events/ondrop-text-html-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/grouping_content/figcaption-element-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/grouping_content/figcaption-element.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/grouping_content/figure-element-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/grouping_content/figure-element.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/grouping_content/main-element-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/grouping_content/main-element.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/sections/article-element-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/sections/article-element.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/sections/aside-element-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/sections/aside-element.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/sections/footer-element-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/sections/footer-element.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/sections/header-element-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/sections/header-element.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/sections/hgroup-element-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/sections/hgroup-element.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/sections/section-element-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/sections/section-element.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/text_level_semantics/mark-element-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/html/text_level_semantics/mark-element.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-styles-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/media/track/track-css-matching-default.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/linux/fast/css/css2-system-fonts-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/mac/external/wpt/editing/run/italic-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/css1/font_properties/font_style-expected.png
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/css2.1/t1504-c523-font-style-00-b-expected.png
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/css2.1/t1504-c523-font-style-00-b-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/css2.1/t1508-c527-font-08-b-expected.png
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/css2.1/t1508-c527-font-08-b-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/external/wpt/editing/run/italic-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/fast/css/css2-system-fonts-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/smallFonts-expected.png
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/smallFonts-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textFeatures-expected.png
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textFeatures-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textStyles-expected.png
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textStyles-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/css1/font_properties/font-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/css1/font_properties/font_style-expected.png
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/css1/font_properties/font_style-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/platform/win7/virtual/mojo-loading/css1/font_properties/font-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/svg/parser/foreign-object-case-sensitivity-expected.txt
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/LayoutTests/svg/parser/foreign-object-case-sensitivity.html
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/animation/FontWeightConversion.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/animation/FontWeightConversion.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/CSSFontFace.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/CSSFontFaceSource.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/CSSFontFaceSourceTest.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/CSSFontFamilyValue.h
[delete] https://crrev.com/57a70ec50111c83525e093d818b801534426b215/third_party/WebKit/Source/core/css/CSSFontStyleRangeValue.cpp
[delete] https://crrev.com/57a70ec50111c83525e093d818b801534426b215/third_party/WebKit/Source/core/css/CSSFontStyleRangeValue.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/CSSValue.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/CSSValue.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/CSSValueKeywords.json5
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/FontFace.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/FontFaceCache.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/FontFaceCache.h
[delete] https://crrev.com/57a70ec50111c83525e093d818b801534426b215/third_party/WebKit/Source/core/css/FontFaceCacheTest.cpp
[add] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/FontStyleMatcher.cpp
[add] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/FontStyleMatcher.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/LocalFontFaceSource.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/StyleRule.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFont.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/resolver/FontBuilder.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/resolver/FontBuilderTest.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/resolver/FontStyleResolver.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/html/forms/InternalPopupMenu.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/layout/LayoutTheme.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/layout/LayoutTheme.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/layout/LayoutThemeDefault.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/layout/LayoutThemeFontProvider.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/layout/LayoutThemeFontProviderDefault.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/layout/LayoutThemeFontProviderWin.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/layout/LayoutThemeMac.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/paint/EmbeddedObjectPainter.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/platform/DragImage.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/platform/DragImageTest.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/platform/exported/WebFontDescription.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/platform/fonts/FontDescription.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/platform/fonts/FontDescription.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/platform/fonts/FontDescriptionTest.cpp
[delete] https://crrev.com/57a70ec50111c83525e093d818b801534426b215/third_party/WebKit/Source/platform/fonts/FontSelectionAlgorithm.cpp
[delete] https://crrev.com/57a70ec50111c83525e093d818b801534426b215/third_party/WebKit/Source/platform/fonts/FontSelectionAlgorithm.h
[delete] https://crrev.com/57a70ec50111c83525e093d818b801534426b215/third_party/WebKit/Source/platform/fonts/FontSelectionTypes.cpp
[delete] https://crrev.com/57a70ec50111c83525e093d818b801534426b215/third_party/WebKit/Source/platform/fonts/FontSelectionTypes.h
[delete] https://crrev.com/57a70ec50111c83525e093d818b801534426b215/third_party/WebKit/Source/platform/fonts/FontSelectionTypesTest.cpp
[add] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/platform/fonts/FontTraits.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMac.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMac.mm
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMacTest.mm
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.h
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp
[modify] https://crrev.com/48906e26e45db659ea543f9ee1df9b694cdd3a15/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 27 2017

Labels: merge-merged-3168
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff6c324ccc5322fa8b344d73898bb0ed834c1efe

commit ff6c324ccc5322fa8b344d73898bb0ed834c1efe
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Thu Jul 27 18:07:25 2017

Revert "Introduce FontSelectionTypes and FontSelectionAlgorithm" and dependent patches.

This patch causes an internal compiler error in Clang x86_64 official Android
codegen related to FontSelectionValueStyle.  This bot
gates all Android canary releases and the fix is not immediately obvious, so as
sheriff I unfortunately need to revert this patch and its dependencies.

Revert "Add range-matching capabilities to FontFaceCache"
This reverts commit b45665298c860afc0b5042ceac5b4131e8d55cac.

Revert "Move font-weight parsing and representation to CSSPrimitiveValue"
This reverts commit 4284165bb5adcb7cf7c06565e9f13e2c0fb775d4.

Revert "Introduce FontSelectionTypes and FontSelectionAlgorithm"
This reverts commit ad9b5da819de07237b1986dc59ca06a792467728.

NOTRY=true
TBR=aelias@chromium.org, drott
BUG=749273, 739139 , 733154 

(cherry picked from commit 48906e26e45db659ea543f9ee1df9b694cdd3a15)

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2155239b95ea002fe139661318a63a5a537c7821
Reviewed-on: https://chromium-review.googlesource.com/587342
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489811}
Reviewed-on: https://chromium-review.googlesource.com/589816
Reviewed-by: Alexei Svitkine (OOO July28-Aug6) <asvitkine@chromium.org>
Cr-Commit-Position: refs/branch-heads/3168@{#3}
Cr-Branched-From: da2455bea333a5a4bfe61ba1fcfe9e325dc368e1-refs/heads/master@{#489803}
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/css3/font-weight-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/css3/font-weight-multiple-selectors-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/css3/font-weight-multiple-selectors.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/css3/font-weight.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/editing/pasteboard/onpaste-text-html-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/editing/pasteboard/paste-text-with-style-4-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/external/wpt/editing/run/multitest-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-shorthands.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/child-selector-implicit-tbody.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/css-properties-case-insensitive.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/font-face-character-fallback-expected.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/font-face-default-font-expected.html
[add] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/font-face-multiple-faces-expected.html
[add] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/font-face-multiple-faces.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/font-weight-1.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-empty-font-family-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-font-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/script-tests/computed-style-font.js
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/invalidation/non-independent-inheritance-identical-computed-styles.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/css/variables/longhand-pending-shorthand-substitution.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/fast/events/ondrop-text-html-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/grouping_content/figcaption-element-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/grouping_content/figcaption-element.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/grouping_content/figure-element-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/grouping_content/figure-element.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/grouping_content/main-element-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/grouping_content/main-element.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/sections/article-element-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/sections/article-element.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/sections/aside-element-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/sections/aside-element.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/sections/footer-element-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/sections/footer-element.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/sections/header-element-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/sections/header-element.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/sections/hgroup-element-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/sections/hgroup-element.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/sections/section-element-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/sections/section-element.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/text_level_semantics/mark-element-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/html/text_level_semantics/mark-element.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-styles-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/media/track/track-css-matching-default.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/linux/fast/css/css2-system-fonts-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/mac/external/wpt/editing/run/italic-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/css1/font_properties/font_style-expected.png
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/css2.1/t1504-c523-font-style-00-b-expected.png
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/css2.1/t1504-c523-font-style-00-b-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/css2.1/t1508-c527-font-08-b-expected.png
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/css2.1/t1508-c527-font-08-b-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/external/wpt/editing/run/italic-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/fast/css/css2-system-fonts-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/smallFonts-expected.png
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/smallFonts-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textFeatures-expected.png
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textFeatures-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textStyles-expected.png
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textStyles-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/css1/font_properties/font-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/css1/font_properties/font_style-expected.png
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/css1/font_properties/font_style-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/platform/win7/virtual/mojo-loading/css1/font_properties/font-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/svg/parser/foreign-object-case-sensitivity-expected.txt
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/LayoutTests/svg/parser/foreign-object-case-sensitivity.html
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/animation/FontWeightConversion.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/animation/FontWeightConversion.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/CSSFontFace.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/CSSFontFaceSource.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/CSSFontFaceSourceTest.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/CSSFontFamilyValue.h
[delete] https://crrev.com/c2f36afa734678235a7f54c869b585203b2b8c7b/third_party/WebKit/Source/core/css/CSSFontStyleRangeValue.cpp
[delete] https://crrev.com/c2f36afa734678235a7f54c869b585203b2b8c7b/third_party/WebKit/Source/core/css/CSSFontStyleRangeValue.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/CSSValue.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/CSSValue.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/CSSValueKeywords.json5
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/FontFace.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/FontFaceCache.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/FontFaceCache.h
[delete] https://crrev.com/c2f36afa734678235a7f54c869b585203b2b8c7b/third_party/WebKit/Source/core/css/FontFaceCacheTest.cpp
[add] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/FontStyleMatcher.cpp
[add] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/FontStyleMatcher.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/LocalFontFaceSource.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/StyleRule.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFont.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/resolver/FontBuilder.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/resolver/FontBuilderTest.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/resolver/FontStyleResolver.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/html/forms/InternalPopupMenu.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/layout/LayoutTheme.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/layout/LayoutTheme.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/layout/LayoutThemeDefault.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/layout/LayoutThemeFontProvider.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/layout/LayoutThemeFontProviderDefault.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/layout/LayoutThemeFontProviderWin.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/layout/LayoutThemeMac.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/paint/EmbeddedObjectPainter.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/platform/DragImage.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/platform/DragImageTest.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/platform/exported/WebFontDescription.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/platform/fonts/FontDescription.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/platform/fonts/FontDescription.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/platform/fonts/FontDescriptionTest.cpp
[delete] https://crrev.com/c2f36afa734678235a7f54c869b585203b2b8c7b/third_party/WebKit/Source/platform/fonts/FontSelectionAlgorithm.cpp
[delete] https://crrev.com/c2f36afa734678235a7f54c869b585203b2b8c7b/third_party/WebKit/Source/platform/fonts/FontSelectionAlgorithm.h
[delete] https://crrev.com/c2f36afa734678235a7f54c869b585203b2b8c7b/third_party/WebKit/Source/platform/fonts/FontSelectionTypes.cpp
[delete] https://crrev.com/c2f36afa734678235a7f54c869b585203b2b8c7b/third_party/WebKit/Source/platform/fonts/FontSelectionTypes.h
[delete] https://crrev.com/c2f36afa734678235a7f54c869b585203b2b8c7b/third_party/WebKit/Source/platform/fonts/FontSelectionTypesTest.cpp
[add] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/platform/fonts/FontTraits.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMac.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMac.mm
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMacTest.mm
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.h
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp
[modify] https://crrev.com/ff6c324ccc5322fa8b344d73898bb0ed834c1efe/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c42c9e59df46381a15d51fe87ddb4928a1d64b6e

commit c42c9e59df46381a15d51fe87ddb4928a1d64b6e
Author: Dominik Röttsches <drott@chromium.org>
Date: Fri Jul 28 08:42:50 2017

Reland: Move font-weight parsing and representation to CSSPrimitiveValue

Reland of 4284165bb5adcb7cf7c06565e9f13e2c0fb775d4, reverted in
b45665298c860afc0b5042ceac5b4131e8d55cac. Original issue fixed in parent
commit. This CL itself got reverted because it was dependent on the
parent.

This also changes the computed style of font-weight to a number type,
according to the CSS Fonts Level 4 font-weight: property definition [1].

[1] https://drafts.csswg.org/css-fonts/#font-weight-prop

Bug:  739139 
Change-Id: I10e98c8b708b0c6f6fc4cc61fd86a38be64fc3fa
TBR: meade, eae, yosin
Reviewed-on: https://chromium-review.googlesource.com/589569
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490321}
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/css3/font-weight-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/css3/font-weight-multiple-selectors-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/css3/font-weight-multiple-selectors.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/css3/font-weight.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/editing/pasteboard/onpaste-text-html-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/editing/pasteboard/paste-text-with-style-4-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/external/wpt/editing/run/multitest-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-shorthands.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/fast/css/child-selector-implicit-tbody.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/fast/css/css-properties-case-insensitive.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/fast/css/font-weight-1.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-empty-font-family-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-font-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/script-tests/computed-style-font.js
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/fast/css/invalidation/non-independent-inheritance-identical-computed-styles.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/fast/css/variables/longhand-pending-shorthand-substitution.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/fast/events/ondrop-text-html-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/grouping_content/figcaption-element-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/grouping_content/figcaption-element.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/grouping_content/figure-element-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/grouping_content/figure-element.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/grouping_content/main-element-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/grouping_content/main-element.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/sections/article-element-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/sections/article-element.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/sections/aside-element-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/sections/aside-element.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/sections/footer-element-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/sections/footer-element.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/sections/header-element-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/sections/header-element.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/sections/hgroup-element-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/sections/hgroup-element.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/sections/section-element-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/sections/section-element.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/text_level_semantics/mark-element-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/html/text_level_semantics/mark-element.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-styles-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/media/track/track-css-matching-default.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/platform/linux/fast/css/css2-system-fonts-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/platform/win/fast/css/css2-system-fonts-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/svg/parser/foreign-object-case-sensitivity-expected.txt
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/LayoutTests/svg/parser/foreign-object-case-sensitivity.html
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/core/css/CSSValueKeywords.json5
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/core/css/FontFaceCacheTest.cpp
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.cpp
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.h
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFont.cpp
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/core/css/resolver/FontBuilder.h
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/c42c9e59df46381a15d51fe87ddb4928a1d64b6e/third_party/WebKit/Source/platform/fonts/FontSelectionTypes.h

Comment 7 by drott@chromium.org, Jul 28 2017

Blockedon: 750014
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2f2550028224570ded9a13ddd6d972eece39df4

commit e2f2550028224570ded9a13ddd6d972eece39df4
Author: Dominik Röttsches <drott@chromium.org>
Date: Tue Aug 01 12:22:45 2017

Allow parsing of font-stretch from percentage into CSSPrimitiveValue

At the same time change computed style to a number type according to CSS
Fonts Level 4 [1].

[1] https://drafts.csswg.org/css-fonts-4/#font-stretch-prop

Bug:  739139 
Change-Id: I30db184559e7f047efcca999ae1b63aaa18b5eab
Reviewed-on: https://chromium-review.googlesource.com/574590
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490949}
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/LayoutTests/animations/svg/svg-presentation-attribute-animation.html
[add] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/LayoutTests/external/wpt/css-fonts/variations/font-parse-numeric-stretch-style-weight.html
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-empty-font-family-expected.txt
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontStretch.cpp
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.cpp
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.h
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFont.cpp
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/core/css/resolver/FontBuilder.h
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/core/css/resolver/FontStyleResolver.cpp
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h
[modify] https://crrev.com/e2f2550028224570ded9a13ddd6d972eece39df4/third_party/WebKit/Source/platform/fonts/FontSelectionTypes.h
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebc21ea05638561d60da231a0e52e50d712520e5

commit ebc21ea05638561d60da231a0e52e50d712520e5
Author: Dominik Röttsches <drott@chromium.org>
Date: Tue Aug 01 13:59:25 2017

Custom converter, properties API, using FontSelectionValue for font-style

Preparation for updating font-style to behave as in CSS
Fonts Level 4 [1].

[1] https://drafts.csswg.org/css-fonts-4/#font-style-prop

Bug:  739139 
Change-Id: Ia65d84b19d44e15dd8ac9faa194526246434b73d
Reviewed-on: https://chromium-review.googlesource.com/579429
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490981}
[modify] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
[modify] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontStyle.cpp
[modify] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.cpp
[modify] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.h
[modify] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFont.cpp
[modify] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/core/css/resolver/FontBuilder.h
[modify] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/core/css/resolver/FontStyleResolver.cpp
[modify] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h
[modify] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/ebc21ea05638561d60da231a0e52e50d712520e5/third_party/WebKit/Source/platform/fonts/FontSelectionTypes.h

Comment 10 by drott@chromium.org, Aug 4 2017

Cc: bugsnash@chromium.org e...@chromium.org r...@opera.com
Status: Fixed (was: Started)
Thanks to everyone who helped with reviews!
►

Sign in to add a comment