Issue metadata
Sign in to add a comment
|
[WPT import] Directories being removed can cause presubmit to fail |
||||||||||||||||||||||||
Issue descriptionAfter https://github.com/w3c/web-platform-tests/pull/6442 the importer began failing on presubmit: https://chromium-review.googlesource.com/c/558150/ https://chromium-review.googlesource.com/c/558469/ https://chromium-review.googlesource.com/c/558764/ https://chromium-review.googlesource.com/c/558546/ https://chromium-review.googlesource.com/c/558765/ Detecting directory renames is non-trivial, but we could detect that a directory has been removed entirely. drott@, how would you ideally liked this to work during automatic import?
,
Jul 5 2017
Good question, I am not sure there's the perfect automation solution for it which could be implemented with reasonable effort. The importer could remove lines from NeverFixTests or W3CImportExpectations when directories get removed? But overall, I think the import scripts and presubmit flagged this situation well. Did you fix this problem manually now, or is there something I can do?
,
Jul 5 2017
The problem was fixed manually, although it was only after the fact that I noticed that presubmit had been failed. Just removing directories that don't exist any more probably works, but it could mean that if you had some idea behind disabling the whole directory, then that could be subverted by enabling it and adding failing expectations for specific tests only.
,
Jul 6 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by foolip@chromium.org
, Jul 4 2017