New issue
Advanced search Search tips

Issue 739121 link

Starred by 1 user
Status: Fixed
Owner:
brat...@opera.com
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Be explicit about the namespace ::testing to not get it mixed up with ::blink::testing

Project Member Reported by brat...@opera.com, Jul 4 2017 
If you, in blink, are looking for a class testing::Test (from gtest) and you have included the ::blink::testing helper namespace, then you have to prepend testing::Test with ::.

Since you can't know when someone will make blink::testing visible, it's better to always use ::testing for gtest classes.

Currently half the usages are ::testing, and half testing. 

To avoid too many exclusions in jumbo, I plan to convert them all to ::testing (since jumbo will make blink::testing visible to much more code).
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51287d5e74cd270ce91e432d072e856718b677e3

commit 51287d5e74cd270ce91e432d072e856718b677e3
Author: bratell <bratell@opera.com>
Date: Tue Jul 04 11:36:03 2017

Be explicit about namespace testing to not mix it with blink::testing

There are two namespaces named testing used in Blink unit tests, one
from gtest and one internal helper namespace. If both are visible then
the gtest testing namespace won't be used unless prepended with ::, as
is already done in large parts of the code.

BUG= 739121 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2970833002
Cr-Commit-Position: refs/heads/master@{#484087}

[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/animation/TimingInputTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/css/parser/CSSLazyParsingTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/css/threaded/MultiThreadedTestUtil.h
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/dom/IdleDeadlineTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/dom/MockScriptElementBase.h
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/dom/ModuleMapTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/dom/ScriptedIdleTaskControllerTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/dom/StaticRangeTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/editing/KeyboardTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/events/TouchEventTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/exported/WebElementTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/exported/WebNodeTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/frame/DOMTimerTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/frame/LocalFrameViewTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/html/HTMLEmbedElementTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/html/HTMLIFrameElementAllowTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/html/HTMLImageElementTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/html/HTMLLinkElementSizesAttributeTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/html/HTMLSlotElementTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/html/media/AutoplayUmaHelperTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/html/parser/HTMLDocumentParserTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/layout/CollapsedBorderValueTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/layout/LayoutTestHelper.h
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/layout/OverflowModelTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/loader/DocumentLoadTimingTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/loader/NetworkQuietDetectorTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/page/ChromeClientTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/page/EffectiveNavigationPolicyTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/page/FocusControllerTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/page/PageOverlayTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/page/scrolling/RootScrollerTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/page/scrolling/ScrollStateTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/page/scrolling/SnapCoordinatorTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/paint/HTMLCanvasPainterTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/scheduler/ActiveConnectionThrottlingTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/scheduler/FrameThrottlingTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/scheduler/ThrottlingTest.cpp
[modify] https://crrev.com/51287d5e74cd270ce91e432d072e856718b677e3/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c04dbb714b62253db69c04d7671b2c58af1fccf9

commit c04dbb714b62253db69c04d7671b2c58af1fccf9
Author: bratell <bratell@opera.com>
Date: Fri Jul 07 17:37:36 2017

Be explicit about namespace testing to not mix it with blink::testing

There are two namespaces named testing used in Blink unit tests, one
from gtest and one internal helper namespace. If both are visible then
the gtest testing namespace won't be used unless prepended with ::, as
is already done in large parts of the code.

BUG= 739121 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2967013002
Cr-Commit-Position: refs/heads/master@{#484966}

[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/bindings/core/v8/ActivityLoggerTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/modules/accessibility/AXObjectTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainerTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/modules/csspaint/PaintWorkletTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/modules/indexeddb/MockWebIDBDatabase.h
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/PODArenaTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/PODFreeListArenaTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/TimerTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/WebIconSizesParserTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/bindings/RuntimeCallStatsTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/blob/BlobBytesProviderTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/blob/BlobDataTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/fonts/ScriptRunIteratorTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/fonts/SmallCapsIteratorTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/geometry/FloatBoxTestHelpers.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/graphics/ContiguousContainerTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/graphics/filters/ImageFilterBuilderTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContextTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversionTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/graphics/paint/CullRectTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItemTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/loader/LinkHeaderTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/base/intrusive_heap_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/base/work_queue_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/child/idle_canceled_delayed_task_sweeper_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/child/idle_helper_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/renderer/budget_pool_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/renderer/deadline_task_runner_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/renderer/render_widget_signals_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/renderer/task_cost_estimator_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/renderer/task_duration_metric_reporter_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/renderer/user_model_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scroll/ScrollbarThemeAuraTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/testing/CompositorTest.h
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/text/CharacterTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/text/TextBreakIteratorTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/weborigin/OriginAccessEntryTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/web/tests/LocalFrameClientImplTest.cpp
[modify] https://crrev.com/c04dbb714b62253db69c04d7671b2c58af1fccf9/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00824436b20d36ccd8c98f895364940aed1a17c1

commit 00824436b20d36ccd8c98f895364940aed1a17c1
Author: Daniel Bratell <bratell@opera.com>
Date: Mon Jul 10 10:34:42 2017

Mojo: Be more explicit with namespace 'testing'

There are two namespaces named testing used in Blink unit tests, one
from gtest and one internal helper namespace. If both are visible then
the gtest testing namespace won't be used unless prepended with ::, as
is already done in large parts of the code.

This is more important for jumbo builds where the visibility of code
expands.

BUG= 739121 

Change-Id: Iaed685c8750fbffbaac384aabc4e2a8f54bcf5c0
Reviewed-on: https://chromium-review.googlesource.com/563619
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: bratell at Opera <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#485226}
[modify] https://crrev.com/00824436b20d36ccd8c98f895364940aed1a17c1/third_party/WebKit/Source/platform/mojo/CommonCustomTypesStructTraitsTest.cpp
[modify] https://crrev.com/00824436b20d36ccd8c98f895364940aed1a17c1/third_party/WebKit/Source/platform/mojo/GeometryStructTraitsTest.cpp
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c865be663632a798e0413ae5273d03d226853c2

commit 4c865be663632a798e0413ae5273d03d226853c2
Author: Daniel Bratell <bratell@opera.com>
Date: Fri Jul 14 19:23:11 2017

blink/platform: Be explicit about namespace testing to not mix it with blink::testing

There are two namespaces named testing used in Blink unit tests, one
from gtest and one internal helper namespace. If both are visible then
the gtest testing namespace won't be used unless prepended with ::, as
is already done in large parts of the code.

BUG= 739121 
R=haraken@opera.com

Change-Id: I48f6a3145886253576a53d1ad9c08307ceca0d52
Reviewed-on: https://chromium-review.googlesource.com/567143
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#486839}
[modify] https://crrev.com/4c865be663632a798e0413ae5273d03d226853c2/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTest.cpp
[modify] https://crrev.com/4c865be663632a798e0413ae5273d03d226853c2/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8494c2f0b2496b80091a7c4338841d41ab8f1f4c

commit 8494c2f0b2496b80091a7c4338841d41ab8f1f4c
Author: Morten Stenshorne <mstensho@opera.com>
Date: Mon Jul 24 19:43:13 2017

Explicit namespace ::testing, to not confuse it with blink::testing

This fixes a merge mistake at
https://chromium-review.googlesource.com/c/519168/25/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

That CL overwrote parts of https://codereview.chromium.org/2970833002 ,
which broke Jumbo compilation.

BUG= 739121 

Change-Id: I486a2c49032ffeef2bd81d5e230a9f9cf81b646f
Reviewed-on: https://chromium-review.googlesource.com/582611
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#489050}
[modify] https://crrev.com/8494c2f0b2496b80091a7c4338841d41ab8f1f4c/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

Comment 6 by brat...@opera.com, Sep 5 2017

Status: Fixed (was: Untriaged)
I think I've fixed all of the important ones now, so closing this bug. I might still use it if something small appears and need fixing.
►

Sign in to add a comment