New issue
Advanced search Search tips

Issue 739111 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10%-22.2% regression in blink_perf.layout at 483388:483596

Project Member Reported by rmcilroy@chromium.org, Jul 4 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=739111

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnvvu9QkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnuSXjwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgntWIowkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnqiX2QgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnqWF4ggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnuybsQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnsjGkggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnsLqrQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnsnU6goM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnsO2swkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnsnU6ggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7oOQiggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7u_Q2gsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnq7V-wkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnq7V-woM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnq7V-wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnsahoAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnuiI-AoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7omN0AoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnoXPrggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7pnMoggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnoeGuwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgno717wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnpingQgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7pnMwgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnpin_gsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnvndjAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnpW5tAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg3qyv6AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnuCnzAgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnsCypAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnqa9wgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnv3E2wkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnpO0ugsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnvWwtQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnsLPiwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgno6RjggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnpXDnQgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnqrlmAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg3o6ttQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg3sCeugkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7t2SgwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnoXP7ggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7saM_AoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnpDz2gsM


Bot(s) for this bug's original alert(s):

android-webview-nexus6
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
win-high-dpi
Cc: wangxianzhu@chromium.org
Owner: wangxianzhu@chromium.org

=== Auto-CCing suspected CL author wangxianzhu@chromium.org ===

Hi wangxianzhu@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Xianzhu Wang
  Commit : 7d51399398db180fe1a7a83a95820e56a9fac755
  Date   : Thu Jun 29 18:28:49 2017
  Subject: Devirtualize LayoutBoxModelObject logical orientation border/margin/padding accessors

Bisect Details
  Configuration: winx64_high_dpi_perf_bisect
  Benchmark    : blink_perf.layout
  Metric       : floats_2_100_nested/floats_2_100_nested
  Change       : 19.64% | 157.191833333 -> 188.060333333

Revision             Result                  N
chromium@483416      157.192 +- 1.18147      6      good
chromium@483425      154.259 +- 2.6891       6      good
chromium@483430      153.39 +- 2.13364       6      good
chromium@483431      155.047 +- 1.18452      6      good
chromium@483432      190.28 +- 6.49793       6      bad       <--
chromium@483434      193.369 +- 36.5085      6      bad
chromium@483451      187.875 +- 2.98011      6      bad
chromium@483486      186.015 +- 2.82797      6      bad
chromium@483555      188.06 +- 0.770882      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.layout

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8975010211115927504


For feedback, file a bug with component Speed>Bisection

Comment 4 by pdr@chromium.org, Jul 7 2017

Owner: pdr@chromium.org
Status: Assigned (was: Untriaged)
Xianzhu is on vacation. I can take care of reverting the patch.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b825bde118a19baa2d913ed350b62656cb2abf7

commit 3b825bde118a19baa2d913ed350b62656cb2abf7
Author: Philip Rogers <pdr@chromium.org>
Date: Fri Jul 07 07:07:24 2017

Revert "Devirtualize LayoutBoxModelObject logical orientation border/margin/padding accessors"

This manually reverts commit 7d51399398db180fe1a7a83a95820e56a9fac755:
https://crrev.com/7d51399398db180fe1a7a83a95820e56a9fac755

Reason for revert: Performance regression  crbug.com/739111 

TBR=wangxianzhu@chromium.org,dgrogan@chromium.org,eae@chromium.org

Bug:  739111 
Change-Id: Ic8b1d3dd4654d45a761666f8b61a1f6eb5fa5137
Reviewed-on: https://chromium-review.googlesource.com/562595
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484846}
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/fast/sub-pixel/input-caret-on-subpixel-bound-expected.html
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/fast/table/table-in-table-percent-width-collapsing-border-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/mac-mac10.9/tables/mozilla_expected_failures/bugs/bug89315-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug89315-expected.png
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/core/html/HTMLElement.h
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/core/layout/LayoutInline.h
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.h
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/core/layout/LayoutTable.h
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/core/layout/LayoutTableTest.cpp
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.h
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/platform/geometry/LayoutRectOutsetsTest.cpp
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/platform/text/WritingModeUtils.h
[modify] https://crrev.com/3b825bde118a19baa2d913ed350b62656cb2abf7/third_party/WebKit/Source/platform/text/WritingModeUtilsTest.cpp

Comment 6 by pdr@chromium.org, Jul 7 2017

Status: Fixed (was: Assigned)
These graphs have all gone back to baseline.

This regression was primarily on Windows. I wonder if the patch just needs to do something special for the windows compiler.

Sign in to add a comment