New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 739104 link

Starred by 2 users
Status: Duplicate
Merged: issue 774303
Owner:
hbos@chromium.org
Closed: Nov 2017
Cc:
█ deadbeef@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 700916
issue 760107



Sign in to add a comment

RTP Media API: Fire RTCPeerConnection.ontrack and MediaStreamTrack.onmuted/MediaStream.onremovetrack

Project Member Reported by hbos@chromium.org, Jul 4 2017 
addTrack should result in an ontrack event firing on the remote side.

removeTrack should result in an onmuted event firing on the remote side, and MediaStream.onremovetrack

https://github.com/w3c/webrtc-pc/issues/1161#issuecomment-313088496
https://github.com/w3c/webrtc-pc/issues/1181

Comment 1 by hbos@chromium.org, Jul 12 2017

Description: Show this description

Comment 2 by hbos@chromium.org, Jul 12 2017

Summary: RTP Media API: Fire RTCPeerConnection.ontrack and MediaStreamTrack.onmuted/MediaStream.onremovetrack (was: RTP Media API: Fire RTCPeerConnection.ontrack and MediaStreamTrack.ended events)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9147fe68cd4c9c65f4949eb6317b90de8b879965

commit 9147fe68cd4c9c65f4949eb6317b90de8b879965
Author: Henrik Boström <hbos@chromium.org>
Date: Thu Aug 17 16:05:15 2017

RTCPeerConnection.ontrack event added.

Interface RTCTrackEvent and dictionary RTCTrackEventInit added.
The event is fired when the remote track is added.

Spec refs:

RTCPeerConnection.ontrack
https://rawgit.com/w3c/webrtc-pc/master/webrtc.html#dom-rtcpeerconnection-ontrack

RTCTrackEvent
https://rawgit.com/w3c/webrtc-pc/master/webrtc.html#dom-rtctrackevent

RTCTrackEventInit
https://rawgit.com/w3c/webrtc-pc/master/webrtc.html#dom-rtctrackeventinit

Processing a remote track
https://rawgit.com/w3c/webrtc-pc/master/webrtc.html#process-remote-track
(Note: we don't support transceivers yet, only firing with receiver)

Bug:  739104 
Change-Id: I8d175c42f0e67531635560b528c7b854558d732e
Reviewed-on: https://chromium-review.googlesource.com/574855
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495183}
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/chrome/browser/media/webrtc/webrtc_browsertest_base.h
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/chrome/browser/media/webrtc/webrtc_rtp_browsertest.cc
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/chrome/test/data/webrtc/peerconnection.js
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/content/renderer/media/mock_web_rtc_peer_connection_handler_client.h
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/content/renderer/media/rtc_peer_connection_handler.cc
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/content/renderer/media/rtc_peer_connection_handler.h
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/content/renderer/media/webrtc/rtc_rtp_receiver.cc
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/content/renderer/media/webrtc/rtc_rtp_receiver.h
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/content/shell/test_runner/mock_webrtc_peer_connection_handler.cc
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-idl-expected.txt
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-ontrack-expected.txt
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/LayoutTests/external/wpt/webrtc/interfaces-expected.txt
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-AddRemoveTrack.html
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-getReceivers.html
[add] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-ontrack.html
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/Source/core/events/EventTypeNames.json5
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/Source/modules/peerconnection/BUILD.gn
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
[add] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/Source/modules/peerconnection/RTCTrackEvent.cpp
[add] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/Source/modules/peerconnection/RTCTrackEvent.h
[add] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/Source/modules/peerconnection/RTCTrackEvent.idl
[add] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/Source/modules/peerconnection/RTCTrackEventInit.idl
[modify] https://crrev.com/9147fe68cd4c9c65f4949eb6317b90de8b879965/third_party/WebKit/public/platform/WebRTCPeerConnectionHandlerClient.h

Comment 4 by hbos@chromium.org, Aug 18 2017

Status: Started (was: Assigned)
If this lands https://github.com/w3c/webrtc-pc/pull/1519 we need to make ontrack fire before setRemoteDescription's promise resolves.

Comment 5 by hbos@chromium.org, Sep 25 2017

Blocking: 760107

Comment 6 by hbos@chromium.org, Nov 27 2017

Mergedinto: 774303
Status: Duplicate (was: Started)
►

Sign in to add a comment