Write a test which closes quick view. |
|||||
Issue descriptionFollow up for crbug.com/738826 . Let's create a test to prevent the regression caused by removal of paper-dialog. Currently we have only one test for quick view, which opens quick view. It was too weak to catch the regression. https://cs.chromium.org/chromium/src/ui/file_manager/integration_tests/file_manager/quick_view.js
,
Jul 5 2017
OK, I'll take a look. Thanks!
,
Jul 5 2017
,
Jul 5 2017
Hmm, I realized the openQuickView test has been disabled. https://cs.chromium.org/chromium/src/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc?type=cs&q=openQuickView&l=180 Could you also revive this test? You may need another bug for this. Thanks.
,
Jul 5 2017
,
Jul 5 2017
Can we migrate the files pp to not use paper-dialog (and use cr-dialog instead)?
,
Jul 6 2017
dpapad@: Thank you! (it seems fukino@ LGTM'd the CL https://crrev.com/2966163003/)
,
Jul 7 2017
oka@: FYI it is also possible to catch this type of regression by openQuickView #4.
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6330d60e1258f7ce29cdee7c4a4a1d85d54c9642 commit 6330d60e1258f7ce29cdee7c4a4a1d85d54c9642 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Jul 18 05:09:23 2017 FilesApp: Add closeQuickView integration test. Wrote a test to close Quick View dialog. In order to do this, also extended test.util.sync.{fakeMouseClick,sendEvent} functions. BUG= 739103 TEST= out/Debug/browser_tests '--gtest_filter=QuickView/FileManagerBrowserTest.Test*' Change-Id: Idad7568541eba65b08a116f8a29b94a6c009cf7c Reviewed-on: https://chromium-review.googlesource.com/567910 Reviewed-by: Naoki Fukino <fukino@chromium.org> Reviewed-by: Keigo Oka <oka@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#487389} [modify] https://crrev.com/6330d60e1258f7ce29cdee7c4a4a1d85d54c9642/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/6330d60e1258f7ce29cdee7c4a4a1d85d54c9642/ui/file_manager/file_manager/background/js/test_util_base.js [modify] https://crrev.com/6330d60e1258f7ce29cdee7c4a4a1d85d54c9642/ui/file_manager/integration_tests/file_manager/quick_view.js
,
Jul 21 2017
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by oka@chromium.org
, Jul 4 2017Components: Platform>Apps>FileManager
Labels: -Type-Bug OS-Chrome Type-Task
Owner: tetsui@chromium.org
Status: Available (was: Untriaged)