New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739092 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 734950



Sign in to add a comment

Mojoify WebContentSettingsClient for shared worker

Project Member Reported by shimazu@chromium.org, Jul 4 2017

Issue description

Implement mojoified WebContentSettingsClient for shared worker. 
The interface for worker's ContentSettingsClient can be implemented on the blink layer. It'll be connected via GetInterfaceProvider(). 

 
Blocking: 734950
Components: -Blink>ServiceWorker Blink>Workers
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68992b01414a40f61ecfcc02a9a71925f5c6a04c

commit 68992b01414a40f61ecfcc02a9a71925f5c6a04c
Author: Yuki Yamada <yukiy@google.com>
Date: Mon Jul 31 06:13:45 2017

Mojoify WebContentSettingsClient for shared worker.

This patch Mojoifies WebContentSettingsClient used by shared worker.
SharedWorkerContentSettingsProxy is created in browser, and then passed onto 
renderer.
Inside blink, it gets some content settings information from browser 
via mojom::SharedWorkerContentSettingsProxy.

Replaced by SharedWorkerContentSettingsProxy,
EmbeddedSharedWorkerContentSettingsClientProxy was removed.

There are no useful tests for indexeddb or filesystem, so I tested this patch
by hand, Using some .js and called indexeddb.open and webkitRequestFileSystem.
https://crbug.com/113738 is for adding indexeddb tests, and it is still available.

Bug:  739092 
Change-Id: I5523b3ba533707416452a56c5f04250a1117ba15
Reviewed-on: https://chromium-review.googlesource.com/562854
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@google.com>
Cr-Commit-Position: refs/heads/master@{#490717}
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/content/browser/BUILD.gn
[add] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/content/browser/shared_worker/DEPS
[add] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/content/browser/shared_worker/shared_worker_content_settings_proxy_impl.cc
[add] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/content/browser/shared_worker/shared_worker_content_settings_proxy_impl.h
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/content/browser/shared_worker/shared_worker_host.cc
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/content/browser/shared_worker/shared_worker_host.h
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/content/browser/shared_worker/shared_worker_message_filter.cc
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/content/browser/shared_worker/shared_worker_message_filter.h
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/content/browser/shared_worker/shared_worker_service_impl.cc
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/content/browser/shared_worker/shared_worker_service_impl.h
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/content/common/worker_messages.h
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/content/renderer/BUILD.gn
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/content/renderer/render_thread_impl.cc
[delete] https://crrev.com/4a68f1fc165546a950bc013ad0e72399dbba91af/content/renderer/shared_worker/embedded_shared_worker_content_settings_client_proxy.cc
[delete] https://crrev.com/4a68f1fc165546a950bc013ad0e72399dbba91af/content/renderer/shared_worker/embedded_shared_worker_content_settings_client_proxy.h
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/third_party/WebKit/Source/core/workers/BUILD.gn
[add] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/third_party/WebKit/Source/core/workers/SharedWorkerContentSettingsProxy.cpp
[add] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/third_party/WebKit/Source/core/workers/SharedWorkerContentSettingsProxy.h
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/third_party/WebKit/public/web/WebSharedWorker.h
[modify] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/third_party/WebKit/public/web/WebSharedWorkerClient.h
[add] https://crrev.com/68992b01414a40f61ecfcc02a9a71925f5c6a04c/third_party/WebKit/public/web/shared_worker_content_settings_proxy.mojom

Comment 4 by yukiy@google.com, Aug 10 2017

Status: Fixed (was: Started)
This issue is followed up by  https://crbug.com/754182 

Sign in to add a comment