A prototype using blink::PageOverlay works on my local machine.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fed9c4bc9f4f9de9bd9fc8cbe2e8437576dc90a3 commit fed9c4bc9f4f9de9bd9fc8cbe2e8437576dc90a3 Author: Kent Tamura <tkent@chromium.org> Date: Wed Jul 05 06:23:58 2017 ValidationBubbleInRenderer: Add a runtime flag, and a skeleton of PageOverlay implementation. This CL is the first step of implementing form validation message bubble in Blink. This CL has no behavior changes. * blink::ValidationMessageOverlayDelegate An empty implementation of blink::PageOverlay for validation bubbles. * blink::ValidationMessageClientImpl If the flag is set, creates a ValidationMessageOverlayDelegate, do not call validation message functions of WebViewClient, do not start a timer. The timer isn't necessary for PageOverlay because LayoutOverlay() is called after every layout. * blink::WebViewImpl Add hooks for PageOverlay in ValidationMessageClient like other PageOverlays. BeginFrame() needs a hook because ValidationMessageOverlayDelegate will use CSS animation though other PageOverlays don't need CSS animation. * blink::WebFrameWidgetImpl Add a hook in BeginFrame(). This is necessary for OOPIF. Bug: 739091 Change-Id: I6f22d8e46eeb82898b4d30daa3ee73241df03b18 Reviewed-on: https://chromium-review.googlesource.com/558858 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#484196} [modify] https://crrev.com/fed9c4bc9f4f9de9bd9fc8cbe2e8437576dc90a3/third_party/WebKit/Source/core/page/BUILD.gn [modify] https://crrev.com/fed9c4bc9f4f9de9bd9fc8cbe2e8437576dc90a3/third_party/WebKit/Source/core/page/ValidationMessageClient.h [modify] https://crrev.com/fed9c4bc9f4f9de9bd9fc8cbe2e8437576dc90a3/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp [modify] https://crrev.com/fed9c4bc9f4f9de9bd9fc8cbe2e8437576dc90a3/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h [add] https://crrev.com/fed9c4bc9f4f9de9bd9fc8cbe2e8437576dc90a3/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.cpp [add] https://crrev.com/fed9c4bc9f4f9de9bd9fc8cbe2e8437576dc90a3/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.h [modify] https://crrev.com/fed9c4bc9f4f9de9bd9fc8cbe2e8437576dc90a3/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 [modify] https://crrev.com/fed9c4bc9f4f9de9bd9fc8cbe2e8437576dc90a3/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp [modify] https://crrev.com/fed9c4bc9f4f9de9bd9fc8cbe2e8437576dc90a3/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/fed9c4bc9f4f9de9bd9fc8cbe2e8437576dc90a3/third_party/WebKit/Source/web/WebViewImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09990d270ca4df99e5322b79f622148ccb9bbd47 commit 09990d270ca4df99e5322b79f622148ccb9bbd47 Author: Kent Tamura <tkent@chromium.org> Date: Wed Jul 05 06:41:28 2017 ValidationBubbleInRenderer: Set up an internal Page, and paint it. This CL has no behavior changes. All code is behind a flag. Bug: 739091 Change-Id: I5f839101ad36b69379ed6c5416412b468d46dcdf Reviewed-on: https://chromium-review.googlesource.com/558843 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#484197} [modify] https://crrev.com/09990d270ca4df99e5322b79f622148ccb9bbd47/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp [modify] https://crrev.com/09990d270ca4df99e5322b79f622148ccb9bbd47/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.cpp [modify] https://crrev.com/09990d270ca4df99e5322b79f622148ccb9bbd47/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e65a6eccff55c9b055307c45421ff74756a09f36 commit e65a6eccff55c9b055307c45421ff74756a09f36 Author: Kent Tamura <tkent@chromium.org> Date: Thu Jul 06 06:21:08 2017 ValidationBubbleInRenderer: Build an HTML document representing a validation bubble. - Disable CSS transition in the layout test mode. - Disable auto-hiding behavior in the layout test mode. - Enable this feature as "experimental" ValidationMessage request dump in test_runner isn't used any longer. This CL needs to update some -expected.txt of existing tests. - Add two pixel tests. Bug: 739091 Change-Id: I33285b345af4d76e2cf6ebf6d5ee0707c14792d8 Reviewed-on: https://chromium-review.googlesource.com/560919 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#484478} [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/content/child/blink_platform_impl.cc [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/date/date-interactive-validation-required-expected.txt [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/datetimelocal/datetimelocal-interactive-validation-required-expected.txt [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/file/file-input-empty-validation-expected.txt [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/file/file-input-reset-validation-expected.txt [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/interactive-validation-assertion-by-validate-twice-expected.txt [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/interactive-validation-attach-assertion-expected.txt [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/interactive-validation-prevented-expected.txt [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/interactive-validation-select-crash-expected.txt [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/month/month-interactive-validation-required-expected.txt [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/number/number-interactive-validation-required-expected.txt [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/reportValidity-cancel-expected.txt [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/reportValidity-handler-updates-dom-expected.txt [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/reportValidity-invalid-expected.txt [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/submit-onFocus-invalidForm-expected.txt [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/time/time-interactive-validation-required-expected.txt [add] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-edge-expected.png [add] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-edge-expected.txt [add] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-edge.html [add] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-iframe-expected.png [add] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-iframe-expected.txt [add] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-iframe.html [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/LayoutTests/fast/forms/week/week-interactive-validation-required-expected.txt [add] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/Source/core/html/forms/resources/input_alert.svg [add] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/Source/core/html/forms/resources/validation_bubble.css [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.cpp [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.h [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 [modify] https://crrev.com/e65a6eccff55c9b055307c45421ff74756a09f36/third_party/WebKit/public/blink_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e827db9bb82986fb9e00d28695c9bc60b7ebde0a commit e827db9bb82986fb9e00d28695c9bc60b7ebde0a Author: Kent Tamura <tkent@chromium.org> Date: Fri Jul 07 16:49:15 2017 Make the default Locale object resettable by internals.setUserPreferredLanguages(). This is necessary to test a behavior depending on the default language. Bug: 739091 Change-Id: Ifcf3b7e5347e4a065094bfff70d95ac0ea47672d Reviewed-on: https://chromium-review.googlesource.com/560930 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#484957} [modify] https://crrev.com/e827db9bb82986fb9e00d28695c9bc60b7ebde0a/third_party/WebKit/Source/platform/Language.cpp [modify] https://crrev.com/e827db9bb82986fb9e00d28695c9bc60b7ebde0a/third_party/WebKit/Source/platform/text/PlatformLocale.cpp [modify] https://crrev.com/e827db9bb82986fb9e00d28695c9bc60b7ebde0a/third_party/WebKit/Source/platform/text/PlatformLocale.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91f7d6cc738e768e5d64f7d49b53002df0a072a4 commit 91f7d6cc738e768e5d64f7d49b53002df0a072a4 Author: Kent Tamura <tkent@chromium.org> Date: Fri Jul 07 19:13:05 2017 ValidationBubbleInRenderer: Adjust bubble arrow position. This CL includes RTL support. * If the UI locale is RTL, flip the bubble layout. - The default arrow position is on the right side. - The icon is on the right side. * If the default position of the bubble arrow doesn't point at the anchor element rectangle, move the arrow position. Implementation: - Set <body dir=> for the UI locale. - Found that it's difficult to adjust arrow position in RTL + position:relative. Switch inner arrow's position to 'absolute', and add spacer elements to secure height. - Fix the icon margin in RTL. - Drop layout tree dump from tests. Bug: 739091 Change-Id: I3da7f9ed3a248d1bf5a95d77d3b93667e3bdf9da Reviewed-on: https://chromium-review.googlesource.com/561048 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#485002} [modify] https://crrev.com/91f7d6cc738e768e5d64f7d49b53002df0a072a4/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/91f7d6cc738e768e5d64f7d49b53002df0a072a4/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-edge-expected.png [modify] https://crrev.com/91f7d6cc738e768e5d64f7d49b53002df0a072a4/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-edge-expected.txt [modify] https://crrev.com/91f7d6cc738e768e5d64f7d49b53002df0a072a4/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-edge.html [modify] https://crrev.com/91f7d6cc738e768e5d64f7d49b53002df0a072a4/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-iframe-expected.png [modify] https://crrev.com/91f7d6cc738e768e5d64f7d49b53002df0a072a4/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-iframe-expected.txt [modify] https://crrev.com/91f7d6cc738e768e5d64f7d49b53002df0a072a4/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-iframe.html [add] https://crrev.com/91f7d6cc738e768e5d64f7d49b53002df0a072a4/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-rtl-ui-expected.png [add] https://crrev.com/91f7d6cc738e768e5d64f7d49b53002df0a072a4/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-rtl-ui-expected.txt [add] https://crrev.com/91f7d6cc738e768e5d64f7d49b53002df0a072a4/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-rtl-ui.html [modify] https://crrev.com/91f7d6cc738e768e5d64f7d49b53002df0a072a4/third_party/WebKit/Source/core/html/forms/resources/validation_bubble.css [modify] https://crrev.com/91f7d6cc738e768e5d64f7d49b53002df0a072a4/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.cpp [modify] https://crrev.com/91f7d6cc738e768e5d64f7d49b53002df0a072a4/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27fed03fda701a6e29d4b5796b56f56f4f96921a commit 27fed03fda701a6e29d4b5796b56f56f4f96921a Author: Kent Tamura <tkent@chromium.org> Date: Mon Jul 10 08:32:52 2017 ValidationBubbleInRenderer: Escape validation messages. Unescaped custom validation messages could cause DCHECK failures. Bug: 739091 Change-Id: Ia7993221cad5d7ff00767cfe676e88da2fba2114 Reviewed-on: https://chromium-review.googlesource.com/564194 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#485204} [add] https://crrev.com/27fed03fda701a6e29d4b5796b56f56f4f96921a/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-escape.html [modify] https://crrev.com/27fed03fda701a6e29d4b5796b56f56f4f96921a/third_party/WebKit/Source/core/page/PagePopupClient.cpp [modify] https://crrev.com/27fed03fda701a6e29d4b5796b56f56f4f96921a/third_party/WebKit/Source/core/page/PagePopupClient.h [modify] https://crrev.com/27fed03fda701a6e29d4b5796b56f56f4f96921a/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f6794f6320b550d233f023248b84096234e550e commit 3f6794f6320b550d233f023248b84096234e550e Author: Kent Tamura <tkent@chromium.org> Date: Tue Jul 11 12:14:13 2017 ValidationBubbleInRenderer: Update an icon image. Add some shadow to input_alert.svg in order to match to input_alert.png. Bug: 739091 Change-Id: I4dcb0617180fba917be85151601722f5e1cb40e9 Reviewed-on: https://chromium-review.googlesource.com/566790 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#485603} [modify] https://crrev.com/3f6794f6320b550d233f023248b84096234e550e/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-edge-expected.png [modify] https://crrev.com/3f6794f6320b550d233f023248b84096234e550e/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-iframe-expected.png [modify] https://crrev.com/3f6794f6320b550d233f023248b84096234e550e/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-appearance-rtl-ui-expected.png [modify] https://crrev.com/3f6794f6320b550d233f023248b84096234e550e/third_party/WebKit/Source/core/html/forms/resources/input_alert.svg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4782b12a04373772f011a4fbaaf271e6512d0727 commit 4782b12a04373772f011a4fbaaf271e6512d0727 Author: Kent Tamura <tkent@chromium.org> Date: Wed Jul 12 07:21:54 2017 ValidationBubbleInRenderer: Add height grow animation on showing a bubble. This behavior is similar to the current behavior on macOS. Note that Windows and Linux have height and width grow animation from the center of a bubble, and Android has no animation. Bug: 739091 Change-Id: I771b1f22ba503287222e91919afa1c2853aea940 Reviewed-on: https://chromium-review.googlesource.com/567616 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#485888} [modify] https://crrev.com/4782b12a04373772f011a4fbaaf271e6512d0727/third_party/WebKit/Source/core/html/forms/resources/validation_bubble.css [modify] https://crrev.com/4782b12a04373772f011a4fbaaf271e6512d0727/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8a73395332ec02683f4662e9e08c25ae650c42e commit d8a73395332ec02683f4662e9e08c25ae650c42e Author: Kent Tamura <tkent@chromium.org> Date: Thu Jul 13 03:23:32 2017 ValidationBubbleInRenderer: Support Hi-DPI display and page zoom. Bug: 739091 Change-Id: Iff2e9afd1b472bd5acd3259651733ffe7878f542 Reviewed-on: https://chromium-review.googlesource.com/566747 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#486252} [modify] https://crrev.com/d8a73395332ec02683f4662e9e08c25ae650c42e/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/d8a73395332ec02683f4662e9e08c25ae650c42e/third_party/WebKit/LayoutTests/fast/hidpi/static/validation-bubble-appearance-hidpi.html [add] https://crrev.com/d8a73395332ec02683f4662e9e08c25ae650c42e/third_party/WebKit/LayoutTests/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/d8a73395332ec02683f4662e9e08c25ae650c42e/third_party/WebKit/LayoutTests/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.txt [add] https://crrev.com/d8a73395332ec02683f4662e9e08c25ae650c42e/third_party/WebKit/LayoutTests/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/d8a73395332ec02683f4662e9e08c25ae650c42e/third_party/WebKit/LayoutTests/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.txt [add] https://crrev.com/d8a73395332ec02683f4662e9e08c25ae650c42e/third_party/WebKit/LayoutTests/virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/d8a73395332ec02683f4662e9e08c25ae650c42e/third_party/WebKit/LayoutTests/virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.txt [modify] https://crrev.com/d8a73395332ec02683f4662e9e08c25ae650c42e/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5f61e2a7b9511a3b38937a26aef4b598c713c70 commit f5f61e2a7b9511a3b38937a26aef4b598c713c70 Author: Kent Tamura <tkent@chromium.org> Date: Thu Jul 13 05:45:40 2017 ValidationBubbleInRenderer: Schedule animation correctly. CSS Animation for validation bubbles didn't work if the main page had no CSS Animation because ValidationMessageChromeClient failed to run ScheduleAnimation(). Bug: 739091 Change-Id: Ief3afa079ceb7137ed8db50d5b1bd6e2e4835d14 Reviewed-on: https://chromium-review.googlesource.com/569419 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#486286} [modify] https://crrev.com/f5f61e2a7b9511a3b38937a26aef4b598c713c70/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bffab1cca50a1bc0b6ac8fffcd8ac18fd4e98f62 commit bffab1cca50a1bc0b6ac8fffcd8ac18fd4e98f62 Author: Kent Tamura <tkent@chromium.org> Date: Thu Jul 13 08:24:47 2017 ValidationBubbleInRenderer: Add fade-out animation on hiding a bubble. This behavior is similar to the current behavior on macOS. Note that there is no hiding animation on other OSes with the old implementation. Bug: 739091 Change-Id: I8ac7f914cccd8eadd104b9b2a90db85f432a4c2f Reviewed-on: https://chromium-review.googlesource.com/569520 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#486318} [modify] https://crrev.com/bffab1cca50a1bc0b6ac8fffcd8ac18fd4e98f62/third_party/WebKit/Source/core/html/forms/resources/validation_bubble.css [modify] https://crrev.com/bffab1cca50a1bc0b6ac8fffcd8ac18fd4e98f62/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp [modify] https://crrev.com/bffab1cca50a1bc0b6ac8fffcd8ac18fd4e98f62/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h [modify] https://crrev.com/bffab1cca50a1bc0b6ac8fffcd8ac18fd4e98f62/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.cpp [modify] https://crrev.com/bffab1cca50a1bc0b6ac8fffcd8ac18fd4e98f62/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efd05f304df3a112f8d8923e9510f6ec324822cb commit efd05f304df3a112f8d8923e9510f6ec324822cb Author: Kent Tamura <tkent@chromium.org> Date: Thu Jul 13 23:13:12 2017 ValidationBubbleInRenderer: Enable pixel tests Bug: 739091 Change-Id: Ifbc99e569813dfc2c2ae674beee3e1ea0c062666 TBR: keishi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/569838 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#486522} [modify] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/linux/fast/forms/validation-bubble-appearance-edge-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/linux/fast/forms/validation-bubble-appearance-iframe-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/linux/fast/forms/validation-bubble-appearance-rtl-ui-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/validation-bubble-appearance-edge-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/validation-bubble-appearance-iframe-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/validation-bubble-appearance-rtl-ui-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/validation-bubble-appearance-edge-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/validation-bubble-appearance-iframe-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/validation-bubble-appearance-rtl-ui-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/validation-bubble-appearance-edge-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/validation-bubble-appearance-iframe-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/validation-bubble-appearance-rtl-ui-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/validation-bubble-appearance-edge-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/validation-bubble-appearance-iframe-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/validation-bubble-appearance-rtl-ui-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [rename] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/mac/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/win/fast/forms/validation-bubble-appearance-edge-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/win/fast/forms/validation-bubble-appearance-iframe-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/win/fast/forms/validation-bubble-appearance-rtl-ui-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [add] https://crrev.com/efd05f304df3a112f8d8923e9510f6ec324822cb/third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [delete] https://crrev.com/2f547332c05513d8fe8a620119a39cbdf2bb1f9f/third_party/WebKit/LayoutTests/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [delete] https://crrev.com/2f547332c05513d8fe8a620119a39cbdf2bb1f9f/third_party/WebKit/LayoutTests/virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4 commit 7ca06f6a1f933cfaa87a291ac59138baff5e3cc4 Author: Kent Tamura <tkent@chromium.org> Date: Thu Aug 03 03:18:51 2017 ValidationBubbleInRenderer: Update appearance and motion. Apply feedback from UX team. - Adopt 'Harmony motion' for small dialogue - Make font-size smaller Bug: 739091 Change-Id: I785820860227a9fa4584d5d816d3984c2062efdf Reviewed-on: https://chromium-review.googlesource.com/597088 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#491628} [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/linux/fast/forms/validation-bubble-appearance-edge-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/linux/fast/forms/validation-bubble-appearance-iframe-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/linux/fast/forms/validation-bubble-appearance-rtl-ui-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/validation-bubble-appearance-edge-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/validation-bubble-appearance-iframe-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/validation-bubble-appearance-rtl-ui-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/validation-bubble-appearance-edge-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/validation-bubble-appearance-iframe-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/validation-bubble-appearance-rtl-ui-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/validation-bubble-appearance-edge-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/validation-bubble-appearance-iframe-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/validation-bubble-appearance-rtl-ui-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/validation-bubble-appearance-edge-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/validation-bubble-appearance-iframe-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/validation-bubble-appearance-rtl-ui-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac/fast/forms/validation-bubble-appearance-edge-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac/fast/forms/validation-bubble-appearance-iframe-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac/fast/forms/validation-bubble-appearance-rtl-ui-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/mac/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/win/fast/forms/validation-bubble-appearance-edge-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/win/fast/forms/validation-bubble-appearance-iframe-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/win/fast/forms/validation-bubble-appearance-rtl-ui-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/Source/core/html/forms/resources/validation_bubble.css [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp [modify] https://crrev.com/7ca06f6a1f933cfaa87a291ac59138baff5e3cc4/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2752293b8965ddfdcf7a3780573e795188a62f1f commit 2752293b8965ddfdcf7a3780573e795188a62f1f Author: Kent Tamura <tkent@chromium.org> Date: Thu Aug 17 01:04:51 2017 ValidationBubbleInRenderer: Enable it by default. Bug: 432243 , 597044 , 734729 , 736009 , 736792 , 739091 Change-Id: I15a9a24cd86be34dca315f898e556b044bf0acfd Reviewed-on: https://chromium-review.googlesource.com/607770 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#495027} [modify] https://crrev.com/2752293b8965ddfdcf7a3780573e795188a62f1f/content/browser/web_contents/web_contents_impl_browsertest.cc [modify] https://crrev.com/2752293b8965ddfdcf7a3780573e795188a62f1f/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
I'll remove the old implementation after Google Chrome 62 Beta release.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4abbc42c1cd1d4ef3822e49fc7c5057a6128ef9 commit c4abbc42c1cd1d4ef3822e49fc7c5057a6128ef9 Author: Kent Tamura <tkent@chromium.org> Date: Fri Aug 25 02:20:41 2017 ValidationBubbleInRenderer: Remove height scaling animation. This scaling animation was very slow, like 1px/1.166s, and it showed a jitter of text. This CL removes the height scaling animation. This change was approved by UX team. Bug: 739091 Change-Id: Ia5e774a351564665228d90cc3f47d95bd4e8d8a8 Reviewed-on: https://chromium-review.googlesource.com/633965 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#497303} [modify] https://crrev.com/c4abbc42c1cd1d4ef3822e49fc7c5057a6128ef9/third_party/WebKit/Source/core/html/forms/resources/validation_bubble.css
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35da2e64efaf6e3ad7d9f8beba40eeda63e23aa9 commit 35da2e64efaf6e3ad7d9f8beba40eeda63e23aa9 Author: Kent Tamura <tkent@chromium.org> Date: Tue Aug 29 03:19:57 2017 ValidationBubbleInRenderer: Scale animation origin should match to arrow anchor point. Apply a feedback from UX team. Bug: 739091 Change-Id: I061f477b786fb4764540a6280d5b954f47cac027 Reviewed-on: https://chromium-review.googlesource.com/640052 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#498008} [modify] https://crrev.com/35da2e64efaf6e3ad7d9f8beba40eeda63e23aa9/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.cpp
The NextAction date has arrived: 2017-09-14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b74d542fe63fd76c5a23fd53b56254be2ed9633e commit b74d542fe63fd76c5a23fd53b56254be2ed9633e Author: Kent Tamura <tkent@chromium.org> Date: Wed Oct 25 21:53:11 2017 Remove unused browser-side validation bubble implementation. A renderer-side validation bubble was shipped with M62. This CL is just a dead-code removal, and has no behavior changes. Bug: 739091 Change-Id: Ibad4d9a3d8068c48a681b3b02db1f8770a58d350 Reviewed-on: https://chromium-review.googlesource.com/726059 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#511602} [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/build/android/lint/suppressions.xml [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/chrome/browser/ui/browser.cc [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/chrome/browser/ui/browser.h [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/chrome/browser/ui/cocoa/tab_dialogs_cocoa.h [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.h [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/chrome/browser/ui/cocoa/validation_message_bubble_controller.h [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/chrome/browser/ui/cocoa/validation_message_bubble_controller_unittest.mm [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/chrome/browser/ui/tab_dialogs.h [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/chrome/browser/ui/validation_message_bubble.h [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/chrome/browser/ui/views/tab_dialogs_views.cc [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/chrome/browser/ui/views/tab_dialogs_views.h [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/chrome/browser/ui/views/validation_message_bubble_view.cc [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/chrome/browser/ui/views/validation_message_bubble_view.h [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/chrome/browser/ui/views/validation_message_bubble_view_unittest.cc [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/chrome/test/BUILD.gn [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/components/web_contents_delegate_android/BUILD.gn [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/components/web_contents_delegate_android/java/res/drawable-hdpi/bubble.9.png [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/components/web_contents_delegate_android/java/res/drawable-hdpi/bubble_arrow_up.png [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/components/web_contents_delegate_android/java/res/drawable-hdpi/ic_warning.png [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/components/web_contents_delegate_android/java/res/drawable-mdpi/bubble.9.png [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/components/web_contents_delegate_android/java/res/drawable-mdpi/bubble_arrow_up.png [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/components/web_contents_delegate_android/java/res/drawable-mdpi/ic_warning.png [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/components/web_contents_delegate_android/java/res/drawable-xhdpi/bubble.9.png [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/components/web_contents_delegate_android/java/res/drawable-xhdpi/bubble_arrow_up.png [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/components/web_contents_delegate_android/java/res/drawable-xhdpi/ic_warning.png [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/components/web_contents_delegate_android/java/res/drawable-xxhdpi/ic_warning.png [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/components/web_contents_delegate_android/java/res/drawable-xxxhdpi/ic_warning.png [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/components/web_contents_delegate_android/java/res/layout/validation_message_bubble.xml [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/components/web_contents_delegate_android/java/src/org/chromium/components/web_contents_delegate_android/ValidationMessageBubble.java [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/components/web_contents_delegate_android/validation_message_bubble_android.cc [delete] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/components/web_contents_delegate_android/validation_message_bubble_android.h [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/components/web_contents_delegate_android/web_contents_delegate_android.cc [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/components/web_contents_delegate_android/web_contents_delegate_android.h [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/content/browser/web_contents/web_contents_impl_browsertest.cc [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/content/browser/web_contents/web_contents_impl_unittest.cc [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/content/common/view_messages.h [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/content/public/browser/web_contents_delegate.h [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/content/renderer/render_view_impl.cc [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/content/renderer/render_view_impl.h [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/content/shell/test_runner/web_view_test_client.cc [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/content/shell/test_runner/web_view_test_client.h [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/content/shell/test_runner/web_view_test_proxy.h [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/third_party/WebKit/Source/platform/runtime_enabled_features.json5 [modify] https://crrev.com/b74d542fe63fd76c5a23fd53b56254be2ed9633e/third_party/WebKit/public/web/WebViewClient.h
Comment 1 by tkent@chromium.org
, Jul 4 2017