I'd like to work on this

I've moved the content in KeyboardUIContent into ChromeKeyboardUI. There's not errors when running ninja, but I'd like to test if everything works fine before uploading. Can you guide me, please? Where can I enable Chrome Keyboard? I don't remember seeing any "virtual keyboard" in chromium.

My irc nick is gvso in case you want to reach me there.

The virtual keyboard is for Chrome OS, not Chrome.
"Chrome" in the OS checkbox below means Chrome OS.

If you really want to work on this, could you check this page and build and run Chrome OS version of Chromium on Linux?
https://chromium.googlesource.com/chromium/src/+/master/docs/old_chromeos_build_instructions.md
(If your machine is not Linux, I'd recommend you to work on other Chromium issues which are not specific to Chrome OS.)
You can specify --enable-virtual-keyboard flag to the chrome binary you build, to enable virtual keyboard.
If virtual keyboard still successfully works with you patch, please send it for review.
I'd happy to test it on my end, or will tell you how to test it.

Thanks.

I'm using Linux and have uploaded a patch.
https://chromium-review.googlesource.com/c/563916/

Just realized that I forgot about the test file, should I rewrite it for ChromeKeyBoardUI too?

Thanks for your guidance

Yes. Please rewrite it for ChromeKeyboardUI. Thank you!

I uploaded another patch set which merge the changes done to the files a few days ago.

I also moved the unit test, but when running it, I get FATAL:notification_service_impl.cc(43)] Check failed: current() == NULL. It doesn't seem to be the test itself which is failing though. I couldn't fine a solution on the internet.

Any ideas of what can be the cause?

Thank you very much!

<please triage>

--> oka@ for triage (although it's marked GoodFirstBug, does this need an owner?)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa4328bed19d775652065274b3056cc00e527bc8

commit fa4328bed19d775652065274b3056cc00e527bc8
Author: Getulio Sánchez <valentin2507@gmail.com>
Date: Thu Sep 07 01:54:16 2017

[Chrome] Refactoring: Remove KeyboardUIContent

ChromeKeyboardUI is the only inheritor of KeyboardUIContent except for tests;
inheritance graph is KeyboardUI > KeyboardUIContent > ChromeKeyboardUI.

This patch consolidates KeyboardUIContent into ChromeKeyboardUI.

R=oka@chromium.org, sky@chromium.org

Bug:  739083 
Change-Id: I9a83dbd69f4b2bdcbe26a0db8c7e7ee11a9d4fb9
Reviewed-on: https://chromium-review.googlesource.com/563916
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500180}
[modify] https://crrev.com/fa4328bed19d775652065274b3056cc00e527bc8/AUTHORS
[modify] https://crrev.com/fa4328bed19d775652065274b3056cc00e527bc8/chrome/browser/ui/ash/chrome_keyboard_ui.cc
[modify] https://crrev.com/fa4328bed19d775652065274b3056cc00e527bc8/chrome/browser/ui/ash/chrome_keyboard_ui.h
[add] https://crrev.com/fa4328bed19d775652065274b3056cc00e527bc8/chrome/browser/ui/ash/chrome_keyboard_ui_unittest.cc
[modify] https://crrev.com/fa4328bed19d775652065274b3056cc00e527bc8/chrome/test/BUILD.gn
[modify] https://crrev.com/fa4328bed19d775652065274b3056cc00e527bc8/ui/keyboard/BUILD.gn
[delete] https://crrev.com/3348ae78d8af5aef4fccd6ff19be07f0ec7b52bc/ui/keyboard/content/keyboard_ui_content.cc
[delete] https://crrev.com/3348ae78d8af5aef4fccd6ff19be07f0ec7b52bc/ui/keyboard/content/keyboard_ui_content.h
[delete] https://crrev.com/3348ae78d8af5aef4fccd6ff19be07f0ec7b52bc/ui/keyboard/content/keyboard_ui_content_unittest.cc