New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739078 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Content is not seen on hitting Enter on Show license link in chrome://credits/

Project Member Reported by keerthan...@techmahindra.com, Jul 4 2017

Issue description

Chrome Version:61.0.3148.0
OS:Ubuntu 14.04
What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://credits/
(2)Keep tabbing till focus reaches the show license link
(3)Hit Enter and observe


Expected:Content should be seen on hitting enter
Actual:Instead, content is not seen on hitting enter

This is a Regression issue broken in M-61
Will update other info soon...
 
Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce this issue on Mac OS 10.12.5 using chrome latest dev #61.0.3148.0.
Labels: Needs-Bisect M-61 OS-Windows
Manual Bisect Info:
===================
Good Build:61.0.3137.0 dev
Bad Build: 61.0.3138.0 dev

NOTE: Till #61.0.3124.0 dev , it's able to open show license link using Enter key.
      From #61.0.3125.0 dev to  #61.0.3137.0 dev unable to navigate to show license link using tab. Hence, considering #61.0.3137.0 dev as good build since focus is not travelling to show license link while tabbing.
ExpectedCredits.ogv
1.2 MB View Download
ActualCredits.ogv
1.2 MB View Download
Cc: jmukthavaram@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision
Owner: yipengw@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue on Windows 7,Mac 10.12.5 & Ubuntu 14.04 using chrome latest Canary#61.0.3147.0.
Manual bisect info:
------------------
Good Build:61.0.3137.0 -Revision-481056
Bad Build: 61.0.3138.0 -Revision-481386

Per revision bisect info:
------------------------
You are probably looking for a change made after 481294 (known good), but no later than 481295 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/6d28625a1e39b2970372984277083e6bf765aa4b..f44e29c25a15fe16c90e352c25375a32e1656fda

Possible suspect:
----------------
https://chromium.googlesource.com/chromium/src/+/f44e29c25a15fe16c90e352c25375a32e1656fda

Yipengw@,Could you please take a look & reassign to the respective owner if it is not related to your change.

Thanks..!!
Cc: msrchandra@chromium.org ranjitkan@chromium.org rbasuvula@chromium.org nyerramilli@chromium.org
 Issue 739141  has been merged into this issue.
This issue should be fixed when this CL(https://chromium-review.googlesource.com/c/558710/) is checked in :-P
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ef4afc3acbd3aedcf02287e39e83733d555fbd4

commit 0ef4afc3acbd3aedcf02287e39e83733d555fbd4
Author: Yipeng Wang <yipengw@chromium.org>
Date: Thu Jul 06 18:07:19 2017

[about:credits] Enable enter on 'show license' link.

Bug:  739078 
Change-Id: I8bd60368df405b6fa6d48852f67627a1c220454f
Reviewed-on: https://chromium-review.googlesource.com/558710
Commit-Queue: Yipeng Wang <yipengw@chromium.org>
Reviewed-by: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484668}
[modify] https://crrev.com/0ef4afc3acbd3aedcf02287e39e83733d555fbd4/components/about_ui/resources/about_credits.js

Status: Fixed (was: Assigned)

Comment 8 by sans...@etouch.net, Jul 11 2017

Labels: TE-Verified-M61 TE-Verified-61.0.3153.0 TE-Verified-61.0.3153.4
 Above issue is fixed on latest Dev version 61.0.3153.0 for Win and 61.0.3153.4 for Mac, Linux OS

Sign in to add a comment