Remove chrome_test_util::WebViewNotContainingText. |
||||
Issue descriptionEarlGrey matchers should not wait. [ChromeEarlGrey waitForWebViewNotContainingText:] has already been created and should be used instead.
,
Jul 5 2017
,
Jul 6 2017
,
Jul 7 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/9bd534bc557a026a5b2563f812d3efa31e28223b commit 9bd534bc557a026a5b2563f812d3efa31e28223b Author: baxley <baxley@google.com> Date: Fri Jul 07 18:10:33 2017
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dd645169fc27e18d86eb03d0ebd052b0d2e85bc commit 6dd645169fc27e18d86eb03d0ebd052b0d2e85bc Author: Mike Baxley <baxley@chromium.org> Date: Mon Jul 10 06:09:16 2017 Delete chrome_test_util::WebViewNotContainingText(). EarlGrey matchers should not wait, this has been replaced by [ChromeEarlGrey waitForWebViewNotContainingText:] Bug: 739073 Change-Id: I742a65025f2814bb29bb32f753623fd88ed179a2 Reviewed-on: https://chromium-review.googlesource.com/558988 Commit-Queue: Mike Baxley <baxley@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#485194} [modify] https://crrev.com/6dd645169fc27e18d86eb03d0ebd052b0d2e85bc/ios/chrome/browser/ui/external_url_error_page_egtest.mm [modify] https://crrev.com/6dd645169fc27e18d86eb03d0ebd052b0d2e85bc/ios/chrome/browser/web/navigation_egtest.mm [modify] https://crrev.com/6dd645169fc27e18d86eb03d0ebd052b0d2e85bc/ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm [modify] https://crrev.com/6dd645169fc27e18d86eb03d0ebd052b0d2e85bc/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/6dd645169fc27e18d86eb03d0ebd052b0d2e85bc/ios/chrome/test/earl_grey/chrome_matchers.mm
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d693cb664d8521f9e12f8e97a4d312d848718e46 commit d693cb664d8521f9e12f8e97a4d312d848718e46 Author: Mike Baxley <baxley@chromium.org> Date: Fri Aug 04 23:27:24 2017 Remove chrome_test_util::WebViewNotContainingText. All callsites have been updated, and now use waitForWebViewNotContainingText. Bug: 739073 Change-Id: Ib25c76e4acfee2221bf65bc2314e2ad46487ce8d Reviewed-on: https://chromium-review.googlesource.com/602891 Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#492171} [modify] https://crrev.com/d693cb664d8521f9e12f8e97a4d312d848718e46/ios/web/public/test/earl_grey/web_view_matchers.h [modify] https://crrev.com/d693cb664d8521f9e12f8e97a4d312d848718e46/ios/web/public/test/earl_grey/web_view_matchers.mm
,
Aug 8 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by baxley@chromium.org
, Jul 4 2017