New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739073 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task

Blocking:
issue 700067



Sign in to add a comment

Remove chrome_test_util::WebViewNotContainingText.

Project Member Reported by baxley@chromium.org, Jul 4 2017

Issue description

EarlGrey matchers should not wait. [ChromeEarlGrey waitForWebViewNotContainingText:] has already been created and should be used instead.
 
Blocking: 700067
Owner: baxley@chromium.org
Status: Assigned (was: Untriaged)
Components: Test>iOS
Labels: -Type-Bug Type-Task
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/9bd534bc557a026a5b2563f812d3efa31e28223b

commit 9bd534bc557a026a5b2563f812d3efa31e28223b
Author: baxley <baxley@google.com>
Date: Fri Jul 07 18:10:33 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d693cb664d8521f9e12f8e97a4d312d848718e46

commit d693cb664d8521f9e12f8e97a4d312d848718e46
Author: Mike Baxley <baxley@chromium.org>
Date: Fri Aug 04 23:27:24 2017

Remove chrome_test_util::WebViewNotContainingText.

All callsites have been updated, and now use
waitForWebViewNotContainingText.

Bug:  739073 
Change-Id: Ib25c76e4acfee2221bf65bc2314e2ad46487ce8d
Reviewed-on: https://chromium-review.googlesource.com/602891
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492171}
[modify] https://crrev.com/d693cb664d8521f9e12f8e97a4d312d848718e46/ios/web/public/test/earl_grey/web_view_matchers.h
[modify] https://crrev.com/d693cb664d8521f9e12f8e97a4d312d848718e46/ios/web/public/test/earl_grey/web_view_matchers.mm

Status: Fixed (was: Assigned)

Sign in to add a comment