New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 739069 link

Starred by 1 user
Status: Verified
Owner:
█ oka@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
omrilio@chromium.org
█ blakeo@chromium.org
yhanada@chromium.org
pcovell@chromium.org
█ dvallet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Refactoring: Rename to distinguish keyboard container window and web contests window

Project Member Reported by oka@chromium.org, Jul 4 2017 
Currently "keyboard" is an overused term referring either
1. the keyboard container window
2. the web contents window in it
3. the entire window as a whole
depending on the context, which is confusing.

Let's use "container" or "web contents (window)" for 1 and 2 where appropriate.

Comment 1 by oka@chromium.org, Jul 4 2017

Summary: Refactroing: distinguish keyboard container window and web contests window (was: Refactroing: Rename to distinguish keyboard container window and web contests window)

Comment 2 by oka@chromium.org, Jul 4 2017

Summary: Refactroing: Rename to distinguish keyboard container window and web contests window (was: Refactroing: distinguish keyboard container window and web contests window)

Comment 3 by oka@chromium.org, Jul 4 2017

Labels: -Pri-3 Pri-2

Comment 4 by oka@chromium.org, Jul 4 2017 

Discussed offline with Hanada-san.
Let's use "contents" instead of "web contents" for the case 2.
Rationale: "web contents" is an implementation detail which might change in the future, e.g. if Android IME comes in.

Comment 5 by oka@chromium.org, Jul 4 2017

Summary: Refactoring: Rename to distinguish keyboard container window and web contests window (was: Refactroing: Rename to distinguish keyboard container window and web contests window)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b01c92faa369712c5b2e52b2596699399401140

commit 4b01c92faa369712c5b2e52b2596699399401140
Author: oka@chromium.org <oka@chromium.org>
Date: Wed Jul 12 21:45:07 2017

Rename keyboard to contents where appropriate

Currently "keyboard" is used for both the container window and the web
contents in it, which is confusing.
To avoid the confusion, this CL renames some "keyboard" to "contents"
or "Keyboard" to "Contents"

Bug:  739069 
Test: try

Change-Id: I8d94626f4a25bca69e328e583cde2b3239dd9367
Reviewed-on: https://chromium-review.googlesource.com/558180
Commit-Queue: Keigo Oka <oka@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486093}
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/ash/test/test_keyboard_ui.cc
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/ash/test/test_keyboard_ui.h
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/ash/wm/always_on_top_controller_unittest.cc
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/ash/wm/lock_action_handler_layout_manager_unittest.cc
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/ash/wm/lock_layout_manager_unittest.cc
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/chrome/browser/ui/ash/keyboard_controller_browsertest.cc
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/ui/keyboard/content/keyboard_ui_content.cc
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/ui/keyboard/content/keyboard_ui_content.h
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/ui/keyboard/content/keyboard_ui_content_unittest.cc
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/ui/keyboard/keyboard_controller_unittest.cc
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/ui/keyboard/keyboard_ui.cc
[modify] https://crrev.com/4b01c92faa369712c5b2e52b2596699399401140/ui/keyboard/keyboard_ui.h

Comment 7 by oka@chromium.org, Jul 12 2017

Status: Fixed (was: Assigned)

Comment 9 by kathrelk...@chromium.org, Aug 10 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment