New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738959 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Remove unused method ServiceWorkerUtills::IsMojoForServiceWorkerEnabled()

Project Member Reported by yukiy@google.com, Jul 4 2017

Issue description

This method always returns true, and is used only for DCHECK so it can be removed.
 

Comment 1 by yukiy@google.com, Jul 4 2017

Summary: Remove unused method ServiceWorkerUtills::IsMojoForServiceWorkerEnabled() (was: Removed unused method ServiceWorkerUtills::IsMojoForServiceWorkerEnabled())

Comment 2 by yukiy@google.com, Jul 4 2017

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/468c6ca853b5f75fc61897c87ee815c18605d407

commit 468c6ca853b5f75fc61897c87ee815c18605d407
Author: Yuki Yamada <yukiy@google.com>
Date: Thu Jul 06 03:11:27 2017

remove ServiceWorkerUtills::IsMojoForServiceWorkerEnabled()

This method always returns true, and used only for DCHECK so it can be removed.

Bug:  738959 
Change-Id: Ic76255ce1be93e875c9ea8c4e8c74fc029a52d12
Reviewed-on: https://chromium-review.googlesource.com/558338
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@google.com>
Cr-Commit-Position: refs/heads/master@{#484451}
[modify] https://crrev.com/468c6ca853b5f75fc61897c87ee815c18605d407/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/468c6ca853b5f75fc61897c87ee815c18605d407/content/common/service_worker/service_worker_utils.cc
[modify] https://crrev.com/468c6ca853b5f75fc61897c87ee815c18605d407/content/common/service_worker/service_worker_utils.h

Comment 4 by yukiy@google.com, Jul 6 2017

Status: Fixed (was: Started)

Sign in to add a comment