New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738958 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[MD Bookmarks] Should scroll to and select newly created bookmarks

Project Member Reported by tsergeant@chromium.org, Jul 4 2017

Issue description

When:

- Creating a new bookmark
- Pasting bookmarks
- Dropping bookmarks
- Selecting 'show in folder' in a bookmark

The newly shown bookmarks should be selected and scrolled into view.
 
Owner: tsergeant@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f42530c8a51162f2b510188de04752edf06a1345

commit f42530c8a51162f2b510188de04752edf06a1345
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Jul 28 02:44:57 2017

MD Bookmarks: Scroll and select items that are added to the main list

This 'highlights' bookmark items in the following situations:
* A new item is created in the list
* Item(s) are pasted into the list
* Item(s) are dropped into the list
* 'Show in folder' is selected on a search result

The list of items which will be created is not always known ahead
of time. Therefore, each time the user performs an action which can
create items, we track all items that are created and updated, and
highlight those items once the action has finished processing.

BUG= 738958 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2977523002
Cr-Commit-Position: refs/heads/master@{#490223}

[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/browser/resources/md_bookmarks/actions.js
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/browser/resources/md_bookmarks/api_listener.js
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/browser/resources/md_bookmarks/app.js
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/browser/resources/md_bookmarks/dialog_focus_manager.js
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/browser/resources/md_bookmarks/edit_dialog.js
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/browser/resources/md_bookmarks/list.js
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/browser/resources/md_bookmarks/store_client.js
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/browser/resources/md_bookmarks/timer_proxy.js
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/common/extensions/api/bookmark_manager_private.json
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/test/data/webui/md_bookmarks/command_manager_test.js
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/test/data/webui/md_bookmarks/list_test.js
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/chrome/test/data/webui/md_bookmarks/test_store.js
[modify] https://crrev.com/f42530c8a51162f2b510188de04752edf06a1345/third_party/closure_compiler/externs/bookmark_manager_private.js

Status: Fixed (was: Started)

Sign in to add a comment