Currently, UKM on iOS behaves as though there are always incognito windows open, so it is always disabled. Need to implement the correct checks, so that UKM can be enabled on iOS. See also crbug/734091
Issue 697565 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6 commit e04d095bcb359d195a2df1c4bfac47c0a6fe97d6 Author: Mohamad Ahmadi <mahmadi@chromium.org> Date: Fri Nov 17 23:31:24 2017 TabModelListObserver Introduces a TabModelListObserver interface that notifies its implementations when a TabModel is registered to a browser state. Also makes loose utility functions in tab_model_list.h static functions of the TabModelList and expands the unit tests for the TabModelList class. Signed-off-by: Mohamad Ahmadi <mahmadi@chromium.org> Bug: 738938 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie6dd56b8dd87467a3a5d280fc4f38ab35d9bad10 Reviewed-on: https://chromium-review.googlesource.com/772319 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517599} [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/browser_state/BUILD.gn [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/browser_state/test_chrome_browser_state_manager.cc [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/browser_state/test_chrome_browser_state_manager.h [add] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/browser_state/test_chrome_browser_state_manager_unittest.cc [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/metrics/new_tab_page_uma.mm [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.mm [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.mm [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/tabs/BUILD.gn [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/tabs/tab_model.mm [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/tabs/tab_model_list.h [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/tabs/tab_model_list.mm [add] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/tabs/tab_model_list_observer.h [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/tabs/tab_model_list_unittest.mm [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/tabs/tab_model_synced_window_delegate_getter.mm [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/browser/ui/external_file_remover_impl.mm [modify] https://crrev.com/e04d095bcb359d195a2df1c4bfac47c0a6fe97d6/ios/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807 commit b1eb939d79d6d1184b614d5d6a1b8b0658cc9807 Author: Mohamad Ahmadi <mahmadi@chromium.org> Date: Sat Nov 18 23:34:40 2017 Enables UKM recorder in iOS Bug: 738938 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I75950dc5af48af4dcb8b26db9c093cc8837034fd Reviewed-on: https://chromium-review.googlesource.com/776035 Commit-Queue: Moe Ahmadi (OOO until Nov. 27) <mahmadi@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517724} [modify] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/components/ukm/ukm_recorder_impl.h [modify] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/components/ukm/ukm_service.h [modify] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/ios/chrome/browser/ios_chrome_main_parts.mm [modify] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/ios/chrome/browser/metrics/BUILD.gn [add] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/ios/chrome/browser/metrics/incognito_web_state_observer.h [add] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/ios/chrome/browser/metrics/incognito_web_state_observer.mm [modify] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor.cc [modify] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor.h [modify] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h [modify] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm [modify] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm [add] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/ios/chrome/browser/metrics/ukm_egtest.mm [modify] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/ios/chrome/test/earl_grey/chrome_actions.h [modify] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/ios/chrome/test/earl_grey/chrome_actions.mm [modify] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/ios/chrome/test/earl_grey/chrome_matchers.mm [modify] https://crrev.com/b1eb939d79d6d1184b614d5d6a1b8b0658cc9807/services/metrics/public/cpp/ukm_recorder.cc
Comment 1 by holte@chromium.org
, Aug 7 2017