New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738932 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Display bugs with memory tab; heap profile snapshot views

Reported by macon...@mtu.edu, Jul 3 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce the problem:
1. Record an 'allocation timeline' on a page
2. Do some things on the page to get arrays/data into the timeline
3. Stop recording and look at the results

What is the expected behavior?
To be able to look through the data

What went wrong?
If you open and collapse a drop down for an array or something in the profile view, the next time you open it is only white space and the data is gone. If you scroll, it will sometimes appear but randomly scrolls the screen down

Did this work before? N/A 

Chrome version: 59.0.3071.115  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

Applies to any dropdowns in the profile, either outer layer or within other dropdowns
 
chrome1.PNG
66.1 KB View Download

Comment 1 by macon...@mtu.edu, Jul 3 2017

example 2, where it doesn't even get filled with white space, the data is just completely gone
chrome3.PNG
9.8 KB View Download
Cc: hdodda@chromium.org
Labels: Needs-Feedback
Tested the issue on windows 7 & 10 using chrome M59 #59.0.3071.115 and M61 #61.0.3147.0 and issue is not reproduced.

Attached screencast for reference.

@maconard-- Could you please check attached screencast and confirm us if we had missed any steps in reproducing the issue and also please try in fresh chrome profile without any extensions and flags enabled.

Thanks!
738932.mp4
3.7 MB View Download
 Issue 738931  has been merged into this issue.

Comment 4 by alph@chromium.org, Jul 10 2017

Labels: -Needs-Feedback
Owner: alph@chromium.org
Status: Assigned (was: Unconfirmed)
I can reproduce it. Thanks for the report!

Comment 5 by alph@chromium.org, Jul 10 2017

Labels: -OS-Windows M-59 OS-All
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83bf8907db8938eb97d2d16fe6cf2c347727b739

commit 83bf8907db8938eb97d2d16fe6cf2c347727b739
Author: Alexei Filippov <alph@chromium.org>
Date: Thu Jul 13 05:35:43 2017

DevTools: Fix memory panel datagrid being empty.

1. The revealed getter should not return true for detached nodes.
2. The height of a node used to calculate the viewport should not depend on
   the node is attached or not.

Bug:  738932 
Change-Id: Ib526c3476fd51996158d87736bdeb6cf2678aed5
Reviewed-on: https://chromium-review.googlesource.com/567774
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486282}
[add] https://crrev.com/83bf8907db8938eb97d2d16fe6cf2c347727b739/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-expand-collapse-expected.txt
[add] https://crrev.com/83bf8907db8938eb97d2d16fe6cf2c347727b739/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-expand-collapse.html
[modify] https://crrev.com/83bf8907db8938eb97d2d16fe6cf2c347727b739/third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js
[modify] https://crrev.com/83bf8907db8938eb97d2d16fe6cf2c347727b739/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

Comment 8 by alph@chromium.org, Jul 13 2017

Labels: Merge-Request-60

Comment 9 by alph@chromium.org, Jul 13 2017

Labels: -Pri-2 M-60 Pri-1
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 13 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Rejected-60
Since it's quite late and we're only a few weeks away from M60 stable, the bar is much higher for merges since we're trying to minimize risk and ensure high stability. My recommendation is to wait until M61. This doesn't seem like a critical bug, that is impacting large number of users. Rejecting merge. If you think otherwise, please re-apply Merge-Request label with explanation. 

Comment 12 by alph@chromium.org, Jul 19 2017

Status: Fixed (was: Assigned)

Sign in to add a comment