Issue 738881 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	sdefresne@chromium.org
Closed:	Feb 2018
Cc:	ios-bugs@chromium.org
Components:	Internals
EstimatedDays:	----
NextAction:	----
OS:	iOS
Pri:	3
Type:	Task

Remove use of ChromeExecuteCommand

Project Member Reported by marq@chromium.org, Jul 3 2017

Issue description

In order to facilitate migrating to the new architecture for iOS Chrome, -chromeExecuteCommand will be deprecated. Instead, existing code will be migrated to use the command dispatcher system that is used in the new architecture.

This is a tracking bug for the refactoring work involved in this.

Comment 1 by eugene...@chromium.org, Jul 6 2017

Components: Internals

Mark, could you please update component when assigning the bug. Thanks!

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c58ea9dcbfa516648cb1f408c1dd9fed3310690

commit 6c58ea9dcbfa516648cb1f408c1dd9fed3310690
Author: Mark Cogan <marq@google.com>
Date: Thu Jul 06 13:08:24 2017

[ios] Remove IDC_CLOSE_TAB

This CL removes the IDC_CLOSE_TAB command ID and replaces all uses of it
 with calls to a command dispatcher.

In order to do that, the following infrastructural changes are also made:

- A BrowserCommands protocol is created that will house all of the
ChromeCommands handled by the BVC.

- The BVC's _dispatcher is exposed publicly as an id<BrowserCommands>

- Various other classes that accepted the BVC's dispatcher have
BrowserCommands added to the protocols that dispatcher conforms to.

- An egtest utility to get the dispatcher for the main BVC is added, and
will be used to replace calls to RunCommandWithActiveViewController().

BUG= 738881 
TEST=Manually tested closing tabs.

Change-Id: Iaa01293aec0caf16927578803ca8d0a1aae7cedd
Reviewed-on: https://chromium-review.googlesource.com/561357
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484563}
[modify] https://crrev.com/6c58ea9dcbfa516648cb1f408c1dd9fed3310690/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.h
[modify] https://crrev.com/6c58ea9dcbfa516648cb1f408c1dd9fed3310690/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/6c58ea9dcbfa516648cb1f408c1dd9fed3310690/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
[modify] https://crrev.com/6c58ea9dcbfa516648cb1f408c1dd9fed3310690/ios/chrome/browser/ui/browser_view_controller.h
[modify] https://crrev.com/6c58ea9dcbfa516648cb1f408c1dd9fed3310690/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/6c58ea9dcbfa516648cb1f408c1dd9fed3310690/ios/chrome/browser/ui/commands/BUILD.gn
[add] https://crrev.com/6c58ea9dcbfa516648cb1f408c1dd9fed3310690/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/6c58ea9dcbfa516648cb1f408c1dd9fed3310690/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/6c58ea9dcbfa516648cb1f408c1dd9fed3310690/ios/chrome/browser/ui/key_commands_provider.h
[modify] https://crrev.com/6c58ea9dcbfa516648cb1f408c1dd9fed3310690/ios/chrome/browser/ui/key_commands_provider.mm
[modify] https://crrev.com/6c58ea9dcbfa516648cb1f408c1dd9fed3310690/ios/chrome/browser/ui/key_commands_provider_unittest.mm
[modify] https://crrev.com/6c58ea9dcbfa516648cb1f408c1dd9fed3310690/ios/chrome/browser/ui/ntp/google_landing_view_controller.h
[modify] https://crrev.com/6c58ea9dcbfa516648cb1f408c1dd9fed3310690/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm
[modify] https://crrev.com/6c58ea9dcbfa516648cb1f408c1dd9fed3310690/ios/chrome/test/app/chrome_test_util.h
[modify] https://crrev.com/6c58ea9dcbfa516648cb1f408c1dd9fed3310690/ios/chrome/test/app/chrome_test_util.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1808bc078fd4791e0d925ecc88d5e00454819c23

commit 1808bc078fd4791e0d925ecc88d5e00454819c23
Author: Mark Cogan <marq@google.com>
Date: Thu Jul 06 14:45:15 2017

[ios] Remove IDC_BACK and IDC_FORWARD

This CL removes the IDC_BACK and IDC_FORWARD command IDs, and adds
-goBack and goForward to BrowserCommands. Call sites are updated to
call these methods on the dispatcher.

- Adds a dispatcher to ToolbarController.

- Plumbs the dispatcher from the BVC into toolbar via the dependency
factory. 

BUG= 738881 
TEST=Manually tested forward/back in simulator

Change-Id: I7931ae43eac5a95e4283aea08dd8d3df4e709aa1
Reviewed-on: https://chromium-review.googlesource.com/561321
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484586}
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/browser_view_controller_dependency_factory.h
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/key_commands_provider.mm
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.h
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/omnibox_perftest.mm
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/toolbar/toolbar_controller.h
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/toolbar/toolbar_controller_unittest.mm
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/toolbar/web_toolbar_controller.h
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/ui/toolbar/web_toolbar_controller_unittest.mm
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/web/cache_egtest.mm
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/browser/web/visible_url_egtest.mm
[modify] https://crrev.com/1808bc078fd4791e0d925ecc88d5e00454819c23/ios/chrome/test/earl_grey/chrome_earl_grey.mm

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cc791cb275f4a3231c82a68133ec62c77578dfd

commit 6cc791cb275f4a3231c82a68133ec62c77578dfd
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jul 06 16:46:43 2017

Revert "[ios] Remove IDC_BACK and IDC_FORWARD"

This reverts commit 1808bc078fd4791e0d925ecc88d5e00454819c23.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [ios] Remove IDC_BACK and IDC_FORWARD
> 
> This CL removes the IDC_BACK and IDC_FORWARD command IDs, and adds
> -goBack and goForward to BrowserCommands. Call sites are updated to
> call these methods on the dispatcher.
> 
> - Adds a dispatcher to ToolbarController.
> 
> - Plumbs the dispatcher from the BVC into toolbar via the dependency
> factory. 
> 
> BUG= 738881 
> TEST=Manually tested forward/back in simulator
> 
> Change-Id: I7931ae43eac5a95e4283aea08dd8d3df4e709aa1
> Reviewed-on: https://chromium-review.googlesource.com/561321
> Commit-Queue: Mark Cogan <marq@chromium.org>
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Louis Romero <lpromero@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#484586}

TBR=marq@chromium.org,lpromero@chromium.org,gambard@chromium.org

Change-Id: If71a9a990e37c4031a31bc6fe4f9cc763d81d0e2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  738881 
Reviewed-on: https://chromium-review.googlesource.com/561938
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484636}
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/browser_view_controller_dependency_factory.h
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/key_commands_provider.mm
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.h
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/omnibox_perftest.mm
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/toolbar/toolbar_controller.h
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/toolbar/toolbar_controller_unittest.mm
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/toolbar/web_toolbar_controller.h
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/ui/toolbar/web_toolbar_controller_unittest.mm
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/web/cache_egtest.mm
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/browser/web/visible_url_egtest.mm
[modify] https://crrev.com/6cc791cb275f4a3231c82a68133ec62c77578dfd/ios/chrome/test/earl_grey/chrome_earl_grey.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e

commit 6ebbde072a4829a3e9b70de9be9a4e42a9a5322e
Author: Mark Cogan <marq@google.com>
Date: Fri Jul 07 12:50:13 2017

[ios] Remove IDC_BACK and IDC_FORWARD (reland)

This is a reland of https://chromium-review.googlesource.com/c/561321/,
fixed so that the toolbar buttons on iPad aren't broken.

This CL removes the IDC_BACK and IDC_FORWARD command IDs, and adds
-goBack and goForward to BrowserCommands. Call sites are updated to
call these methods on the dispatcher.

- Adds a dispatcher to ToolbarController.

- Plumbs the dispatcher from the BVC into toolbar via the dependency
factory.

BUG= 738881 
TEST=Manually tested forward/back in simulator

Change-Id: I4c5e68d6f54277bcf843dbcbe0b378ff507c9d1a
Reviewed-on: https://chromium-review.googlesource.com/562774
Commit-Queue: Louis Romero <lpromero@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484903}
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/browser_view_controller_dependency_factory.h
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/key_commands_provider.mm
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.h
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/omnibox_perftest.mm
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/toolbar/toolbar_controller.h
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/toolbar/toolbar_controller_unittest.mm
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/toolbar/web_toolbar_controller.h
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/ui/toolbar/web_toolbar_controller_unittest.mm
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/web/cache_egtest.mm
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/browser/web/visible_url_egtest.mm
[modify] https://crrev.com/6ebbde072a4829a3e9b70de9be9a4e42a9a5322e/ios/chrome/test/earl_grey/chrome_earl_grey.mm

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9aac643aaa7a01bccc7abde501dafbad78036f2

commit b9aac643aaa7a01bccc7abde501dafbad78036f2
Author: Mark Cogan <marq@google.com>
Date: Fri Jul 07 13:26:35 2017

[ios] Remove IDC_STOP and IDC_RELOAD

This CL replaces the IDC_STOP and IDC_RELOAD command-ids with selectors
in BrowserCommands. Call sites and ancillary usage is also updated.

This involves:

- Plumbing a dispatcher into the PageInfoController and having the 
reload button in that class target the dispatcher with the right method.

- Plumbing a dispatcher into the PopupMenuController (and subclasses), 
and the ToolsMenuViewController.

This CL also establishes the pattern for migrating tools menu items to
use the dispatcher. It is unfortunately hacky. The tools menu uses
the existing command IDs for two purposes: to tag the menu item so it
can be sent with chromeExecuteCommand, and for -commandWasSelected to
key off of to increment the right metric. Removing the first use (the
primary goal of this CL) means finding something else to use for the
second, and in this case it's a new enum defined in tools_menu_constants.h

These enum values are arbitrary *except* they are unique and need to be
distinguished from command IDs; to fit the latter criterion they are all
negative values.

This all comes together in ToolsMenuViewController:

- -collectionView:cellForItemAtIndexPath:, which already attaches
  -buttonPressed: as an action to every button in the menu, also 
  attaches the dispatcher methods for the stop and reload buttons.
- hideContent, similarly, removes those as actions.
- -buttonPressed: used to send ChromeExecuteCommand; now it only does
  so if the commandID is > 0. I realize this is terrible.

Because -buttonPressed, via two further levels of delegation(!), is 
responsible for dismissing the menu itself, the dispatcher methods must
be called *before* buttonPressed:, and so are added as actions before that
method is.

Note that because some downstream code uses IDC_RELOAD, the command ID
itself isn't removed in this CL, and the BVC switch still handles it.
That will be cleaned up in a follow-up CL.

Bug:  738881 
Change-Id: Ibe2643c80b399e7a8ddee11c42c1ab7a569d7f2f
Reviewed-on: https://chromium-review.googlesource.com/561678
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484909}
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/key_commands_provider.mm
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/omnibox/page_info_view_controller.h
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/omnibox/page_info_view_controller.mm
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/popup_menu/popup_menu_controller.h
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/popup_menu/popup_menu_controller.mm
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/tools_menu/tools_menu_constants.h
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/tools_menu/tools_popup_controller.h
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/browser/web/cache_egtest.mm
[modify] https://crrev.com/b9aac643aaa7a01bccc7abde501dafbad78036f2/ios/chrome/test/earl_grey/chrome_earl_grey.mm

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 8 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/c6c1f3603331812a0187d055a8cfa8162f819678

commit c6c1f3603331812a0187d055a8cfa8162f819678
Author: marq <marq@google.com>
Date: Sat Jul 08 01:18:02 2017

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8ad19310b33bf362976193b6681673a144b6fd4

commit c8ad19310b33bf362976193b6681673a144b6fd4
Author: Mark Cogan <marq@google.com>
Date: Mon Jul 10 11:45:48 2017

[ios] Remove final usage of IDC_RELOAD

This CL removes the remaining usage of IDC_RELOAD now that downstream
usage has also been cleaned up.

Bug:  738881 
Change-Id: I720f8474a97e418efecb16e8940c14d2718db68c
Reviewed-on: https://chromium-review.googlesource.com/563797
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485235}
[modify] https://crrev.com/c8ad19310b33bf362976193b6681673a144b6fd4/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/c8ad19310b33bf362976193b6681673a144b6fd4/ios/chrome/browser/ui/commands/ios_command_ids.h

Comment 9 by marq@chromium.org, Jul 11 2017

(Manually adding this, since I mistyped the bug in the CL description:)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e79102feb576651f4c52ef931015898478a55fe

commit 8e79102feb576651f4c52ef931015898478a55fe
Author: Mark Cogan <marq@google.com>
Date: Mon Jul 10 09:55:35 2017

[ios] Remove IDC_BOOKMARK_PAGE and IDC_SHARE_PAGE

This CL removes two further command IDs used in the toolbar and tools
menu, replacing them with methods in BrowserCommands.

This also "fixes" the hack required to record metrics for taps on the
bookmarks button separately when the page is bookmarked and when
it isn't (by separating the metrics-identifying ID from the actual thing
the button does).

Bug: 228521,   73881  
Change-Id: I8e046760fef9aca271a5f4cf75c47f1fa7d85e40
Reviewed-on: https://chromium-review.googlesource.com/563307
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485221}
[modify] https://crrev.com/8e79102feb576651f4c52ef931015898478a55fe/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/8e79102feb576651f4c52ef931015898478a55fe/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/8e79102feb576651f4c52ef931015898478a55fe/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/8e79102feb576651f4c52ef931015898478a55fe/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/8e79102feb576651f4c52ef931015898478a55fe/ios/chrome/browser/ui/key_commands_provider.mm
[modify] https://crrev.com/8e79102feb576651f4c52ef931015898478a55fe/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[modify] https://crrev.com/8e79102feb576651f4c52ef931015898478a55fe/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/8e79102feb576651f4c52ef931015898478a55fe/ios/chrome/browser/ui/tools_menu/tools_menu_constants.h
[modify] https://crrev.com/8e79102feb576651f4c52ef931015898478a55fe/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/8e79102feb576651f4c52ef931015898478a55fe/ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm
[modify] https://crrev.com/8e79102feb576651f4c52ef931015898478a55fe/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e3da1596d592fcd2db55b4580510ecc6a2b833c

commit 5e3da1596d592fcd2db55b4580510ecc6a2b833c
Author: Mark Cogan <marq@google.com>
Date: Tue Jul 11 15:57:30 2017

[ios] Remove IDC_OPTIONS

This CL removes IDC_OPTIONS. Since this is handled by MainController and
not a BVC, this CL adds the plumbing necessary for this.

Commands handled by the MainController are grouped into ApplicationCommands;
the existing dispatchers will dispatch for this protocol. The BVCs and 
tab switchers will be handed an 'Application command endpoint' that they
can dispatch that protocol to. 

This means that the various id<BrowserCommands> 'dispatcher' properties 
become id<ApplicationCommands, BrowserCommands>s. That accounts for many
of the small changes in this CL. It is clunky for formatting in some cases,
so when all of the refactoring is done, a clean-up CL might be needed that
groups protocols together for brevity.

The other major change is adding a selector parameter to the tools menu
model. Menu items that use a dispatcher have a nonnull selector. Note that
because a "command ID" is still needed for metrics, converted items get a
TOOLS_<blah>_ITEM ID as well.

Menu items with selectors use -performSelector: on their dispatcher to 
send the relevant method.

Bug:  738881 
Change-Id: I1cce22e20b96f8593ca3b74f5e54b8ccf5fe6c8e
Reviewed-on: https://chromium-review.googlesource.com/565508
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485640}
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/app/main_controller.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/test/perf_test_with_bvc_ios.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/browser_view_controller.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/browser_view_controller_dependency_factory.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/commands/BUILD.gn
[add] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/key_commands_provider.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/key_commands_provider.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/key_commands_provider_unittest.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/main/browser_view_wrangler.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/main/browser_view_wrangler.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/main/browser_view_wrangler_unittest.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/popup_menu/popup_menu_controller.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/stack_view/stack_view_controller.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/stack_view/stack_view_controller_private.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/stack_view/stack_view_controller_unittest.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/tab_switcher/tab_switcher.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/toolbar/toolbar_controller.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/toolbar/web_toolbar_controller.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/tools_menu/tools_menu_constants.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/tools_menu/tools_menu_model.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/tools_menu/tools_popup_controller.h
[modify] https://crrev.com/5e3da1596d592fcd2db55b4580510ecc6a2b833c/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e01ebce251763d5704fdae3c13bd900f0d114cf1

commit e01ebce251763d5704fdae3c13bd900f0d114cf1
Author: Mark Cogan <marq@google.com>
Date: Wed Jul 12 19:31:03 2017

[ios] Use a NewTabCommand for creating new tabs.

This CL adds a NewTabCommand subclass of GenericChromeCommand. This
allows the sender to include an origin point for the new tab animation.
Previously, this was derived by inspecting the sender caught by
-chromeExecuteCommand:, and using its UIView properties (if it had any)
to locate an origin point.

This is an intermediate step towards removing use of IDC_NEW_TAB and
IDC_NEW_INCOGNITO_TAB

Bug:  738881 
Change-Id: I3aaa5a16c3e28e85ff81e3c9a0208342d0d8dd09
Reviewed-on: https://chromium-review.googlesource.com/567146
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486058}
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/commands/BUILD.gn
[add] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/commands/new_tab_command.h
[add] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/commands/new_tab_command.mm
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/key_commands_provider.mm
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/toolbar/new_tab_button.h
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/toolbar/new_tab_button.mm
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/tools_menu/BUILD.gn
[add] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/tools_menu/new_tab_menu_view_item.h
[add] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/tools_menu/new_tab_menu_view_item.mm
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.h
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
[modify] https://crrev.com/e01ebce251763d5704fdae3c13bd900f0d114cf1/ios/chrome/test/app/tab_test_util.mm

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a4d5851ee0f5f7d8d0e0141dda1afb87f34189e

commit 3a4d5851ee0f5f7d8d0e0141dda1afb87f34189e
Author: Mark Cogan <marq@google.com>
Date: Thu Jul 13 11:40:05 2017

[ios] Remove seven unused IDC command-ids.

This CL removes the following command-ids:

IDC_FULLSCREEN: Only usage was a NOTIMPLEMENTED() case in the BVC.

IDC_SWITCH_BROWSER_MODES: Unused.

IDC_SETUP_FOR_TESTING: Only used in SetUpForTestingCommand, which in
turn wasn't used anywhere.

IDC_RESET_ALL_WEBVIEWS: Handled in MainController, but never sent.

IDC_SHOW_PRIVACY_SETTINGS: Unused.

IDC_HIDE_SETTINGS_AND_SHOW_PRIVACY_SETTINGS: Unused.

IDC_CLOSE_SETTINGS_AND_OPEN_NEW_INCOGNITO_TAB: Handled in the settings
nav controller, but never sent.

Bug:  738881 
Change-Id: Id931882add017306dc8a191616cef4006d9b9421
Reviewed-on: https://chromium-review.googlesource.com/569959
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486345}
[modify] https://crrev.com/3a4d5851ee0f5f7d8d0e0141dda1afb87f34189e/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/3a4d5851ee0f5f7d8d0e0141dda1afb87f34189e/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/3a4d5851ee0f5f7d8d0e0141dda1afb87f34189e/ios/chrome/browser/ui/commands/BUILD.gn
[modify] https://crrev.com/3a4d5851ee0f5f7d8d0e0141dda1afb87f34189e/ios/chrome/browser/ui/commands/ios_command_ids.h
[delete] https://crrev.com/dfc664b249c52acc410d3752e3be855d3fe95047/ios/chrome/browser/ui/commands/set_up_for_testing_command.h
[delete] https://crrev.com/dfc664b249c52acc410d3752e3be855d3fe95047/ios/chrome/browser/ui/commands/set_up_for_testing_command.mm
[delete] https://crrev.com/dfc664b249c52acc410d3752e3be855d3fe95047/ios/chrome/browser/ui/commands/set_up_for_testing_command_unittest.mm
[modify] https://crrev.com/3a4d5851ee0f5f7d8d0e0141dda1afb87f34189e/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
[modify] https://crrev.com/3a4d5851ee0f5f7d8d0e0141dda1afb87f34189e/ios/chrome/test/BUILD.gn

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfcdea7909540a99c8ff990e2bfed0cde54e9a93

commit dfcdea7909540a99c8ff990e2bfed0cde54e9a93
Author: Mark Cogan <marq@google.com>
Date: Tue Jul 18 13:47:38 2017

[ios] Remove use of IDC_NEW_(INCOGNITO_)TAB

This CL removes use of IDC_NEW_TAB and IDC_NEW_INCOGNITO_TAB. Call sites
were already using NewTabCommand instead of the raw command_ids, but 
there were still plenty of plumbing changes needed to switch over to
calling dispatcher methods.

The commands are now split into a BrowserCommands method, -openNewTab:,
and an ApplicationsCommands method, -switchModesAndOpenNewTab:. Both
methods take a NewTabCommand as their argument.

Since NewTabCommand includes a flag to indicate if an incognito tab
should be opened, there's no separate methods for that. If the BVC
gets an openNewTab: whose incognito-ness (incognition?) doesn't match
the BVC, it sends -switchModesAndOpenNewTab: instead. The application
command endpoint (MainController) then switches active BVCs and sends
the newly-active one a new openNewTab: command on its dispatcher, passing
the same NewTabCommand.

BVC also exposed a special -newTab: method for various classes to use 
instead of sending tedious ChromeCommands. That's gone, and all of the 
callers of -newTab: now use openTab: on a dispatcher like everyone else.

Removing -newTab: as a public BVC method meant some tests had to change, 
too.

Tab now needs a dispatcher handed to it, so it can send commands. It only
needs to do this for its ManageAccountsDelegate methods, so when they are
moved out of Tab, the dispatcher can go away as well. It's not feasible to
attach a dispatcher to each Tab as it's created, since that happens 
(ideally) outside of the UI layer where the dispatchers live. Thus, the
BVC attaches a dispatcher to the tab in -installDelegatesForTab:.

TabStripController, TabSwitcherController, TabSwitcherPanelController,
and TabSwitcherPanelOverlayView all have a dispatcher plumbed into them.

NewTabButton no longer sets its own target/action. It's only used in the
Stack View, and should probably be moved into that directory.
StackViewController now sets the right target/action on it.

Menu items that have selectors defined -- that is, those that are 
triggering commands that will be sent via dispatcher -- now take care
of sending those selectors themselves in an -executeCommandWithDispatcher:
method. This means that the new tab menu items can take care of creating
the necessary NewTabCommand internally. 

Bug:  738881 
Change-Id: Ic63da24612906b5c9bfe7ef2bb92181233c8198c
Reviewed-on: https://chromium-review.googlesource.com/567987
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487460}
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/app/application_delegate/BUILD.gn
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/app/application_delegate/app_state.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/app/application_delegate/app_state_unittest.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/browser_view_controller.h
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/browser_view_controller_dependency_factory.h
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/commands/BUILD.gn
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/commands/ios_command_ids.h
[delete] https://crrev.com/2bef170fc1afbd2bc4a149f8868e5353d8c4b739/ios/chrome/browser/ui/commands/new_tab_command.h
[delete] https://crrev.com/2bef170fc1afbd2bc4a149f8868e5353d8c4b739/ios/chrome/browser/ui/commands/new_tab_command.mm
[add] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/commands/open_new_tab_command.h
[add] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/commands/open_new_tab_command.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/key_commands_provider.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/ntp/new_tab_page_perftest.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.h
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.h
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.h
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tabs/tab_strip_controller.h
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tabs/tab_strip_controller_unittest.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/toolbar/new_tab_button.h
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/toolbar/new_tab_button.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tools_menu/new_tab_menu_view_item.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tools_menu/tools_menu_constants.h
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.h
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/test/app/BUILD.gn
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/test/app/chrome_test_util.h
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/test/app/chrome_test_util.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/chrome/test/app/tab_test_util.mm
[modify] https://crrev.com/dfcdea7909540a99c8ff990e2bfed0cde54e9a93/ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83da264b14bc343f7e77d5736f4eebc5a3ac4c06

commit 83da264b14bc343f7e77d5736f4eebc5a3ac4c06
Author: Mark Cogan <marq@google.com>
Date: Wed Jul 19 12:21:32 2017

[ios] Remove IDC_SHOW_ACCOUNTS_SETTINGS

This CL removes the IDC_SHOW_ACCOUNTS_SETTINGS command and sets up 
infrastructure for dispatching commands into settings.

IDC_SHOW_ACCOUNTS_SETTINGS is one of several commands that, under the
chromeExecuteCommand model can be handled by either MainController or the 
SettingsNavigationController. The methods that correspond to those commands 
are now grouped into the ApplicationSettingsCommands protocol, a subprotocol of 
ApplicationCommands. The SettingsNavigationController conforms to 
SettingsCommands, so MainController can call ApplicationSettingsCommands methods
on it when a SettingsNavigationController instance already exists to handle 
them;  otherwise it handles them itself.

Since there a large number of initializers for SettingsNavigationController,
it would be painful to add a dispatcher parameter to all of them. Instead, since
all of the initializers already take a delegate parameter, a 
-dispatcherForSettings method is added to the delegate protocol so that the 
SettingsNavigationController can ask for a dispatcher when its initialized.

The actual path by which IDC_SHOW_ACCOUNTS_SETTINGS was invoked was somewhat 
convoluted, so the following changes were necessary:

- ChromeSigninViewController had a -acceptSignInAndExecuteCommand: method
which in theory could accept any GenericChromeCommand to pass on for execution,
but in practice which either accepted a IDC_SHOW_ACCOUNTS_SETTINGS command or 
nil. Accordingly, the method is changed to be 
-acceptSignInAndShowAccountsSettings:, with a BOOL parameter. 

- This change is propagated into the ChromeSigninViewControllerDelegate protocol
and the classes that implement it, changing the didAcceptSignIn:executeCommand:
method to didAcceptSignIn:showAccountsSettings:.

- The various classes that could end up actually sending the command passed 
by didAcceptSignIn:executeCommand: now all have a dispatcher plumbed into them,
and call the -showAccountsSettings method on that dispatcher. This removes one
of the instances of [command executeOnMainWindow] (one still remains).

Additionally:

- The PromoViewController protocol, which only had one conforming class, is 
removed. The sole promo class, SigninPromoViewController, now takes a dispatcher
on init.

- The logic for selecting a promo to display in MainController is simplified
given that there is only one possible promo.

Bug:  738881 , 546154
Change-Id: I97c85e35f043a2ff4d47e208570a7718f1246b51
Reviewed-on: https://chromium-review.googlesource.com/570448
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Benoit Zanotti <bzanotti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487830}
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/authentication/BUILD.gn
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/authentication/authentication_flow_performer.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.h
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.h
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/authentication/signin_interaction_controller.h
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/authentication/signin_interaction_controller.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/commands/BUILD.gn
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/first_run/first_run_chrome_signin_view_controller.h
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/first_run/first_run_chrome_signin_view_controller.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.h
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller_unittest.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/promos/BUILD.gn
[delete] https://crrev.com/c22ffedb8312a0a2b086859aafb269584925d769/ios/chrome/browser/ui/promos/promo_view_controller.h
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/promos/signin_promo_view_controller.h
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/promos/signin_promo_view_controller.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/promos/signin_promo_view_controller_unittest.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/settings/accounts_collection_view_controller.h
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/settings/settings_collection_view_controller.h
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/settings/settings_navigation_controller.h
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/clean/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/clean/chrome/browser/ui/settings/settings_coordinator.mm
[modify] https://crrev.com/83da264b14bc343f7e77d5736f4eebc5a3ac4c06/ios/clean/chrome/browser/ui/settings/settings_main_page_coordinator.mm

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1238950005ae03c68795abb46cd53a893dc67e77

commit 1238950005ae03c68795abb46cd53a893dc67e77
Author: Mark Cogan <marq@google.com>
Date: Thu Jul 20 12:54:06 2017

[ios] Remove IDC_PRINT

Bug:  738881 
Change-Id: I74f4c504cb2fc20b710b8b5011a649c50599e8ec
Reviewed-on: https://chromium-review.googlesource.com/575981
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488218}
[modify] https://crrev.com/1238950005ae03c68795abb46cd53a893dc67e77/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/1238950005ae03c68795abb46cd53a893dc67e77/ios/chrome/browser/ui/activity_services/activity_service_controller.mm
[modify] https://crrev.com/1238950005ae03c68795abb46cd53a893dc67e77/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm
[modify] https://crrev.com/1238950005ae03c68795abb46cd53a893dc67e77/ios/chrome/browser/ui/activity_services/print_activity.h
[modify] https://crrev.com/1238950005ae03c68795abb46cd53a893dc67e77/ios/chrome/browser/ui/activity_services/print_activity.mm
[modify] https://crrev.com/1238950005ae03c68795abb46cd53a893dc67e77/ios/chrome/browser/ui/activity_services/share_protocol.h
[modify] https://crrev.com/1238950005ae03c68795abb46cd53a893dc67e77/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/1238950005ae03c68795abb46cd53a893dc67e77/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/1238950005ae03c68795abb46cd53a893dc67e77/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/1238950005ae03c68795abb46cd53a893dc67e77/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/1238950005ae03c68795abb46cd53a893dc67e77/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
[modify] https://crrev.com/1238950005ae03c68795abb46cd53a893dc67e77/ios/chrome/browser/web/print_observer.h
[modify] https://crrev.com/1238950005ae03c68795abb46cd53a893dc67e77/ios/chrome/browser/web/print_observer.mm

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa25b0517b4abca1f6b38f6765fd7f64e69f422d

commit fa25b0517b4abca1f6b38f6765fd7f64e69f422d
Author: Mark Cogan <marq@google.com>
Date: Thu Jul 20 17:31:03 2017

[ios] Remove IDC_ADD_READING_LIST

Bug:  738881 
Change-Id: If191e9f0a32a0948844ee123a323781143127b27
Reviewed-on: https://chromium-review.googlesource.com/576097
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488288}
[modify] https://crrev.com/fa25b0517b4abca1f6b38f6765fd7f64e69f422d/ios/chrome/browser/ui/activity_services/activity_service_controller.mm
[modify] https://crrev.com/fa25b0517b4abca1f6b38f6765fd7f64e69f422d/ios/chrome/browser/ui/activity_services/reading_list_activity.h
[modify] https://crrev.com/fa25b0517b4abca1f6b38f6765fd7f64e69f422d/ios/chrome/browser/ui/activity_services/reading_list_activity.mm
[modify] https://crrev.com/fa25b0517b4abca1f6b38f6765fd7f64e69f422d/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/fa25b0517b4abca1f6b38f6765fd7f64e69f422d/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/fa25b0517b4abca1f6b38f6765fd7f64e69f422d/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/fa25b0517b4abca1f6b38f6765fd7f64e69f422d/ios/chrome/browser/ui/commands/reading_list_add_command.mm

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a

commit 0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a
Author: Mark Cogan <marq@google.com>
Date: Thu Jul 20 18:51:47 2017

[ios] Remove remainder of contextual search.

This CL removes the last parts of contextual search from shipping code.

The settings UI is moved into contextual_search/, and is still built
and tested for unit tests, but all of the remaining logic around 
initializing CS and enabling it, and possibly showing the settings,
is removed.

The IDC_SHOW_CONTEXTUAL_SEARCH_SETTINGS command is also removed.

Bug:  738881 
Change-Id: I41226091de512660b5969623083c6a450d86cd59
Reviewed-on: https://chromium-review.googlesource.com/577870
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488331}
[modify] https://crrev.com/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a/ios/chrome/browser/ui/contextual_search/contextual_search_controller.mm
[add] https://crrev.com/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a/ios/chrome/browser/ui/contextual_search/settings/BUILD.gn
[rename] https://crrev.com/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a/ios/chrome/browser/ui/contextual_search/settings/contextual_search_collection_view_controller.h
[rename] https://crrev.com/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a/ios/chrome/browser/ui/contextual_search/settings/contextual_search_collection_view_controller.mm
[rename] https://crrev.com/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a/ios/chrome/browser/ui/contextual_search/settings/contextual_search_collection_view_controller_unittest.mm
[modify] https://crrev.com/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm
[modify] https://crrev.com/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a/ios/chrome/browser/ui/settings/privacy_collection_view_controller_unittest.mm
[modify] https://crrev.com/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a/ios/chrome/browser/ui/settings/settings_navigation_controller.h
[modify] https://crrev.com/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
[modify] https://crrev.com/0d7f2f1718b59d9d9ffff46a7c90d0f771106d6a/ios/chrome/test/BUILD.gn

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/709777eba8e607ee24ed23f067aaebf39628b0b0

commit 709777eba8e607ee24ed23f067aaebf39628b0b0
Author: Jean-François Geyelin <jif@chromium.org>
Date: Thu Jul 27 09:10:46 2017

[iOS] Remove IDC_SHOW_QR_SCANNER

Bug:  738881 ,  738106 
Change-Id: I22773332fdc53a22754e79b6030bc285e599f9da
Reviewed-on: https://chromium-review.googlesource.com/586597
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489887}
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/browser/ui/browser_view_controller.h
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_delegate.h
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_views.mm
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d2e184c15fe03a29881498a9b409f44f5326c34

commit 5d2e184c15fe03a29881498a9b409f44f5326c34
Author: Jean-François Geyelin <jif@chromium.org>
Date: Fri Jul 28 19:48:00 2017

[iOS] Remove IDC_VOICE_SEARCH command.

Bug:  738881 
Change-Id: Id0ead6ad3126294274e53cf58c94ee6e49602285
Reviewed-on: https://chromium-review.googlesource.com/589927
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490490}
[modify] https://crrev.com/5d2e184c15fe03a29881498a9b409f44f5326c34/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/5d2e184c15fe03a29881498a9b409f44f5326c34/ios/chrome/browser/ui/browser_view_controller.h
[modify] https://crrev.com/5d2e184c15fe03a29881498a9b409f44f5326c34/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/5d2e184c15fe03a29881498a9b409f44f5326c34/ios/chrome/browser/ui/commands/BUILD.gn
[modify] https://crrev.com/5d2e184c15fe03a29881498a9b409f44f5326c34/ios/chrome/browser/ui/commands/application_commands.h
[add] https://crrev.com/5d2e184c15fe03a29881498a9b409f44f5326c34/ios/chrome/browser/ui/commands/start_voice_search_command.h
[add] https://crrev.com/5d2e184c15fe03a29881498a9b409f44f5326c34/ios/chrome/browser/ui/commands/start_voice_search_command.mm
[modify] https://crrev.com/5d2e184c15fe03a29881498a9b409f44f5326c34/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm
[modify] https://crrev.com/5d2e184c15fe03a29881498a9b409f44f5326c34/ios/chrome/browser/ui/key_commands_provider.mm
[modify] https://crrev.com/5d2e184c15fe03a29881498a9b409f44f5326c34/ios/chrome/browser/ui/ntp/google_landing_view_controller.h
[modify] https://crrev.com/5d2e184c15fe03a29881498a9b409f44f5326c34/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm
[modify] https://crrev.com/5d2e184c15fe03a29881498a9b409f44f5326c34/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/5d2e184c15fe03a29881498a9b409f44f5326c34/ios/public/provider/chrome/browser/voice/voice_search_provider.h
[modify] https://crrev.com/5d2e184c15fe03a29881498a9b409f44f5326c34/ios/public/provider/chrome/browser/voice/voice_search_provider.mm

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30be04c1b541ef3debf55dbfe4843f7cbe3c4080

commit 30be04c1b541ef3debf55dbfe4843f7cbe3c4080
Author: sczs <sczs@chromium.org>
Date: Tue Aug 01 03:03:57 2017

[ios] Removes IDC History Navigation commands.

This CL Removes the use of the following commands and uses the dispatcher
instead:
IDC_BACK_FORWARD_IN_TAB_HISTORY
IDC_SHOW_BACK_HISTORY
IDC_SHOW_FORWARD_HISTORY

Bug:  738881 
Change-Id: I6c711c72c926708cdbf2b47b383e54deb0efde67
Reviewed-on: https://chromium-review.googlesource.com/591997
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490842}
[modify] https://crrev.com/30be04c1b541ef3debf55dbfe4843f7cbe3c4080/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/30be04c1b541ef3debf55dbfe4843f7cbe3c4080/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/30be04c1b541ef3debf55dbfe4843f7cbe3c4080/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/30be04c1b541ef3debf55dbfe4843f7cbe3c4080/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/30be04c1b541ef3debf55dbfe4843f7cbe3c4080/ios/chrome/browser/ui/history/tab_history_popup_controller.h
[modify] https://crrev.com/30be04c1b541ef3debf55dbfe4843f7cbe3c4080/ios/chrome/browser/ui/history/tab_history_popup_controller.mm
[modify] https://crrev.com/30be04c1b541ef3debf55dbfe4843f7cbe3c4080/ios/chrome/browser/ui/history/tab_history_popup_controller_unittest.mm
[modify] https://crrev.com/30be04c1b541ef3debf55dbfe4843f7cbe3c4080/ios/chrome/browser/ui/history/tab_history_view_controller.h
[modify] https://crrev.com/30be04c1b541ef3debf55dbfe4843f7cbe3c4080/ios/chrome/browser/ui/history/tab_history_view_controller.mm
[modify] https://crrev.com/30be04c1b541ef3debf55dbfe4843f7cbe3c4080/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
[modify] https://crrev.com/30be04c1b541ef3debf55dbfe4843f7cbe3c4080/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Project Member

Comment 21 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a8c8601efe75e137156603c0da02918a3f655f4

commit 3a8c8601efe75e137156603c0da02918a3f655f4
Author: sczs <sczs@chromium.org>
Date: Tue Aug 01 20:14:08 2017

[ios] Removes Reading List and Reading mode IDC commands.

This CL Removes the use of the following commands and uses the dispatcher
instead:
IDC_READER_MODE
IDC_SHOW_READING_LIST


Bug:  738881 
Change-Id: I72e1dd2add7905e3168daca502084c53a42fa4c8
Reviewed-on: https://chromium-review.googlesource.com/596530
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491093}
[modify] https://crrev.com/3a8c8601efe75e137156603c0da02918a3f655f4/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/3a8c8601efe75e137156603c0da02918a3f655f4/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/3a8c8601efe75e137156603c0da02918a3f655f4/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/3a8c8601efe75e137156603c0da02918a3f655f4/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/3a8c8601efe75e137156603c0da02918a3f655f4/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
[modify] https://crrev.com/3a8c8601efe75e137156603c0da02918a3f655f4/ios/chrome/browser/ui/tools_menu/tools_menu_constants.h
[modify] https://crrev.com/3a8c8601efe75e137156603c0da02918a3f655f4/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
[modify] https://crrev.com/3a8c8601efe75e137156603c0da02918a3f655f4/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/3a8c8601efe75e137156603c0da02918a3f655f4/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Project Member

Comment 22 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/94ed7f69a8680f60e95146c16bafacff8143b95d

commit 94ed7f69a8680f60e95146c16bafacff8143b95d
Author: jif <jif@google.com>
Date: Wed Aug 02 16:38:29 2017

Project Member

Comment 23 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5184a3108eb8149b843e1d5f17f016053b94df35

commit 5184a3108eb8149b843e1d5f17f016053b94df35
Author: sczs <sczs@chromium.org>
Date: Wed Aug 02 22:58:59 2017

[ios] Removes IDC_SHOW_HISTORY command.

This CL Removes the use of IDC_SHOW_HISTORY and uses the dispatcher
instead.

Bug:  738881 
Change-Id: Ia33b0303a19e2fe5e72d9e336f42c3c6faa2f81f
Reviewed-on: https://chromium-review.googlesource.com/596921
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491540}
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/chrome/browser/ui/key_commands_provider.mm
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller.h
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller.mm
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_view_controller.h
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_view_controller.mm
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.h
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/chrome/browser/ui/tools_menu/tools_menu_constants.h
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
[modify] https://crrev.com/5184a3108eb8149b843e1d5f17f016053b94df35/ios/clean/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm

Project Member

Comment 24 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d47c219a868d2b9c29db74d28ba480effe39d31

commit 3d47c219a868d2b9c29db74d28ba480effe39d31
Author: Jean-François Geyelin <jif@chromium.org>
Date: Thu Aug 03 09:24:09 2017

[iOS] Completely remove IDC_VOICE_SEARCH command.

Follow up to https://chromium-review.googlesource.com/c/589927

Bug:  738881 
Change-Id: I8234c93e7557fea982cf6f98fce45a5a6e2bf5c4
Reviewed-on: https://chromium-review.googlesource.com/593649
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491687}
[modify] https://crrev.com/3d47c219a868d2b9c29db74d28ba480effe39d31/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/3d47c219a868d2b9c29db74d28ba480effe39d31/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/3d47c219a868d2b9c29db74d28ba480effe39d31/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/3d47c219a868d2b9c29db74d28ba480effe39d31/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Project Member

Comment 25 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbdda25082ad81b0ed6d70a8c2cd15033df8979c

commit bbdda25082ad81b0ed6d70a8c2cd15033df8979c
Author: sczs <sczs@chromium.org>
Date: Fri Aug 04 15:57:00 2017

[ios]Removes IDC_CLOSE_MODALS command

This CL Removes the use of IDC_CLOSE_MODALS and uses the dispatcher
instead

Bug:  738881 
Change-Id: Iffc9813c869191b2c45e88d13bdd9e5de06c70a4
Reviewed-on: https://chromium-review.googlesource.com/601531
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492043}
[modify] https://crrev.com/bbdda25082ad81b0ed6d70a8c2cd15033df8979c/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/bbdda25082ad81b0ed6d70a8c2cd15033df8979c/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/bbdda25082ad81b0ed6d70a8c2cd15033df8979c/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/bbdda25082ad81b0ed6d70a8c2cd15033df8979c/ios/chrome/browser/ui/key_commands_provider.mm

Project Member

Comment 26 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edef955d95757053da45a4b8947d098273e2ac59

commit edef955d95757053da45a4b8947d098273e2ac59
Author: Jean-François Geyelin <jif@chromium.org>
Date: Mon Aug 07 09:56:56 2017

Rebased.

[iOS] Remove IDC_PRELOAD_VOICE_SEARCH.

Bug:  738881 
Change-Id: Id43944c921fd28e61847fe594748b15bb3ca1865
Reviewed-on: https://chromium-review.googlesource.com/595527
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492287}
[modify] https://crrev.com/edef955d95757053da45a4b8947d098273e2ac59/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/edef955d95757053da45a4b8947d098273e2ac59/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.h
[modify] https://crrev.com/edef955d95757053da45a4b8947d098273e2ac59/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/edef955d95757053da45a4b8947d098273e2ac59/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/edef955d95757053da45a4b8947d098273e2ac59/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/edef955d95757053da45a4b8947d098273e2ac59/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/edef955d95757053da45a4b8947d098273e2ac59/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm
[modify] https://crrev.com/edef955d95757053da45a4b8947d098273e2ac59/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Project Member

Comment 27 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e6e37448af8c37f6d060355652f6975c785205f

commit 9e6e37448af8c37f6d060355652f6975c785205f
Author: sczs <sczs@chromium.org>
Date: Thu Aug 10 15:57:50 2017

[ios] Adds support for closeSettings via dispatcher.

This CL adds dispatcher support for both IDC_CLOSE_SETTINGS_AND_OPEN_URL
and IDC_CLOSE_SETTINGS. It also uses the new dispatcher support in 
accounts_CVC in order to test that its working.

Since IDC_CLOSE_SETTINGS is used downstream, this CL doesn't remove
any previous IDC_COMMAND functionality. This way downstream will not
break. That will be done once downstream changes have landed. 

Bug:  738881 
Change-Id: Idc2bbac04ff41515fee0679e3730a5de516884d8
Reviewed-on: https://chromium-review.googlesource.com/609598
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493403}
[modify] https://crrev.com/9e6e37448af8c37f6d060355652f6975c785205f/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/9e6e37448af8c37f6d060355652f6975c785205f/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/9e6e37448af8c37f6d060355652f6975c785205f/ios/chrome/browser/ui/settings/accounts_collection_view_controller.h
[modify] https://crrev.com/9e6e37448af8c37f6d060355652f6975c785205f/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
[modify] https://crrev.com/9e6e37448af8c37f6d060355652f6975c785205f/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
[modify] https://crrev.com/9e6e37448af8c37f6d060355652f6975c785205f/ios/public/provider/chrome/browser/user_feedback/user_feedback_provider.h
[modify] https://crrev.com/9e6e37448af8c37f6d060355652f6975c785205f/ios/public/provider/chrome/browser/user_feedback/user_feedback_provider.mm

Project Member

Comment 28 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/800375a9c82f159deb771c5914e330001df6b032

commit 800375a9c82f159deb771c5914e330001df6b032
Author: edchin <edchin@chromium.org>
Date: Thu Aug 10 16:18:33 2017

[ios] Remove IDC_CLOSE_ALL_TABS and IDC_CLOSE_ALL_INCOGNITO_TABS

Bug:  738881 
Change-Id: Ic39a8c455bbe3d0347f1ad4ad1982f18e3dc230c
Reviewed-on: https://chromium-review.googlesource.com/609554
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Ed Chin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493413}
[modify] https://crrev.com/800375a9c82f159deb771c5914e330001df6b032/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/800375a9c82f159deb771c5914e330001df6b032/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/800375a9c82f159deb771c5914e330001df6b032/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/800375a9c82f159deb771c5914e330001df6b032/ios/chrome/browser/ui/tools_menu/tools_menu_constants.h
[modify] https://crrev.com/800375a9c82f159deb771c5914e330001df6b032/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
[modify] https://crrev.com/800375a9c82f159deb771c5914e330001df6b032/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/800375a9c82f159deb771c5914e330001df6b032/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Project Member

Comment 29 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adaf512f4cfd5ebe4d4deea54dff128ab915fc1b

commit adaf512f4cfd5ebe4d4deea54dff128ab915fc1b
Author: Gregory Chatzinoff <gchatz@chromium.org>
Date: Fri Aug 11 02:25:44 2017

Revert "[ios] Adds support for closeSettings via dispatcher."

This reverts commit 9e6e37448af8c37f6d060355652f6975c785205f.

Reason for revert: Causes eg test failure downstream.
In MainController, closeSettingsAndOpenUrl calls itself,
causing infinite recursion.

Original change's description:
> [ios] Adds support for closeSettings via dispatcher.
> 
> This CL adds dispatcher support for both IDC_CLOSE_SETTINGS_AND_OPEN_URL
> and IDC_CLOSE_SETTINGS. It also uses the new dispatcher support in 
> accounts_CVC in order to test that its working.
> 
> Since IDC_CLOSE_SETTINGS is used downstream, this CL doesn't remove
> any previous IDC_COMMAND functionality. This way downstream will not
> break. That will be done once downstream changes have landed. 
> 
> Bug:  738881 
> Change-Id: Idc2bbac04ff41515fee0679e3730a5de516884d8
> Reviewed-on: https://chromium-review.googlesource.com/609598
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Commit-Queue: Sergio Collazos <sczs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#493403}

TBR=marq@chromium.org,sczs@chromium.org

Change-Id: I5fa4784384b3cafb288e240b6e524c1b95ee790c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  738881 
Reviewed-on: https://chromium-review.googlesource.com/611581
Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493648}
[modify] https://crrev.com/adaf512f4cfd5ebe4d4deea54dff128ab915fc1b/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/adaf512f4cfd5ebe4d4deea54dff128ab915fc1b/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/adaf512f4cfd5ebe4d4deea54dff128ab915fc1b/ios/chrome/browser/ui/settings/accounts_collection_view_controller.h
[modify] https://crrev.com/adaf512f4cfd5ebe4d4deea54dff128ab915fc1b/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
[modify] https://crrev.com/adaf512f4cfd5ebe4d4deea54dff128ab915fc1b/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
[modify] https://crrev.com/adaf512f4cfd5ebe4d4deea54dff128ab915fc1b/ios/public/provider/chrome/browser/user_feedback/user_feedback_provider.h
[modify] https://crrev.com/adaf512f4cfd5ebe4d4deea54dff128ab915fc1b/ios/public/provider/chrome/browser/user_feedback/user_feedback_provider.mm

Project Member

Comment 30 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ee87820aaf00f4f34a8ee6c1ffdc92a562168ca

commit 2ee87820aaf00f4f34a8ee6c1ffdc92a562168ca
Author: sczs <sczs@chromium.org>
Date: Fri Aug 11 14:14:35 2017

RELAND [ios] Adds support for closeSettings via dispatcher.

This CL adds dispatcher support for both IDC_CLOSE_SETTINGS_AND_OPEN_URL
and IDC_CLOSE_SETTINGS. It also uses the new dispatcher support in
accounts_CVC in order to test that its working.

Since IDC_CLOSE_SETTINGS is used downstream, this CL doesn't remove
any previous IDC_COMMAND functionality. This way downstream will not
break. That will be done once downstream changes have landed.

This is a fixed version of:
https://chromium-review.googlesource.com/c/609598

Bug:  738881 
Change-Id: Ie0843e160252766fbd2513f2dd2338f1c84665a8
Reviewed-on: https://chromium-review.googlesource.com/611651
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493725}
[modify] https://crrev.com/2ee87820aaf00f4f34a8ee6c1ffdc92a562168ca/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/2ee87820aaf00f4f34a8ee6c1ffdc92a562168ca/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/2ee87820aaf00f4f34a8ee6c1ffdc92a562168ca/ios/chrome/browser/ui/settings/accounts_collection_view_controller.h
[modify] https://crrev.com/2ee87820aaf00f4f34a8ee6c1ffdc92a562168ca/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
[modify] https://crrev.com/2ee87820aaf00f4f34a8ee6c1ffdc92a562168ca/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
[modify] https://crrev.com/2ee87820aaf00f4f34a8ee6c1ffdc92a562168ca/ios/chrome/browser/ui/settings/settings_utils.h
[modify] https://crrev.com/2ee87820aaf00f4f34a8ee6c1ffdc92a562168ca/ios/chrome/browser/ui/settings/settings_utils.mm
[modify] https://crrev.com/2ee87820aaf00f4f34a8ee6c1ffdc92a562168ca/ios/public/provider/chrome/browser/user_feedback/user_feedback_provider.h
[modify] https://crrev.com/2ee87820aaf00f4f34a8ee6c1ffdc92a562168ca/ios/public/provider/chrome/browser/user_feedback/user_feedback_provider.mm

Project Member

Comment 31 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/d2b351287f967d93facb3fa730a4e405ebb07118

commit d2b351287f967d93facb3fa730a4e405ebb07118
Author: sczs <sczs@google.com>
Date: Sat Aug 12 00:02:01 2017

Project Member

Comment 32 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2b4a82310f6013f89daee6998be0c112d6802b1

commit e2b4a82310f6013f89daee6998be0c112d6802b1
Author: edchin <edchin@chromium.org>
Date: Mon Aug 14 18:15:15 2017

[ios] Remove IDC_TOGGLE_TAB_SWITCHER

Bug:  738881 
Change-Id: Id0c6d139c73f55158c8966855be88a58facc4659
Reviewed-on: https://chromium-review.googlesource.com/609108
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494103}
[modify] https://crrev.com/e2b4a82310f6013f89daee6998be0c112d6802b1/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/e2b4a82310f6013f89daee6998be0c112d6802b1/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/e2b4a82310f6013f89daee6998be0c112d6802b1/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/e2b4a82310f6013f89daee6998be0c112d6802b1/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
[modify] https://crrev.com/e2b4a82310f6013f89daee6998be0c112d6802b1/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/e2b4a82310f6013f89daee6998be0c112d6802b1/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm
[modify] https://crrev.com/e2b4a82310f6013f89daee6998be0c112d6802b1/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[modify] https://crrev.com/e2b4a82310f6013f89daee6998be0c112d6802b1/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm
[modify] https://crrev.com/e2b4a82310f6013f89daee6998be0c112d6802b1/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller_egtest.mm
[modify] https://crrev.com/e2b4a82310f6013f89daee6998be0c112d6802b1/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/e2b4a82310f6013f89daee6998be0c112d6802b1/ios/chrome/browser/ui/toolbar/BUILD.gn
[modify] https://crrev.com/e2b4a82310f6013f89daee6998be0c112d6802b1/ios/chrome/browser/ui/toolbar/toolbar_controller.h
[modify] https://crrev.com/e2b4a82310f6013f89daee6998be0c112d6802b1/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[delete] https://crrev.com/dd761b76e28a1c4d4a1657d7a943e902dc68a7f1/ios/chrome/browser/ui/toolbar/toolbar_controller_private.h
[modify] https://crrev.com/e2b4a82310f6013f89daee6998be0c112d6802b1/ios/chrome/browser/ui/toolbar/toolbar_controller_unittest.mm
[modify] https://crrev.com/e2b4a82310f6013f89daee6998be0c112d6802b1/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Project Member

Comment 33 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c57207227e8a945f168575553cf82233979803ec

commit c57207227e8a945f168575553cf82233979803ec
Author: edchin <edchin@chromium.org>
Date: Mon Aug 14 22:06:31 2017

[ios] Remove IDC_VIEW_SOURCE

Bug:  738881 
Change-Id: Ifdb2fee0f7bee5af3de95531ae52aba6445b9cc9
Reviewed-on: https://chromium-review.googlesource.com/614390
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494196}
[modify] https://crrev.com/c57207227e8a945f168575553cf82233979803ec/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/c57207227e8a945f168575553cf82233979803ec/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/c57207227e8a945f168575553cf82233979803ec/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/c57207227e8a945f168575553cf82233979803ec/ios/chrome/browser/ui/tools_menu/tools_menu_constants.h
[modify] https://crrev.com/c57207227e8a945f168575553cf82233979803ec/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/c57207227e8a945f168575553cf82233979803ec/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Project Member

Comment 34 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2134c0429447d6e1a9878e53639b83ceda812997

commit 2134c0429447d6e1a9878e53639b83ceda812997
Author: edchin <edchin@chromium.org>
Date: Fri Aug 18 13:57:35 2017

[ios] Refactor IDC_RATE_THIS_APP to use dispatcher

This CL refactors IDC_RATE_THIS_APP to use 
dispatcher rather than ChromeCommand. 
This is a first step to removing the IDC.

Bug:  738881 
Change-Id: Ib27e4d865707faa1387a26c5b503bb1c890cf54c
Reviewed-on: https://chromium-review.googlesource.com/615884
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495542}
[modify] https://crrev.com/2134c0429447d6e1a9878e53639b83ceda812997/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/2134c0429447d6e1a9878e53639b83ceda812997/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/2134c0429447d6e1a9878e53639b83ceda812997/ios/chrome/browser/ui/ntp/google_landing_mediator.mm

Project Member

Comment 35 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c96f800ccd96136acadc40f8bad4d251d9e87b5

commit 1c96f800ccd96136acadc40f8bad4d251d9e87b5
Author: Gregory Chatzinoff <gchatz@chromium.org>
Date: Fri Aug 18 19:02:20 2017

[ios] Remove various settings IDC commands.

This CL replaces the following commands with usage of the dispatcher:
IDC_SHOW_CLEAR_BROWSING_DATA_SETTINGS
IDC_SHOW_AUTOFILL_SETTINGS

Bug:  738881 
Change-Id: I79478f98c5ac2e0fd60fad36bec10a2c42b33779
Reviewed-on: https://chromium-review.googlesource.com/619625
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495638}
[modify] https://crrev.com/1c96f800ccd96136acadc40f8bad4d251d9e87b5/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/1c96f800ccd96136acadc40f8bad4d251d9e87b5/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/1c96f800ccd96136acadc40f8bad4d251d9e87b5/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/1c96f800ccd96136acadc40f8bad4d251d9e87b5/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/1c96f800ccd96136acadc40f8bad4d251d9e87b5/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/1c96f800ccd96136acadc40f8bad4d251d9e87b5/ios/chrome/browser/ui/contextual_search/contextual_search_controller.mm
[modify] https://crrev.com/1c96f800ccd96136acadc40f8bad4d251d9e87b5/ios/chrome/browser/ui/history/history_panel_view_controller.h
[modify] https://crrev.com/1c96f800ccd96136acadc40f8bad4d251d9e87b5/ios/chrome/browser/ui/history/history_panel_view_controller.mm
[modify] https://crrev.com/1c96f800ccd96136acadc40f8bad4d251d9e87b5/ios/chrome/browser/ui/payments/payment_request_manager.h
[modify] https://crrev.com/1c96f800ccd96136acadc40f8bad4d251d9e87b5/ios/chrome/browser/ui/payments/payment_request_manager.mm
[delete] https://crrev.com/ea65a745e112a8585a75b15e18c4f7dbc72fa13e/ios/chrome/browser/ui/show_privacy_settings_util.h
[delete] https://crrev.com/ea65a745e112a8585a75b15e18c4f7dbc72fa13e/ios/chrome/browser/ui/show_privacy_settings_util.mm

Project Member

Comment 36 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0

commit 37b2b70304ddfb18b194a2e04e96e3ee6f049cb0
Author: sczs <sczs@chromium.org>
Date: Tue Aug 22 16:41:36 2017

[ios] Removes more IDC_CLOSE_SETTINGS_AND_OPEN_URL calls

-Removes temporary provider and utils methods used for not breaking
downstream when removing IDC command calls.

-Removes all IDC_CLOSE_SETTINGS calls and only leaves one
IDC_CLOSE_SETTINGS_AND_OPEN_URL call used by the settings CVC super class.
That one will be removed in a further CL since the dispatcher needs to be
plumbed into more CVC's and this CL would've been too large.

Bug:  738881 
Change-Id: I705fbceabc272591a6c4b2c410f226d863491bca
Reviewed-on: https://chromium-review.googlesource.com/615160
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496331}
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/about_chrome_collection_view_controller.mm
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/about_chrome_collection_view_controller_unittest.mm
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/accounts_collection_view_controller.h
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/autofill_profile_edit_collection_view_controller.mm
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.h
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/settings_utils.h
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/settings_utils.mm
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/public/provider/chrome/browser/user_feedback/user_feedback_provider.h
[modify] https://crrev.com/37b2b70304ddfb18b194a2e04e96e3ee6f049cb0/ios/public/provider/chrome/browser/user_feedback/user_feedback_provider.mm

Project Member

Comment 37 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da09c86e774dcde4ef250bc08dfb047dbc9ff786

commit da09c86e774dcde4ef250bc08dfb047dbc9ff786
Author: Gregory Chatzinoff <gchatz@chromium.org>
Date: Tue Aug 22 21:32:45 2017

Removes IDC_SHOW_SAVE_PASSWORDS_SETTINGS.

This CL removes the IDC_SHOW_SAVE_PASSWORDS_SETTINGS IDC command.
Also, in order to provide PasswordController a dispatcher, this CL 
moves the instantiation of PasswordController and all objects that 
depend on PasswordController to attachDispatcherDependentTabHelpers. 
This is required since dispatcher is nil during attachTabHelpers.

Bug:  738881 
Change-Id: I292e678bc1ebf2c297674d50350fe8e4140fffe7
Reviewed-on: https://chromium-review.googlesource.com/624908
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496450}
[modify] https://crrev.com/da09c86e774dcde4ef250bc08dfb047dbc9ff786/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/da09c86e774dcde4ef250bc08dfb047dbc9ff786/ios/chrome/browser/passwords/password_controller.h
[modify] https://crrev.com/da09c86e774dcde4ef250bc08dfb047dbc9ff786/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/da09c86e774dcde4ef250bc08dfb047dbc9ff786/ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm
[modify] https://crrev.com/da09c86e774dcde4ef250bc08dfb047dbc9ff786/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/da09c86e774dcde4ef250bc08dfb047dbc9ff786/ios/chrome/browser/passwords/password_generation_agent.h
[modify] https://crrev.com/da09c86e774dcde4ef250bc08dfb047dbc9ff786/ios/chrome/browser/passwords/password_generation_agent.mm
[modify] https://crrev.com/da09c86e774dcde4ef250bc08dfb047dbc9ff786/ios/chrome/browser/passwords/password_generation_agent_unittest.mm
[modify] https://crrev.com/da09c86e774dcde4ef250bc08dfb047dbc9ff786/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/da09c86e774dcde4ef250bc08dfb047dbc9ff786/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/da09c86e774dcde4ef250bc08dfb047dbc9ff786/ios/chrome/browser/ui/commands/ios_command_ids.h

Project Member

Comment 38 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/9e321c0f24dd171d78314a9f125986e1965b12df

commit 9e321c0f24dd171d78314a9f125986e1965b12df
Author: sczs <sczs@google.com>
Date: Tue Aug 22 21:51:27 2017

Project Member

Comment 39 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ed5b1ff2e74057cc93dbbeec9a0113420d51e72

commit 9ed5b1ff2e74057cc93dbbeec9a0113420d51e72
Author: sczs <sczs@chromium.org>
Date: Wed Aug 23 16:02:00 2017

[ios] Removes all upstream IDC_CLOSE_SETTINGS_AND_OPEN_URL calls.

This is a follow up to https://chromium-review.googlesource.com/c/615160
It plumbs the dispatcher through all the sub-classes that were using the
base class didOpenURL method which called the IDC command.

This CL also deletes and cleans around IDC_CLOSE_SETTINGS_AND_OPEN_URL.

Bug:  738881 
Change-Id: If1498794127071a65f4ec6123182a6c17580b8d7
Reviewed-on: https://chromium-review.googlesource.com/616141
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496695}
[modify] https://crrev.com/9ed5b1ff2e74057cc93dbbeec9a0113420d51e72/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/9ed5b1ff2e74057cc93dbbeec9a0113420d51e72/ios/chrome/browser/ui/authentication/authentication_flow_performer.mm
[modify] https://crrev.com/9ed5b1ff2e74057cc93dbbeec9a0113420d51e72/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/9ed5b1ff2e74057cc93dbbeec9a0113420d51e72/ios/chrome/browser/ui/settings/content_settings_collection_view_controller.mm
[modify] https://crrev.com/9ed5b1ff2e74057cc93dbbeec9a0113420d51e72/ios/chrome/browser/ui/settings/settings_navigation_controller.h
[modify] https://crrev.com/9ed5b1ff2e74057cc93dbbeec9a0113420d51e72/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
[modify] https://crrev.com/9ed5b1ff2e74057cc93dbbeec9a0113420d51e72/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm
[modify] https://crrev.com/9ed5b1ff2e74057cc93dbbeec9a0113420d51e72/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
[modify] https://crrev.com/9ed5b1ff2e74057cc93dbbeec9a0113420d51e72/ios/clean/chrome/browser/ui/settings/settings_coordinator.mm

Project Member

Comment 40 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8f81c3cdffbad3bdf657903fa3b7aea86f17c0c

commit b8f81c3cdffbad3bdf657903fa3b7aea86f17c0c
Author: sczs <sczs@chromium.org>
Date: Tue Aug 29 15:45:49 2017

[ios] Removes IDC_REPORT_AN_ISSUE command.

Removes the use of IDC_REPORT_AN_ISSUE and uses the dispatcher
instead.

Bug:  738881 
Change-Id: If8ccfacb915e6756fe1cb14284963f25857583f0
Reviewed-on: https://chromium-review.googlesource.com/638840
Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498119}
[modify] https://crrev.com/b8f81c3cdffbad3bdf657903fa3b7aea86f17c0c/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/b8f81c3cdffbad3bdf657903fa3b7aea86f17c0c/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/b8f81c3cdffbad3bdf657903fa3b7aea86f17c0c/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/b8f81c3cdffbad3bdf657903fa3b7aea86f17c0c/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/b8f81c3cdffbad3bdf657903fa3b7aea86f17c0c/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/b8f81c3cdffbad3bdf657903fa3b7aea86f17c0c/ios/chrome/browser/ui/sad_tab/sad_tab_view.h
[modify] https://crrev.com/b8f81c3cdffbad3bdf657903fa3b7aea86f17c0c/ios/chrome/browser/ui/sad_tab/sad_tab_view.mm
[modify] https://crrev.com/b8f81c3cdffbad3bdf657903fa3b7aea86f17c0c/ios/chrome/browser/ui/tools_menu/tools_menu_constants.h
[modify] https://crrev.com/b8f81c3cdffbad3bdf657903fa3b7aea86f17c0c/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
[modify] https://crrev.com/b8f81c3cdffbad3bdf657903fa3b7aea86f17c0c/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Project Member

Comment 41 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f40c15481f438cdc515908c12cb2e638319a742

commit 3f40c15481f438cdc515908c12cb2e638319a742
Author: Gregory Chatzinoff <gchatz@chromium.org>
Date: Wed Aug 30 07:50:04 2017

Remove IDC commands for Find in Page.

This CL removes the IDC commands for Find in Page, and replaces them
with use of the dispatcher.

Bug:  738881 
Change-Id: I40b0349ab5e2dae1bdbd31596e9fac93d6eacde5
Reviewed-on: https://chromium-review.googlesource.com/636050
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498391}
[modify] https://crrev.com/3f40c15481f438cdc515908c12cb2e638319a742/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/3f40c15481f438cdc515908c12cb2e638319a742/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/3f40c15481f438cdc515908c12cb2e638319a742/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/3f40c15481f438cdc515908c12cb2e638319a742/ios/chrome/browser/ui/find_bar/find_bar_controller_ios.h
[modify] https://crrev.com/3f40c15481f438cdc515908c12cb2e638319a742/ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm
[modify] https://crrev.com/3f40c15481f438cdc515908c12cb2e638319a742/ios/chrome/browser/ui/find_bar/find_bar_view.h
[modify] https://crrev.com/3f40c15481f438cdc515908c12cb2e638319a742/ios/chrome/browser/ui/find_bar/find_bar_view.mm
[modify] https://crrev.com/3f40c15481f438cdc515908c12cb2e638319a742/ios/chrome/browser/ui/key_commands_provider.mm
[modify] https://crrev.com/3f40c15481f438cdc515908c12cb2e638319a742/ios/chrome/browser/ui/tools_menu/tools_menu_constants.h
[modify] https://crrev.com/3f40c15481f438cdc515908c12cb2e638319a742/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
[modify] https://crrev.com/3f40c15481f438cdc515908c12cb2e638319a742/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/3f40c15481f438cdc515908c12cb2e638319a742/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Project Member

Comment 42 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02ad28e92e0d7a63d12b130705019b8e5c472372

commit 02ad28e92e0d7a63d12b130705019b8e5c472372
Author: sczs <sczs@chromium.org>
Date: Thu Aug 31 11:22:15 2017

[ios] Removes IDC_OPEN_URL command.

Removes the use of IDC_OPEN_URL and uses the dispatcher instead.

Bug:  738881 
Change-Id: I645b3b3fd162449da33e6f17ecc436c8ff0c823b
Reviewed-on: https://chromium-review.googlesource.com/642454
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498818}
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.h
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.mm
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.h
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.h
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/ui/commands/open_url_command.mm
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/ui/sad_tab/sad_tab_view.mm
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/ui/tabs/tab_strip_controller.h
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/upgrade/upgrade_center.h
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/upgrade/upgrade_center.mm
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/browser/upgrade/upgrade_center_unittest.mm
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/test/app/chrome_test_util.h
[modify] https://crrev.com/02ad28e92e0d7a63d12b130705019b8e5c472372/ios/chrome/test/app/chrome_test_util.mm

Project Member

Comment 43 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d1144c0a049a3fb715efbda08508631c2a6854f

commit 7d1144c0a049a3fb715efbda08508631c2a6854f
Author: Gregory Chatzinoff <gchatz@chromium.org>
Date: Thu Aug 31 15:00:36 2017

Remove various page info IDC commands.

This CL removes the IDC_HIDE_PAGE_INFO, IDC_SHOW_PAGE_INFO, and
IDC_SHOW_SECURITY_HELP commands, and uses the dispatcher instead.
This CL also cleans up use of unsafe_unretained where it is no
longer required.

Bug:  738881 
Change-Id: I93a6d3a1c0e17b413a754aa63d76f48d76d88d26
Reviewed-on: https://chromium-review.googlesource.com/641904
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498866}
[modify] https://crrev.com/7d1144c0a049a3fb715efbda08508631c2a6854f/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/7d1144c0a049a3fb715efbda08508631c2a6854f/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/7d1144c0a049a3fb715efbda08508631c2a6854f/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/7d1144c0a049a3fb715efbda08508631c2a6854f/ios/chrome/browser/ui/omnibox/location_bar_controller_impl.h
[modify] https://crrev.com/7d1144c0a049a3fb715efbda08508631c2a6854f/ios/chrome/browser/ui/omnibox/location_bar_controller_impl.mm
[modify] https://crrev.com/7d1144c0a049a3fb715efbda08508631c2a6854f/ios/chrome/browser/ui/omnibox/page_info_view_controller.h
[modify] https://crrev.com/7d1144c0a049a3fb715efbda08508631c2a6854f/ios/chrome/browser/ui/omnibox/page_info_view_controller.mm
[modify] https://crrev.com/7d1144c0a049a3fb715efbda08508631c2a6854f/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/7d1144c0a049a3fb715efbda08508631c2a6854f/ios/clean/chrome/browser/ui/omnibox/location_bar_coordinator.mm

Project Member

Comment 44 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f84b250d729294a4c2a2c6f76a886f39b6b9a8c7

commit f84b250d729294a4c2a2c6f76a886f39b6b9a8c7
Author: edchin <edchin@chromium.org>
Date: Thu Aug 31 21:30:45 2017

[ios] Remove IDC_HELP_PAGE_VIA_MENU

This CL replaces IDC_HELP_PAGE_VIA_MENU with -showHelpPage in
browser_commands.h, which is called through the dispatcher.

Bug:  738881 
Change-Id: I56af36421835eabc6bfe04e743b3c470880572c8
Reviewed-on: https://chromium-review.googlesource.com/644576
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499008}
[modify] https://crrev.com/f84b250d729294a4c2a2c6f76a886f39b6b9a8c7/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/f84b250d729294a4c2a2c6f76a886f39b6b9a8c7/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/f84b250d729294a4c2a2c6f76a886f39b6b9a8c7/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/f84b250d729294a4c2a2c6f76a886f39b6b9a8c7/ios/chrome/browser/ui/key_commands_provider.mm
[modify] https://crrev.com/f84b250d729294a4c2a2c6f76a886f39b6b9a8c7/ios/chrome/browser/ui/tools_menu/tools_menu_constants.h
[modify] https://crrev.com/f84b250d729294a4c2a2c6f76a886f39b6b9a8c7/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
[modify] https://crrev.com/f84b250d729294a4c2a2c6f76a886f39b6b9a8c7/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Project Member

Comment 45 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b59b560695afb2cdd7c5c02ee08b52b6c4af9610

commit b59b560695afb2cdd7c5c02ee08b52b6c4af9610
Author: edchin <edchin@chromium.org>
Date: Fri Sep 01 15:00:20 2017

[ios] Remove IDC_SHOW_BOOKMARK_MANAGER

This CL refactors IDC_SHOW_BOOKMARK_MANAGER to use the dispatcher rather
than ChromeCommand. This CL also removes all IDC commands from the 
whats new promo. 

Bug:  738881 
Change-Id: I9584caaf580f0fff335173f171782819eba8aeed
Reviewed-on: https://chromium-review.googlesource.com/644120
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499196}
[modify] https://crrev.com/b59b560695afb2cdd7c5c02ee08b52b6c4af9610/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/b59b560695afb2cdd7c5c02ee08b52b6c4af9610/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/b59b560695afb2cdd7c5c02ee08b52b6c4af9610/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/b59b560695afb2cdd7c5c02ee08b52b6c4af9610/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/b59b560695afb2cdd7c5c02ee08b52b6c4af9610/ios/chrome/browser/ui/ntp/google_landing_mediator.mm
[modify] https://crrev.com/b59b560695afb2cdd7c5c02ee08b52b6c4af9610/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
[modify] https://crrev.com/b59b560695afb2cdd7c5c02ee08b52b6c4af9610/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm
[modify] https://crrev.com/b59b560695afb2cdd7c5c02ee08b52b6c4af9610/ios/chrome/browser/ui/ntp/notification_promo_whats_new.h
[modify] https://crrev.com/b59b560695afb2cdd7c5c02ee08b52b6c4af9610/ios/chrome/browser/ui/ntp/notification_promo_whats_new.mm
[modify] https://crrev.com/b59b560695afb2cdd7c5c02ee08b52b6c4af9610/ios/chrome/browser/ui/ntp/notification_promo_whats_new_unittest.mm
[modify] https://crrev.com/b59b560695afb2cdd7c5c02ee08b52b6c4af9610/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
[modify] https://crrev.com/b59b560695afb2cdd7c5c02ee08b52b6c4af9610/ios/chrome/browser/ui/tools_menu/tools_menu_constants.h
[modify] https://crrev.com/b59b560695afb2cdd7c5c02ee08b52b6c4af9610/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
[modify] https://crrev.com/b59b560695afb2cdd7c5c02ee08b52b6c4af9610/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Project Member

Comment 46 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ee0807d9c587ba26682308f116dc414f759fc58

commit 8ee0807d9c587ba26682308f116dc414f759fc58
Author: edchin <edchin@chromium.org>
Date: Fri Sep 01 23:52:47 2017

[ios] Remove IDC_SHOW_OTHER_DEVICES

This CL removes IDC_SHOW_OTHER_DEVICES chrome command in favor of the
dispatcher.

Bug:  738881 
Change-Id: Ide80608bd915b32c95e8c4563a45a99894ed9f86
Reviewed-on: https://chromium-review.googlesource.com/644719
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499344}
[modify] https://crrev.com/8ee0807d9c587ba26682308f116dc414f759fc58/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/8ee0807d9c587ba26682308f116dc414f759fc58/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/8ee0807d9c587ba26682308f116dc414f759fc58/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/8ee0807d9c587ba26682308f116dc414f759fc58/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
[modify] https://crrev.com/8ee0807d9c587ba26682308f116dc414f759fc58/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm
[modify] https://crrev.com/8ee0807d9c587ba26682308f116dc414f759fc58/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
[modify] https://crrev.com/8ee0807d9c587ba26682308f116dc414f759fc58/ios/chrome/browser/ui/tools_menu/tools_menu_constants.h
[modify] https://crrev.com/8ee0807d9c587ba26682308f116dc414f759fc58/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
[modify] https://crrev.com/8ee0807d9c587ba26682308f116dc414f759fc58/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Project Member

Comment 47 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6de7e9a5a9fb61843a182668f242166e08106d8c

commit 6de7e9a5a9fb61843a182668f242166e08106d8c
Author: Mark Cogan <marq@google.com>
Date: Wed Sep 06 12:57:21 2017

[ios] Remove IDC_REQUEST_DESKTOP_SITE and IDC_REQUEST_MOBILE_SITE

This CL removes the final two command IDs used in the tools menu. 

Accordingly, it also cleans up the remaining support for ChromeExecuteCommand
in the tools menu and removes the associated includes from those files.

Bug:  738881 
Change-Id: I2ea647cdacec149db863faafe61ceb828d7584bc
Reviewed-on: https://chromium-review.googlesource.com/652447
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499944}
[modify] https://crrev.com/6de7e9a5a9fb61843a182668f242166e08106d8c/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/6de7e9a5a9fb61843a182668f242166e08106d8c/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/6de7e9a5a9fb61843a182668f242166e08106d8c/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/6de7e9a5a9fb61843a182668f242166e08106d8c/ios/chrome/browser/ui/tools_menu/tools_menu_constants.h
[modify] https://crrev.com/6de7e9a5a9fb61843a182668f242166e08106d8c/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
[modify] https://crrev.com/6de7e9a5a9fb61843a182668f242166e08106d8c/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/6de7e9a5a9fb61843a182668f242166e08106d8c/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller_unittest.mm
[modify] https://crrev.com/6de7e9a5a9fb61843a182668f242166e08106d8c/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
[modify] https://crrev.com/6de7e9a5a9fb61843a182668f242166e08106d8c/ios/clean/chrome/browser/ui/adaptor/browser_commands_adaptor.mm

Project Member

Comment 48 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e

commit d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e
Author: Mark Cogan <marq@google.com>
Date: Fri Sep 08 15:58:56 2017

[ios] Remove spurious includes from command refactor

This CL removes a number of includes of ios_command_id.h and
generic_chrome_command.h that are no longer needed.

Bug:  738881 
Change-Id: Id00918d771648b87163d128c369994367588b5b7
Reviewed-on: https://chromium-review.googlesource.com/652371
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500601}
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/ui/commands/open_url_command.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/ui/keyboard_commands_egtest.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/web/browsing_egtest.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/web/cache_egtest.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/browser/web/visible_url_egtest.mm
[modify] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/ios/chrome/test/earl_grey/chrome_earl_grey.mm

Project Member

Comment 49 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cad67be75a6ab9c5e207051fc61dada99f7bf06

commit 9cad67be75a6ab9c5e207051fc61dada99f7bf06
Author: edchin <edchin@chromium.org>
Date: Mon Sep 11 20:13:57 2017

[ios] Remove IDC_SHOW_SYNC_SETTINGS and IDC_SHOW_SYNC_PASSPHRASE_SETTINGS

This CL removes IDC_SHOW_SYNC_SETTINGS and IDC_SHOW_SYNC_PASSPHRASE_SETTINGS
Chrome commands in favor of the dispatcher.

Bug:  738881 
Change-Id: I1915c02cf9848669345551feeae6413d5ba2794b
Reviewed-on: https://chromium-review.googlesource.com/659517
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501015}
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/first_run/first_run_chrome_signin_view_controller.mm
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/first_run/first_run_util.h
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/first_run/first_run_util.mm
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/ntp/recent_tabs/views/signed_in_sync_off_view.h
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/ntp/recent_tabs/views/signed_in_sync_off_view.mm
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/sync/sync_error_infobar_delegate.h
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/sync/sync_error_infobar_delegate.mm
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/sync/sync_util.h
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/sync/sync_util.mm
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.h
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm
[modify] https://crrev.com/9cad67be75a6ab9c5e207051fc61dada99f7bf06/ios/clean/chrome/browser/ui/adaptor/application_commands_adaptor.mm

Project Member

Comment 50 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb8ba89619144649986dba5a9a4d3699ccfd3abe

commit bb8ba89619144649986dba5a9a4d3699ccfd3abe
Author: edchin <edchin@chromium.org>
Date: Tue Sep 12 15:44:03 2017

[ios] Remove IDC_SHOW_SIGNIN_IOS

This CL removes IDC_SHOW_SIGNIN_IOS Chrome command in favor of the
dispatcher.

Bug:  738881 
Change-Id: I4ce80192f3db33097c4cf7537ba15190ccc7d9df
Reviewed-on: https://chromium-review.googlesource.com/662557
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501289}
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/authentication/re_signin_infobar_delegate.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/authentication/re_signin_infobar_delegate.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/authentication/re_signin_infobar_delegate_unittest.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/authentication/signin_interaction_controller.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/authentication/signin_interaction_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/authentication/signin_promo_view_mediator_unittest.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/bookmarks/bookmark_collection_view.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/bookmarks/bookmark_controller_factory.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/bookmarks/bookmark_controller_factory.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller_unittest.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/bookmarks/bookmark_promo_controller.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/bookmarks/bookmark_promo_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/bookmarks/bookmark_table_view.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/bookmarks/bookmark_table_view.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/commands/show_signin_command.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/first_run/first_run_chrome_signin_view_controller.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/first_run/first_run_chrome_signin_view_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/first_run/first_run_util.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/first_run/first_run_util.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/ntp/recent_tabs/views/signed_in_sync_off_view.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/ntp/recent_tabs/views/signed_in_sync_off_view.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/promos/signin_promo_view_controller.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/promos/signin_promo_view_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/sync/sync_error_infobar_delegate.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/sync/sync_error_infobar_delegate.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/sync/sync_util.h
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/sync/sync_util.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/clean/chrome/browser/ui/adaptor/application_commands_adaptor.mm
[modify] https://crrev.com/bb8ba89619144649986dba5a9a4d3699ccfd3abe/ios/clean/chrome/browser/ui/bookmarks/bookmarks_coordinator.mm

Project Member

Comment 51 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179

commit 5f9f7f0695a6c3bc37a1525f04436ee79a8c2179
Author: Gregory Chatzinoff <gchatz@chromium.org>
Date: Tue Sep 19 02:04:57 2017

Remove IDC_SHOW_MAIL_COMPOSER command.

This CL removes the IDC_SHOW_MAIL_COMPOSER command. The sole use of this
command is in the Net Export WebUI page, so the command was replaced
with a NetExportTabHelper that can trigger the Mail Composer UI. As a
part of this removal, the CL replaces ShowMailComposerCommand with a
context object. Since this was the last command supported by BVC, this CL
also removes BVC's implementation of chromeExecuteCommand.

Bug:  738881 
Change-Id: I4c765ffc93c95aa313867161a8dfb04708a06497
Reviewed-on: https://chromium-review.googlesource.com/667810
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502761}
[modify] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/ui/commands/BUILD.gn
[modify] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/ui/key_commands_provider.h
[delete] https://crrev.com/567b14dde568b497082c1960564b427c9d71faf2/ios/chrome/browser/ui/show_mail_composer_util.h
[delete] https://crrev.com/567b14dde568b497082c1960564b427c9d71faf2/ios/chrome/browser/ui/show_mail_composer_util.mm
[modify] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/ui/webui/net_export/BUILD.gn
[rename] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/ui/webui/net_export/net_export_ui.mm
[add] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/webui/BUILD.gn
[add] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/webui/OWNERS
[add] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/webui/net_export_tab_helper.h
[add] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/webui/net_export_tab_helper.mm
[add] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/webui/net_export_tab_helper_delegate.h
[add] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/webui/net_export_tab_helper_unittest.mm
[rename] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/webui/show_mail_composer_context.h
[rename] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/browser/webui/show_mail_composer_context.mm
[modify] https://crrev.com/5f9f7f0695a6c3bc37a1525f04436ee79a8c2179/ios/chrome/test/BUILD.gn

Project Member

Comment 52 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f724e3ffe57f7ab78e0ab0ad52fa15fb4af77830

commit f724e3ffe57f7ab78e0ab0ad52fa15fb4af77830
Author: Mark Cogan <marq@google.com>
Date: Mon Oct 09 15:18:27 2017

Remove IDC_SHOW_ADD_ACCOUNT

This CL removes usage of IDC_SHOW_ADD_ACCOUNT. A follow-up CL
will remove the command ID itself once downstream changes have landed.

This CL also removes some now-unused ChromeExecuteCommand utilities
from ui/keyboard/

Bug:  738881 
Change-Id: If391a80de4628549c6ec330246bfd055576b0793
Reviewed-on: https://chromium-review.googlesource.com/707100
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507377}
[modify] https://crrev.com/f724e3ffe57f7ab78e0ab0ad52fa15fb4af77830/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/f724e3ffe57f7ab78e0ab0ad52fa15fb4af77830/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/f724e3ffe57f7ab78e0ab0ad52fa15fb4af77830/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/f724e3ffe57f7ab78e0ab0ad52fa15fb4af77830/ios/chrome/browser/ui/keyboard/UIKeyCommand+Chrome.h
[modify] https://crrev.com/f724e3ffe57f7ab78e0ab0ad52fa15fb4af77830/ios/chrome/browser/ui/keyboard/UIKeyCommand+Chrome.mm
[modify] https://crrev.com/f724e3ffe57f7ab78e0ab0ad52fa15fb4af77830/ios/clean/chrome/browser/ui/adaptor/application_commands_adaptor.mm

Project Member

Comment 53 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/5ca7f865aeb464bfdf304c3d0ccc0dc76bb1c335

commit 5ca7f865aeb464bfdf304c3d0ccc0dc76bb1c335
Author: Mark Cogan <marq@google.com>
Date: Mon Oct 09 17:15:21 2017

Project Member

Comment 54 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdfb075b987c6e9f7d63326894bf162326f4f773

commit cdfb075b987c6e9f7d63326894bf162326f4f773
Author: Mark Cogan <marq@google.com>
Date: Tue Oct 10 08:47:53 2017

Finally remove IDC_SHOW_ADD_ACCOUNT.

This CL removes the remaining definition and usage of the
IDC_SHOW_ADD_ACCOUNT command ID. An EG test utility method, whose last
use case is removed by the downstream CL related to this change,
is also removed.

Bug:  738881 
Change-Id: I25103b5e58860803c1dcdcdb6c83c12e36178ae8
Reviewed-on: https://chromium-review.googlesource.com/707134
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507620}
[modify] https://crrev.com/cdfb075b987c6e9f7d63326894bf162326f4f773/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/cdfb075b987c6e9f7d63326894bf162326f4f773/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/cdfb075b987c6e9f7d63326894bf162326f4f773/ios/chrome/test/app/chrome_test_util.h
[modify] https://crrev.com/cdfb075b987c6e9f7d63326894bf162326f4f773/ios/chrome/test/app/chrome_test_util.mm

Project Member

Comment 55 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0248a98dc0c7c0341a4f50c0cd2d6e60de70ff62

commit 0248a98dc0c7c0341a4f50c0cd2d6e60de70ff62
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Jan 11 18:03:51 2018

Clean AuthenticationService before refactoring.

Clean AuthenticationService:

-   explicitly inject all used KeyedService via the constructor
    for consistency instead of fetching them via factories in
    the implementation

-   stop observing other KeyedService in the Shutdown method
    instead of the destructor, as only the call to Shutdown is
    guaranteed to be executed in reverse dependency order, not
    the actual destruction

-   add the missing dependencies to used KeyedService in the
    AuthenticationServiceFactory

-   use WeakPtr<> instead of unretained raw pointer for bound
    callbacks and blocks (speculative fix of crashes if said
    callback or block is executed after the object destruction)

-   fix code style violation (local variable naming)

Bug:  738881 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1684559fa28d193a33061ed2b37dee971e7b38a8
Reviewed-on: https://chromium-review.googlesource.com/861787
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528666}
[modify] https://crrev.com/0248a98dc0c7c0341a4f50c0cd2d6e60de70ff62/ios/chrome/browser/signin/authentication_service.h
[modify] https://crrev.com/0248a98dc0c7c0341a4f50c0cd2d6e60de70ff62/ios/chrome/browser/signin/authentication_service.mm
[modify] https://crrev.com/0248a98dc0c7c0341a4f50c0cd2d6e60de70ff62/ios/chrome/browser/signin/authentication_service_factory.mm
[modify] https://crrev.com/0248a98dc0c7c0341a4f50c0cd2d6e60de70ff62/ios/chrome/browser/signin/authentication_service_fake.h
[modify] https://crrev.com/0248a98dc0c7c0341a4f50c0cd2d6e60de70ff62/ios/chrome/browser/signin/authentication_service_fake.mm
[modify] https://crrev.com/0248a98dc0c7c0341a4f50c0cd2d6e60de70ff62/ios/chrome/browser/signin/authentication_service_unittest.mm

Project Member

Comment 56 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d3cec0baad602fb9f5d30e00b723060cd42198c

commit 8d3cec0baad602fb9f5d30e00b723060cd42198c
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Fri Jan 12 14:14:25 2018

Add delegate to AuthenticationService.

Clearing the browsing data needs to acces the UI, so add a delegate
to AuthenticationService that is injected via the Initialize method.

Since calling any method on AuthenticationService before Initialize
is a potential security risk, add a CHECK in GetForBrowserState in
the AuthenticationServiceFactory and a method to explicit create and
invoke the Initialize method.

Add a fake implementation of the AuthenticationServiceDelegate for
the unit tests and fix the tests.

Bug:  738881 , 464306
Change-Id: I1003af89966f43a52f15aba3466b976876987319
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/863666
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528936}
[modify] https://crrev.com/8d3cec0baad602fb9f5d30e00b723060cd42198c/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/8d3cec0baad602fb9f5d30e00b723060cd42198c/ios/chrome/browser/signin/BUILD.gn
[modify] https://crrev.com/8d3cec0baad602fb9f5d30e00b723060cd42198c/ios/chrome/browser/signin/authentication_service.h
[modify] https://crrev.com/8d3cec0baad602fb9f5d30e00b723060cd42198c/ios/chrome/browser/signin/authentication_service.mm
[add] https://crrev.com/8d3cec0baad602fb9f5d30e00b723060cd42198c/ios/chrome/browser/signin/authentication_service_delegate.h
[add] https://crrev.com/8d3cec0baad602fb9f5d30e00b723060cd42198c/ios/chrome/browser/signin/authentication_service_delegate_fake.h
[add] https://crrev.com/8d3cec0baad602fb9f5d30e00b723060cd42198c/ios/chrome/browser/signin/authentication_service_delegate_fake.mm
[modify] https://crrev.com/8d3cec0baad602fb9f5d30e00b723060cd42198c/ios/chrome/browser/signin/authentication_service_factory.h
[modify] https://crrev.com/8d3cec0baad602fb9f5d30e00b723060cd42198c/ios/chrome/browser/signin/authentication_service_factory.mm
[modify] https://crrev.com/8d3cec0baad602fb9f5d30e00b723060cd42198c/ios/chrome/browser/signin/authentication_service_fake.h
[modify] https://crrev.com/8d3cec0baad602fb9f5d30e00b723060cd42198c/ios/chrome/browser/signin/authentication_service_fake.mm
[modify] https://crrev.com/8d3cec0baad602fb9f5d30e00b723060cd42198c/ios/chrome/browser/signin/authentication_service_unittest.mm
[modify] https://crrev.com/8d3cec0baad602fb9f5d30e00b723060cd42198c/ios/chrome/browser/ui/authentication/re_signin_infobar_delegate_unittest.mm

Comment 57 by sdefresne@chromium.org, Feb 16 2018

Owner: sdefresne@chromium.org
Status: Started (was: Assigned)

I'm removing the last of the ChromeExecuteCommand calls.

Project Member

Comment 58 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc

commit a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Feb 27 09:10:24 2018

Remove use of ClearBrowsingDataCommand

Introduce a new protocol BrowsingDataCommands that can be
implemented by the dispatcher. Modify code using the old
command ClearBrowsingDataCommand to instead use this new
protocol as a dispatcher.

Bug:  738881 
Change-Id: I76b8650c6c9d4311a611980dc26c8850c4960d5b
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/934501
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539413}
[modify] https://crrev.com/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc/ios/chrome/app/main_controller_private.h
[modify] https://crrev.com/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc/ios/chrome/browser/ui/authentication/authentication_flow.h
[modify] https://crrev.com/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc/ios/chrome/browser/ui/authentication/authentication_flow.mm
[modify] https://crrev.com/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc/ios/chrome/browser/ui/authentication/authentication_flow_performer.h
[modify] https://crrev.com/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc/ios/chrome/browser/ui/authentication/authentication_flow_performer.mm
[modify] https://crrev.com/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc/ios/chrome/browser/ui/authentication/authentication_flow_unittest.mm
[modify] https://crrev.com/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm
[modify] https://crrev.com/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc/ios/chrome/browser/ui/commands/BUILD.gn
[modify] https://crrev.com/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc/ios/chrome/browser/ui/commands/application_commands.h
[add] https://crrev.com/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc/ios/chrome/browser/ui/commands/browsing_data_commands.h
[modify] https://crrev.com/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm
[modify] https://crrev.com/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
[modify] https://crrev.com/a6ba86bd4d1024c0e1c9809468d4842b0ccb74bc/ios/chrome/test/app/history_test_util.mm

Project Member

Comment 59 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78f3d5ab5403f387de8e59bbedc712a548ae9eb0

commit 78f3d5ab5403f387de8e59bbedc712a548ae9eb0
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Feb 27 17:20:42 2018

Remove -chromeExecuteCommand:

Since ClearBrowsingDataCommand is no longer used (removed by
http://crrev.com/c/934501), there is no need to support the
deprecated -chromeExecuteCommand:.

Remove it and all the legacy support (GenericChromeCommand,
old #import, ...).

Bug:  738881 
Change-Id: I004e548733550824aca4e9f5d0609e7172d2da1a
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/934270
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539475}
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/app/main_application_delegate.mm
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/app/main_controller.h
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/authentication/authentication_flow_performer.mm
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/commands/BUILD.gn
[delete] https://crrev.com/10fde2da6b806828bea35eed97d05d69c26053b3/ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h
[delete] https://crrev.com/10fde2da6b806828bea35eed97d05d69c26053b3/ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.mm
[delete] https://crrev.com/10fde2da6b806828bea35eed97d05d69c26053b3/ios/chrome/browser/ui/commands/clear_browsing_data_command.h
[delete] https://crrev.com/10fde2da6b806828bea35eed97d05d69c26053b3/ios/chrome/browser/ui/commands/clear_browsing_data_command.mm
[delete] https://crrev.com/10fde2da6b806828bea35eed97d05d69c26053b3/ios/chrome/browser/ui/commands/generic_chrome_command.h
[delete] https://crrev.com/10fde2da6b806828bea35eed97d05d69c26053b3/ios/chrome/browser/ui/commands/generic_chrome_command.mm
[delete] https://crrev.com/10fde2da6b806828bea35eed97d05d69c26053b3/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/commands/open_new_tab_command.h
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/commands/open_new_tab_command.mm
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/commands/open_url_command.h
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/commands/open_url_command.mm
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/commands/reading_list_add_command.h
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/commands/reading_list_add_command.mm
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/commands/show_signin_command.h
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/commands/show_signin_command.mm
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/commands/start_voice_search_command.h
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/commands/start_voice_search_command.mm
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/settings/sync_utils/sync_error_infobar_delegate.h
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/settings/sync_utils/sync_util.h
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/settings/sync_utils/sync_util.mm
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/browser/ui/tabs/tab_view.mm
[modify] https://crrev.com/78f3d5ab5403f387de8e59bbedc712a548ae9eb0/ios/chrome/test/app/chrome_test_util.h

Comment 60 by sdefresne@chromium.org, Feb 27 2018

Status: Fixed (was: Started)

►

Issue 738881 link

Issue metadata

Remove use of ChromeExecuteCommand

Issue description

Comment 1 by eugene...@chromium.org, Jul 6 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Jul 6 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Jul 6 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Jul 6 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Jul 7 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Jul 7 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Jul 8 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Jul 10 2017

Comment 8 Deleted

Comment 9 by marq@chromium.org, Jul 11 2017

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Jul 11 2017

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Jul 12 2017

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Jul 13 2017

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Jul 18 2017

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Jul 19 2017

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Jul 20 2017

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Jul 20 2017

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Jul 20 2017

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Jul 27 2017

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Jul 28 2017

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Aug 1 2017

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Aug 1 2017

Comment 21 Deleted

Comment 22 by bugdroid1@chromium.org, Aug 2 2017

Comment 22 Deleted

Comment 23 by bugdroid1@chromium.org, Aug 2 2017

Comment 23 Deleted

Comment 24 by bugdroid1@chromium.org, Aug 3 2017

Comment 24 Deleted

Comment 25 by bugdroid1@chromium.org, Aug 4 2017

Comment 25 Deleted

Comment 26 by bugdroid1@chromium.org, Aug 7 2017

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, Aug 10 2017

Comment 27 Deleted

Comment 28 by bugdroid1@chromium.org, Aug 10 2017

Comment 28 Deleted

Comment 29 by bugdroid1@chromium.org, Aug 11 2017

Comment 29 Deleted

Comment 30 by bugdroid1@chromium.org, Aug 11 2017

Comment 30 Deleted

Comment 31 by bugdroid1@chromium.org, Aug 12 2017

Comment 31 Deleted

Comment 32 by bugdroid1@chromium.org, Aug 14 2017

Comment 32 Deleted

Comment 33 by bugdroid1@chromium.org, Aug 14 2017

Comment 33 Deleted

Comment 34 by bugdroid1@chromium.org, Aug 18 2017

Comment 34 Deleted

Comment 35 by bugdroid1@chromium.org, Aug 18 2017

Comment 35 Deleted

Comment 36 by bugdroid1@chromium.org, Aug 22 2017

Comment 36 Deleted

Comment 37 by bugdroid1@chromium.org, Aug 22 2017

Comment 37 Deleted

Comment 38 by bugdroid1@chromium.org, Aug 22 2017

Comment 38 Deleted