New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 738872 link

Starred by 3 users
Status: Duplicate
Merged: issue 721407
Owner:
█ dgn@chromium.org
Not on Chrome anymore
Closed: Jul 2017
Cc:
mvanouwe...@chromium.org
█ rachelis@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 734509



Sign in to add a comment

Prompt to signup for content suggestions although content suggestions are disabled

Project Member Reported by dullweber@chromium.org, Jul 3 2017 
When you disable “search and site suggestions” in the privacy settings, you still see a message to signup to see personalized content in Chrome Home. 
Signup doesn’t matter at this point because content suggestions are already disabled, so I think this message is shown incorrectly?

When you swipe this message away, you see a cut-off image.
Screenshot_20170629-124658.png
226 KB View Download
Screenshot_20170629-124716.png
304 KB View Download

Comment 1 by dullweber@chromium.org, Jul 3 2017

Blocking: 734509

Comment 2 by mvanouwe...@chromium.org, Jul 3 2017

Cc: rachelis@chromium.org
Labels: zine-ux zine-client OS-Android
Owner: dgn@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by dgn@chromium.org, Jul 3 2017 

Thanks for the report. I don't have access to the linked blocked issue 734509. TL;DR, or do I need to get this for context?

Comment 4 by dullweber@chromium.org, Jul 3 2017 

734509 is the privacy review for Chrome Home. I wanted to link to this bug to keep track of remaining issues as Chrome Home makes this problem more visible.

Comment 5 by mvanouwe...@chromium.org, Jul 4 2017

Cc: mvanouwe...@chromium.org

Comment 6 by rachelis@chromium.org, Jul 6 2017

Labels: -zine-ux

Comment 7 by dgn@chromium.org, Jul 12 2017

Mergedinto: 721407
Status: Duplicate (was: Assigned)
Merging into  issue 721407 , where CLs are being landed. We currently plan to just hide the Sign In promo and the All Dismissed item.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e

commit 139a79ec5ec1f0743c808e18fe4df7e2df0bd37e
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Wed Jul 12 18:37:34 2017

[Suggestions] Remove CTAs when feature is disabled

Stops showing the Sign in Promo and the All Dismissed item when remote
suggestions are disabled and performing the advertised actions would not
provide the user with new suggestions.

Part of this CL involves making the SuggestionsSources notifies a list
of observer rather than a single one.

Bug:  738872 
Change-Id: I16c300fb14a1d5780578387d48d848570339befe
Reviewed-on: https://chromium-review.googlesource.com/567182
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486034}
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/OptionalLeaf.java
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/android/java/src/org/chromium/chrome/browser/preferences/ContentSuggestionsPreferences.java
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/browser/android/ntp/ntp_snippets_bridge.cc
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/browser/android/ntp/ntp_snippets_bridge.h
[modify] https://crrev.com/139a79ec5ec1f0743c808e18fe4df7e2df0bd37e/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeSuggestionsSource.java

Comment 9 by huayinz@chromium.org, Jul 13 2017 

I'm seeing this crash ToT that I think is related to this patch:

Crash:
[FATAL:SnippetsBridge_jni.h(103)] Check failed: native. AreRemoteSuggestionsEnabled

Repro steps: only on tablet,
1) open an NTP
2) open anything else in the tab (e.g. most visited tile, history, bookmarks...)
3) crash...
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cab44dfa8ac0ef5766ac97019c6da9ae295ef615

commit cab44dfa8ac0ef5766ac97019c6da9ae295ef615
Author: Ryan Landay <rlanday@chromium.org>
Date: Fri Jul 14 01:21:17 2017

Revert "[Suggestions] Remove CTAs when feature is disabled"

This reverts commit 139a79ec5ec1f0743c808e18fe4df7e2df0bd37e.

Reason for revert: This is instacrashing one of my test devices when I
try to load a webpage. See crbug.com/742056

Original change's description:
> [Suggestions] Remove CTAs when feature is disabled
> 
> Stops showing the Sign in Promo and the All Dismissed item when remote
> suggestions are disabled and performing the advertised actions would not
> provide the user with new suggestions.
> 
> Part of this CL involves making the SuggestionsSources notifies a list
> of observer rather than a single one.
> 
> Bug:  738872 
> Change-Id: I16c300fb14a1d5780578387d48d848570339befe
> Reviewed-on: https://chromium-review.googlesource.com/567182
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486034}

TBR=bauerb@chromium.org,dgn@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  738872 
Change-Id: I9c3c7724215e59f6988c84e95fc7422c40872d72
Reviewed-on: https://chromium-review.googlesource.com/570806
Reviewed-by: Ryan Landay <rlanday@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486597}
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/OptionalLeaf.java
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/android/java/src/org/chromium/chrome/browser/preferences/ContentSuggestionsPreferences.java
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/browser/android/ntp/ntp_snippets_bridge.cc
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/browser/android/ntp/ntp_snippets_bridge.h
[modify] https://crrev.com/cab44dfa8ac0ef5766ac97019c6da9ae295ef615/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeSuggestionsSource.java
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdfb9a1af6211a0b3f09b9eee4c2694969c7a59c

commit cdfb9a1af6211a0b3f09b9eee4c2694969c7a59c
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Fri Jul 14 10:31:02 2017

[Suggestions] Enforce destruction order for the SnippetsBridge

Make the SuggestionsSource be destroyed after all the other
DestructionObservers to ensure they are still able to use it
while they are being destroyed.

Bug: 742056, 738872 
Change-Id: I36c299297c647c5fb9e680d49d5912a4469f02da
Reviewed-on: https://chromium-review.googlesource.com/570298
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486720}
[modify] https://crrev.com/cdfb9a1af6211a0b3f09b9eee4c2694969c7a59c/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
[modify] https://crrev.com/cdfb9a1af6211a0b3f09b9eee4c2694969c7a59c/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java
[modify] https://crrev.com/cdfb9a1af6211a0b3f09b9eee4c2694969c7a59c/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegate.java
[modify] https://crrev.com/cdfb9a1af6211a0b3f09b9eee4c2694969c7a59c/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegateImpl.java
[modify] https://crrev.com/cdfb9a1af6211a0b3f09b9eee4c2694969c7a59c/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeSuggestionsSource.java
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4b7aed8a7576fcb6a0262276923ecf08cb16af6

commit d4b7aed8a7576fcb6a0262276923ecf08cb16af6
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Fri Jul 14 10:51:11 2017

Reland "[Suggestions] Remove CTAs when feature is disabled"

This is a reland of 139a79ec5ec1f0743c808e18fe4df7e2df0bd37e
Original change's description:
> [Suggestions] Remove CTAs when feature is disabled
>
> Stops showing the Sign in Promo and the All Dismissed item when remote
> suggestions are disabled and performing the advertised actions would not
> provide the user with new suggestions.
>
> Part of this CL involves making the SuggestionsSources notifies a list
> of observer rather than a single one.
>
> Bug:  738872 
> Change-Id: I16c300fb14a1d5780578387d48d848570339befe
> Reviewed-on: https://chromium-review.googlesource.com/567182
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486034}

Bug:  738872 
Change-Id: Ifc5f6643b4402657b9a62e08596d9e3267ce79a8
Reviewed-on: https://chromium-review.googlesource.com/571722
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486723}
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/OptionalLeaf.java
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/android/java/src/org/chromium/chrome/browser/preferences/ContentSuggestionsPreferences.java
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/browser/android/ntp/ntp_snippets_bridge.cc
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/browser/android/ntp/ntp_snippets_bridge.h
[modify] https://crrev.com/d4b7aed8a7576fcb6a0262276923ecf08cb16af6/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeSuggestionsSource.java
►

Sign in to add a comment