Blocks shouldn't be passed as const-refs in GetAccessToken methods. |
||
Issue descriptionChromeIdentityService exposes GetAccessToken APIs that take a const ios::AccessTokenCallback& callback. For correct memory management and for enabling ARC compatibility, objc blocks should be passed by pointer.
,
Jul 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/853a46cde856de187f916e7b56734a7bba821b36 commit 853a46cde856de187f916e7b56734a7bba821b36 Author: stkhapugin <stkhapugin@chromium.org> Date: Mon Jul 03 12:12:36 2017 Change GetAccessToken APIs so that they don't pass const ref to blocks. Objective-C blocks should not be passed as const ref. This CL replaces APIs that take const ref to an Obj-C block and instead uses a pointer to a block. This makes the code compatible with ARC in the future. BUG= 738861 Review-Url: https://codereview.chromium.org/2970703002 Cr-Commit-Position: refs/heads/master@{#483992} [modify] https://crrev.com/853a46cde856de187f916e7b56734a7bba821b36/ios/public/provider/chrome/browser/signin/chrome_identity_service.h [modify] https://crrev.com/853a46cde856de187f916e7b56734a7bba821b36/ios/public/provider/chrome/browser/signin/chrome_identity_service.mm [modify] https://crrev.com/853a46cde856de187f916e7b56734a7bba821b36/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h [modify] https://crrev.com/853a46cde856de187f916e7b56734a7bba821b36/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm
,
Jul 3 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/ef403cdb9371c1349ab8347fcda405d881ed400e commit ef403cdb9371c1349ab8347fcda405d881ed400e Author: stkhapugin <stkhapugin@google.com> Date: Mon Jul 03 13:39:19 2017
,
Jul 12 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by stkhapugin@chromium.org
, Jul 3 2017