New issue
Advanced search Search tips

Issue 738831 link

Starred by 2 users
Status: Fixed
Owner:
mlippautz@chromium.org
Closed: Jul 2017
Cc:
jgruber@chromium.org
tebbi@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

19.3%-77.9% regression in v8.runtimestats.browsing_desktop at 480980:483542

Project Member Reported by jgruber@chromium.org, Jul 3 2017 
See the link to graphs below.

Comment 1 by jgruber@chromium.org, Jul 3 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=738831

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnqyFsgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7o2tywkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnpy5rAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnuqWvQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnoX04wkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnrv8tgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnsDZjAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnqa9_AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnqrlqAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgntHa8AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnr3hrQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnsWCwQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7oe65AsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnqSoyQgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7ofwqAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnu_fvAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7tmdiQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnr2GtAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnub-5woM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7rfyhwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnpyutQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnrvbsQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7tvXlQgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7v_u_QgM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-dual
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jul 3 2017 


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : v8.runtimestats.browsing_desktop
  Metric       : v8-gc-total_max/browse_news/browse_news_flipboard

Revision             Result                  N
chromium@480979      7.20024 +- 4.50643      21      good
chromium@483387      7.67829 +- 6.49985      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.flipboard v8.runtimestats.browsing_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8975102451108498112


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jul 3 2017 


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : v8.runtimestats.browsing_desktop
  Metric       : v8-gc-total_max/browse_news/browse_news_flipboard

Revision             Result                  N
chromium@480979      7.1351 +- 4.14198       20      good
chromium@483387      8.51686 +- 7.60466      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.flipboard v8.runtimestats.browsing_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8975082743931224304


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Jul 4 2017 


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : v8.browsing_desktop
  Metric       : v8-gc-full-mark-compactor_avg/browse_media/browse_media_youtube

Revision             Result                  N
chromium@483368      17.9753 +- 27.6273      21      good
chromium@483491      15.8705 +- 26.0183      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.youtube v8.browsing_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8975021381519269904


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Jul 4 2017 


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : v8.browsing_desktop
  Metric       : v8-gc-full-mark-compactor_sum/browse_media/browse_media_youtube

Revision             Result                  N
chromium@483368      15.3734 +- 28.6993      21      good
chromium@483491      17.5953 +- 25.5723      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.youtube v8.browsing_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8975021373950566880


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, Jul 4 2017

Cc: mlippautz@chromium.org
Owner: mlippautz@chromium.org

=== Auto-CCing suspected CL author mlippautz@chromium.org ===

Hi mlippautz@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Michael Lippautz
  Commit : 3dffe2e3adda823c8eb951bd83a9f7a0da1a31cb
  Date   : Thu Jun 29 15:09:31 2017
  Subject: [heap] MC: Switch to instance-based visitor

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : v8.browsing_desktop
  Metric       : v8-gc-full-mark-compactor_max/browse_search/browse_search_google_india
  Change       : 21.31% | 9.50833333333 -> 11.5346666667

Revision                           Result                   N
chromium@483368                    9.50833 +- 0.686594      6      good
chromium@483430                    9.61317 +- 1.28206       6      good
chromium@483438                    9.77767 +- 0.826962      6      good
chromium@483440                    9.23467 +- 0.188322      6      good
chromium@483441                    9.28933 +- 0.310534      6      good
chromium@483441,v8@8b97f512ac      9.7685 +- 0.740864       6      good
chromium@483441,v8@3dffe2e3ad      11.9537 +- 0.798938      6      bad       <--
chromium@483441,v8@261867021f      11.8992 +- 0.833464      6      bad
chromium@483442                    11.5007 +- 0.374269      6      bad
chromium@483446                    11.7553 +- 0.945931      6      bad
chromium@483461                    11.6227 +- 0.645227      6      bad
chromium@483491                    11.5347 +- 0.350587      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.search.google.india v8.browsing_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8975021366810956240


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 15 by 42576172...@developer.gserviceaccount.com, Jul 4 2017 


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Michael Lippautz
  Commit : 3dffe2e3adda823c8eb951bd83a9f7a0da1a31cb
  Date   : Thu Jun 29 15:09:31 2017
  Subject: [heap] MC: Switch to instance-based visitor

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : v8.runtimestats.browsing_desktop
  Metric       : v8-gc-full-mark-compactor_avg/browse_media/browse_media_imgur
  Change       : 29.78% | 63.70742182 -> 82.6793169576

Revision                           Result                  N
chromium@483368                    63.7074 +- 4.00067      6      good
chromium@483430                    65.017 +- 4.24167       6      good
chromium@483438                    66.7695 +- 3.47431      6      good
chromium@483440                    63.9061 +- 4.46042      6      good
chromium@483441                    63.6215 +- 5.66384      6      good
chromium@483441,v8@8b97f512ac      64.8592 +- 3.59329      6      good
chromium@483441,v8@3dffe2e3ad      81.5269 +- 6.63916      6      bad       <--
chromium@483441,v8@261867021f      81.7638 +- 5.83979      6      bad
chromium@483442                    81.3079 +- 2.79595      6      bad
chromium@483446                    82.096 +- 3.58017       6      bad
chromium@483461                    81.6707 +- 3.3259       6      bad
chromium@483491                    82.6793 +- 8.50032      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.imgur v8.runtimestats.browsing_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8975021348163315520


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 16 by 42576172...@developer.gserviceaccount.com, Jul 4 2017 


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : v8.browsing_desktop
  Metric       : v8-gc-full-mark-compactor_avg/browse_media/browse_media_youtube

Revision             Result                  N
chromium@483368      24.997 +- 43.0155       21      good
chromium@483491      29.7875 +- 49.6525      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.youtube v8.browsing_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8975007245278583200


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 17 by 42576172...@developer.gserviceaccount.com, Jul 5 2017 


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : v8.browsing_desktop
  Metric       : v8-gc-full-mark-compactor_sum/browse_media/browse_media_youtube

Revision             Result                  N
chromium@483368      14.5215 +- 26.0869      21      good
chromium@483491      17.2018 +- 27.7918      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.youtube v8.browsing_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8975007241813546512


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 18 by 42576172...@developer.gserviceaccount.com, Jul 5 2017

Cc: tebbi@chromium.org
 Issue 739099  has been merged into this issue.
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/53d68701c20e1edd4dc8c003e35b98b2fae329d5

commit 53d68701c20e1edd4dc8c003e35b98b2fae329d5
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Wed Jul 05 13:13:36 2017

[heap] Change inlining for full MC marking visitor

Inline pointers visitation instead of handling recursive marking.

Bug:  chromium:738831 
Change-Id: I0840258988c3097119f6299f0e1b6759b55fbd27
Reviewed-on: https://chromium-review.googlesource.com/559346
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46414}
[modify] https://crrev.com/53d68701c20e1edd4dc8c003e35b98b2fae329d5/src/heap/mark-compact.cc

Comment 20 by mlippautz@chromium.org, Jul 6 2017

Cc: -mlippautz@chromium.org
Status: Fixed (was: Untriaged)
The regressions recovered as far as I can see.
►

Sign in to add a comment