Issue metadata
Sign in to add a comment
|
Regression : Unable to close 'General Info' page in Files App |
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3147.0/9708.0.0 dev-channel Kip,Peppy and Daisy OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Download images -> Go to Files App -> Select Image -> Right Click and select 'Get info' option or click on 'Space' Key (2)Try to close General information page using 'Space' Key and observe page is not getting closed (3)Click on 'Open' option -> Observe General information page is not getting closed (4)Observe Title, Open and Info Icon is now at bottom of the page (5)Observe Background of the Image and Options at Menu bar(Open,delete,Search..)are enabled Expected: a)Should be able to close 'General Info' page after Step 2 b)On clicking 'Open' option General information page should get closed c)Title, Open and Info Icons should be at top of the page d) Options at Menu bar(Open,delete,Search..)should be disabled i.e. Background should be dark Actual: Instead a)Unable to close 'General Info' page b)On clicking 'Open' option General information page is not getting closed c)Title, Open and Info Icons should be at bottom of the page d)Options at Menu bar(Open,delete,Search..)is seen enabled This is a Regression issue as same is working fine in 61.0.3144.0/9693.1.0 dev channel Daisy @fukino: Please confirm the issue
,
Jul 3 2017
oka@, could you take a look?
,
Jul 4 2017
Debug build crashes while quick view is opening. [120832:120832:0704/152358.760228:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M65, around March 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) [120832:120858:0704/152406.529273:FATAL:shared_resources_data_source.cc(106)] Check failed: -1 != idr (-1 vs. -1) path: polymer/v1_0/paper-dialog/paper-dialog.html
,
Jul 4 2017
Confirmed reverting https://codereview.chromium.org/2963213002 fixes the issue.
,
Jul 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b449e1b8f24470071fc6d07df3f42e0d914a484 commit 7b449e1b8f24470071fc6d07df3f42e0d914a484 Author: oka <oka@chromium.org> Date: Tue Jul 04 09:03:04 2017 Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior. (patchset #1 id:1 of https://codereview.chromium.org/2963213002/ ) Reason for revert: It caused http://crbug.com/738826 BUG= 738826 , 720781 Original issue's description: > Polymer: Remove unused paper-dialog and paper-dialog-behavior. > > BUG= 720781 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2963213002 > Cr-Commit-Position: refs/heads/master@{#483554} > Committed: https://chromium.googlesource.com/chromium/src/+/4a140b8e1f361cdaf3a13e3c620a6bbe84ca7882 TBR=michaelpg@chromium.org,dpapad@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 720781 Review-Url: https://codereview.chromium.org/2969003002 Cr-Commit-Position: refs/heads/master@{#484071} [modify] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/bower.json [add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/bower.json [add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/compiled_resources2.gyp [add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior-extracted.js [add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior.html [add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-common.css [add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-shared-styles.html [add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog/bower.json [add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog/compiled_resources2.gyp [add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog-extracted.js [add] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog.html [modify] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/third_party/polymer/v1_0/components_summary.txt [modify] https://crrev.com/7b449e1b8f24470071fc6d07df3f42e0d914a484/ui/webui/resources/polymer_resources.grdp
,
Jul 4 2017
The issue should have been fixed. Filed https://bugs.chromium.org/p/chromium/issues/detail?id=739103 for preventing the regression in the future.
,
Jul 28 2017
Verified on Chrome OS 9765.9.0, 61.0.3163.16 dev build. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmanchala@chromium.org
, Jul 3 2017