New issue
Advanced search Search tips

Issue 738825 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

NOEXPORT=true should be "No-Export: true" for Gerrit reviews

Project Member Reported by foolip@chromium.org, Jul 3 2017

Issue description

Import adds NOEXPORT=true and export looks at it. Commit footers are now in this style:
    Change-Id: I31b4c809584f8dbb8e5626a28562d94a422611e7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug:  683256 ,  738067 
    Reviewed-on: https://chromium-review.googlesource.com/558101
    Reviewed-by: Andrew Grieve <agrieve@chromium.org>
    Commit-Queue: Andrew Grieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#483709}

We should make it No-Export: true.
 
Owner: foolip@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c33c6bfd246fc6a24ae29ae41c7aa53747c5226f

commit c33c6bfd246fc6a24ae29ae41c7aa53747c5226f
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Wed Jul 05 18:52:29 2017

wpt-import/export: In is_exportable, also look for No-Export tag

Bug:  738825 
Change-Id: I348aebf18617a0677dc1a189499f0ef9fee8e013
Reviewed-on: https://chromium-review.googlesource.com/558869
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484321}
[modify] https://crrev.com/c33c6bfd246fc6a24ae29ae41c7aa53747c5226f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py
[modify] https://crrev.com/c33c6bfd246fc6a24ae29ae41c7aa53747c5226f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/common_unittest.py

Status: Fixed (was: Started)

Sign in to add a comment