Issue metadata
Sign in to add a comment
|
Regression : Unable to click on 'Back','Learn more','TRY AGAIN' buttons in Sign-in permissions page |
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3147.0/9708.0.0 dev-channel Kip,Peppy and Daisy OS: Chrome What steps will reproduce the problem? (1)Sign in to user -> Go to chrome://md-settings/accounts page -> Enable 'Restrict sign-in to the following users' option so that 'Add person' option is enabled ->Click on 'Add person' -> Enter any email id (2)Now Click on 'Sign out' option in Uber tray -> In Sign-out screen click on 'Add person' option (3)Enter another mail id ->Now in Sign-in permissions page try to click on 'Back','Learn more','TRY AGAIN' buttons (Please refer Video) Expected: Should be able to click on 'Back','Learn more','TRY AGAIN' buttons Actual: Instead unable to click on 'Back','Learn more','TRY AGAIN' buttons This is Regression issue as same is working fine in 61.0.3144.0/9693.1.0 dev channel daisy @wzang: Please confirm the issue Note:Issue is not seen on Windows,Linux OS
,
Jul 4 2017
alemate@, please let me know whether our team or the GAIA team should fix this, like issue 738796 .
,
Jul 4 2017
,
Jul 6 2017
,
Jul 6 2017
+Few more people. This seems to be a design bug (missing mocks for the Gaia feature). Zach, could you handle this?
,
Jul 6 2017
Actually all the bottom buttons are part of ChromeOS UI. But we still need to decide how to display this. (We probably do not need "try again" button anymore, but messages should be placed.)
,
Jul 10 2017
Checking in since this is tagged as a dev blocker. If the buttons are non-actionable it would appear to be. Or has this been recategorized as a UI optimization? Also, do we know if the scope is more than Kip,Peppy and Daisy? Thanks,
,
Jul 10 2017
This affects all the devices. As soon as we get new mocks, I'll update error overlay. PS: currently new UI is switched off because of ChromeOS test, but I am going to turn it back on as soon as possible. (before modifying the overlay).
,
Jul 11 2017
Removing RBD since this is by design (missing mocks).
,
Jul 13 2017
Here is the spec: https://drive.google.com/a/google.com/file/d/0B_2Uyb2Rhx2OZzhnNXdPX2pLTDA/view?usp=sharing Please let me know if you have any questions.
,
Jul 20 2017
The tricky part is that ChromeOS shows only Gaia overlay, so we do not have full Gaia layout on our side. We can try to cover "Next" button on the Gaia page with "TRY AGAIN" button, but this will break as soon as Gaia team updates layout. Our current overlay hides Gaia completely with white background. If I rescale it to the new UI size, it will look as attached. WDYT?
,
Jul 20 2017
Ah that makes sense. Given that this is very much an edge case, screenshot in #11 LGTM. Elizabeth, I know it's not ideal, but does this work for you?
,
Jul 20 2017
For now I think it's ok, but would be great if we can update this later to be consistent with the other error screens.
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef38d50d66034d001871e6c64581252c7fe2656e commit ef38d50d66034d001871e6c64581252c7fe2656e Author: Alexander Alekseev <alemate@chromium.org> Date: Thu Jul 20 20:28:16 2017 ChromeOS: Fix screen-gaia-signin error overlay visibility. This CL fixes the problem with Gaia screen error overlay visibility. Bug: 738806 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I741951a0d1d8ba511b37783cb5651fdc50a05378 Reviewed-on: https://chromium-review.googlesource.com/579287 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#488385} [modify] https://crrev.com/ef38d50d66034d001871e6c64581252c7fe2656e/chrome/browser/resources/chromeos/login/screen_gaia_signin.css [modify] https://crrev.com/ef38d50d66034d001871e6c64581252c7fe2656e/chrome/browser/resources/chromeos/login/screen_gaia_signin.html
,
Jul 20 2017
,
Jan 22 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmanchala@chromium.org
, Jul 3 20172.6 MB
2.6 MB View Download