Regression: Unnecessary glimpse of Sync icon is seen beside avatar icon while 'Sign into chrome'
Reported by
abom...@etouch.net,
Jul 3 2017
|
|||
Issue descriptionChrome Version:61.0.3147.0 (Official Build) Revision e6db2be32f63ad9c3b8bce1b4f0dab810a7f2622-refs/heads/master@{#483897} OS: Mac (10.12.3,10.11.6),Windows(7,8,10),Linux What steps will reproduce the problem? 1. Launch chrome and sign into chrome with valid credentials. 2. Click on check box of ‘Manage Chrome Sync and personalisation in Settings’ option and click on ‘OK, Got it’ button. 3. Immediately observe beside avatar icon. Actual:Unnecessary Sync icon glimpse is seen beside avatar icon after step 3. Expected: Sync icon should not be seen. This is regression issue, broken in ‘M 61’ and below is manual bisect: Good build: 61.0.3128.0 Bad build: 61.0.3129.0
,
Jul 5 2017
This is a result of a (brief) period during which sync setup is incomplete but is reported as not being in progress. OneClickSigninSyncStarter deletes its sync_blocker(effectively a handle that tells sync that a confirmation ui is currently active somewhere in the browser) and navigates to the sync settings page. The settings page eventually acquires its own sync_blocker, but until it loads, no sync_blocker exists, causing sync to think that the setup isn't in progress, even when it is. I am looking at how to best fix this.
,
Jul 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7580295ea5bc9ae2c4c8c8d02821d56ecdc2af0 commit a7580295ea5bc9ae2c4c8c8d02821d56ecdc2af0 Author: pnoland <pnoland@chromium.org> Date: Mon Jul 17 20:48:51 2017 [sync] Prevent flash of error icon while loading syncSetup page Profile sync service relies on the lifetime of SyncSetupInProgressHandles to determine if setup is in progress. Currently, none of these handles are alive in the period between the closure of the sync confirmation dialog and the loading of the sync setup page. This causes profile sync service to think that setup is both incomplete and not in progress, which surfaces an error icon on the avatar. This CL causes PeopleHandler to acquire its SyncSetupInProgressHandle earlier if it detects that it's navigating directly to the syncSetup page. R= BUG= 738789 Review-Url: https://codereview.chromium.org/2971353002 Cr-Commit-Position: refs/heads/master@{#487236} [modify] https://crrev.com/a7580295ea5bc9ae2c4c8c8d02821d56ecdc2af0/chrome/browser/ui/webui/settings/people_handler.cc [modify] https://crrev.com/a7580295ea5bc9ae2c4c8c8d02821d56ecdc2af0/chrome/browser/ui/webui/settings/people_handler.h [modify] https://crrev.com/a7580295ea5bc9ae2c4c8c8d02821d56ecdc2af0/chrome/browser/ui/webui/settings/people_handler_unittest.cc
,
Jul 17 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jmukthavaram@chromium.org
, Jul 3 2017Labels: hasbisect-per-revision
Owner: pnoland@chromium.org
Status: Assigned (was: Unconfirmed)