New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 738788 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jul 2017
Cc:
█ youcheng@chromium.org
█ phoenixshen@chromium.org
hungte@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Missing netboot_firmware_settings in factory zip

Project Member Reported by youcheng@chromium.org, Jul 3 2017 
After CL:517363, target of symlink src/platform/factory/setup/netboot_firmware_settings.py was changed to src/dev/host/netboot_firmware_settings.py.
This makes netboot_firmware_settings.py disappear from factory zip (FACTORY_IMAGE_ARCHIVE).
finalize_bundle is also effected since it calls netboot_firmware_settings.py in factory zip.

Comment 1 by youcheng@chromium.org, Jul 3 2017

Components: Factory

Comment 2 by hungte@chromium.org, Jul 3 2017 

did https://chromium-review.googlesource.com/#/c/552759/ solve the problem?

if not, I'll replace the symlink with a modified forked copy to solve the problem.

Comment 3 by youcheng@chromium.org, Jul 3 2017 

CL:552759 landed in 9700.0.0
But we are still seeing this problem in 9708.0.0
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/f981110088922c27912c7ebb15535a7440d2e38a

commit f981110088922c27912c7ebb15535a7440d2e38a
Author: Hung-Te Lin <hungte@chromium.org>
Date: Mon Jul 03 07:04:46 2017

setup: Change netboot_firmware_settings back to local copy.

The transition to remove symlink has created lots of problems so we
should revert to local forked versions.

The new version is enhanced that can read and modify netboot firmware
settings.

BUG= chromium:738788 
TEST=netboot_firmware_settings -i image.net.bin

Change-Id: I46d049d6003fd2d30c655de85b24938d7bb32c56
Reviewed-on: https://chromium-review.googlesource.com/554512
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@chromium.org>
Commit-Queue: Hung-Te Lin <hungte@chromium.org>
Trybot-Ready: Hung-Te Lin <hungte@chromium.org>

[rewrite] https://crrev.com/f981110088922c27912c7ebb15535a7440d2e38a/setup/netboot_firmware_settings.py
[modify] https://crrev.com/f981110088922c27912c7ebb15535a7440d2e38a/devtools/mk/bundle.sh
[modify] https://crrev.com/f981110088922c27912c7ebb15535a7440d2e38a/Makefile
[delete] https://crrev.com/6a471e45b9075a34cf710ecee31ccade5d71471e/devtools/mk/external_symlinks.lst

Comment 6 by hungte@chromium.org, Jul 3 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment