New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 738785 link

Starred by 1 user
Status: Fixed
Owner:
lgrey@chromium.org
Closed: Jul 2017
Cc:
█ spqc...@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
lgrey@chromium.org
█ msrchandra@chromium.org
erikc...@chromium.org
█ ranjitkan@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary white patch is seen while dragging the bookmarked url from Folder on Bookmark bar.

Reported by abom...@etouch.net, Jul 3 2017 
Chrome Version :61.0.3147.0 (Official Build) Revision e6db2be32f63ad9c3b8bce1b4f0dab810a7f2622-refs/heads/master@{#483897}
OS:Mac (10.12.3,10.11.6)

Pre-condition: Create one folder on bookmark bar and bookmark 2-3 webpage in it.

What steps will reproduce the problem?
1. Launch chrome and click on Folder such that folder drop list is seen.
2. Drag one of the url of bookmark and observe folder drop list.

Actual: Unnecessary white patch is seen while dragging the bookmarked url from Folder.
Expected: White patch should not be seen.

This is regression issue, broken in ‘M 61’ and below is manual bisect info:

Good build:61.0.3142.0
Bad build:61.0.3143.0

Note: Issue is not seen on Windows and Linux OS.
Actual.mov
1.7 MB Download
Exp.mov
1.7 MB Download

Comment 1 by abom...@etouch.net, Jul 3 2017

Labels: hasbisect
Owner: erikc...@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/c6f4af3584484510a05497d4f63d1194a6f553d7..5ea29b706bbe01fb6f5734292922c2753bad9a1e?pretty=fuller&n=10000

Suspecting: r482776 ?

Kindly help to re-assign, if your changes are not cause for this issue.

Comment 2 by shrike@chromium.org, Jul 5 2017

Cc: lgrey@chromium.org

Comment 3 by lgrey@chromium.org, Jul 10 2017

Cc: -rbasuvula@chromium.org erikc...@chromium.org
Owner: lgrey@chromium.org
Status: Started (was: Assigned)

Comment 4 by lgrey@chromium.org, Jul 10 2017

Cc: rbasuvula@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf028a206df3c8a39cd154c3a908a2dc09e855a2

commit bf028a206df3c8a39cd154c3a908a2dc09e855a2
Author: Leonard Grey <lgrey@chromium.org>
Date: Tue Jul 11 15:28:52 2017

[Mac] Fix bookmark bar folder background color

This fixes an unintended white background in bookmark bar folder views
when a button is being dragged. Not really sure what changed here
(the bisect in the bug looks wrong), but setting that view's
background color explicitly does the trick.

Bug:  738785 
Change-Id: Ib9d0c07fdd84aceea0e318ea2a03d69b50452a50
Reviewed-on: https://chromium-review.googlesource.com/565455
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485632}
[modify] https://crrev.com/bf028a206df3c8a39cd154c3a908a2dc09e855a2/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm

Comment 6 by lgrey@chromium.org, Jul 12 2017

Status: Fixed (was: Started)

Comment 7 by abom...@etouch.net, Jul 18 2017

Labels: TE-Verified-M61 TE-Verified-61.0.3159.5
Note: Above issue is fixed on latest Dev version 61.0.3159.5 on Mac OS

Thanks you.

Comment 8 by abom...@etouch.net, Jul 18 2017 

Please find the attachment.
Bookmark.png
31.4 KB View Download
►

Sign in to add a comment