"text-decoration: line-through" creates extra underline and overline in vertical writing mode
Reported by
babata...@gmail.com,
Jul 3 2017
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3147.0 Safari/537.36 Example URL: https://jsbin.com/secupuguca/edit?html,css,output Steps to reproduce the problem: 1. Open https://jsbin.com/secupuguca/edit?html,css,output What is the expected behavior? Underline and overline do not appear. What went wrong? If the "lang" of the element is "ja", an underline and an overline will appear. Does it occur on multiple sites: N/A Is it a problem with a plugin? No Did this work before? N/A Does this work in other browsers? N/A Chrome version: 61.0.3147.0 Channel: canary OS Version: 10.0 Flash Version:
,
Jul 3 2017
,
Jul 4 2017
Able to reproduce the issue on Windows 7,Mac 10.12.5 & Ubuntu 14.04 using latest stable#59.0.3071.115 & Canary#61.0.3147.0 as per the above JSfiddle. Manual bisect info: ------------------ Good-58.0.3007.0 -Revision-449173 Bad-58.0.3008.0 -Revision-449509 Per revision bisect info: ------------------------- You are probably looking for a change made after 449173 (known good), but no later than 449174 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/0e09de60e479fe2ee105fb731b403c729fce3ac1..7affa3729f4c422d9db4076e4806fddc49008560 kojii@Could you please take a look & update the thread. Thanks..!!
,
Jul 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe56c88d9d01183d5ac0f53ea901ff66e5d2d644 commit fe56c88d9d01183d5ac0f53ea901ff66e5d2d644 Author: kojii <kojii@chromium.org> Date: Wed Jul 05 01:45:36 2017 Fix underline/overline flipping Underline/overline flipping logic is triggered as defined in the spec[1]. The logic, however, did not handle cases where both are off, or both are on correctly. This patch fixes the flipping logic to handle such cases. [1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet BUG= 738778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2970803002 Cr-Commit-Position: refs/heads/master@{#484174} [add] https://crrev.com/fe56c88d9d01183d5ac0f53ea901ff66e5d2d644/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/line-through-vertical-expected.html [add] https://crrev.com/fe56c88d9d01183d5ac0f53ea901ff66e5d2d644/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/line-through-vertical.html [modify] https://crrev.com/fe56c88d9d01183d5ac0f53ea901ff66e5d2d644/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
,
Jul 5 2017
Thank you for the report as always, fixed.
,
Jul 11 2017
Tested the issue on Mac OS 10.12.5, Ubuntu 14.04 and Windows 10 using Chrome Dev version M61 - 61.0.3153.4 as per the issue mentioned in original comment. Observed that issue is working as intended (When text is displayed vertically, extra underline and overline is not observed). Hence adding TE-Verified label. Please find the screenshot for reference. Thank you! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kochi@chromium.org
, Jul 3 2017Owner: kojii@chromium.org
Status: Assigned (was: Unconfirmed)