Worklet: Add layout/wpt tests for WorkletOptions |
||||
Issue descriptionCurrently there are no tests for WorkletOptions: https://drafts.css-houdini.org/worklets/#worklet-section (This is split from issue 710837 )
,
Jul 3 2017
,
Oct 2 2017
In the current spec, WorkletOptions has only "credentials" field. I'm now writing tests for it.
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4eca7587fe5f74fcb2bf2338f21029016cf2a06d commit 4eca7587fe5f74fcb2bf2338f21029016cf2a06d Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Thu Oct 05 22:46:23 2017 Worklet: Add tests for addModule() to access a cross origin resource The Worklet spec allows addModule() on a cross origin resource: https://drafts.css-houdini.org/worklets/ Bug: 738769 Change-Id: Ib18114697112966309ccc4d6107a4804f05a24fe Reviewed-on: https://chromium-review.googlesource.com/694704 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#506895} [modify] https://crrev.com/4eca7587fe5f74fcb2bf2338f21029016cf2a06d/third_party/WebKit/LayoutTests/external/wpt/worklets/animation-worklet-import.html [modify] https://crrev.com/4eca7587fe5f74fcb2bf2338f21029016cf2a06d/third_party/WebKit/LayoutTests/external/wpt/worklets/paint-worklet-import.html [modify] https://crrev.com/4eca7587fe5f74fcb2bf2338f21029016cf2a06d/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-tests.js
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ffd921940877f84065229c2c8cfbfe8829b71d4 commit 1ffd921940877f84065229c2c8cfbfe8829b71d4 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Oct 31 07:00:11 2017 Worklet: Add tests for WorkletOptions Bug: 738769 Change-Id: I8e15f7c05d64a98e6fdd7e3b69e2047902e04aad Reviewed-on: https://chromium-review.googlesource.com/694723 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#512768} [add] https://crrev.com/1ffd921940877f84065229c2c8cfbfe8829b71d4/third_party/WebKit/LayoutTests/external/wpt/worklets/animation-worklet-credentials.html [add] https://crrev.com/1ffd921940877f84065229c2c8cfbfe8829b71d4/third_party/WebKit/LayoutTests/external/wpt/worklets/paint-worklet-credentials.html [add] https://crrev.com/1ffd921940877f84065229c2c8cfbfe8829b71d4/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/credentials-tests.js [add] https://crrev.com/1ffd921940877f84065229c2c8cfbfe8829b71d4/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/credentials.py [add] https://crrev.com/1ffd921940877f84065229c2c8cfbfe8829b71d4/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/set-cookie.py
,
Oct 31 2017
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecb522dd8d700b77f800e157228e838a1fa19c61 commit ecb522dd8d700b77f800e157228e838a1fa19c61 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Wed Dec 13 07:40:17 2017 Worklet: Fix credentials tests for worklets Before this CL, credentials tests for worklets are completely broken as follows: - In credentials.py, |credentials_mode| is compared by "is" that conducts the object equality check. As a result, all conditions unexpectedly pass through and the script always returns a valid response. - In credentials.py, |is_cross_origin| value is always |False| because requests don't have the GET param. - fetch() needs { credentials: 'include' } option for configuring the document's cookie with the Set-Cookie header, but it's not specified. - Response headers are not specified for a 404 response. This results in test timeout instead of a network error. This CL fixes these bugs and cleans up tests. Bug: 738769 Change-Id: I9aeb11fca23dec3fd3057a765fa60eb6e59d8258 Reviewed-on: https://chromium-review.googlesource.com/799730 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#523713} [modify] https://crrev.com/ecb522dd8d700b77f800e157228e838a1fa19c61/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/credentials-tests.js [modify] https://crrev.com/ecb522dd8d700b77f800e157228e838a1fa19c61/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/credentials.py [modify] https://crrev.com/ecb522dd8d700b77f800e157228e838a1fa19c61/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/set-cookie.py |
||||
►
Sign in to add a comment |
||||
Comment 1 by nhiroki@chromium.org
, Jul 3 2017