New issue
Advanced search Search tips

Issue 738768 link

Starred by 1 user
Status: Fixed
Owner:
nverne@chromium.org
Closed: Jun 2018
Cc:
esprehn@chromium.org
Components:
EstimatedDays: 90
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

Support controllers in Blink for Onion Soup 2.0

Project Member Reported by nverne@chromium.org, Jul 3 2017 
Onion Soup 2.0 
https://docs.google.com/document/d/1hBKAYGGM2Zm7qhqXtdLSubklVDKUo9ir-vJtPEOx11Y/view is a major re-architecting of the render process as a whole. 

From the doc, in referenct to the controller/ directory:
"The system infrastructure of the renderer process that uses or drives the web platform. controller/ can directly use core/ and modules/ without using Web types (but with some DEPS rules). Examples are RenderProcess, RenderThread, Android View, Extensions, Native Client etc."

We will refine this loose definition as more examples are found.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b685592fda2fffc2a88318d2031860b174290030

commit b685592fda2fffc2a88318d2031860b174290030
Author: Nicholas Verne <nverne@chromium.org>
Date: Wed Jul 05 00:51:47 2017

Create controller/ component in blink.

This commences the new blink architecture outlined in Onion Soup 2.0

Most of the remaining files in web/ will migrate to controller/ either as the
existing Web* classes, or as controller-specific refactorings. The controller/
directory is not intended as a dumping ground.


Bug:  738768 
Change-Id: I7dbe02690ca3a90c08fead13468d160773fe7753
Reviewed-on: https://chromium-review.googlesource.com/547379
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484172}
[add] https://crrev.com/b685592fda2fffc2a88318d2031860b174290030/third_party/WebKit/Source/controller/BUILD.gn
[add] https://crrev.com/b685592fda2fffc2a88318d2031860b174290030/third_party/WebKit/Source/controller/BlinkInitializer.cpp
[add] https://crrev.com/b685592fda2fffc2a88318d2031860b174290030/third_party/WebKit/Source/controller/BlinkInitializer.h
[add] https://crrev.com/b685592fda2fffc2a88318d2031860b174290030/third_party/WebKit/Source/controller/ControllerExport.h
[add] https://crrev.com/b685592fda2fffc2a88318d2031860b174290030/third_party/WebKit/Source/controller/DEPS
[add] https://crrev.com/b685592fda2fffc2a88318d2031860b174290030/third_party/WebKit/Source/controller/OWNERS
[add] https://crrev.com/b685592fda2fffc2a88318d2031860b174290030/third_party/WebKit/Source/controller/README.md
[modify] https://crrev.com/b685592fda2fffc2a88318d2031860b174290030/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/b685592fda2fffc2a88318d2031860b174290030/third_party/WebKit/Source/web/DEPS
[modify] https://crrev.com/b685592fda2fffc2a88318d2031860b174290030/third_party/WebKit/Source/web/WebFactoryImpl.h
[modify] https://crrev.com/b685592fda2fffc2a88318d2031860b174290030/third_party/WebKit/Source/web/WebKit.cpp
[modify] https://crrev.com/b685592fda2fffc2a88318d2031860b174290030/third_party/WebKit/public/BUILD.gn
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c0f51f50d9487b83d8ee40857ec55df460cdde0

commit 6c0f51f50d9487b83d8ee40857ec55df460cdde0
Author: Nicholas Verne <nverne@chromium.org>
Date: Wed Jul 19 11:15:38 2017

Reorgs Blink dependencies as controller/ -> web/ -> core/.

web/ will eventually be removed. Until then, this dependency chain
allows us to start making controllers which temporarily use classes
in web/.

Bug:  738768 
Change-Id: If2dd46efc5cf653c25b50f7e9afd2302ee3ffa10
Reviewed-on: https://chromium-review.googlesource.com/576589
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487822}
[modify] https://crrev.com/6c0f51f50d9487b83d8ee40857ec55df460cdde0/third_party/WebKit/Source/controller/BUILD.gn
[modify] https://crrev.com/6c0f51f50d9487b83d8ee40857ec55df460cdde0/third_party/WebKit/Source/controller/BlinkInitializer.cpp
[delete] https://crrev.com/782aaff5b06c8bc32730a11dc33a342b0b6463d5/third_party/WebKit/Source/controller/BlinkInitializer.h
[modify] https://crrev.com/6c0f51f50d9487b83d8ee40857ec55df460cdde0/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/6c0f51f50d9487b83d8ee40857ec55df460cdde0/third_party/WebKit/Source/web/WebKit.cpp
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5a00a3d8bc6db6b98225b864ba30bb615e7c69b

commit d5a00a3d8bc6db6b98225b864ba30bb615e7c69b
Author: Nicholas Verne <nverne@chromium.org>
Date: Fri Jul 21 05:37:43 2017

Add nverne to controller/OWNERS

I will be on-hook for populating this directory in the short term.

Bug:  738768 
Change-Id: I01a1ef5456f3dacb4eec645df8d12cf762d7fc52
Reviewed-on: https://chromium-review.googlesource.com/580013
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488595}
[modify] https://crrev.com/d5a00a3d8bc6db6b98225b864ba30bb615e7c69b/third_party/WebKit/Source/controller/OWNERS

Comment 4 by slangley@chromium.org, Oct 19 2017

Components: -Blink>Internals Blink>Internals>Modularization

Comment 5 by nverne@chromium.org, Jun 13 2018

Status: Fixed (was: Assigned)
Any new work on controllers will require a new bug.
►

Sign in to add a comment