Null-dereference in content::BlinkTestController::OnDumpFrameLayoutResponse |
||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=4671625537781760 Fuzzer: mbarbella_js_mutation_layout Job Type: windows_syzyasan_content_shell Platform Id: windows Crash Type: Null-dereference Crash Address: 0x00000003 Crash State: content::BlinkTestController::OnDumpFrameLayoutResponse base::internal::Invoker<base::internal::BindState<void base::Callback<void __cdecl Memory Tool: SYZYASAN Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_content_shell&range=483918:483919 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4671625537781760 Issue filed automatically. See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Jul 5 2017
I am asking for help with the repro at https://groups.google.com/a/chromium.org/d/topic/clusterfuzz-tools-users/1gba0VeFN6M/discussion I assume that the problem here is a UaF of BlinkTestController, which might have been destroyed when the response to DumpFrameLayout comes back. Without a local repro I can try a speculative fix, but I am not yet sure what is the right way forward: 1) paper over the problem by adding base::WeakPtrFactory to BlinkTestController, vs 2) somehow tweak how mojo tracks lifetimes.
,
Jul 6 2017
FWIW, I am not able to repro locally on Win10: D:\src\chromium\src>type out\fuzz\args.gn # Build arguments go here. # See "gn args <out_dir> --list" for available build arguments. enable_precompiled_headers = false is_debug = false is_syzyasan = true target_cpu = "x86" D:\src\chromium\src>third_party\WebKit\Tools\Scripts\run-webkit-tests -t fuzz C:\Users\lukasza\Downloads\clusterfuzz-testcase-minimized-4671625537781760.htm --iterations 10 ... no crashes, just complaints about missing -expected.txt/-expected.png ... D:\src\chromium\src>git log --oneline 6e8a61b ... ...
,
Jul 11 2017
ClusterFuzz has detected this issue as fixed in range 485497:485520. Detailed report: https://clusterfuzz.com/testcase?key=4671625537781760 Fuzzer: mbarbella_js_mutation_layout Job Type: windows_syzyasan_content_shell Platform Id: windows Crash Type: Null-dereference Crash Address: 0x00000003 Crash State: content::BlinkTestController::OnDumpFrameLayoutResponse base::internal::Invoker<base::internal::BindState<void base::Callback<void __cdecl Memory Tool: SYZYASAN Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_content_shell&range=483918:483919 Fixed: https://clusterfuzz.com/revisions?job=windows_syzyasan_content_shell&range=485497:485520 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4671625537781760 See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Jul 11 2017
ClusterFuzz testcase 4671625537781760 is verified as fixed, so closing issue. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
||
►
Sign in to add a comment |
||
Comment 1 by msrchandra@chromium.org
, Jul 3 2017Labels: Test-Predator-Wrong-CLs M-61
Owner: lukasza@chromium.org
Status: Assigned (was: Untriaged)