New issue
Advanced search Search tips

Issue 738746 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in SkMatrix::postConcat

Project Member Reported by ClusterFuzz, Jul 2 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4873638250807296

Fuzzer: inferno_canvas_wrecker
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  SkMatrix::postConcat
  SkTwoPointConicalGradient::adjustMatrixAndAppendStages
  SkGradientShaderBase::onAppendStages
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Low

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=483748:483753

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4873638250807296


Additional requirements: Requires Gestures

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: mtklein@chromium.org
Components: Internals>Skia
Owner: fmalita@chromium.org
Status: Assigned (was: Untriaged)
fmalia: ClusterFuzz thinks your CL https://skia-review.googlesource.com/c/21111/ might be the cause of this. Can you please take a look?
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 3 2017

Labels: Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 3 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/974aad487a81e507ca9e953e0b7e016a42ba3c39

commit 974aad487a81e507ca9e953e0b7e016a42ba3c39
Author: Florin Malita <fmalita@chromium.org>
Date: Mon Jul 03 23:20:52 2017

Handle degenerate 2pt conical center values gracefully

SkMatrix::setPolyToPoly() may fail to map degenerate values.  Handle
this case explicitly, instead of assuming it never fails.

BUG= chromium:738746 
TBR=

Change-Id: Ie1049b98f7e07ae5d6bdb706ba7b4a399388e5d8
Reviewed-on: https://skia-review.googlesource.com/21375
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>

[modify] https://crrev.com/974aad487a81e507ca9e953e0b7e016a42ba3c39/src/shaders/gradients/SkTwoPointConicalGradient.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24a77db7cda3a52eba6e7f8c70dc3412f968fc3c

commit 24a77db7cda3a52eba6e7f8c70dc3412f968fc3c
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Tue Jul 04 00:48:37 2017

Roll src/third_party/skia/ a920d367b..974aad487 (1 commit)

https://skia.googlesource.com/skia.git/+log/a920d367bf9b..974aad487a81

$ git log a920d367b..974aad487 --date=short --no-merges --format='%ad %ae %s'
2017-07-03 fmalita Handle degenerate 2pt conical center values gracefully

Created with:
  roll-dep src/third_party/skia
BUG= 738746 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=csmartdalton@chromium.org

Change-Id: I6af0effd4727e65cc33f9d8c66af93480141ed80
Reviewed-on: https://chromium-review.googlesource.com/558383
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484034}
[modify] https://crrev.com/24a77db7cda3a52eba6e7f8c70dc3412f968fc3c/DEPS

Project Member

Comment 6 by sheriffbot@chromium.org, Jul 4 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 7 by ClusterFuzz, Jul 5 2017

ClusterFuzz has detected this issue as fixed in range 484025:484273.

Detailed report: https://clusterfuzz.com/testcase?key=4873638250807296

Fuzzer: inferno_canvas_wrecker
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  SkMatrix::postConcat
  SkTwoPointConicalGradient::adjustMatrixAndAppendStages
  SkGradientShaderBase::onAppendStages
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Low

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=483748:483753
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=484025:484273

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4873638250807296


Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by sheriffbot@chromium.org, Oct 10 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment