"Add to dictionary" is shown for correctly spelled but grammatically/contextually incorrect words |
||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36 Steps to reproduce the problem: 1. Type a grammatically incorrect sentence, like - Their are flowers in the garden. 2. Right click on the grammatically incorrect word (Their). What is the expected behavior? "Add to dictionary" is absent. What went wrong? "Add to dictionary" exists and makes no sense. Did this work before? N/A Chrome version: 59.0.3071.115 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: It only makes sense for incorrectly spelled words. Unless it adds the contextual or grammatical definition to the dictionary, which I doubt.
,
Jul 3 2017
Route to UI>Browser>Language>Spellcheck since Bink doesn't involved for "Add to dictionary" menu item in context menu.
We add IDC_SPELLCHECK_ADD_TO_DICTIONARY in SpellingMenuObserver::InitMenu()[1] whenever |ContextMenuParams| has
a misspelled word.
We should tweak below code SpellingMenuObserver::InitMenu()
// If word is misspelled, give option for "Add to dictionary" and, if
// multilingual spellchecking is not enabled, a check item "Ask Google for
// suggestions".
proxy_->AddMenuItem(IDC_SPELLCHECK_ADD_TO_DICTIONARY,
l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_ADD_TO_DICTIONARY));
proxy_->AddSpellCheckServiceItem(integrate_spelling_service_.GetValue());
[1] https://cs.chromium.org/chromium/src/chrome/browser/renderer_context_menu/spelling_menu_observer.cc
|
||
►
Sign in to add a comment |
||
Comment 1 by phistuck@chromium.org
, Jul 2 2017