New issue
Advanced search Search tips

Issue 738679 link

Starred by 1 user
Status: Verified
Owner:
machenb...@chromium.org
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 685318



Sign in to add a comment

Fix V8 roll-branch script for Gerrit

Project Member Reported by machenb...@chromium.org, Jul 1 2017 
Before, it created branches and then just directly pushed without CL upload. That's no longer possible with gerrit. Right now it's broken:

https://build.chromium.org/p/client.v8.fyi/builders/Auto-roll%20-%20push/builds/74577
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/53d0e1cb59fc764ff31fed5bdbbabb1e6fef6da1

commit 53d0e1cb59fc764ff31fed5bdbbabb1e6fef6da1
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Jul 03 11:57:35 2017

[release] Fix create-release script for Gerrit

This uploads roll-branch CLs before landing and fixes an
ambiguity bug when pushing tags.

NOTRY=true
TBR=hablich@chromium.org

Bug:  chromium:738679 
Change-Id: I51e03d714ec97ee2d9bca4ecaf753d66038891c1
Reviewed-on: https://chromium-review.googlesource.com/558415
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46382}
[modify] https://crrev.com/53d0e1cb59fc764ff31fed5bdbbabb1e6fef6da1/tools/release/common_includes.py
[modify] https://crrev.com/53d0e1cb59fc764ff31fed5bdbbabb1e6fef6da1/tools/release/create_release.py
[modify] https://crrev.com/53d0e1cb59fc764ff31fed5bdbbabb1e6fef6da1/tools/release/test_scripts.py

Comment 2 by machenb...@chromium.org, Jul 3 2017

Status: Verified (was: Assigned)
►

Sign in to add a comment