New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738651 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Task Manager does not show ARC++ processes with minimized windows

Project Member Reported by w...@chromium.org, Jul 1 2017

Issue description

Chrome Version: 60.0.3112.41
OS: ChromeOS Caroline

What steps will reproduce the problem?
(1) Set up Play Store on ChromeOS.
(2) Install GMail.
(3) Run GMail.
(4) Open Task Manager.
(5) Open crosh and run "top".
(6) Minimize the GMail window.

What is the expected result?

GMail process either disappears from both Task Manager and top, or is displayed in both.

What happens instead?

Top still shows the GMail process, but it disappears from Task Manager. If the window is restored then GMail reappears in Task Manager.
 
Owner: edcourtney@chromium.org
Eliot, do you know if this intended ?

(I am wondering if this was related to https://bugs.chromium.org/p/chromium/issues/detail?id=654564)

I think this is not intended, and I suspect it is related to that bug, as you say. I will have a look. Thanks~!
Status: Started (was: Untriaged)
CL at https://chromium-review.googlesource.com/c/562906/.

However, I think the task manager needs some PM input - last time we looked at this we put it off but maybe it's time to take another look. See crbug.com/705784. 

Comment 5 by w...@chromium.org, Jul 7 2017

Regardless of what's decided in terms of how the processes are presented in
the UI, we should show them all, otherwise Task Manager loses its
usefulness in seeing what is going on on a system.
For context: In  crbug.com/654564 , it was decided to filter at least some processes out.
Cc: mitsuji@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a22a574d88c8a87f4854b8306dff5d4d776f94a

commit 8a22a574d88c8a87f4854b8306dff5d4d776f94a
Author: Eliot Courtney <edcourtney@chromium.org>
Date: Mon Jul 10 04:36:00 2017

[Task Manager] Implicitly white list more process states.

If you minimise Gmail, it disappears from the task manager, so allow the
LAST_ACTIVITY process state to be displayed for ARC processes.

Additionally allow FOREGROUND_SERVICE since foreground services are user
visible.

BUG= 738651 

Change-Id: I403b9946fbbb29b115fe1877f63bb64e3fe3b2c7
Reviewed-on: https://chromium-review.googlesource.com/562906
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485183}
[modify] https://crrev.com/8a22a574d88c8a87f4854b8306dff5d4d776f94a/chrome/browser/task_manager/providers/arc/arc_process_filter.cc
[modify] https://crrev.com/8a22a574d88c8a87f4854b8306dff5d4d776f94a/chrome/browser/task_manager/providers/arc/arc_process_filter.h

Status: Fixed (was: Started)
Marking this as fixed since the direct problem should be fixed now - the bug for what to do with the task manager in general is here: crbug.com/705784.

Comment 10 by w...@chromium.org, Jul 10 2017

Status: Assigned (was: Fixed)
Re-opening, since based on the LAST_ACTIVITY name, I don't think this addresses the problem if I have multiple Android apps minimized - e.g. if I run GMail and Calendar and minimize them then only Calendar will be displayed in Task Manager, right?
Yeah, you're right. I thought I tested this case before submitting, but it seems like minimised apps that aren't LAST_ACTIVITY (sometimes(?)) get categorised as CACHED_ACTIVITY, which isn't handled. Thanks for re-opening!

Comment 12 by w...@chromium.org, Jul 19 2017

Shouldn't Task Manager should list *all* the process, regardless of their
state?
I tend to agree that task manager should show all processes. I think that's the point. edcourtney@ what's the cost of getting this done in M61? 

Comment 14 by uekawa@google.com, Jul 21 2017

wait, we've just blacklisted processes and now we want to just revert to the original behavior of many different system processes showing up ?

Comment 15 by w...@chromium.org, Jul 21 2017

Task Manager should account for all the resources in-use on the system, to
a close approximation.  What was the motivation for hiding some of them?

Comment 17 by w...@chromium.org, Jul 21 2017

Ah, I did wonder if it was process-spew causing the request, and it's fair
to note that there are other process in ChromeOS that don't feature in Task
Manager, though I'd argue that's more an omission than a pattern to follow.
;)

Nonetheless, to address the problem of Android process overload, while also
fairly accounting for Android system process resource usage, how would you
feel about filtering, but collating the total resource usage of the
filtered processes into an "ARC++ Subsystem" (yes, I'm bad at naming)
meta-Task, say?
Personally, I also think the task manager should show all processes and I like the suggestion of collating the ARC system processes into a meta-task, although it might be hard to decide which processes belong in the meta-task. Maybe another option is a tab for ARC processes.

I think the current filtering approach doesn't work very well, as wez@ said, and from what I've seen recently looking at this bug, seems hard to get working well (e.g. I found an app that had the process state 'SERVICE' when I minimised it - to handle cases like that we may end up letting through most of the processes anyway).

mitsuji@:
As for the cost of getting this done in M61 - removing the filter is easy, and until we work out what we want to do with this, maybe it's best to get rid of it.

Right our plate is pretty full for M61 so let's go with that and revisit this via M63.  
Labels: -M-60 M-63
Project Member

Comment 21 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2359bbad5b93466005569849ee3f918a838a9016

commit 2359bbad5b93466005569849ee3f918a838a9016
Author: Eliot Courtney <edcourtney@chromium.org>
Date: Thu Aug 03 05:11:38 2017

Remove ARC process task manager filter.

We had tried filtering noisy ARC processes out, using their
ProcessState. However, ideally the task manager should summarise the
total resource usage and not completely hide processes. Further, there
were some hard to resolve issues about processes that ought to
definitely be shown being hidden (see linked bug for context). So, until
we have a better solution for noisy ARC processes, remove this filter.

BUG= 738651 

Change-Id: Icf9d246e053185af5c5d7b20f90245fcd169ecc8
Reviewed-on: https://chromium-review.googlesource.com/582265
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491650}
[modify] https://crrev.com/2359bbad5b93466005569849ee3f918a838a9016/chrome/browser/BUILD.gn
[delete] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/chrome/browser/task_manager/providers/arc/arc_process_filter.cc
[delete] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/chrome/browser/task_manager/providers/arc/arc_process_filter.h
[delete] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/chrome/browser/task_manager/providers/arc/arc_process_filter_unittest.cc
[modify] https://crrev.com/2359bbad5b93466005569849ee3f918a838a9016/chrome/browser/task_manager/providers/arc/arc_process_task_provider.cc
[modify] https://crrev.com/2359bbad5b93466005569849ee3f918a838a9016/chrome/browser/task_manager/providers/arc/arc_process_task_provider.h
[modify] https://crrev.com/2359bbad5b93466005569849ee3f918a838a9016/chrome/test/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment