Task Manager does not show ARC++ processes with minimized windows |
|||||||
Issue descriptionChrome Version: 60.0.3112.41 OS: ChromeOS Caroline What steps will reproduce the problem? (1) Set up Play Store on ChromeOS. (2) Install GMail. (3) Run GMail. (4) Open Task Manager. (5) Open crosh and run "top". (6) Minimize the GMail window. What is the expected result? GMail process either disappears from both Task Manager and top, or is displayed in both. What happens instead? Top still shows the GMail process, but it disappears from Task Manager. If the window is restored then GMail reappears in Task Manager.
,
Jul 5 2017
I think this is not intended, and I suspect it is related to that bug, as you say. I will have a look. Thanks~!
,
Jul 7 2017
,
Jul 7 2017
CL at https://chromium-review.googlesource.com/c/562906/. However, I think the task manager needs some PM input - last time we looked at this we put it off but maybe it's time to take another look. See crbug.com/705784.
,
Jul 7 2017
Regardless of what's decided in terms of how the processes are presented in the UI, we should show them all, otherwise Task Manager loses its usefulness in seeing what is going on on a system.
,
Jul 7 2017
For context: In crbug.com/654564 , it was decided to filter at least some processes out.
,
Jul 7 2017
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a22a574d88c8a87f4854b8306dff5d4d776f94a commit 8a22a574d88c8a87f4854b8306dff5d4d776f94a Author: Eliot Courtney <edcourtney@chromium.org> Date: Mon Jul 10 04:36:00 2017 [Task Manager] Implicitly white list more process states. If you minimise Gmail, it disappears from the task manager, so allow the LAST_ACTIVITY process state to be displayed for ARC processes. Additionally allow FOREGROUND_SERVICE since foreground services are user visible. BUG= 738651 Change-Id: I403b9946fbbb29b115fe1877f63bb64e3fe3b2c7 Reviewed-on: https://chromium-review.googlesource.com/562906 Reviewed-by: Nick Carter <nick@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#485183} [modify] https://crrev.com/8a22a574d88c8a87f4854b8306dff5d4d776f94a/chrome/browser/task_manager/providers/arc/arc_process_filter.cc [modify] https://crrev.com/8a22a574d88c8a87f4854b8306dff5d4d776f94a/chrome/browser/task_manager/providers/arc/arc_process_filter.h
,
Jul 10 2017
Marking this as fixed since the direct problem should be fixed now - the bug for what to do with the task manager in general is here: crbug.com/705784.
,
Jul 10 2017
Re-opening, since based on the LAST_ACTIVITY name, I don't think this addresses the problem if I have multiple Android apps minimized - e.g. if I run GMail and Calendar and minimize them then only Calendar will be displayed in Task Manager, right?
,
Jul 19 2017
Yeah, you're right. I thought I tested this case before submitting, but it seems like minimised apps that aren't LAST_ACTIVITY (sometimes(?)) get categorised as CACHED_ACTIVITY, which isn't handled. Thanks for re-opening!
,
Jul 19 2017
Shouldn't Task Manager should list *all* the process, regardless of their state?
,
Jul 20 2017
I tend to agree that task manager should show all processes. I think that's the point. edcourtney@ what's the cost of getting this done in M61?
,
Jul 21 2017
wait, we've just blacklisted processes and now we want to just revert to the original behavior of many different system processes showing up ?
,
Jul 21 2017
Task Manager should account for all the resources in-use on the system, to a close approximation. What was the motivation for hiding some of them?
,
Jul 21 2017
,
Jul 21 2017
Ah, I did wonder if it was process-spew causing the request, and it's fair to note that there are other process in ChromeOS that don't feature in Task Manager, though I'd argue that's more an omission than a pattern to follow. ;) Nonetheless, to address the problem of Android process overload, while also fairly accounting for Android system process resource usage, how would you feel about filtering, but collating the total resource usage of the filtered processes into an "ARC++ Subsystem" (yes, I'm bad at naming) meta-Task, say?
,
Jul 21 2017
Personally, I also think the task manager should show all processes and I like the suggestion of collating the ARC system processes into a meta-task, although it might be hard to decide which processes belong in the meta-task. Maybe another option is a tab for ARC processes. I think the current filtering approach doesn't work very well, as wez@ said, and from what I've seen recently looking at this bug, seems hard to get working well (e.g. I found an app that had the process state 'SERVICE' when I minimised it - to handle cases like that we may end up letting through most of the processes anyway). mitsuji@: As for the cost of getting this done in M61 - removing the filter is easy, and until we work out what we want to do with this, maybe it's best to get rid of it.
,
Jul 21 2017
Right our plate is pretty full for M61 so let's go with that and revisit this via M63.
,
Jul 25 2017
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2359bbad5b93466005569849ee3f918a838a9016 commit 2359bbad5b93466005569849ee3f918a838a9016 Author: Eliot Courtney <edcourtney@chromium.org> Date: Thu Aug 03 05:11:38 2017 Remove ARC process task manager filter. We had tried filtering noisy ARC processes out, using their ProcessState. However, ideally the task manager should summarise the total resource usage and not completely hide processes. Further, there were some hard to resolve issues about processes that ought to definitely be shown being hidden (see linked bug for context). So, until we have a better solution for noisy ARC processes, remove this filter. BUG= 738651 Change-Id: Icf9d246e053185af5c5d7b20f90245fcd169ecc8 Reviewed-on: https://chromium-review.googlesource.com/582265 Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Nick Carter <nick@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#491650} [modify] https://crrev.com/2359bbad5b93466005569849ee3f918a838a9016/chrome/browser/BUILD.gn [delete] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/chrome/browser/task_manager/providers/arc/arc_process_filter.cc [delete] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/chrome/browser/task_manager/providers/arc/arc_process_filter.h [delete] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/chrome/browser/task_manager/providers/arc/arc_process_filter_unittest.cc [modify] https://crrev.com/2359bbad5b93466005569849ee3f918a838a9016/chrome/browser/task_manager/providers/arc/arc_process_task_provider.cc [modify] https://crrev.com/2359bbad5b93466005569849ee3f918a838a9016/chrome/browser/task_manager/providers/arc/arc_process_task_provider.h [modify] https://crrev.com/2359bbad5b93466005569849ee3f918a838a9016/chrome/test/BUILD.gn
,
Sep 4 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by uekawa@chromium.org
, Jul 4 2017