New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 738649 link

Starred by 1 user
Status: Archived
Owner:
pwang@chromium.org
Closed: Jul 2017
Cc:
█ dshi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Enable job priorities for suite_scheduler

Project Member Reported by ihf@chromium.org, Jul 1 2017 
Investigate how to add job priorities to control files.
src/third_party/autotest/files/client/common_lib/priorities.py

This would be quite useful to prioritize tasks from the out of band suite scheduler (say some branches or suites having precedence over others). 

Basically add a line to a control file like
PRIORITY="PostBuild"
and pipe this through to the suite_scheduler. I once looked this up, but not sure it already exists?
src/third_party/autotest/files/site_utils/suite_scheduler/deduping_scheduler_unittest.py

Comment 1 by pwang@chromium.org, Jul 6 2017 

Is the control file specifics priority what we intended to do?
IIUC, as long as we can specify the priority of the suite, the same effect can be achieved by assigning a single control file into a suite.

I have a pending CL that will add the ability to assign priority/timeout explicitly to a suite.
https://chromium-review.googlesource.com/c/560537/
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7972bb5cf00a84921fb1a8c059a87a8af5933546

commit 7972bb5cf00a84921fb1a8c059a87a8af5933546
Author: Po-Hsien Wang <pwang@chromium.org>
Date: Fri Jul 14 02:46:07 2017

task.py: explicitly specify priority/timeout

1) Add the ability to explicitly specify the priority/timeout of a suite.
2) Enable user to associate integer value/defined name to suite priority

BUG= chromium:738649 
TEST=unit test

Change-Id: Ia496dc321e9dc4d6cebf19e1196c93d985f807f7
Reviewed-on: https://chromium-review.googlesource.com/560537
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/7972bb5cf00a84921fb1a8c059a87a8af5933546/site_utils/suite_scheduler/task.py
[modify] https://crrev.com/7972bb5cf00a84921fb1a8c059a87a8af5933546/site_utils/suite_scheduler/task_unittest.py

Comment 3 by ihf@chromium.org, Jul 27 2017

Status: Fixed (was: Untriaged)
Summary: Enable job priorities for suite_scheduler (was: Enable job priorities for control files)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment