New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 738648 link

Starred by 1 user
Status: Fixed
Owner:
noel@chromium.org
Closed: Jul 2017
Cc:
█ roc...@chromium.org
sa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 597124



Sign in to add a comment

Mojo content/common/utility_messages.h

Project Member Reported by noel@chromium.org, Jul 1 2017 
The IPC in content/common/utility_messages.h should maybe converted to mojo. There are two IPC left in the message file, namely,

  UtilityMsg_BatchMode_Started, UtilityMsg_BatchMode_Finished

However, after all the utility process IPC-to-mojo conversions on  issue 604282 ,  issue 680928 , and  issue 691410 , I noticed there are no users of the utility process batch mode feature anymore.

Might be better to just remove the utility process batch mode feature, and delete these IPC (no need to convert them to mojo in that case).

Comment 1 by noel@chromium.org, Jul 3 2017 

https://chromium-review.googlesource.com/c/558526 if we like the idea ...
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93d53afdce310ac3f259c01c8d33908b912b427a

commit 93d53afdce310ac3f259c01c8d33908b912b427a
Author: Noel Gordon <noel@chromium.org>
Date: Thu Jul 06 12:48:08 2017

Remove utility process batch mode support and its IPCs

The utility_process_host_impl batch mode feature has no users
anymore, nor is it a useful feature in the age of mojo. Ditch
the feature:

  - remove batch mode IPC and the message file.
  - remove StartBatchMode / EndBatchMode code.
  - change IPC unit tests to use AutomationMsgStart
    IPC start name (instead of UtilityMsgStart).
  - remove UtilityMsgStart IPC message start name.
  - utility_process_host_impl.*, document members
    and remove old / unused #include files.
  - utility_thread{,impl}.h, ditto.

No change in behavior, no new tests.

Bug:  738648 
Change-Id: Ifcb65939ba7bf0a52451d2b8cb3a8a254399fcd2
Reviewed-on: https://chromium-review.googlesource.com/558526
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484557}
[modify] https://crrev.com/93d53afdce310ac3f259c01c8d33908b912b427a/content/browser/utility_process_host_impl.cc
[modify] https://crrev.com/93d53afdce310ac3f259c01c8d33908b912b427a/content/browser/utility_process_host_impl.h
[modify] https://crrev.com/93d53afdce310ac3f259c01c8d33908b912b427a/content/common/BUILD.gn
[modify] https://crrev.com/93d53afdce310ac3f259c01c8d33908b912b427a/content/common/content_message_generator.h
[delete] https://crrev.com/25e46762a1dc6a7f5604f06cd5fb11ed43afb287/content/common/utility_messages.h
[modify] https://crrev.com/93d53afdce310ac3f259c01c8d33908b912b427a/content/public/browser/utility_process_host.h
[modify] https://crrev.com/93d53afdce310ac3f259c01c8d33908b912b427a/content/public/utility/utility_thread.h
[modify] https://crrev.com/93d53afdce310ac3f259c01c8d33908b912b427a/content/utility/utility_thread_impl.cc
[modify] https://crrev.com/93d53afdce310ac3f259c01c8d33908b912b427a/content/utility/utility_thread_impl.h
[modify] https://crrev.com/93d53afdce310ac3f259c01c8d33908b912b427a/ipc/OWNERS
[modify] https://crrev.com/93d53afdce310ac3f259c01c8d33908b912b427a/ipc/ipc_channel_proxy_unittest.cc
[modify] https://crrev.com/93d53afdce310ac3f259c01c8d33908b912b427a/ipc/ipc_channel_proxy_unittest_messages.h
[modify] https://crrev.com/93d53afdce310ac3f259c01c8d33908b912b427a/ipc/ipc_message_start.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ee2b6a51b7557fd1e65c5c4872ab9be9ffd531a

commit 5ee2b6a51b7557fd1e65c5c4872ab9be9ffd531a
Author: Noel Gordon <noel@chromium.org>
Date: Fri Jul 07 11:36:49 2017

Rename utility process ReleaseProcessIfNeeded to ReleaseProcess

ReleaseProcess is always needed now the utility process batch mode
has been removed.

Bug:  738648 
Change-Id: I307ba6e0e6dfaae36d4c4c56b47b80a890c822cb
Reviewed-on: https://chromium-review.googlesource.com/562841
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484888}
[modify] https://crrev.com/5ee2b6a51b7557fd1e65c5c4872ab9be9ffd531a/chrome/utility/extensions/extensions_handler.cc
[modify] https://crrev.com/5ee2b6a51b7557fd1e65c5c4872ab9be9ffd531a/chrome/utility/printing_handler.cc
[modify] https://crrev.com/5ee2b6a51b7557fd1e65c5c4872ab9be9ffd531a/chrome/utility/profile_import_handler.cc
[modify] https://crrev.com/5ee2b6a51b7557fd1e65c5c4872ab9be9ffd531a/content/public/utility/utility_thread.h
[modify] https://crrev.com/5ee2b6a51b7557fd1e65c5c4872ab9be9ffd531a/content/utility/utility_service_factory.cc
[modify] https://crrev.com/5ee2b6a51b7557fd1e65c5c4872ab9be9ffd531a/content/utility/utility_thread_impl.cc
[modify] https://crrev.com/5ee2b6a51b7557fd1e65c5c4872ab9be9ffd531a/content/utility/utility_thread_impl.h

Comment 4 by noel@chromium.org, Jul 7 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment