Mac Only: Keyboard Shortcut to go Forward Doesn't Work on NTP |
||||||
Issue descriptionChrome Version: 59.0.3071.115 OS: Mac OS X What steps will reproduce the problem? (1) Open a new tab. (2) Search for something or navigate somewhere or click on a most visited tiles or something (3) On the resulting page, press command + left-arrow to go back. You should see the NTP. (4) Press command + right-arrow to go forward What is the expected result? (5) You're back on the page you left. What happens instead? (5) The keyboard shortcut is silently ignored. This can happen with longer sequence for forward and back too. Everything works except when you get on the NTP, at which point the forward keyboard shortcut doesn't work anymore. I think what's happening is that keyboard shortcuts don't work in the omnibox on Mac.
,
Jul 6 2017
,
Aug 4 2017
The command+left/command+right shortcuts are used to jump to the beginning/end of a text field, so when the omnibox is selected it interprets those commands as an attempt to move the cursor in the omnibox. (Of course, when there is no text in the omnibox, this has no effect.) One possible solution would be to ignore these commands if the omnibox is empty -- does this seem like a reasonable solution?
,
Feb 8 2018
> One possible solution would be to ignore these commands if the > omnibox is empty -- does this seem like a reasonable solution? Seems reasonable to me. I'm happy to review any changes in this regard. (I'm not familiar with Mac shortcut handling so don't know where this code would go.) Setting a next action date in the future so, if we don't get a fix by then, we remember to retest it to see if the new Mac omnibox design fixes it.
,
May 3 2018
I can still reproduce this.
,
May 3 2018
> I can still reproduce this. On MacViews?
,
May 3 2018
Yes, I tested this on MacViews.
,
May 3 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mpear...@chromium.org
, Jul 1 2017