New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 738638 link

Starred by 4 users
Status: Verified
Owner:
za...@chromium.org
Closed: Nov 2017
Cc:
█ puneetster@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

virtio_wl

Project Member Reported by za...@chromium.org, Jul 1 2017 
land virtio wayland in the v4.4 kernel and in crosvm

Comment 1 by puneetster@chromium.org, Jul 5 2017

Cc: puneetster@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/fd3425db4731e8db64d1dab632892544de6b12d4

commit fd3425db4731e8db64d1dab632892544de6b12d4
Author: Zach Reizner <zachr@google.com>
Date: Mon Jul 10 18:22:37 2017

sys_util: add shared memory module

This CL adds the SharedMemory structure for managing memory attached to
a file descriptor, which can be sent to external processes.

TEST=cargo test
BUG= chromium:738638 

Change-Id: I2b6a10e0e7275367ddb578831a73de6956d231bb
Reviewed-on: https://chromium-review.googlesource.com/562509
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[add] https://crrev.com/fd3425db4731e8db64d1dab632892544de6b12d4/sys_util/src/shm.rs
[modify] https://crrev.com/fd3425db4731e8db64d1dab632892544de6b12d4/sys_util/src/lib.rs
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/bf36bcbc4a843279aebff26666a5ca802a7b37fb

commit bf36bcbc4a843279aebff26666a5ca802a7b37fb
Author: Zach Reizner <zachr@google.com>
Date: Fri Jul 21 04:21:29 2017

sys_util: add sock_ctrl_msg module for transmitting messages with FD

This CL also includes the gcc build time dependency for building the
sock_ctrl_msg.c helper code.

TEST=cargo test
BUG= chromium:738638 

Change-Id: I4adc2360b7fab4ed7d557603aa7bad2e738b69b4
Reviewed-on: https://chromium-review.googlesource.com/562574
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[add] https://crrev.com/bf36bcbc4a843279aebff26666a5ca802a7b37fb/sys_util/src/sock_ctrl_msg.rs
[add] https://crrev.com/bf36bcbc4a843279aebff26666a5ca802a7b37fb/sys_util/sock_ctrl_msg.c
[modify] https://crrev.com/bf36bcbc4a843279aebff26666a5ca802a7b37fb/sys_util/src/lib.rs
[modify] https://crrev.com/bf36bcbc4a843279aebff26666a5ca802a7b37fb/sys_util/Cargo.toml
[add] https://crrev.com/bf36bcbc4a843279aebff26666a5ca802a7b37fb/sys_util/build.rs
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/3eddedd005c0333390e1eae4c2f0eb661790748e

commit 3eddedd005c0333390e1eae4c2f0eb661790748e
Author: Zach Reizner <zachr@google.com>
Date: Thu Aug 03 08:11:01 2017

sys_util: add Pollable impls for UnixDatagram and UnixStream

UnixDatagram and UnixStream are both wrappers around unix domain sockets
which are often polled.

TEST=None
BUG= chromium:738638 

Change-Id: Ib5572faf1d601b89b9fdd323f654ba04650b7600
Reviewed-on: https://chromium-review.googlesource.com/599041
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/3eddedd005c0333390e1eae4c2f0eb661790748e/sys_util/src/poll.rs
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/7a9de27c36b9a5ea3e29b3508939c20e6a5c7779

commit 7a9de27c36b9a5ea3e29b3508939c20e6a5c7779
Author: Zach Reizner <zachr@google.com>
Date: Thu Aug 03 08:11:01 2017

sys_util: allow sock_ctrl_msg to be more flexible with iovecs

Because there are more than one kind of slice (typical &[T] and
VolatileSlice), the trait IntoIovec is added that any linear memory
region-like type can implement. This helps to reduce the number of
copies needed when dealing with volatile memory.

TEST=cargo test
BUG= chromium:738638 

Change-Id: I86bbb693cb7a10ec85bafccf562c078167121c03
Reviewed-on: https://chromium-review.googlesource.com/599042
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/7a9de27c36b9a5ea3e29b3508939c20e6a5c7779/sys_util/src/sock_ctrl_msg.rs
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/09a95f5e74c47d43a1f6962fca108466d8cc31e5

commit 09a95f5e74c47d43a1f6962fca108466d8cc31e5
Author: Zach Reizner <zachr@google.com>
Date: Sun Aug 06 05:07:53 2017

kvm: add device memory interface to Vm

This interface is to dynamically add and remove memory mappings to guest
physical address space.

TEST=cargo test
BUG= chromium:738638 

Change-Id: I695775289d56686ef16a1e3cf7640c97d5da2662
Reviewed-on: https://chromium-review.googlesource.com/599040
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/09a95f5e74c47d43a1f6962fca108466d8cc31e5/kvm/src/lib.rs
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/29ad3c7d0fed6a4d2ffa1d02268a9aeb4f2ebf14

commit 29ad3c7d0fed6a4d2ffa1d02268a9aeb4f2ebf14
Author: Zach Reizner <zachr@google.com>
Date: Sat Aug 26 02:54:11 2017

crosvm: refactor and expand vm control socket IPC

This CL adds VM request capabilities to the control socket. These
requests include the basic exit as well as the essential ioeventfd and
irqfd requests. For virtio wayland, the register/unregister device
memory request was added.

TEST=cargo test
BUG= chromium:738638 

Change-Id: I0cbf62d85a299cf454bcf6924a4e1d52d5b7183f
Reviewed-on: https://chromium-review.googlesource.com/602593
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/29ad3c7d0fed6a4d2ffa1d02268a9aeb4f2ebf14/kvm/src/lib.rs
[modify] https://crrev.com/29ad3c7d0fed6a4d2ffa1d02268a9aeb4f2ebf14/src/main.rs
[add] https://crrev.com/29ad3c7d0fed6a4d2ffa1d02268a9aeb4f2ebf14/src/vm_control.rs
[modify] https://crrev.com/29ad3c7d0fed6a4d2ffa1d02268a9aeb4f2ebf14/sys_util/src/lib.rs
[modify] https://crrev.com/29ad3c7d0fed6a4d2ffa1d02268a9aeb4f2ebf14/data_model/src/endian.rs
[modify] https://crrev.com/29ad3c7d0fed6a4d2ffa1d02268a9aeb4f2ebf14/Cargo.toml
[delete] https://crrev.com/5e77e88062c65463a98d1c58ba9646e99b47d80f/src/control_socket.rs
[modify] https://crrev.com/29ad3c7d0fed6a4d2ffa1d02268a9aeb4f2ebf14/src/device_manager.rs
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/e9321023861f8584df4237ecc4f3c8fbc01f90f3

commit e9321023861f8584df4237ecc4f3c8fbc01f90f3
Author: Zach Reizner <zachr@google.com>
Date: Fri Sep 01 21:41:52 2017

data_model: add copy functions for copying slices in VolatileSlice's

These copy functions are functionally similar to read_from and write_to,
but have stronger guarantees because they are copying to/from concrete
slices. In particular, the volatile access pattern is specified and the
copy operation never returns an error.

TEST=cargo test
BUG= chromium:738638 

Change-Id: Ie10152e10bc8a36058f5d5001ff392ff8975ee36
Reviewed-on: https://chromium-review.googlesource.com/599043
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/e9321023861f8584df4237ecc4f3c8fbc01f90f3/data_model/src/volatile_memory.rs
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/1ea2f8ec346bf21ee2b1fbc21eb69883fc29d2a9

commit 1ea2f8ec346bf21ee2b1fbc21eb69883fc29d2a9
Author: Zach Reizner <zachr@google.com>
Date: Fri Sep 08 04:21:25 2017

crosvm: bump libc version to 0.2.29

This is so future changes can use getresuid/setresuid and similar
syscalls.

BUG= chromium:738638 
TEST=./build_test

Change-Id: I47765fa1f45c549d8e148d02655dd61993a10f58
Reviewed-on: https://chromium-review.googlesource.com/655143
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/1ea2f8ec346bf21ee2b1fbc21eb69883fc29d2a9/Cargo.toml
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/2bcf05b2afbcbe1287583a229dbb3e5b6c78aa8c

commit 2bcf05b2afbcbe1287583a229dbb3e5b6c78aa8c
Author: Zach Reizner <zachr@google.com>
Date: Sat Sep 09 00:35:58 2017

crosvm: add virtio wayland device

This adds the virtio wayland device which is activated by default. The wayland
device needs the XDG_RUNTIME_DIR env variable to be set and a running wayland
compositor to connect to in that directory.

TEST=crosvm run <other args>
BUG= chromium:738638 

Change-Id: Iaa417c6bb74739896042318451b4befcac0c1d0e
Reviewed-on: https://chromium-review.googlesource.com/559860
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/2bcf05b2afbcbe1287583a229dbb3e5b6c78aa8c/src/hw/virtio/mod.rs
[add] https://crrev.com/2bcf05b2afbcbe1287583a229dbb3e5b6c78aa8c/src/hw/virtio/wl.rs
[add] https://crrev.com/2bcf05b2afbcbe1287583a229dbb3e5b6c78aa8c/seccomp/x86_64/wl_device.policy
[modify] https://crrev.com/2bcf05b2afbcbe1287583a229dbb3e5b6c78aa8c/src/main.rs
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c43ca20f0fd66f44b26d95c2e442a6d0dbf68e6d

commit c43ca20f0fd66f44b26d95c2e442a6d0dbf68e6d
Author: Zach Reizner <zachr@google.com>
Date: Wed Sep 27 03:43:59 2017

linux-headers: add virtwl headers

Adds the virtio wayland headers to the linux headers package for the
purposes of building guest applications and the host's kvmtool package.

BUG= chromium:738638 
TEST=emerge sys-kernel/linux-headers

Change-Id: I7dbecaee9ea3306be6f512a6316eea96087deebd
Reviewed-on: https://chromium-review.googlesource.com/442704
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/c43ca20f0fd66f44b26d95c2e442a6d0dbf68e6d/sys-kernel/linux-headers/files/0019-virtwl-add-virtwl-driver.patch
[modify] https://crrev.com/c43ca20f0fd66f44b26d95c2e442a6d0dbf68e6d/sys-kernel/linux-headers/linux-headers-4.4.ebuild
[rename] https://crrev.com/c43ca20f0fd66f44b26d95c2e442a6d0dbf68e6d/sys-kernel/linux-headers/linux-headers-4.4-r8.ebuild
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c76d777c5dc45ae0a20edc2aec38682087d9b9ff

commit c76d777c5dc45ae0a20edc2aec38682087d9b9ff
Author: Zach Reizner <zachr@google.com>
Date: Sat Oct 14 23:54:38 2017

vm_tools: add a proxy daemon for virtio wayland

BUG= chromium:738638 
TEST=cros_workon_make --board=${BOARD} --install vm_tools
CQ-DEPEND=CL:442704

Change-Id: Ia7504194aa9e1f6ff68b0b8504a7258ab70cd3ac
Reviewed-on: https://chromium-review.googlesource.com/443315
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[add] https://crrev.com/c76d777c5dc45ae0a20edc2aec38682087d9b9ff/vm_tools/virtwl_guest_proxy/main.c
[modify] https://crrev.com/c76d777c5dc45ae0a20edc2aec38682087d9b9ff/vm_tools/guest.gypi
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c2efc12c816bf04411ba91be425176ab44092a42

commit c2efc12c816bf04411ba91be425176ab44092a42
Author: Stephen Barber <smbarber@chromium.org>
Date: Tue Oct 17 07:33:17 2017

vm_tools: add virtwl_guest_proxy binary

BUG= chromium:738638 
TEST=emerge-tatl vm_tools

Change-Id: Ibf4cc37a33f852e57ed33fb877ae5ee48f0633db
Reviewed-on: https://chromium-review.googlesource.com/721563
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/c2efc12c816bf04411ba91be425176ab44092a42/chromeos-base/vm_tools/vm_tools-9999.ebuild
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/149e06207b720ac06ce146944936e6f82e859763

commit 149e06207b720ac06ce146944936e6f82e859763
Author: Stephen Barber <smbarber@chromium.org>
Date: Tue Oct 17 07:33:17 2017

vm_tools: maitred: start virtwl_guest_proxy on boot

Start the guest proxy for wayland automatically on boot.

BUG= chromium:738638 
TEST=boot tatl image; ssh in and see virtwl_guest_proxy running

Change-Id: I067c21350bace4f6f93cc75c1d520f14eb2c9468
Reviewed-on: https://chromium-review.googlesource.com/721769
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/149e06207b720ac06ce146944936e6f82e859763/vm_tools/maitred/init.cc

Comment 17 by dgreid@chromium.org, Nov 18 2017

Status: Verified (was: Started)
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 22 2017

Labels: merge-merged-chromeos-4.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/99b354577a77efc7b59eb873477a13eca6ca1b05

commit 99b354577a77efc7b59eb873477a13eca6ca1b05
Author: Zach Reizner <zachr@google.com>
Date: Tue Nov 21 23:58:28 2017

CHROMIUM: virtwl: add virtwl driver

TEST=emerge-tatl chromeos-kernel-4_4
BUG= chromium:738638 

[dgreid - conflicts with Makefile and find_vqs function + clean
checkpatch.pl run]

Change-Id: I6e8e128a5548c915a9561938cbb066edc8c42747
Reviewed-on: https://chromium-review.googlesource.com/567299
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/780812
Commit-Ready: Dylan Reid <dgreid@chromium.org>
Tested-by: Dylan Reid <dgreid@chromium.org>

[add] https://crrev.com/99b354577a77efc7b59eb873477a13eca6ca1b05/include/uapi/linux/virtwl.h
[modify] https://crrev.com/99b354577a77efc7b59eb873477a13eca6ca1b05/drivers/virtio/Makefile
[add] https://crrev.com/99b354577a77efc7b59eb873477a13eca6ca1b05/drivers/virtio/virtio_wl.c
[add] https://crrev.com/99b354577a77efc7b59eb873477a13eca6ca1b05/include/uapi/linux/virtio_wl.h
[modify] https://crrev.com/99b354577a77efc7b59eb873477a13eca6ca1b05/include/uapi/linux/virtio_ids.h
[modify] https://crrev.com/99b354577a77efc7b59eb873477a13eca6ca1b05/drivers/virtio/Kconfig
Project Member

Comment 19 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/4aff8d03eb86e7e95e94a27f730dee9b6aa8b86c

commit 4aff8d03eb86e7e95e94a27f730dee9b6aa8b86c
Author: Guenter Roeck <groeck@chromium.org>
Date: Fri Dec 01 04:30:18 2017

FIXUP: CHROMIUM: virtwl: add virtwl driver

0day reports:

drivers//virtio/virtio_wl.c: In function do_send:
drivers//virtio/virtio_wl.c:790:9: warning:
	ret may be used uninitialized in this function [-Wmaybe-uninitialized]

BUG= chromium:738638 
TEST=Build driver with W=1

Change-Id: I83afb8b7e754bd80e660ec772671a20a87df5624
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/802255
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/4aff8d03eb86e7e95e94a27f730dee9b6aa8b86c/drivers/virtio/virtio_wl.c
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/7f88ef322c82e453d5beba0ad1131359b599f5c9

commit 7f88ef322c82e453d5beba0ad1131359b599f5c9
Author: Zach Reizner <zachr@google.com>
Date: Wed Feb 21 19:24:13 2018

CHROMIUM: virtwl: fix asterisk placement around __user

Should fix these warnings:

drivers/virtio/virtio_wl.c:1013:52: sparse:
			dereference of noderef expression
drivers/virtio/virtio_wl.c:1013:52: sparse:
			incorrect type in argument 3 (different address spaces)

BUG= chromium:738638 
TEST=Run virtio_wl.c through sparse

Change-Id: Ic2085290789b118686ab8b6b3403884257981e66
Reviewed-on: https://chromium-review.googlesource.com/922387
Commit-Ready: Guenter Roeck <groeck@chromium.org>
Tested-by: Guenter Roeck <groeck@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>

[modify] https://crrev.com/7f88ef322c82e453d5beba0ad1131359b599f5c9/drivers/virtio/virtio_wl.c
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b91ac9cda7bb9d8f17bf6b9196649e838378ba8b

commit b91ac9cda7bb9d8f17bf6b9196649e838378ba8b
Author: Zach Reizner <zachr@google.com>
Date: Sat Mar 10 06:59:04 2018

CHROMIUM: virtwl: fix asterisk placement around __user

Should fix these warnings:

drivers/virtio/virtio_wl.c:1013:52: sparse:
			dereference of noderef expression
drivers/virtio/virtio_wl.c:1013:52: sparse:
			incorrect type in argument 3 (different address spaces)

BUG= chromium:738638 
TEST=Run virtio_wl.c through sparse

Change-Id: Ic2085290789b118686ab8b6b3403884257981e66
Reviewed-on: https://chromium-review.googlesource.com/922387
Commit-Ready: Guenter Roeck <groeck@chromium.org>
Tested-by: Guenter Roeck <groeck@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>
(cherry-picked from commit 7f88ef322c82e453d5beba0ad1131359b599f5c9)
Reviewed-on: https://chromium-review.googlesource.com/957812
Commit-Ready: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/b91ac9cda7bb9d8f17bf6b9196649e838378ba8b/drivers/virtio/virtio_wl.c

Comment 22 by vapier@chromium.org, May 9 2018

Components: OS>Systems>Containers
►

Sign in to add a comment