New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 738633 link

Starred by 1 user
Status: Fixed
Owner:
█ halliwell@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Allow critical memory pressure handling in renderer on Chromecast

Project Member Reported by halliwell@chromium.org, Jul 1 2017 
This CL led to frequent OOM on Chromecast:
https://codereview.chromium.org/1780523002/

since we can run out of memory very quickly in some situations, and running the critical pressure handlers is necessary to save memory quickly.

We have had a downstream patch in our fork to fix this for a while, which we'd like to remove.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16136dec0940b5c2a63c7cacf961198a5f7128cf

commit 16136dec0940b5c2a63c7cacf961198a5f7128cf
Author: Luke Halliwell <halliwell@chromium.org>
Date: Wed Jul 05 21:15:56 2017

Allow critical memory pressure handling on Chromecast

This (yes, very old!) CL led to frequent OOM on Chromecast:
https://codereview.chromium.org/1780523002/

We've worked around since then with a downstream patch, which I'd
like to eliminate :)

BUG= 738633 

Change-Id: I9bd276fcda6f46382184a7783721138c003738b9
Reviewed-on: https://chromium-review.googlesource.com/553459
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484351}
[modify] https://crrev.com/16136dec0940b5c2a63c7cacf961198a5f7128cf/content/common/BUILD.gn
[modify] https://crrev.com/16136dec0940b5c2a63c7cacf961198a5f7128cf/content/common/features.gni
[modify] https://crrev.com/16136dec0940b5c2a63c7cacf961198a5f7128cf/content/renderer/render_thread_impl.cc

Comment 2 by halliwell@chromium.org, Jul 5 2017

Status: Fixed (was: Started)
►

Sign in to add a comment