eclog USE flag missing from a lot of platforms |
|||||||||||
Issue description
eclog control the start of timberslide, which gather EC console log.
It is only present on few boards:
find . -type f -exec grep eclog {} \+
./baseboard-poppy/profiles/base/make.defaults:USE="${USE} eclog"
./baseboard-gru/profiles/base/make.defaults:USE="${USE} cros_ec eclog mosys_eventlog -opengl"
./baseboard-oak/profiles/base/make.defaults:USE="${USE} eclog"
It should be on all boards with 3.18 and 4.4, as it allows retrieval of EC console log in feedbacks.
,
Jul 1 2017
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/4c02f24dde3346fbcf8c90dc6e1f94b1e6ff6465 commit 4c02f24dde3346fbcf8c90dc6e1f94b1e6ff6465 Author: Gwendal Grignou <gwendal@chromium.org> Date: Tue Jul 11 05:35:10 2017 Add eclog on most board eclog USE flag install timberslide that collect ec logs. These log are collected during feedback. BUG= chromium:738630 TEST=Verify on cyan that /var/log/cros_ec log file are created. Change-Id: I4880eff58deed3221434679104bd7deca1b799cb Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/561918 Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [modify] https://crrev.com/4c02f24dde3346fbcf8c90dc6e1f94b1e6ff6465/baseboard-glados/profiles/base/make.defaults [modify] https://crrev.com/4c02f24dde3346fbcf8c90dc6e1f94b1e6ff6465/baseboard-fizz/profiles/base/make.defaults [modify] https://crrev.com/4c02f24dde3346fbcf8c90dc6e1f94b1e6ff6465/baseboard-strago/profiles/base/make.defaults [modify] https://crrev.com/4c02f24dde3346fbcf8c90dc6e1f94b1e6ff6465/baseboard-reef/profiles/base/make.defaults [modify] https://crrev.com/4c02f24dde3346fbcf8c90dc6e1f94b1e6ff6465/baseboard-kunimitsu/profiles/base/make.defaults
,
Jul 13 2017
,
Jul 13 2017
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 13 2017
A user feedback report below on Caroline needs EC log for further clarification, but this cros_ec section was missing. https://listnr.corp.google.com/report/68073152415 It seems to me that we should consider this feature into R60. Thanks to Tod for helping confirming "chrome://system cros_ec= support" on caroline with 9734.0.0.
,
Jul 13 2017
Agreed would be useful to pull this back R60 before stable cut pulled Gwendal's eclog USE flag patch to R60 here: https://chromium-review.googlesource.com/?polygerrit=0#/c/570180/ Retest once buildbot completes
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/39279b44c062eae75a4da035c86105fe82327209 commit 39279b44c062eae75a4da035c86105fe82327209 Author: Gwendal Grignou <gwendal@chromium.org> Date: Thu Jul 13 16:28:38 2017 Add eclog on most board eclog USE flag install timberslide that collect ec logs. These log are collected during feedback. BUG= chromium:738630 TEST=Verify on cyan that /var/log/cros_ec log file are created. Change-Id: I4880eff58deed3221434679104bd7deca1b799cb Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/561918 Reviewed-by: Eric Caruso <ejcaruso@chromium.org> (cherry picked from commit 4c02f24dde3346fbcf8c90dc6e1f94b1e6ff6465) Reviewed-on: https://chromium-review.googlesource.com/570180 [modify] https://crrev.com/39279b44c062eae75a4da035c86105fe82327209/baseboard-glados/profiles/base/make.defaults [modify] https://crrev.com/39279b44c062eae75a4da035c86105fe82327209/baseboard-fizz/profiles/base/make.defaults [modify] https://crrev.com/39279b44c062eae75a4da035c86105fe82327209/baseboard-strago/profiles/base/make.defaults [modify] https://crrev.com/39279b44c062eae75a4da035c86105fe82327209/baseboard-reef/profiles/base/make.defaults [modify] https://crrev.com/39279b44c062eae75a4da035c86105fe82327209/baseboard-kunimitsu/profiles/base/make.defaults
,
Jul 13 2017
,
Jul 13 2017
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 13 2017
I approved Todd CL too quickly: the change is request to R60 to be able to see EC log in feedback reports on most machines.
,
Jul 19 2017
,
Jul 19 2017
IIUC, Gwendal/Todd already picked this to 60, so after retroactive approval, I guess this should just be "Merge-Merged-60".
,
Jan 22 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by gwendal@chromium.org
, Jul 1 2017